Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@Moltijoe
Copy link
Contributor

@Moltijoe Moltijoe commented Jul 1, 2024

It was initially added alongside jungleland but deemed too dangerous as actual acid
jungleland feels lacking in features, adding acid rain both lets people experience what they were missing
as well as making it slightly more dangerous to freely explore
which should have the side effect of slowing down the speed at which jungleland is fully explored

it will last longer, but it'll be significantly less dangerous than ash storms as a result

also refactors water immunity into using bitflags rather than lists

Why is this good for the game?

Adds more to jungleland
also i love the aesthetic of rainfall

Testing

image

🆑
rscadd: Enables jungleland's acid rain
tweak: jungleland acid rain only injects toxic metabolites rather than apply acid
bugfix: jungleland mobs now have the proper weather immunities
/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Tweak This PR contains changes to the game. labels Jul 1, 2024
@Moltijoe Moltijoe marked this pull request as draft July 1, 2024 10:07
@github-actions github-actions bot added the Sound This PR changes audio files label Jul 2, 2024
@Moltijoe Moltijoe added Test Merge - Scheduled This PR is waiting to be test merged Test Merge - Requested This PR is waiting for a test merge to be scheduled labels Jul 2, 2024
@Moltijoe Moltijoe marked this pull request as ready for review July 2, 2024 15:59
@Moltijoe Moltijoe requested a review from a team as a code owner July 2, 2024 15:59
Yogbot-13 added a commit that referenced this pull request Jul 2, 2024
Yogbot-13 added a commit that referenced this pull request Jul 2, 2024
Yogbot-13 added a commit that referenced this pull request Jul 2, 2024
@Moltijoe Moltijoe requested a review from a team as a code owner July 3, 2024 12:44
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Jul 3, 2024
Yogbot-13 added a commit that referenced this pull request Jul 13, 2024
Yogbot-13 added a commit that referenced this pull request Jul 13, 2024
Yogbot-13 added a commit that referenced this pull request Jul 13, 2024
Yogbot-13 added a commit that referenced this pull request Jul 13, 2024
Yogbot-13 added a commit that referenced this pull request Jul 13, 2024
Yogbot-13 added a commit that referenced this pull request Jul 14, 2024
Yogbot-13 added a commit that referenced this pull request Jul 14, 2024
Yogbot-13 added a commit that referenced this pull request Jul 14, 2024
Yogbot-13 added a commit that referenced this pull request Jul 14, 2024
Yogbot-13 added a commit that referenced this pull request Jul 15, 2024
This was referenced Jul 15, 2024
Yogbot-13 added a commit that referenced this pull request Jul 15, 2024
Yogbot-13 added a commit that referenced this pull request Jul 19, 2024
Yogbot-13 added a commit that referenced this pull request Jul 19, 2024
Yogbot-13 added a commit that referenced this pull request Jul 19, 2024
Yogbot-13 added a commit that referenced this pull request Jul 19, 2024
Copy link
Contributor

@Aquizit Aquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map change fine, just makes the thing completely immune instead of just to lavaland weather.

Yogbot-13 added a commit that referenced this pull request Jul 21, 2024
@ToasterBiome ToasterBiome merged commit 2d4a862 into yogstation13:master Jul 21, 2024
@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Jul 21, 2024
Yogbot-13 added a commit that referenced this pull request Jul 21, 2024
@Moltijoe Moltijoe deleted the EnableAcidRain branch July 21, 2024 04:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map. Sound This PR changes audio files Test Merge - Requested This PR is waiting for a test merge to be scheduled Test Merge - Scheduled This PR is waiting to be test merged TESTMERGED This PR is currently live in a test merge. Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants