This repository was archived by the owner on May 22, 2025. It is now read-only.
Fix a code oopsie regarding lockers that I made 5 years ago #22407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
how did you realize you did this? were you just looking at the code for fun? |
SapphicOverload
approved these changes
Jul 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
5 years ago, I did a #7234 to make lockers airtight when welded. Well, today I was looking at the code for funsies and I realized that I made an oopsie. This oopsie has no effect right now, but if someone were to make a locker that doesnt become airtight when welded or becomes airtight when closed (there are vars in the locker I added for that) it would break in unexpected ways (aka probably throwing runtimes or just not doing what is expected), so this should fix that.
Why is this good for the game?
Testing
Wiki Documentation
Changelog
This PR doesn't have any player-facing changes.