Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@monster860
Copy link
Member

🆑 monster860
add: Lockers are now airtight when welded.
/:cl:

@yogstation13-bot yogstation13-bot added the Feature This adds new content to the game label Dec 4, 2019
@boodaliboo
Copy link
Contributor

i like this

@alexkar598
Copy link
Member

I am somewhat unthrilled by the perpective of fusion in a closet and bringing that on the shuttle

@LoliconSlayer
Copy link
Contributor

You do realize that most lockers have holes in them for air flow right

@CMOisLing
Copy link
Contributor

Maybe change the sprite so the holes get welded as well?

@Bibby0110
Copy link
Contributor

What does this positively add to the game?

@boodaliboo
Copy link
Contributor

What does this positively add to the game?

you can safely afk in a locker

@Bibby0110
Copy link
Contributor

Bibby0110 commented Dec 4, 2019

but you can't space people in lockers anymore
you can hide in lockers from impending plasma fires
you can use lockers as improvised space suits if you have a buddy

just go to the dorms to AFK, why do you think they can be locked

@Hopekz
Copy link
Contributor

Hopekz commented Dec 5, 2019

but you can't space people in lockers anymore
you can hide in lockers from impending plasma fires
you can use lockers as improvised space suits if you have a buddy

just go to the dorms to AFK, why do you think they can be locked

In all my ss13 AFKing I've only been able to survive being in dorms twice otherwise I come back to being dead or worse off. Dorms is known the place people go where they're not playing anymore not to AFK .

I'm not for adding this because of being AFK though, I'm for this because its a really cool feature that makes sense. Its hard to tell what features like this will be used for but its nice to have added options.

@Bibby0110
Copy link
Contributor

You can't justify adding something because it MIGHT create some stuff while debuffing multiple other things

@monster860
Copy link
Member Author

In order to hide from a locker from impending plasma fires you need someone else's help. Same with going to space, and that other person is gonna need a space suit to take you anywhere useful. Either way someone needs a spacesuit. Also, you can still space people in a locker, just don't weld it. Or do weld it, knowing that the moment they escape the locker they will die from the cold hard vacuum of space.

@Hopekz
Copy link
Contributor

Hopekz commented Dec 5, 2019

You can't justify adding something because it MIGHT create some stuff while debuffing multiple other things

The other things that you mentioned aren't even "buffs" or "debuffs" its just different situations that add fun.

but you can't space people in lockers anymore

You defiantly can. If you weld them first for some reason then the locker player has the option of holding on to a little bit to see if they can hit something like a space ruin to get a very slim chance of survival. What else are they going to do when they get out of the locker they can't weld themselves back in.

you can hide in lockers from impending plasma fires

You can't weld yourself in a locker. So if someone does a "get in this locker, save yourself" type situation then that's pretty cool that might add some nice situations. Not that lockers don't melt in extreme heat anyway..

you can use lockers as improvised space suits if you have a buddy

Why is this a bad thing?
Someone else with a space suit that has to weld you, drag you around and then unweld you (so makes you useless until you're unwelded...IF you're unwelded).
I hope your argument isn't a realism argument because that's not really what space manz is about in my opinion (not that heaving a sealed container in space wouldn't be realistic)

You're acting like space survival is a hard to come by resource that needs to be monitored but this will let you survive just unable to do anything in space.

Remember we're playing a video game so we should add fun features.

@Quartich
Copy link

Quartich commented Dec 9, 2019

someone got spaced

@Amelia0010 Amelia0010 merged commit 9381602 into yogstation13:master Dec 10, 2019
@monster860
Copy link
Member Author

actually the reason I made this lr is i looked at comments section of an ss13 video and someone said lockers were airtight when welded. i was like really? so i did some digging around and it was untrue so I made this pr to make it true. @Quartich

Mr-Space added a commit to Mr-Space/Yogstation that referenced this pull request Dec 14, 2019
* Automatic changelog generation yogstation13#7183 [ci skip]

* Revert "Label workflow"

* Silicolysis buff (yogstation13#7127)

* Automatic changelog generation yogstation13#7127 [ci skip]

* map tweaks

* Adds an achievement for creating a borg as a roboticist (yogstation13#7204)

* adds an achievement for creating a borg

* locks it to robos only

* adds dilithium canister (yogstation13#7202)

* Automatic changelog generation yogstation13#7202 [ci skip]

* Automatic TGUI rebuilding on master branch via Github Actions (#47961)

About The Pull Request

Uses actions to automatically rebuild tgui if files are changed, then push the result.
Triggers on push to master, pushes results to master.

Also disables build checking in Travis because it's unimportant now.

* Update autobuild Github action (#48090)

* demodularise

* tgstation/tgstation#47135

* tgstation/tgstation#47230

* tgstation/tgstation#47585

* tgstation/tgstation#47686

* comms console now allows aghost admins to AI-interact (yogstation13#7130)

* comms console now allows aghost admins to AI-interact

* fucks

* removes a spare 0 from the tgui-next UI

* Update achievements.dm

name = "Kick Ass and Chew Bubblegum."
	desc = "Kill Bubblegum, the king of slaughter demons." //Should be improved(?)

* Adds Catastrophe achievement

Emag a PA to get it

* Revert "Adds Catastrophe achievement"

This reverts commit 6889f2d.

* Adds the Catastrophe achievement

Emag a PA to get it

* adds a 10% chance of getting a bluespace emag if you emag an emag

* oops

* Automatic changelog generation yogstation13#7214 [ci skip]

* Automatic changelog generation yogstation13#7212 [ci skip]

* Automatic changelog generation yogstation13#7213 [ci skip]

* Automatic changelog generation yogstation13#7198 [ci skip]

* Update lighting.dm

* #fuck merge conflicts

* powergamers-mad-x24

* fucking ktlsws

* Automatic changelog generation yogstation13#7131 [ci skip]

* Reworks the achievements subsystem to actually instanciate them

* Adds 3 new achievements

* Apply suggestions from code review

Co-Authored-By: Nichlas Pihl <nichlas00100@gmail.com>

* map things

* Badass syndie achievement

* redesigns testing range

* Add lead lined achievement

* Add wizard win achievement

* Add CPR and changeling win achievements

* Add shadowling ascending achievement

* fix the random parallax layers not working (yogstation13#7225)

* Automatic changelog generation yogstation13#7225 [ci skip]

* Add 3 more achievements, one for dying and two related to being cremated

* Automatic changelog generation yogstation13#7220 [ci skip]

* fixes eggpeople being invisible (yogstation13#7232)

* Automatic changelog generation yogstation13#7232 [ci skip]

* Make lockers airtight when welded

* Update marrow_weaver.dm (yogstation13#7227)

* Automatic changelog generation yogstation13#7227 [ci skip]

* redoes the achievements UI once more

* adds support for hiding achievement descriptions untill they've been achieved

* fuck you github

* Added the RCD (yogstation13#7230)

Tested before commit. it works.

* Automatic changelog generation yogstation13#7230 [ci skip]

* Update autolathe_designs.dm (yogstation13#7215)

* Automatic changelog generation yogstation13#7215 [ci skip]

* add short_desc (yogstation13#7224)

* allows you to create insulin (yogstation13#7208)

* Update medicine.dm

* retard

* Unoppresses Mentors pt.1 & 2 (yogstation13#7231)

* tag

* where did that line go

* Update code/modules/client/verbs/ooc.dm

Co-Authored-By: monster860 <mnmaxim@gmail.com>

* Update ooc.dm

* ooc color pref

* bRaCkEtS

* Automatic changelog generation yogstation13#7231 [ci skip]

* Stray pixels

* Makes Parmesan great again

* strips html on modular computer printer

* Update printer.dm

* department biohazard locker

* Glockroaches (yogstation13#7229)

* Glockroaches port

Adds glockroaches.

Next commit will be simplemob interactions

* Simple mob interaction

Ports simple mob ineraction from

This will add functionality to add simple mobs

* FUCK

Adds sound.
TG simplemobs are different too.
It works!

* Automatic changelog generation yogstation13#7229 [ci skip]

* Automatic changelog generation yogstation13#7245 [ci skip]

* demodularise

* meatball icon

* Clock cult stuff

>More map things.
>Change Airlocks correect airlock. Remove lots of randowm loot Spawners but i still leave some

* Revert "Clock cult stuff"

This reverts commit b903e7a.

* Clock Cult Woot

>More map things.
>Change Airlocks correect airlock. Remove lots of randowm loot Spawners but i still leave some

* Something i forgot

Space makes you float who would of thought...
I forgot that you need the  /area/space/nearstation) when i made this map a long time ago.

* Makes PDA messages use the language system

* Makes paper use the language system somewhat. Removes info_links.

* Automatic changelog generation yogstation13#7263 [ci skip]

* Now you can use runes on CentCom

mapmerge finally work

* f (yogstation13#7271)

* Automatic changelog generation yogstation13#7271 [ci skip]

* fix runtime for using strange reagent on simplemobs (yogstation13#7267)

* Update medicine_reagents.dm

* Update medicine_reagents.dm

* Automatic changelog generation yogstation13#7267 [ci skip]

* Makes dilithium crystals visually different from BS crystals (yogstation13#7246)

* Adds separate dilithium

* Adds own visual

* Automatic changelog generation yogstation13#7246 [ci skip]

* change fridges to bar access

* [s] Fixes a couple of exploits (yogstation13#7273)

* Update drink_reagents.dm

* Update other_reagents.dm

* Update food_reagents.dm

* Automatic changelog generation yogstation13#7273 [ci skip]

* f

* Adds new player friendly to the server title

### Intent of your Pull Request

Maybe it will attract more players


#### Changelog

:cl:  
  
tweak: changes hub line
/:cl:

* okay

makes | not

* aeeeeeeeaeaeaeaeaeaeaeaeaeaeaee

merge my pr

* Adds BUG option to adminhelp admin menu

* Automatic changelog generation yogstation13#7221 [ci skip]

* Automatic changelog generation yogstation13#7277 [ci skip]

* fixkckc

* Automatic changelog generation yogstation13#7281 [ci skip]

* Update species.dm

* a

* Update human_defines.dm

* Update dna_vault.dm

* Update human_defines.dm

* Update dna_vault.dm

* Update cult_items.dm

* Automatic changelog generation yogstation13#7222 [ci skip]

* Automatic changelog generation yogstation13#7251 [ci skip]

* gloves of the north star can no longer be exploited (yogstation13#7283)

* Automatic changelog generation yogstation13#7274 [ci skip]

* f

* Ninja jail is no longer permanent (yogstation13#7178)

* Add files via upload

* ninja man explodes

* Ignore that.

* Use list instead of trait and makes the proc go off after the implant activation rather than as soon as you click the icon

* fuck

* the hell is a newline

* Update ninja.dm

* goddamnit

* Checks if the player is actually still in the dojo

* Automatic changelog generation yogstation13#7178 [ci skip]

* Revert "Ninja jail is no longer permanent (yogstation13#7178)" (yogstation13#7287)

This reverts commit f5b602c.

* Automatic changelog generation yogstation13#7286 [ci skip]

* Automatic changelog generation yogstation13#7276 [ci skip]

* Test 

jobama

* wording fix HONK

fuck!

* Animates dab emote (yogstation13#7290)

* Automatic changelog generation yogstation13#7290 [ci skip]

* Revert "Animates dab emote (yogstation13#7290)" (yogstation13#7291)

This reverts commit 7a257e7.

* Revert "Revert "Animates dab emote(yogstation13#7290)" (yogstation13#7291)"

* Theos be like

Okay boomer

* Coco now using milk instead of water

Super important please fix!

* LoneOP? ON MY TEST SERVER!?

* Create FUNDING.yml

* Automatic changelog generation yogstation13#7293 [ci skip]

* Automatic changelog generation yogstation13#7278 [ci skip]

* Automatic changelog generation yogstation13#7226 [ci skip]

* Automatic changelog generation yogstation13#7234 [ci skip]

* Automatic changelog generation yogstation13#7262 [ci skip]

* Automatic changelog generation yogstation13#7216 [ci skip]

* Automatic changelog generation yogstation13#7265 [ci skip]

* Automatic changelog generation yogstation13#7295 [ci skip]

* I guess

* Automatic changelog generation yogstation13#7270 [ci skip]

* Update autobuild_tgui.yml

* this is just a test, I'll revert it later

* lol

* Automatic TGUI Rebuild [ci skip]

* auto-build is gone 🦀

* achive

* server

* Makes written initialize in Initialize() in paper.dm

* Update uplink_items.dm

* Moves some code around and creates /proc/scramble_HTML for languages

* Allows the prewritten text on paper to also have a language

* Forgot to push a line fuck

* Fixes missing variable compiletime in paper.dm

* Makes several premade papers have a language they're written in

* someone said this was important to note

* Update CODEOWNERS.md [ci skip]

* emag does the thing

* Map changes for monstermos

* Automatic changelog generation yogstation13#7307 [ci skip]

* more non sense

* Adds language to prewritten papers defined in /yogstation/code/

* Automatic changelog generation yogstation13#7304 [ci skip]

* [s] (yogstation13#7292)

* Update reinf_floor.dm

* Update pipe.dm

* Conveyor belts stack to 30 (yogstation13#7294)

Fixed. It compiles.
Fixed. It works!

* Automatic changelog generation yogstation13#7294 [ci skip]

* adds a tacti cool kit based off of neo (yogstation13#7233)

* neo

* Update code/game/objects/items/storage/uplink_kits.dm

Co-Authored-By: Theos <theubernyan@gmail.com>

* Update uplink_kits.dm

* stimulants

* Update uplink_kits.dm

* Update uplink_kits.dm

* Automatic changelog generation yogstation13#7233 [ci skip]

* adds stormtrooper armor and helmet and a cargo crate for them working edition maybe thanks to missatesatessy for heping me (yogstation13#7256)

* Add files via upload

* Update packs.dm

* Update armor.dm

* Update helmet.dm

* i deleted all new crates by mistake this should fix it

* Update packs.dm

* Automatic changelog generation yogstation13#7256 [ci skip]

* wouldthisfixit? (yogstation13#7313)

* Update motd.txt

* beep

* Automatic changelog generation yogstation13#7317 [ci skip]

* ssssssssss

* Automatic changelog generation yogstation13#7319 [ci skip]

* I think this does the thing probably tm

* cringecode

* Update dna_vault.dm

* bruh moment

* fixed the code

* Automatic changelog generation yogstation13#7282 [ci skip]

* Automatic changelog generation yogstation13#7303 [ci skip]

* Automatic changelog generation yogstation13#7312 [ci skip]

* Automatic changelog generation yogstation13#7268 [ci skip]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants