This repository was archived by the owner on May 22, 2025. It is now read-only.
Achievement Get Part 1 - Greentext Achievements #7657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saves 50 microseconds, I promise
Contributor
|
do my kudzu bounty |
Member
|
You should add an achievement for greentexting as a nightmare. |
Contributor
Author
That'll be $0.34 at the next window please |
Contributor
LOL is there any way to NOT greentext as nightmare? |
Don't ID increment at home, kids, the moment this goes like you can't pull this shit
Contributor
Author
|
Okay, that should be all the Greentext achievements on my list done, with a couple runtime fixes already committed. Ready for Review. |
alexkar598
suggested changes
Jan 17, 2020
Member
alexkar598
left a comment
alexkar598
left a comment
There was a problem hiding this comment.
My small little nitpick and also you have to write a database query to unlock the green text achievement on everybody who already has a green text achievement
ghost
reviewed
Feb 1, 2020
| if(!achievement) | ||
| log_sql("Achievement [achievementPath] not found in list of achievements when trying to unlock for [C.ckey]") | ||
| return FALSE | ||
| if(istype(achievement,/datum/achievement/greentext) && achievementPath != /datum/achievement/greentext) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopek and Readystorm are paying me for this.
Overview
Included are 18 of the 88 achievements I'm being paid to add to the game, all of them having to do with greentexting.
There are also unique achievements for the leaders of team antag groups winning, too. Like Eminences get both the default "win as clockie" achievement as well as the "win as Eminence" one.
Coder Warning
Doing this involved the creation of a new achievement type,
/datum/achievement/greentext. All achievements related to greentexting should be put under this type so that the user can also get the generic "get a greentext" achievement, too.Additionally,
/datum/antagonistgot a new var:greentext_achieve, which is the type of an achievement the antag will receive if they greentext as that antag type.Not all antag types have been converted to the new
greentext_achievemethod, due to the excessive copypaste and lack of inheritence when it comes to determining win condition and objective accomplishment.Changelog
🆑 Altoids
rscadd: Gangs, Clownops, Generic antags, EAAs, IAAs, Culties, Clockies, Revs, Sentient Diseases, Revenants, Vampires, Pirates and Blobs now all have unique achievements for greentexting!
/:cl: