Achievement Get Part 2 - Engineering Achievements #7729

Altoids1 · 2020-01-29T03:10:20Z

Hopek & Readystorm also paid me to do these, too.

Overview

This is a continuation of #7657, adding some more achievements related to engineering and atmospherics that were on the spreadsheet of shit to add that I was given.

For those interested, here is the full list of achievements I've been tasked with adding:
https://docs.google.com/spreadsheets/d/1Q3XZE5a9B91kYmHl_-GCWASmXXwGjdy6Ld6bv8Ef5JE/edit?usp=sharing

Coder Warnings

This adds yet another achievement type, /datum/achievement/engineering. Later in this quest I will be making a PR to improve the achievement menu UI to group related achievements together using their parent types like this. If you ever add an achievement, try to imitate that design decision.

Adding I'm givin' it all she's got, Captain! required modifying how powernets are created; /datum/powernet/New() now takes in an arg that describes the z-level of the powerlevel, which is then used by SSachievements to determine whether it's on the station and so related to the CE getting the power achievement. I suppose this var could also be used in the future for some optimization of how powernets are created and reset, if that ever becomes relevant.

It also required making SSachievements a SS_BACKGROUND subsystem instead of a SS_NO_TICK one, in some effort to avoid wasting the time of SSmachine.

Changelog

🆑 Altoids
rscadd: Four new Engineering-related Achievements have been added!
bugfix: A potential NTSL exploit involving the Poly achievements has been fixed.
/:cl:

This is a surprise tool that will help us later!

A lot of shit had to happen in order to make this work. I had to add a new specification to powernets to mark what Z-level they exist on, to ensure that I only scan powernets that're on the station Z-level. Additionally, SSachievements now is SS_BACKGROUND instead of SS_NO_FIRE, since I didn't want to have this CE achievement bullshit happen in the middle of the very important SSmachine tick.

I needed *something* to put in for /datum/achievement/engineering, so...

...if you got *EXACTLY* 3000 kW of power in a powernet

boodaliboo · 2020-01-29T03:36:56Z

add assistant achievements

Altoids1 · 2020-01-29T03:39:28Z

add assistant achievements

Will do, probably in the fifth PR

Also ends up lowering the amount of requirements for the Poly_loud achievement. This code in general smells like ass and needs to be reworked to no longer make several NTSL calls to do its fuckin job.

code/controllers/subsystem/achievements.dm

Amelia0010 · 2020-01-29T14:04:42Z

code/datums/achievements/achievements.dm

 	desc = "Trigger a keycard authentication device event, by yourself."
 	id = 23

+/datum/achievement/dab


I do not control the rate at which spacemen dab

Undocumented change, PR denied

Please no, im downvoting this shit until this gets yeeted out

code/controllers/subsystem/achievements.dm

code/modules/power/solar.dm

ThatLing · 2020-01-31T09:08:51Z

yogstation/code/modules/mob/living/emote.dm

 		var/light_dab_speed = rand(3,7)
 		H.DabAnimation(angle = light_dab_angle , speed = light_dab_speed)
 		H.adjustOrganLoss(ORGAN_SLOT_BRAIN, 5)
+		SSachievements.unlock_achievement(/datum/achievement/dab,H.client)


I do not control the rate at which spacemen dab

code/__HELPERS/roundend.dm

code/controllers/subsystem/achievements.dm

alexkar598 · 2020-01-31T21:41:09Z

code/datums/achievements/achievements.dm

 	desc = "Trigger a keycard authentication device event, by yourself."
 	id = 23

+/datum/achievement/dab


Please no, im downvoting this shit until this gets yeeted out

code/modules/power/solar.dm

code/modules/mob/living/carbon/human/life.dm

Readystorm546 · 2020-01-31T23:09:33Z

Imagine being annoyed by a dab in a hidden achievement

FatCat1978 · 2020-02-01T15:02:28Z

uh oh, zoomer! hahaha dab funny make dab achievenem,tn hahahaha wow so original hahahah!!!

Imagine finding an outdated 2015 meme funny, or even relevant enough to make an achievement about. Apparently your sense of humor is as far in the past as your code used to be.

Altoids1 · 2020-02-01T20:06:51Z

uh oh, zoomer! hahaha dab funny make dab achievenem,tn hahahaha wow so original hahahah!!!

Imagine finding an outdated 2015 meme funny, or even relevant enough to make an achievement about. Apparently your sense of humor is as far in the past as your code used to be.

I see Ling shared this with their TG-coder friends.

Again, this PR was paid for. One of the achievements they wanted was for dabbing, and so it's in here. I personally do not control the rate at which spessmen dab.

Unfortunately, you do have to share this game with zoomers who like to dab a non-zero amount. Certainly a tragedy, but this achievement has no practical effect on the gameplay of anyone outside that group, so I doubt it deserves the 'jerk that it's currently getting.

FatCat1978 · 2020-02-01T20:18:51Z

One: TG's gay.
Two: Someone paying for something doesn't mean it's a good idea, and just shifts the blame for this level of dumb shit over to the person paying for it.

The literal only reason it's in this PR is because it wouldn't pass on it's own merit. that's shit.

optimumtact · 2020-02-01T21:06:23Z

^ this guy looks a garfield porn

alexkar598 · 2020-02-01T23:06:52Z

@Altoids1 bruh im not ling, i shared PR because ready posted this abortion in discord:

ThatLing · 2020-02-02T10:21:09Z

I see Altoids is back at it again with the baseless accusations.

Also, imagine paying someone to code something and then throwing a hissy fit because people don't want said thing in the game. Cry more

boodaliboo · 2020-02-02T23:18:25Z

why is a fucking dab achievement causing drama you fucking losers

ThatLing · 2020-02-03T07:59:25Z

why is a fucking dab achievement causing drama you fucking losers

Because it's unfunny. Go make dabstation if you like being an unfunny little shit so bad

boodaliboo · 2020-02-03T16:14:16Z

I don’t find dabbing funny but I find this ridiculous

alexkar598

Turns out acheivement SQL queries arent sanitzed for the name or description. Hold off before merging this PR

alexkar598 · 2020-02-04T03:21:47Z

#7751

alexkar598 · 2020-02-08T03:51:28Z

code/modules/power/solar.dm

+		var/was_not_connected = !(connected_tracker && connected_panels.len)
 		search_for_connected()
+		if(last_user && was_not_connected && connected_tracker && connected_panels.len) // If this guy finished up the solars
+			if(last_user.stat != DEAD && (last_user.mind?.assigned_role in GLOB.engineering_positions)) // and he's an engineer who isn't long-dead or adminbussing


Verify his client exists here

AsV9 · 2020-02-19T09:49:07Z

@Altoids1 Please comply with alexkar's change request.

Altoids1 added 7 commits January 28, 2020 19:01

Adds an achievement for setting up some solars as Engineer

3ed5bf4

Makes emagging the PA an engineering-type achievement

011f7f9

This is a surprise tool that will help us later!

Fixes compiletime with PA emag achievement

0e73a99

Adds achievement for being set on fire while fire-resistant

f5eaa8d

Adds achieve for surviving as part of the engie department

87b7d11

I needed *something* to put in for /datum/achievement/engineering, so...

Adds achievement for dabbing

3bed9f8

Altoids1 requested a review from AsV9 as a code owner January 29, 2020 03:10

yogstation13-bot added the Feature This adds new content to the game label Jan 29, 2020

Altoids1 added 3 commits January 28, 2020 21:11

Merge branch 'master' into achievement-get

e2cdc88

Fixes bug where the Scotty achievement would only fire...

38dcced

...if you got *EXACTLY* 3000 kW of power in a powernet

Fixes define overwrite issue with sound.dm and achievements.dm

629e6d7

Altoids1 added 4 commits January 28, 2020 21:47

Fixes misspell of Isaac Clarke's name

2e40601

Makes the Poly achievements be of /engineering/ type

3c83194

Polishes syntax in solar.dm

4d6f504

Fixes potential DoS exploit with a Poly achievement

8fae206

Also ends up lowering the amount of requirements for the Poly_loud achievement. This code in general smells like ass and needs to be reworked to no longer make several NTSL calls to do its fuckin job.

Amelia0010 suggested changes Jan 29, 2020

View reviewed changes

Altoids1 added 2 commits January 29, 2020 22:01

Switches to is_station_level() instead of (z == 2)

c0da9f6

Fixes misuse of ?. operator

c491c26

ThatLing reviewed Jan 31, 2020

View reviewed changes

code/modules/power/solar.dm Outdated Show resolved Hide resolved

ThatLing reviewed Jan 31, 2020

View reviewed changes

alexkar598 suggested changes Jan 31, 2020

View reviewed changes

Altoids1 added 2 commits January 31, 2020 16:54

Fixes potential runtimes with solar_control

6580000

Makes use of FIRE_SUIT_MAX_TEMP_PROTECT in fire achievement

1812d1a

Removes assigned_role test in roundend.dm

ce39c00

alexkar598 approved these changes Feb 1, 2020

View reviewed changes

alexkar598 added the DO NOT MERGE Should not be merged without express approval from a Head Dev label Feb 4, 2020

alexkar598 suggested changes Feb 4, 2020

View reviewed changes

AsV9 removed the DO NOT MERGE Should not be merged without express approval from a Head Dev label Feb 5, 2020

alexkar598 suggested changes Feb 8, 2020

View reviewed changes

Hopekz added the Bounty This PR is for a bounty, and cash reward label Feb 17, 2020

ThatLing added the Stale I'm closing this in like a week if you don't push a new commit label Feb 19, 2020

Adds minor sanity check for Solar achievement

3e95783

Ktlwjec1 removed the Stale I'm closing this in like a week if you don't push a new commit label Feb 22, 2020

AsV9 merged commit 1824681 into yogstation13:master Feb 23, 2020

yogstation13-bot added a commit that referenced this pull request Feb 23, 2020

Automatic changelog generation #7729 [ci skip]

b742ec3

Uh oh!

Achievement Get Part 2 - Engineering Achievements #7729

Achievement Get Part 2 - Engineering Achievements #7729

Uh oh!

Conversation

Altoids1 commented Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Coder Warnings

Changelog

Uh oh!

boodaliboo commented Jan 29, 2020

Uh oh!

Altoids1 commented Jan 29, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Readystorm546 commented Jan 31, 2020

Uh oh!

FatCat1978 commented Feb 1, 2020

Uh oh!

Altoids1 commented Feb 1, 2020

Uh oh!

FatCat1978 commented Feb 1, 2020

Uh oh!

optimumtact commented Feb 1, 2020

Uh oh!

alexkar598 commented Feb 1, 2020

Uh oh!

ThatLing commented Feb 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boodaliboo commented Feb 2, 2020

Uh oh!

ThatLing commented Feb 3, 2020

Uh oh!

boodaliboo commented Feb 3, 2020

Uh oh!

alexkar598 left a comment

Choose a reason for hiding this comment

Uh oh!

alexkar598 commented Feb 4, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AsV9 commented Feb 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Altoids1 commented Jan 29, 2020 •

edited

Loading

ThatLing commented Feb 2, 2020 •

edited

Loading