Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@ThatLing
Copy link
Contributor

Like it says on the tin. Removes diagonal movement by only allowing one movement direction to be set at once. Behaved exactly like old-yogs code in my tests.

@Kmc2000
Copy link
Contributor

Kmc2000 commented Mar 13, 2018

why

@GrayRachnid
Copy link
Contributor

no

@Jc1469
Copy link
Contributor

Jc1469 commented Mar 13, 2018

as a player of yogstation, the only one who has commented here, I find this PR valid. get the fuck out of here with your down thumbs

@ThatLing
Copy link
Contributor Author

ThatLing commented Mar 13, 2018

@GrayRachnid
Thank you for this constructive feedback.

@Kmc2000
Because our current codebase doesn't have diagonal movement?

@GrayRachnid
Copy link
Contributor

I don't feel like that's a valid reason to remove diagonal movement, what is wrong with it?

@ThatLing
Copy link
Contributor Author

Ok let me turn the tables around, why shouldn't this be removed?

@Bawhoppen
Copy link
Contributor

Because there's no reason for its removal.

@Partheo
Copy link
Contributor

Partheo commented Mar 13, 2018

I don't think it's your call to remove this feature. If we are rebasing then the while point of this is to get new features. If the community hates it then remove it after- not before the rebase is even done.

@ThatLing
Copy link
Contributor Author

@Partheo
It wasn't my intention to come across that way and I apologize if I did. That's the reason why this is a PR and not a straight commit to the branch. But I can see your point so I'll close this now. This can be re-opened in the future if the community wants it removed.

@ThatLing ThatLing closed this Mar 13, 2018
@ThatLing ThatLing deleted the nuke_diagonals branch April 27, 2018 17:23
ThatLing pushed a commit that referenced this pull request Oct 4, 2018
fluffe9911 pushed a commit that referenced this pull request Aug 3, 2019
Amelia0010 pushed a commit that referenced this pull request Oct 29, 2019
strange women in lakes distributing swords
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants