Sort gas reactions by priority properly #16887
Conversation
|
just checked upstream and found this (which confirms my fix is correct) |
|
Test this and make sure hyper noblium doesn't just break the entire gas reaction loop after running 1 time since that is the other possible issue rather then this just being an error with sorting. |
it's not that |
|
I will test this for him |
didnt know there was a priority fix on tg damn |
|
Also just a code side of things was this not possible using the previous proc instead of creating an entirely new proc? |
|
@Simplehorror [09:17:02] Runtime in reactions.dm,62: Cannot read null.priority |
It ran into an error with his new proc which is why the old proc was coded the way it was. |
yeah |
|
the tg fix deleted the old proc |
In theory though if that is the ONLY issue causing noblium to not work you can just use the old proc to create the list in the new location, problem is this means you are now running far more procs per gas reaction going on. |
what? these are different procs |
yeah give me a bit im working on grues right now, my cmp function is being fed nulls |
|
didnt see the s there |
|
ok should be fixed, it was trying to sort an associative list and it isn't |
ok imma gonna run a debug server and test |
|
also I appreciate rdrazga shittalking me in the discord for fixing an atmos bug because it didn't work first try |
so you are actually in discord |
Mate you are posting OPEN PRs that you are not even taking 2 minutes to bug test of course I am going to point it out. |
|
yes because i am working on grues and nobody else was going to do it if i didnt, be happy it happened |
|
obviously the code didn't work (first try), but the logic i had in mind was correct |
|
Ok fair I won't shittalk you as long as you do atleast spend time to bug and lag test this compared to the old code before getting it merged. If this breaks the server it won't be a good fix, if this lags the server people would much rather deal with not having hyper noblium forming properly rather then just laggy atmos reactions. This was a problem with the original TG fix it looks like so it should be a consideration. |
|
it's not going to lag the server, we don't use LINDA + a 5 list sort is nothing, plus I hope being respected isn't being conditional |
|
the middle chamber is hypernob production, the right one is fusion chamber which is being stopped by hypernob |
|
this is the first time im asking for a speedmerge of simeplehorror's PR |
|
In other news for the sake of my sanity (and far more likely future coders sanity) I am going to figure out how to github and put comments on all this dang code to explain what the hell is actually happening in half of this stuff because Jesus. |
NGL I don't think hyper noblium forming is that pressing of an issue, also kat is going to yell at us for conflicting auxmos again |
he will get it sorted out no worries, im atmos mains so i am on my knees for this |
i fear that you will leave incorrect comments (which would be worse if I read comments) |
|
works fine but hotspots from igniters and such still show up even when there's no reaction happening |
yeah igniters will still generate hotspot, but the hotspot wont react with anything, it's not a bug |
it can raise the temperature as it if's burning when it's not actually burning so i recommend fixing it |
|
that is what an igniter is going to do |
it only heats the gas mixture if there's flammable gases in it, because the point of igniters raising temperature is to get the reaction to start, which shouldn't be happening if there's hypernoblium. it's not intended to be a heater. |
|
alright i've made my own pr for that (#16893), but i can close it if you want to include the changes in yours |
ReddicusDragon
left a comment
ReddicusDragon
left a comment
There was a problem hiding this comment.
I'm not even going to try reading atmos code it's black magic
no it is not |
MajManatee
left a comment
MajManatee
left a comment
There was a problem hiding this comment.
test your own god damned code in the future, or im just gonna start closing your PRs
|
i did test this |
|
github ping is shit |
|
remind me to do this properly |
What else |
8 participants
Document the changes in your pull request
guessing that priority doesn't work since they sort into sublists but they're actually only sorted inside the sublists which doesn't make sense when you start pulling them out of these sublists, you would need to sort them again.
Spriting
Wiki Documentation
Changelog
🆑
bugfix: Sort gas reactions by priority properly
/:cl: