Skip to content

refactor: configure golangci-lint and upgrade github actions#246

Merged
yonahd merged 2 commits intoyonahd:mainfrom
cecobask:ci-improvements
Apr 30, 2024
Merged

refactor: configure golangci-lint and upgrade github actions#246
yonahd merged 2 commits intoyonahd:mainfrom
cecobask:ci-improvements

Conversation

@cecobask
Copy link
Copy Markdown
Contributor

  • Setup golangci-lint via a configuration file
    • Enabled all default linters + gci (used for custom imports order)
    • Since the govet linter is already enabled, I removed the vet step from CI
  • Upgraded all GitHub Actions to newer versions
    • Replaced the manual installation and running of goreleaser with the official goreleaser/goreleaser-action
    • Removed the dependencies installation step
  • Created Makefile to enhance local development and shorten commands for CI

This merge request can be reviewed/merged before #241.

Copy link
Copy Markdown
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. One comment

Comment thread go.mod
Copy link
Copy Markdown
Collaborator

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cecobask
Copy link
Copy Markdown
Contributor Author

cecobask commented Apr 27, 2024

The CI fails due to the state of go.mod file.
When I run go mod tidy, it updates the go version in the go.mod file to 1.22.0.
I believe this is happening because of this line, as it expects a particular minimum go version:

toolchain go1.22.2

@yonahd suggested to upgrade go in a separate pull request.

@luisdavim, which option do you suggest as optimal?

  1. Open a separate PR with go version upgrade changes, get it reviewed and merged, then merge this PR
  2. Merge this PR (with failing CI), then handle the CI failure in the PR with go version upgrade changes

@luisdavim
Copy link
Copy Markdown
Collaborator

I'd prefer updating the go version first.

@cecobask
Copy link
Copy Markdown
Contributor Author

I opened a new pull request to address the go version bump: #250

@yonahd
Copy link
Copy Markdown
Owner

yonahd commented Apr 29, 2024

I opened a new pull request to address the go version bump: #250

Can you rebase please

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.52%. Comparing base (6ee101a) to head (3fee0be).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   42.58%   43.52%   +0.94%     
==========================================
  Files          58       58              
  Lines        3276     2718     -558     
==========================================
- Hits         1395     1183     -212     
+ Misses       1707     1361     -346     
  Partials      174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecobask
Copy link
Copy Markdown
Contributor Author

@yonahd, rebased 👍 Everything is working as expected now.
Please, take a look when you get a chance.

@yonahd yonahd merged commit 8adabd8 into yonahd:main Apr 30, 2024
@yonahd
Copy link
Copy Markdown
Owner

yonahd commented Apr 30, 2024

Merged!
Thank you!

@cecobask cecobask deleted the ci-improvements branch April 30, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants