refactor: configure golangci-lint and upgrade github actions#246
refactor: configure golangci-lint and upgrade github actions#246yonahd merged 2 commits intoyonahd:mainfrom
Conversation
29f23a8 to
9f8e840
Compare
f1adfdb to
1997c7b
Compare
yonahd
left a comment
There was a problem hiding this comment.
Looks good overall. One comment
|
The CI fails due to the state of go.mod file. @yonahd suggested to upgrade go in a separate pull request. @luisdavim, which option do you suggest as optimal?
|
|
I'd prefer updating the go version first. |
|
I opened a new pull request to address the go version bump: #250 |
Can you rebase please |
33a1be2 to
3fee0be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 42.58% 43.52% +0.94%
==========================================
Files 58 58
Lines 3276 2718 -558
==========================================
- Hits 1395 1183 -212
+ Misses 1707 1361 -346
Partials 174 174 ☔ View full report in Codecov by Sentry. |
|
@yonahd, rebased 👍 Everything is working as expected now. |
|
Merged! |
golangci-lintvia a configuration filegovetlinter is already enabled, I removed the vet step from CIgoreleaserwith the official goreleaser/goreleaser-actionMakefileto enhance local development and shorten commands for CIThis merge request can be reviewed/merged before #241.