refactor: map false minikube unused resources#241
Conversation
| slicesToAppend := [][]string{ | ||
| volumesCM, | ||
| envCM, | ||
| envFromCM, | ||
| envFromContainerCM, | ||
| envFromInitContainerCM, | ||
| } |
There was a problem hiding this comment.
This is automatic formatting by my IDE (GoLand). There are multiple similar changes across the files.
Let me know if this is okay. If not, I can undo the formatting changes.
Ideally, the code style should be enforced by rules. Possibly, a target in a Makefile using gofmt, gofumpt?
There was a problem hiding this comment.
Yeah. We need to enforce it in the CI.
I'll open a task for it
There was a problem hiding this comment.
Strange. Intellij doesn't reformat to this.
There was a problem hiding this comment.
There might be some differences in how IntelliJ and GoLand work when it comes to formatting. I’m using the default code style configuration, no custom tweaks there.
| slicesToAppend := [][]string{ | ||
| volumesCM, | ||
| envCM, | ||
| envFromCM, | ||
| envFromContainerCM, | ||
| envFromInitContainerCM, | ||
| } |
There was a problem hiding this comment.
Strange. Intellij doesn't reformat to this.
|
This PR also covers #235 almost completely. The ClusterRole
@yonahd would you prefer that I'll submit a different PR for that or rather should we include the single difference in this PR? |
@doronkg there are not some docker related configmaps specific to kind? |
All the ConfigMaps are the same between |
Moving this discussion to the relevant ticket. |
cecobask
force-pushed
the
minikube-exceptions
branch
from
e9f6f23 to
63abd7e
Compare
|
@yonahd, I rebased my branch with the latest changes and fixed the lint issues. |
3 participants
Fixes #238