Skip to content

feat: add Kind exceptions#263

Merged
yonahd merged 1 commit intoyonahd:mainfrom
doronkg:kind-exclusions
May 7, 2024
Merged

feat: add Kind exceptions#263
yonahd merged 1 commit intoyonahd:mainfrom
doronkg:kind-exclusions

Conversation

@doronkg
Copy link
Copy Markdown
Contributor

@doronkg doronkg commented May 7, 2024

What this PR does / why we need it

This PR excludes the default resources created in basic kind installations.
The only excluded resource in a default service created in macOS installation.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes test for any new code

Github Issue

Closes #235

Notes for your reviewers

I've tested kind both on Windows & Linux, and all the default unused resources are already covered by kor (added from other distros exclusions). The only difference is mentioned here but it was added in #252.

This PR adds exceptions from macOS installation.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.37%. Comparing base (97d3873) to head (ef6b8a8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   43.37%   43.37%           
=======================================
  Files          58       58           
  Lines        2808     2808           
=======================================
  Hits         1218     1218           
  Misses       1400     1400           
  Partials      190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd merged commit 0f0a46b into yonahd:main May 7, 2024
@doronkg doronkg deleted the kind-exclusions branch June 18, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map false unused resources: Kind

3 participants