Skip to content

feat: add GKE exceptions#252

Merged
yonahd merged 9 commits intoyonahd:mainfrom
pbr0ck3r:pbr0ck3r/feat/add-GKE-exceptions
May 1, 2024
Merged

feat: add GKE exceptions#252
yonahd merged 9 commits intoyonahd:mainfrom
pbr0ck3r:pbr0ck3r/feat/add-GKE-exceptions

Conversation

@pbr0ck3r
Copy link
Copy Markdown
Contributor

@pbr0ck3r pbr0ck3r commented Apr 30, 2024

kor version: vdev


| |/ / _ | _
| ' / | | | |) |
| . \ |
| | _ <
||____/|| _\

Unused Resources in Namespace: gmp-system
+---+---------------+---------------------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+---+---------------+---------------------------+
| 1 | ConfigMap | config-images |
| 2 | ConfigMap | webhook-ca |
| 3 | ReplicaSet | rule-evaluator-6fd7ddb94c |
+---+---------------+---------------------------+

Unused Resources in Namespace: kube-system
+----+----------------+------------------------------------------------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+----+----------------+------------------------------------------------------+
| 1 | ConfigMap | cluster-autoscaler-status |
| 2 | ConfigMap | cluster-kubestore |
| 3 | ConfigMap | clustermetrics |
| 4 | ConfigMap | extension-apiserver-authentication |
| 5 | ConfigMap | gke-common-webhook-heartbeat |
| 6 | ConfigMap | ingress-uid |
| 7 | ConfigMap | konnectivity-agent-autoscaler-config |
| 8 | ConfigMap | kube-apiserver-legacy-service-account-token-tracking |
| 9 | ConfigMap | kube-dns-autoscaler |
| 10 | ConfigMap | kubedns-config-images |
| 11 | Service | vpa-recommender |
| 12 | ServiceAccount | metadata-proxy |
| 13 | Role | cloud-provider |
| 14 | Role | system:controller:glbc |
| 15 | ReplicaSet | metrics-server-v0.6.3-7cb4458849 |
| 16 | DaemonSet | fluentbit-gke-256pd |
| 17 | DaemonSet | fluentbit-gke-max |
| 18 | DaemonSet | gke-metrics-agent-scaling-10 |
| 19 | DaemonSet | gke-metrics-agent-scaling-100 |
| 20 | DaemonSet | gke-metrics-agent-scaling-20 |
| 21 | DaemonSet | gke-metrics-agent-scaling-200 |
| 22 | DaemonSet | gke-metrics-agent-scaling-50 |
| 23 | DaemonSet | gke-metrics-agent-scaling-500 |
| 24 | DaemonSet | gke-metrics-agent-windows |
| 25 | DaemonSet | kube-proxy |
| 26 | DaemonSet | metadata-proxy-v0.1 |
| 27 | DaemonSet | nccl-fastsocket-installer |
| 28 | DaemonSet | nvidia-gpu-device-plugin-large-cos |
| 29 | DaemonSet | nvidia-gpu-device-plugin-large-ubuntu |
| 30 | DaemonSet | nvidia-gpu-device-plugin-medium-cos |
| 31 | DaemonSet | nvidia-gpu-device-plugin-medium-ubuntu |
| 32 | DaemonSet | nvidia-gpu-device-plugin-small-cos |
| 33 | DaemonSet | nvidia-gpu-device-plugin-small-ubuntu |
| 34 | DaemonSet | pdcsi-node-windows |
| 35 | DaemonSet | runsc-metric-server |
| 36 | DaemonSet | tpu-device-plugin |
+----+----------------+------------------------------------------------------+

Unused Crds:
+----+---------------+-------------------------------------------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+----+---------------+-------------------------------------------------+
| 1 | Crd | allowlistedv2workloads.auto.gke.io |
| 2 | Crd | allowlistedworkloads.auto.gke.io |
| 3 | Crd | backendconfigs.cloud.google.com |
| 4 | Crd | capacityrequests.internal.autoscaling.gke.io |
| 5 | Crd | clusterpodmonitorings.monitoring.googleapis.com |
| 6 | Crd | clusterrules.monitoring.googleapis.com |
| 7 | Crd | frontendconfigs.networking.gke.io |
| 8 | Crd | gkenetworkparamsets.networking.gke.io |
| 9 | Crd | globalrules.monitoring.googleapis.com |
| 10 | Crd | managedcertificates.networking.gke.io |
| 11 | Crd | memberships.hub.gke.io |
| 12 | Crd | networks.networking.gke.io |
| 13 | Crd | podmonitorings.monitoring.googleapis.com |
| 14 | Crd | provisioningrequests.autoscaling.x-k8s.io |
| 15 | Crd | rules.monitoring.googleapis.com |
| 16 | Crd | serviceattachments.networking.gke.io |
| 17 | Crd | servicenetworkendpointgroups.networking.gke.io |
| 18 | Crd | updateinfos.nodemanagement.gke.io |
| 19 | Crd | volumesnapshotclasses.snapshot.storage.k8s.io |
| 20 | Crd | volumesnapshotcontents.snapshot.storage.k8s.io |
| 21 | Crd | volumesnapshots.snapshot.storage.k8s.io |
+----+---------------+-------------------------------------------------+

Unused ClusterRoles:
+----+---------------+----------------------------------------------------------------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+----+---------------+----------------------------------------------------------------------+
| 1 | ClusterRole | admin |
| 2 | ClusterRole | cloud-provider |
| 3 | ClusterRole | edit |
| 4 | ClusterRole | system:aggregate-to-admin |
| 5 | ClusterRole | system:aggregate-to-edit |
| 6 | ClusterRole | system:certificates.k8s.io:certificatesigningrequests:nodeclient |
| 7 | ClusterRole | system:certificates.k8s.io:certificatesigningrequests:selfnodeclient |
| 8 | ClusterRole | system:certificates.k8s.io:kube-apiserver-client-approver |
| 9 | ClusterRole | system:certificates.k8s.io:kube-apiserver-client-kubelet-approver |
| 10 | ClusterRole | system:certificates.k8s.io:kubelet-serving-approver |
| 11 | ClusterRole | system:certificates.k8s.io:legacy-unknown-approver |
| 12 | ClusterRole | system:controller:cloud-node-controller |
| 13 | ClusterRole | system:controller:glbc |
| 14 | ClusterRole | system:heapster |
| 15 | ClusterRole | system:kube-aggregator |
| 16 | ClusterRole | system:kubelet-api-admin |
| 17 | ClusterRole | system:persistent-volume-provisioner |
+----+---------------+----------------------------------------------------------------------+

Unused StorageClasss:
+---+---------------+---------------+
| # | RESOURCE TYPE | RESOURCE NAME |
+---+---------------+---------------+
| 1 | StorageClass | premium-rwo |
| 2 | StorageClass | standard |
| 3 | StorageClass | standard-rwo |
+---+---------------+---------------+

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 43.49%. Comparing base (333b525) to head (3d7de0b).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/kor/crds.go 0.00% 2 Missing ⚠️
pkg/kor/daemonsets.go 0.00% 1 Missing and 1 partial ⚠️
pkg/kor/roles.go 0.00% 1 Missing and 1 partial ⚠️
pkg/kor/storageclasses.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   43.60%   43.49%   -0.12%     
==========================================
  Files          58       58              
  Lines        2768     2773       +5     
==========================================
- Hits         1207     1206       -1     
- Misses       1382     1386       +4     
- Partials      179      181       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread pkg/kor/replicaset.go Outdated
@pbr0ck3r pbr0ck3r requested a review from yonahd May 1, 2024 13:19
Copy link
Copy Markdown
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments

Comment thread .github/pull_request_template.md Outdated
Comment thread pkg/kor/replicaset.go Outdated
@pbr0ck3r pbr0ck3r requested a review from yonahd May 1, 2024 17:27
Copy link
Copy Markdown
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
Thank you!

@yonahd yonahd merged commit e75b893 into yonahd:main May 1, 2024
@yonahd yonahd linked an issue May 1, 2024 that may be closed by this pull request
@pbr0ck3r pbr0ck3r deleted the pbr0ck3r/feat/add-GKE-exceptions branch May 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map false unused resources: GKE

3 participants