Skip to content

Adjust Operations Group Permissions  #2430

@CharlieMc0

Description

@CharlieMc0

Describe the Issue
We want to make sure we correctly categorize high risk messages based on the potential impact.

Some of these messages need to be adjusted:

// OperationPolicyMessages keeps track of the message URLs that can, by default, only be executed by operational policy address
OperationPolicyMessages = []string{
"/zetachain.zetacore.crosschain.MsgRefundAbortedCCTX",
"/zetachain.zetacore.crosschain.MsgAbortStuckCCTX",
"/zetachain.zetacore.crosschain.MsgUpdateRateLimiterFlags",
"/zetachain.zetacore.crosschain.MsgWhitelistERC20",
"/zetachain.zetacore.fungible.MsgDeployFungibleCoinZRC20",
"/zetachain.zetacore.fungible.MsgDeploySystemContracts",
"/zetachain.zetacore.fungible.MsgRemoveForeignCoin",
"/zetachain.zetacore.fungible.MsgUpdateZRC20LiquidityCap",
"/zetachain.zetacore.fungible.MsgUpdateZRC20WithdrawFee",
"/zetachain.zetacore.fungible.MsgUnpauseZRC20",
"/zetachain.zetacore.observer.MsgAddObserver",
"/zetachain.zetacore.observer.MsgRemoveChainParams",
"/zetachain.zetacore.observer.MsgResetChainNonces",
"/zetachain.zetacore.observer.MsgUpdateChainParams",
"/zetachain.zetacore.observer.MsgEnableCCTX",
"/zetachain.zetacore.observer.MsgUpdateGasPriceIncreaseFlags",
"/zetachain.zetacore.lightclient.MsgEnableHeaderVerification",
}
// AdminPolicyMessages keeps track of the message URLs that can, by default, only be executed by admin policy address
AdminPolicyMessages = []string{
"/zetachain.zetacore.crosschain.MsgMigrateTssFunds",
"/zetachain.zetacore.crosschain.MsgUpdateTssAddress",
"/zetachain.zetacore.fungible.MsgUpdateContractBytecode",
"/zetachain.zetacore.fungible.MsgUpdateSystemContract",
"/zetachain.zetacore.observer.MsgUpdateObserver",
"/zetachain.zetacore.authority.MsgAddAuthorization",
"/zetachain.zetacore.authority.MsgRemoveAuthorization",
"/zetachain.zetacore.authority.MsgUpdateChainInfo",
}
// EmergencyPolicyMessages keeps track of the message URLs that can, by default, only be executed by emergency policy address

What is the impact when MsgRemoveForeignCoin is used? If it deletes the supply or takes an irreversible action should be moved to the Admin group

* MsgAddObserver - Does this by itself cause any changes to the network or signing process? It should probably be moved to Admin

Expected Outcome

All of these should move to the admin group and maybe the two described above based on your answers.

  • MsgEnableHeaderVerification
  • MsgRemoveChainParams
  • MsgDeployFungibleCoinZRC20
  • MsgRemoveForeignCoin
  • MsgWhitelistERC20

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions