Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1840 +/- ##
===========================================
+ Coverage 33.95% 40.77% +6.81%
===========================================
Files 132 216 +84
Lines 9253 12780 +3527
===========================================
+ Hits 3142 5211 +2069
- Misses 5886 7173 +1287
- Partials 225 396 +171 |
lumtis
requested review from
brewmaster012,
fadeev,
kevinssgh,
kingpinXD,
skosito and
ws4charlie
as code owners
lumtis
changed the title
skosito
approved these changes
Mar 6, 2024
ws4charlie
approved these changes
Mar 6, 2024
kingpinXD
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
test-coverageto make the command fail when unit test failsFix some failing unit tests.
This also fix the code coverage that went down because of missing directories.