refactor: replace broadcast mode block with sync and remove fungible params#2001
Merged
refactor: replace broadcast mode block with sync and remove fungible params#2001
Conversation
skosito
requested review from
brewmaster012,
kevinssgh,
kingpinXD,
lumtis and
ws4charlie
as code owners
skosito
commented
Apr 9, 2024
skosito
commented
Apr 9, 2024
lumtis
reviewed
Apr 9, 2024
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
There is a lint issue apparently
skosito
changed the title
6 tasks
* Remove unused params from fungible module * Make generate * Changelog * Lint fix * Lint fix
lumtis
approved these changes
Apr 11, 2024
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
Looks good, can we rename the PR title?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2001 +/- ##
===========================================
+ Coverage 70.00% 70.02% +0.01%
===========================================
Files 237 235 -2
Lines 13502 13480 -22
===========================================
- Hits 9452 9439 -13
+ Misses 3598 3589 -9
Partials 452 452
|
skosito
changed the title
Member
Author
done |
ws4charlie
reviewed
Apr 12, 2024
ws4charlie
reviewed
Apr 12, 2024
Member
Author
|
@lumtis @ws4charlie could you please recheck when you get a chance? i reverted proto files indexes changes, including the one i did in cross chain gen state here: 87980cd |
kingpinXD
approved these changes
Apr 17, 2024
lumtis
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of cosmos sdk update (block mode is deprecated in 0.47) , but also generally better to use sync mode.
Also, removing unused fungible params to make upgrade easier.
Closes: #1930
Type of change
Tests
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: