refactor: remove fungible params#2004
Merged
lumtis merged 5 commits intoremove-broadcastmode-blockfrom Apr 11, 2024
Merged
Conversation
skosito
requested review from
brewmaster012,
kevinssgh,
kingpinXD,
lumtis and
ws4charlie
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## remove-broadcastmode-block #2004 +/- ##
==============================================================
+ Coverage 68.52% 68.54% +0.01%
==============================================================
Files 236 234 -2
Lines 13612 13590 -22
==============================================================
- Hits 9328 9315 -13
+ Misses 3834 3825 -9
Partials 450 450
|
lumtis
approved these changes
Apr 10, 2024
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
I fix we can merge this one into develop since since this params was not used at all.
I think we should rather have a feature branch for the BallotMaturityBlock refactoring as it is more sensitive
Member
Author
yes agree, i branched out of: #2001 which is also targeting develop, so we can merge both to develop and have separate branch for params refactoring |
kingpinXD
approved these changes
Apr 11, 2024
lumtis
added a commit
that referenced
this pull request
May 3, 2024
* Remove broadcast mode block wip * Fixes * Changelog * PR comments * Lint fix * refactor: remove fungible params (#2004) * Remove unused params from fungible module * Make generate * Changelog * Lint fix * Lint fix * Fix changelog * Revert proto indexes * Make generate * refactor: deprecate x/params (#2014) * Remove unused params from fungible module * Make generate * Changelog * Lint fix * Lint fix * Migrate emissions params to store * Migrate observer params to its own store * Make generate * Changelog * Lint fixes * Add observer slash amount param to migrate script * Fix tests * Lint fixes * Fixes * Lint fixes * Fixes * Tests * Small cleanup * Remove not needed params store mock * Fixes after merge * Add found flag to get params method * Move ballot maturity blocks param to emissions module * Remove params from observer module * Fix build * PR comments * PR comment * PR comments * PR comments * feat: cosmos v0.47 upgrade (#2039) * proto fixes after merge * Fix tx proto emissions * fixes * make generate * remove tendermint usage * Update changelog * fix test * add some logs to proto gen script * permissions * add more logs * test * test * test * test * test * test * test * test * test * test * cleanup * cleanup * always format proto before generation * generate explicit format deps * set docker username to fix permissions in CI * dummy proto change to test formatting * set buf cache directory * Revert "dummy proto change to test formatting" This reverts commit 7e5c0dc. * refactor: update go-tss (#2094) * Remove unused params from fungible module * Make generate * Changelog * Lint fix * Lint fix * Migrate emissions params to store * Migrate observer params to its own store * Make generate * Changelog * Lint fixes * Add observer slash amount param to migrate script * Fix tests * Lint fixes * Fixes * Lint fixes * Fixes * Tests * Small cleanup * Try upgrade with simapp change * Remove not needed params store mock * fix compile errors * proto changes * Fixes * Upgrade handler changes * Fixes * Fix e2e test * Fixes after merge * Add found flag to get params method * Move ballot maturity blocks param to emissions module * Remove params from observer module * Fix build * Regen proto * Fixes for e2e tests * Fix some unit tests * Fix some lint errors * Fix more unit tests * PR comments * Proto paths fixes * Linters * make typescript * proto format * make specs * make docs * make gen * lint * Fix some unit tests * Fix cli test suites * Fix lints * Tmp comment unit test * lint * Use latest ethermint change and fix test * PR comment * PR comments * Fix one more import * Cleanup * Lint fix * Bump zetachain ethermint * Remove cometbft replace * go mod tidy * bump ethermint * Revert replace * Bump ethermint * Proto files updates after merge * Make generate * Bump ethermint * Fix PR comments * Formatting * Mention observer params removal in breaking changes in changelog * bump ethermint * Remove tendermint dep after go-tss upgrade * go mod tidy * bump go-tss * changelog * changelog --------- Co-authored-by: Alex Gartner <alexg@zetachain.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes params from fungible module as it seems they are not used and there aren't any. Opening a separate PR for this to reduce diffs in upcoming params refactoring PRs, and to check if this removal is ok (base branch is not develop by mistake, so that PR should be merged first).
Closes: n/a
Type of change
Cleanup
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: