test(`e2e`): improve ZEVM Message Passing E2E tests and reformat E2E tests structure by lumtis · Pull Request #2181 · zeta-chain/node

lumtis · 2024-05-14T19:23:08Z

Description

Add assertion that check ZETA are correctly transferred or sent back to the Message Passing contract when reverting
Add new tests: revert failure evm->zevm and zevm->evm
Some other reorganization
- Reorder E2E test names per types
- Create a file for each E2E tests

github-actions · 2024-05-14T19:23:29Z

!!!WARNING!!!
nosec detected in the following files: e2e/e2etests/test_bitcoin_withdraw_multiple.go, e2e/e2etests/e2etests.go, x/crosschain/keeper/process_outbound.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

codecov · 2024-05-14T19:34:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.25%. Comparing base (e57eca1) to head (d4bff59).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2181   +/-   ##
========================================
  Coverage    68.24%   68.25%           
========================================
  Files          259      259           
  Lines        14927    14931    +4     
========================================
+ Hits         10187    10191    +4     
  Misses        4278     4278           
  Partials       462      462

Files	Coverage Δ
x/crosschain/keeper/process_outbound.go	`94.01% <100.00%> (ø)`
x/fungible/keeper/evm.go	`87.25% <100.00%> (ø)`

changelog.md

e2e/e2etests/e2etests.go

e2e/e2etests/helper_bitcoin.go

e2e/e2etests/test_bitcoin_withdraw_segwit.go

Co-authored-by: skosito <skostic9242@gmail.com>

* updated the docker build to utilize the github event release title and removed the mac build because the arm build covers that. * updated change log

…2191) * ci: fixed the conditional for non release runs of the docker build

…ce Proposals (#2192) * adding pipeline to automatically update the release status when a release has gone live i.e. the upgrade height is met and the network is processing blocks again. The script will then update the github release from pre-release to release as long as the release name matches the release title from the governance proposal * updated links to new all that node links

* fix(e2e): correct upgrade-host hostname * fix light upgrade * remove pointless tr * add version change assertion * formatting * fix voting * improve upgrade height check * fix upgrade name * refactor sleep logic --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

e2e/e2etests/test_message_passing_zevm_to_evm.go

e2e/e2etests/test_message_passing_zevm_to_evm_revert.go

ws4charlie

looks good, just two comments (not 100% sure)

lumtis added 3 commits May 14, 2024 19:22

add some spacing

cb0864c

some clean up

afeefa5

add more assertions to zevm mp

9cd4356

lumtis requested review from brewmaster012, kingpinXD, skosito and ws4charlie as code owners May 14, 2024 19:23

github-actions bot added the nosec label May 14, 2024

lumtis added 2 commits May 14, 2024 21:24

changelog

2e778bc

Merge branch 'develop' into test/assertion-message-passing

e98bead

lumtis added 2 commits May 15, 2024 10:41

reorganize e2e tests name

ce38993

create file per test

6f9f3f7

github-actions bot added the breaking:cli label May 15, 2024

lumtis added 6 commits May 15, 2024 12:50

fix error

5bed519

some var name fix in zevm mp tests

f8f98ba

add a no revert test dapp contract

774f589

add zevm mp revert fail test

c25f911

fix zevm revert fail

dced21c

evm to zevm revert fail

c1c0dd0

lumtis changed the title ~~test(e2e): add assertion for ZETA token transfers in ZEVM Message Passing E2E tests~~ test(e2e): improve ZEVM Message Passing E2E tests and reformat E2E tests structure May 15, 2024

lumtis added 3 commits May 15, 2024 14:41

remove redundant types

eaa0257

change changelogs

107ba29

Merge branch 'develop' into test/assertion-message-passing

146b3ec

skosito reviewed May 15, 2024

View reviewed changes

changelog.md Outdated Show resolved Hide resolved

skosito approved these changes May 15, 2024

View reviewed changes

e2e/e2etests/e2etests.go Outdated Show resolved Hide resolved

e2e/e2etests/e2etests.go Show resolved Hide resolved

e2e/e2etests/helper_bitcoin.go Show resolved Hide resolved

e2e/e2etests/test_bitcoin_withdraw_segwit.go Show resolved Hide resolved

lumtis and others added 3 commits May 16, 2024 09:17

Update changelog.md

a95705e

Co-authored-by: skosito <skostic9242@gmail.com>

ci: fix docker release pipeline tag issue. (#2189)

53d2c6d

* updated the docker build to utilize the github event release title and removed the mac build because the arm build covers that. * updated change log

ci: fixed the conditional for non release runs of the docker build (#…

78e702d

…2191) * ci: fixed the conditional for non release runs of the docker build

gzukel and others added 3 commits May 16, 2024 09:56

add note for file per test

b79ff3b

lumtis requested a review from a team as a code owner May 16, 2024 07:57

github-actions bot added the ci Changes to CI pipeline or github actions label May 16, 2024

Merge branch 'develop' into test/assertion-message-passing

3725219

github-actions bot removed the ci Changes to CI pipeline or github actions label May 16, 2024

ws4charlie reviewed May 16, 2024

View reviewed changes

e2e/e2etests/test_message_passing_zevm_to_evm.go Show resolved Hide resolved

ws4charlie reviewed May 16, 2024

View reviewed changes

e2e/e2etests/test_message_passing_zevm_to_evm_revert.go Show resolved Hide resolved

ws4charlie reviewed May 16, 2024

View reviewed changes

conmflicts

d4bff59

lumtis requested a review from ws4charlie May 17, 2024 07:18

ws4charlie approved these changes May 17, 2024

View reviewed changes

lumtis merged commit 8be5a21 into develop May 17, 2024

lumtis deleted the test/assertion-message-passing branch May 17, 2024 15:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(`e2e`): improve ZEVM Message Passing E2E tests and reformat E2E tests structure#2181

test(`e2e`): improve ZEVM Message Passing E2E tests and reformat E2E tests structure#2181
lumtis merged 24 commits intodevelopfrom
test/assertion-message-passing

lumtis commented May 14, 2024 •

edited

Loading

Uh oh!

github-actions bot commented May 14, 2024 •

edited

Loading

Uh oh!

codecov bot commented May 14, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ws4charlie left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

lumtis commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ws4charlie left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lumtis commented May 14, 2024 •

edited

Loading

github-actions bot commented May 14, 2024 •

edited

Loading

codecov bot commented May 14, 2024 •

edited

Loading