Skip to content

ci: fixed the conditional for non release runs of the docker build#2191

Merged
gzukel merged 2 commits intodevelopfrom
fix-docker-build-version-conditional
May 15, 2024
Merged

ci: fixed the conditional for non release runs of the docker build#2191
gzukel merged 2 commits intodevelopfrom
fix-docker-build-version-conditional

Conversation

@gzukel
Copy link
Contributor

@gzukel gzukel commented May 15, 2024

Description

fixed the conditional for non release runs of the docker build

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • CI

How Has This Been Tested?

This was tested in the private ci node repo for testing automation around releases and it is not pulling the release title for the version and the conditional triggers are working correctly.

image
  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@gzukel gzukel requested a review from a team as a code owner May 15, 2024 19:59
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label May 15, 2024
Copy link
Contributor

@CryptoFewka CryptoFewka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gzukel gzukel merged commit 0afe725 into develop May 15, 2024
@gzukel gzukel deleted the fix-docker-build-version-conditional branch May 15, 2024 20:35
lumtis pushed a commit that referenced this pull request May 16, 2024
…2191)

* ci: fixed the conditional for non release runs of the docker build
lumtis added a commit that referenced this pull request May 17, 2024
…tests structure (#2181)

* add some spacing

* some clean up

* add more assertions to zevm mp

* changelog

* reorganize e2e tests name

* create file per test

* fix error

* some var name fix in zevm mp tests

* add a no revert test dapp contract

* add zevm mp revert fail test

* fix zevm revert fail

* evm to zevm revert fail

* remove redundant types

* change changelogs

* Update changelog.md

Co-authored-by: skosito <skostic9242@gmail.com>

* ci: fix docker release pipeline tag issue. (#2189)

* updated the docker build to utilize the github event release title and removed the mac build because the arm build covers that.

* updated change log

* ci: fixed the conditional for non release runs of the docker build (#2191)

* ci: fixed the conditional for non release runs of the docker build

* ci: Automate GitHub Release Status Update Based on ZetaChain Governance Proposals (#2192)

* adding pipeline to automatically update the release status when a release has gone live i.e. the upgrade height is met and the network is processing blocks again. The script will then update the github release from pre-release to release as long as the release name matches the release title from the governance proposal

* updated links to new all that node links

* fix(e2e): upgrade tests (#2190)

* fix(e2e): correct upgrade-host hostname

* fix light upgrade

* remove pointless tr

* add version change assertion

* formatting

* fix voting

* improve upgrade height check

* fix upgrade name

* refactor sleep logic

---------

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* add note for file per test

---------

Co-authored-by: skosito <skostic9242@gmail.com>
Co-authored-by: Grant Zukel <80433392+gzukel@users.noreply.github.com>
Co-authored-by: Alex Gartner <alexg@zetachain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes to CI pipeline or github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants