Skip to content

fix: register the group module sdk.tx interface to the cosmos InterfaceRegistry#3460

Merged
gartnera merged 6 commits intorelease/v27from
release-v27-register-group-module
Feb 4, 2025
Merged

fix: register the group module sdk.tx interface to the cosmos InterfaceRegistry#3460
gartnera merged 6 commits intorelease/v27from
release-v27-register-group-module

Conversation

@kingpinXD
Copy link
Member

@kingpinXD kingpinXD commented Feb 3, 2025

Description

Add the group module to the cosmos interface registry

How Has This Been Tested

Used the following query to verify

zetacored q tx 1BB1551D2360A1BFBEE17F658B8B2E55B019E23ECB05A2BCFCF17D79C9A9C617 --node=https://zetachain-mainnet.g.allthatnode.com:443/archive/tendermint

Summary by CodeRabbit

  • New Features
    • Updated contract interactions for Bitcoin and Solana following a new protocol workflow.
    • Introduced a liquidity cap option for token creation.
    • Added a CLI command to fetch inbound ballots.
    • Enabled inscription parsing on Bitcoin mainnet.
    • Integrated enhanced group management capabilities.
  • Bug Fixes
    • Improved fee validation with additional safeguards.
  • Refactor
    • Upgraded infrastructure components for better performance and clearer error messaging.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This pull request updates the encoding configuration by integrating the group module from the Cosmos SDK. The change adds a new import and a call to groupmodule.RegisterInterfaces(registry) in the MakeEncodingConfig function and updates its comment. Additionally, the changelog is revised for version 27.0.0 to document breaking changes in universal contract calls, the introduction of a liquidity cap parameter in ZRC20 creation, cosmos-sdk upgrade to v50.x, new CLI commands, and several refactoring and error-handling improvements.

Changes

File(s) Change Summary
app/encoding.go Added a new import for the groupmodule package and a call to groupmodule.RegisterInterfaces in MakeEncodingConfig; modified the corresponding comment by removing the phrase "for testing".
changelog.md Updated to version 27.0.0 detailing breaking changes in universal contract calls, addition of a liquidity cap parameter for ZRC20, upgrade to cosmos-sdk v50.x, new CLI command for inbound ballots, and other refactoring improvements.

Sequence Diagram(s)

Old Universal Contract Call Flow

sequenceDiagram
    participant User
    participant Gateway
    participant SystemContract
    participant UniversalContract
    User->>Gateway: Initiate depositAndCall / call
    Gateway->>SystemContract: Invoke onCrossChainCall
    SystemContract->>UniversalContract: Process contract logic
Loading

New Universal Contract Call Flow

sequenceDiagram
    participant User
    participant Gateway
    participant UniversalContract
    User->>Gateway: Initiate depositAndCall / call
    Gateway->>UniversalContract: Invoke onCall
    UniversalContract-->>Gateway: Return result
Loading

Possibly related PRs

Suggested labels

no-changelog

Suggested reviewers

  • fbac
  • skosito
  • lumtis
  • swift1337

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kingpinXD kingpinXD marked this pull request as ready for review February 3, 2025 21:03
@kingpinXD kingpinXD requested a review from a team as a code owner February 3, 2025 21:03
@kingpinXD kingpinXD changed the base branch from develop to release/v27 February 3, 2025 21:04
@gartnera gartnera enabled auto-merge (squash) February 3, 2025 22:49
@gartnera gartnera disabled auto-merge February 3, 2025 22:52
@kingpinXD kingpinXD added the UPGRADE_TESTS Run make start-upgrade-tests label Feb 4, 2025
@gartnera gartnera enabled auto-merge (squash) February 4, 2025 00:12
@gartnera gartnera merged commit 290478e into release/v27 Feb 4, 2025
43 checks passed
@gartnera gartnera deleted the release-v27-register-group-module branch February 4, 2025 00:29
gartnera pushed a commit that referenced this pull request Feb 4, 2025
…aceRegistry` (#3460)

* register group module in MakeEncodingConfig

* fix comment

* add changelog

* add interfaces for missing modules

* add interfaces for missing modules

* update changelog to v27.0.1
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
…aceRegistry` (#3468)

* fix: register the group module sdk.tx interface to the cosmos `InterfaceRegistry` (#3460)

* register group module in MakeEncodingConfig

* fix comment

* add changelog

* add interfaces for missing modules

* add interfaces for missing modules

* update changelog to v27.0.1

* remove duplicate crisistypes

---------

Co-authored-by: Tanmay <tanmay@zetachain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UPGRADE_TESTS Run make start-upgrade-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants