Skip to content

fix: register the group module sdk.tx interface to the cosmos InterfaceRegistry #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gartnera merged 6 commits into from
Feb 4, 2025
Merged

fix: register the group module sdk.tx interface to the cosmos InterfaceRegistry #3460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd3c0d8
register group module in MakeEncodingConfig
kingpinXD Feb 3, 2025
77be2b1
fix comment
kingpinXD Feb 3, 2025
7df5530
add changelog
kingpinXD Feb 3, 2025
f367d12
add interfaces for missing modules
kingpinXD Feb 3, 2025
7c3ea59
add interfaces for missing modules
kingpinXD Feb 3, 2025
ea4bfa9
update changelog to v27.0.1
kingpinXD Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions app/encoding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,22 @@ import (
upgradetypes "cosmossdk.io/x/upgrade/types"
cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
vestingtypes "github.com/cosmos/cosmos-sdk/x/auth/vesting/types"
"github.com/cosmos/cosmos-sdk/x/authz"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
consensusparamtypes "github.com/cosmos/cosmos-sdk/x/consensus/types"
crisistypes "github.com/cosmos/cosmos-sdk/x/crisis/types"
distrtypes "github.com/cosmos/cosmos-sdk/x/distribution/types"
govtypesv1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
govtypesv1beta1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
groupmodule "github.com/cosmos/cosmos-sdk/x/group"
proposaltypes "github.com/cosmos/cosmos-sdk/x/params/types/proposal"
slashingtypes "github.com/cosmos/cosmos-sdk/x/slashing/types"
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
evmenc "github.com/zeta-chain/ethermint/encoding"
ethermint "github.com/zeta-chain/ethermint/types"
evmtypes "github.com/zeta-chain/ethermint/x/evm/types"
feemarkettypes "github.com/zeta-chain/ethermint/x/feemarket/types"

authoritytypes "github.com/zeta-chain/node/x/authority/types"
crosschaintypes "github.com/zeta-chain/node/x/crosschain/types"
Expand All @@ -23,11 +30,10 @@ import (
observertypes "github.com/zeta-chain/node/x/observer/types"
)

// MakeEncodingConfig creates an EncodingConfig for testing
// MakeEncodingConfig creates an EncodingConfig
func MakeEncodingConfig() ethermint.EncodingConfig {
encodingConfig := evmenc.MakeConfig()
registry := encodingConfig.InterfaceRegistry

// TODO test if we need to register these interfaces again as MakeConfig already registers them
// https://github.com/zeta-chain/node/issues/3003
cryptocodec.RegisterInterfaces(registry)
Expand All @@ -48,6 +54,14 @@ func MakeEncodingConfig() ethermint.EncodingConfig {
fungibletypes.RegisterInterfaces(registry)
observertypes.RegisterInterfaces(registry)
lightclienttypes.RegisterInterfaces(registry)
groupmodule.RegisterInterfaces(registry)
govtypesv1beta1.RegisterInterfaces(registry)
govtypesv1.RegisterInterfaces(registry)
proposaltypes.RegisterInterfaces(registry)
crisistypes.RegisterInterfaces(registry)
feemarkettypes.RegisterInterfaces(registry)
consensusparamtypes.RegisterInterfaces(registry)
vestingtypes.RegisterInterfaces(registry)

return encodingConfig
}
6 changes: 6 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# CHANGELOG

## v27.0.1

### Fixes

* [3460](https://github.com/zeta-chain/node/pull/3460) - add `group`,`gov`,`params`,`consensus`,`feemarket` ,`crisis`,`vesting` modules to the cosmos interface registry to enable parsing of tx results.

## v27.0.0

### Breaking Changes
Expand Down