Skip to content

fix: set retry gas limit if outbound is successful#3820

Merged
lumtis merged 2 commits intorelease/v29from
retry-gas-limit-patch
Apr 23, 2025
Merged

fix: set retry gas limit if outbound is successful#3820
lumtis merged 2 commits intorelease/v29from
retry-gas-limit-patch

Conversation

@skosito
Copy link
Member

@skosito skosito commented Apr 22, 2025

Description

Currently if outbound is successful retry gas limit will be 0, meaning there won't be retry for voting if 500k is not enough.
This introduces retry gas limit 1M for all observers.

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

@skosito skosito added the no-changelog Skip changelog CI check label Apr 22, 2025
@skosito skosito requested a review from a team as a code owner April 22, 2025 18:45
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.40%. Comparing base (c2b3813) to head (c2496fc).
Report is 1 commits behind head on release/v29.

Files with missing lines Patch % Lines
zetaclient/chains/solana/observer/outbound.go 0.00% 1 Missing ⚠️
zetaclient/chains/ton/observer/outbound.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           release/v29    #3820   +/-   ##
============================================
  Coverage        64.40%   64.40%           
============================================
  Files              469      469           
  Lines            32915    32915           
============================================
  Hits             21200    21200           
  Misses           10745    10745           
  Partials           970      970           
Files with missing lines Coverage Δ
zetaclient/chains/evm/observer/outbound.go 62.60% <100.00%> (ø)
zetaclient/chains/sui/observer/outbound.go 56.44% <100.00%> (ø)
zetaclient/chains/solana/observer/outbound.go 33.75% <0.00%> (ø)
zetaclient/chains/ton/observer/outbound.go 28.96% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skosito let's create a PR for develop as well

@lumtis lumtis added the CONSENSUS_BREAKING_ACK Acknowledge a consensus breaking change label Apr 23, 2025
@lumtis lumtis merged commit 4beec46 into release/v29 Apr 23, 2025
52 of 53 checks passed
@lumtis lumtis deleted the retry-gas-limit-patch branch April 23, 2025 11:03
skosito added a commit that referenced this pull request Apr 23, 2025
* set retry gas limit if evm outbound is successful

* add constant for retry gas limit
@skosito
Copy link
Member Author

skosito commented Apr 23, 2025

@skosito let's create a PR for develop as well

#3821

github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2025
* fix: set retry gas limit if outbound is successful (#3820)

* set retry gas limit if evm outbound is successful

* add constant for retry gas limit

* changelog

* improve comment
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2025
* fix: set retry gas limit if outbound is successful (#3820)

* set retry gas limit if evm outbound is successful

* add constant for retry gas limit

* parse solana inbounds from inner instructions

* changelog

* cleanup

* update comment

* use instruction index for event index

* extract parsing logic to inbound parser

* use simple counter for event index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CONSENSUS_BREAKING_ACK Acknowledge a consensus breaking change no-changelog Skip changelog CI check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants