Skip to content

fix: set retry gas limit if outbound is successful #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lumtis merged 2 commits into from
Apr 23, 2025
Merged

fix: set retry gas limit if outbound is successful #3820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edb2db4
set retry gas limit if evm outbound is successful
skosito Apr 22, 2025
c2496fc
add constant for retry gas limit
skosito Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zetaclient/chains/evm/observer/outbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (ob *Observer) postVoteOutbound(

const gasLimit = zetacore.PostVoteOutboundGasLimit

var retryGasLimit uint64
retryGasLimit := zetacore.PostVoteOutboundRetryGasLimit
if msg.Status == chains.ReceiveStatus_failed {
retryGasLimit = zetacore.PostVoteOutboundRevertGasLimit
}
Expand Down
2 changes: 1 addition & 1 deletion zetaclient/chains/solana/observer/outbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
gasLimit = zetacore.PostVoteOutboundGasLimit
)

var retryGasLimit uint64
retryGasLimit := zetacore.PostVoteOutboundRetryGasLimit

Check warning on line 154 in zetaclient/chains/solana/observer/outbound.go

View check run for this annotation

Codecov / codecov/patch

zetaclient/chains/solana/observer/outbound.go#L154 

Added line #L154 was not covered by tests
if msg.Status == chains.ReceiveStatus_failed {
retryGasLimit = zetacore.PostVoteOutboundRevertGasLimit
}
Expand Down
2 changes: 1 addition & 1 deletion zetaclient/chains/sui/observer/outbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ func (ob *Observer) validateOutbound(cctx *cctypes.CrossChainTx, tx models.SuiTr
func (ob *Observer) postVoteOutbound(ctx context.Context, msg *cctypes.MsgVoteOutbound) error {
const gasLimit = zetacore.PostVoteOutboundGasLimit

retryGasLimit := uint64(0)
retryGasLimit := zetacore.PostVoteOutboundRetryGasLimit
if msg.Status == chains.ReceiveStatus_failed {
retryGasLimit = zetacore.PostVoteOutboundRevertGasLimit
}
Expand Down
2 changes: 1 addition & 1 deletion zetaclient/chains/ton/observer/outbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@

const gasLimit = zetacore.PostVoteOutboundGasLimit

var retryGasLimit uint64
retryGasLimit := zetacore.PostVoteOutboundRetryGasLimit

Check warning on line 255 in zetaclient/chains/ton/observer/outbound.go

View check run for this annotation

Codecov / codecov/patch

zetaclient/chains/ton/observer/outbound.go#L255 

Added line #L255 was not covered by tests
if msg.Status == chains.ReceiveStatus_failed {
retryGasLimit = zetacore.PostVoteOutboundRevertGasLimit
}
Expand Down
3 changes: 3 additions & 0 deletions zetaclient/zetacore/constant.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ const (
// PostVoteOutboundRevertGasLimit is the gas limit for voting on observed outbound tx for revert (when outbound fails)
// The value is set to 7M because in case of onRevert call, it might consume lot of gas
PostVoteOutboundRevertGasLimit = 7_000_000

// PostVoteOutboundRevertGasLimit is the retry gas limit for voting on observed outbound tx for success outbound
PostVoteOutboundRetryGasLimit uint64 = 1_000_000
)

// constants for monitoring tx results
Expand Down