feat: Sui message context ID as dynamic field#4087
Merged
ws4charlie merged 22 commits intodevelopfrom Aug 27, 2025
Merged
Conversation
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis change set removes all legacy Sui gateway contracts, binaries, and tests, and fully re-enables authenticated call support in the ZetaClient and Sui gateway. It introduces dynamic field handling for message context IDs, updates deployment and test logic to use the current gateway and example contracts, and reactivates all related client, contract, and test code. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ZetaClient
participant SuiGateway
participant SuiChain
User->>ZetaClient: Initiate authenticated withdraw-and-call
ZetaClient->>SuiGateway: Query active message context (dynamic field)
SuiGateway-->>ZetaClient: Return message context ID
ZetaClient->>SuiChain: Build and submit PTB with set/reset message context
SuiChain-->>ZetaClient: Transaction result (success/failure)
ZetaClient-->>User: Report transaction outcome
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes identified. Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
ws4charlie
added
chain:sui
SUI_TESTS
ws4charlie
added
CONSENSUS_BREAKING_ACK
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4087 +/- ##
===========================================
- Coverage 66.04% 65.96% -0.08%
===========================================
Files 454 454
Lines 33602 33674 +72
===========================================
+ Hits 22192 22214 +22
- Misses 10446 10487 +41
- Partials 964 973 +9
🚀 New features to boost your workflow:
|
🚨 Bugbot Trial ExpiredYour team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot. A team admin can activate the plan in the Cursor dashboard. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pkg/contracts/sui/gateway.go (1)
294-308: Consider adding nil check for data parameter.While the implementation is correct, adding a nil check for the
dataparameter would improve robustness.func ParseDynamicFieldValueStr(data models.SuiParsedData) (string, error) { + if data.Fields == nil { + return "", errors.New("nil fields in parsed data") + } + // dynamic field object contains 3 fields: id, name, value // the 'value' is what the dynamic field stores rawValue, ok := data.Fields["value"]e2e/runner/setup_sui.go (1)
380-425: Consider adding retry logic for transient failures.The implementation correctly handles message context issuance with duplicate prevention. However, consider adding retry logic for the transaction execution to handle transient network failures.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (34)
changelog.md(1 hunks)cmd/zetae2e/local/local.go(1 hunks)cmd/zetae2e/local/sui.go(1 hunks)contrib/localnet/orchestrator/Dockerfile.fastbuild(1 hunks)e2e/contracts/sui/bin/bin.go(0 hunks)e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/.gitignore(0 hunks)e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/Move.toml(0 hunks)e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/README.md(0 hunks)e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/sources/evm.move(0 hunks)e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/sources/gateway.move(0 hunks)e2e/contracts/sui/protocol-contracts-sui-upgrade/sources/gateway.move(6 hunks)e2e/e2etests/e2etests.go(0 hunks)e2e/e2etests/test_sui_token_withdraw_and_call_legacy.go(0 hunks)e2e/e2etests/test_sui_token_withdraw_and_call_revert_with_call_legacy.go(0 hunks)e2e/e2etests/test_sui_withdraw_and_call_legacy.go(0 hunks)e2e/e2etests/test_sui_withdraw_and_call_revert_with_call_legacy.go(0 hunks)e2e/runner/setup_sui.go(8 hunks)e2e/runner/sui.go(1 hunks)e2e/runner/sui_gateway_upgrade.go(1 hunks)pkg/contracts/sui/errors.go(0 hunks)pkg/contracts/sui/errors_test.go(0 hunks)pkg/contracts/sui/gateway.go(4 hunks)pkg/contracts/sui/gateway_test.go(3 hunks)pkg/contracts/sui/withdraw_and_call.go(2 hunks)pkg/contracts/sui/withdraw_and_call_test.go(2 hunks)zetaclient/chains/sui/signer/signer.go(1 hunks)zetaclient/chains/sui/signer/signer_test.go(2 hunks)zetaclient/chains/sui/signer/signer_tx.go(2 hunks)zetaclient/chains/sui/signer/tss_owned_object.go(2 hunks)zetaclient/chains/sui/signer/tss_owned_object_test.go(1 hunks)zetaclient/chains/sui/signer/withdraw_and_call.go(5 hunks)zetaclient/chains/sui/signer/withdraw_and_call_test.go(0 hunks)zetaclient/testutils/mocks/sui_client.go(1 hunks)zetaclient/testutils/mocks/sui_gen.go(1 hunks)
💤 Files with no reviewable changes (14)
- e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/README.md
- pkg/contracts/sui/errors_test.go
- pkg/contracts/sui/errors.go
- e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/.gitignore
- e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/sources/evm.move
- e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/Move.toml
- e2e/e2etests/test_sui_withdraw_and_call_revert_with_call_legacy.go
- e2e/e2etests/test_sui_withdraw_and_call_legacy.go
- zetaclient/chains/sui/signer/withdraw_and_call_test.go
- e2e/contracts/sui/bin/bin.go
- e2e/e2etests/test_sui_token_withdraw_and_call_legacy.go
- e2e/e2etests/test_sui_token_withdraw_and_call_revert_with_call_legacy.go
- e2e/e2etests/e2etests.go
- e2e/contracts/sui/protocol-contracts-sui-upgrade-legacy/sources/gateway.move
🧰 Additional context used
📓 Path-based instructions (1)
**/*.go
⚙️ CodeRabbit Configuration File
Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Files:
e2e/runner/sui_gateway_upgrade.gocmd/zetae2e/local/sui.gozetaclient/chains/sui/signer/signer.gopkg/contracts/sui/withdraw_and_call_test.gozetaclient/testutils/mocks/sui_gen.gopkg/contracts/sui/withdraw_and_call.gopkg/contracts/sui/gateway.gozetaclient/testutils/mocks/sui_client.gocmd/zetae2e/local/local.goe2e/runner/sui.gozetaclient/chains/sui/signer/tss_owned_object_test.gozetaclient/chains/sui/signer/signer_tx.gopkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/tss_owned_object.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/sui/signer/withdraw_and_call.goe2e/runner/setup_sui.go
🧠 Learnings (41)
📓 Common learnings
Learnt from: gartnera
PR: zeta-chain/node#3070
File: cmd/zetae2e/init.go:0-0
Timestamp: 2024-10-30T17:56:16.341Z
Learning: In code reviews for Go files like `cmd/zetae2e/init.go` in the ZetaChain project, avoid suggesting unrelated refactoring. Focus comments on changes relevant to the PR objectives.
Learnt from: gartnera
PR: zeta-chain/node#3228
File: zetaclient/orchestrator/orchestrator.go:388-401
Timestamp: 2024-11-27T22:01:49.732Z
Learning: When reviewing code changes in `zetaclient/orchestrator/orchestrator.go`, avoid suggesting refactoring that is unrelated to the current PR.
Learnt from: gartnera
PR: zeta-chain/node#3489
File: pkg/chains/chains.go:0-0
Timestamp: 2025-02-06T15:31:32.723Z
Learning: SuiMainnet uses chain ID 105 (temporarily) instead of 101 to avoid collision with ZetaChainPrivnet. This is tracked in issue #3491 for proper resolution.
Learnt from: skosito
PR: zeta-chain/node#3939
File: go.mod:52-52
Timestamp: 2025-05-30T16:31:30.275Z
Learning: The ethermint dependency updates in the zeta-chain/node repository are typically moves between feature branches and main branch of the same fork, not breaking API changes. CI status should be verified before assuming compilation issues.
Learnt from: gartnera
PR: zeta-chain/node#3632
File: zetaclient/chains/solana/signer/signer.go:304-304
Timestamp: 2025-03-04T22:39:58.395Z
Learning: The Solana signer implementation in zetaclient/chains/solana/signer/signer.go has limited test coverage, particularly for the transaction broadcasting logic with fallback scenarios. Adding this coverage has been acknowledged as a potential future improvement outside the scope of immediate fixes.
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/orchestrator.go:192-217
Timestamp: 2024-07-04T23:46:38.428Z
Learning: The `GetUpdatedSigner` method in `zetaclient/orchestrator/orchestrator.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go` and `zetaclient/orchestrator/orchestrator_test.go`.
Learnt from: gartnera
PR: zeta-chain/node#3228
File: cmd/zetaclientd/start.go:222-231
Timestamp: 2024-11-27T22:02:48.034Z
Learning: In the `zetaclient` codebase, port numbers like `26657` are hardcoded, and changing them to be configurable via the config struct is considered unrelated refactoring.
Learnt from: ws4charlie
PR: zeta-chain/node#4007
File: e2e/contracts/sui/example-authenticated-call/sources/example.move:69-71
Timestamp: 2025-07-14T21:05:38.534Z
Learning: In Sui Move test contracts for the ZetaChain project, it's acceptable to define generic structs with phantom type parameters for testing type argument functionality without fully implementing their usage in entry functions. The goal is to validate the type system behavior, not to provide complete operational functionality.
Learnt from: lumtis
PR: zeta-chain/node#3500
File: pkg/contracts/sui/gateway.go:62-62
Timestamp: 2025-02-12T13:42:27.999Z
Learning: The `from` and `to` parameters in the `queryInbounds` function of the Sui gateway are temporary placeholders that will be removed or implemented in a future PR.
📚 Learning: 2024-10-31T16:21:47.362Z
Learnt from: gartnera
PR: zeta-chain/node#3071
File: e2e/e2etests/test_stress_eth_withdraw.go:0-0
Timestamp: 2024-10-31T16:21:47.362Z
Learning: In `e2e/e2etests/test_stress_eth_withdraw.go`, when handling the error returned by `stats.Describe` in the `TestStressEtherWithdraw` function, log the error instead of failing the test.
Applied to files:
e2e/runner/sui_gateway_upgrade.gocmd/zetae2e/local/local.go
📚 Learning: 2025-04-22T15:32:20.706Z
Learnt from: ws4charlie
PR: zeta-chain/node#3793
File: pkg/contracts/sui/withdraw_and_call_ptb.go:111-118
Timestamp: 2025-04-22T15:32:20.706Z
Learning: The constant `moduleName` is defined in `pkg/contracts/sui/gateway.go` with the value `"gateway"` and is used across multiple files in the `sui` package.
Applied to files:
e2e/runner/sui_gateway_upgrade.gocmd/zetae2e/local/sui.gopkg/contracts/sui/withdraw_and_call_test.gopkg/contracts/sui/withdraw_and_call.gopkg/contracts/sui/gateway.gopkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/tss_owned_object.goe2e/contracts/sui/protocol-contracts-sui-upgrade/sources/gateway.movezetaclient/chains/sui/signer/withdraw_and_call.goe2e/runner/setup_sui.go
📚 Learning: 2024-08-01T18:08:13.681Z
Learnt from: kingpinXD
PR: zeta-chain/node#2615
File: x/crosschain/keeper/msg_server_vote_outbound_tx_test.go:472-472
Timestamp: 2024-08-01T18:08:13.681Z
Learning: The `SaveFailedOutbound` function in `x/crosschain/keeper/msg_server_vote_outbound_tx.go` requires a string argument for the error message.
Applied to files:
e2e/runner/sui_gateway_upgrade.gozetaclient/chains/sui/signer/signer_tx.go
📚 Learning: 2025-08-06T01:54:04.100Z
Learnt from: kingpinXD
PR: zeta-chain/node#4064
File: cmd/zetae2e/local/solana.go:0-0
Timestamp: 2025-08-06T01:54:04.100Z
Learning: The `CheckSolanaTSSBalance()` method in e2e/runner has been refactored to not return an error. Instead, it uses internal assertions (require statements) to fail the test immediately if balance checks fail. This is part of a broader refactoring pattern in the E2E runner where balance check methods were changed from error-returning to assertion-based approaches.
Applied to files:
e2e/runner/sui_gateway_upgrade.gocmd/zetae2e/local/sui.gopkg/contracts/sui/withdraw_and_call_test.gocmd/zetae2e/local/local.goe2e/runner/sui.gozetaclient/chains/sui/signer/tss_owned_object_test.gozetaclient/chains/sui/signer/signer_tx.goe2e/runner/setup_sui.go
📚 Learning: 2024-10-30T17:56:16.341Z
Learnt from: gartnera
PR: zeta-chain/node#3070
File: cmd/zetae2e/init.go:0-0
Timestamp: 2024-10-30T17:56:16.341Z
Learning: In code reviews for Go files like `cmd/zetae2e/init.go` in the ZetaChain project, avoid suggesting unrelated refactoring. Focus comments on changes relevant to the PR objectives.
Applied to files:
cmd/zetae2e/local/sui.gopkg/contracts/sui/withdraw_and_call_test.gocmd/zetae2e/local/local.gozetaclient/chains/sui/signer/withdraw_and_call.goe2e/runner/setup_sui.go
📚 Learning: 2024-11-27T22:01:49.732Z
Learnt from: gartnera
PR: zeta-chain/node#3228
File: zetaclient/orchestrator/orchestrator.go:388-401
Timestamp: 2024-11-27T22:01:49.732Z
Learning: When reviewing code changes in `zetaclient/orchestrator/orchestrator.go`, avoid suggesting refactoring that is unrelated to the current PR.
Applied to files:
cmd/zetae2e/local/sui.gocontrib/localnet/orchestrator/Dockerfile.fastbuildpkg/contracts/sui/withdraw_and_call_test.gocmd/zetae2e/local/local.gozetaclient/chains/sui/signer/signer_tx.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/sui/signer/withdraw_and_call.goe2e/runner/setup_sui.go
📚 Learning: 2024-11-01T17:07:59.584Z
Learnt from: gartnera
PR: zeta-chain/node#3079
File: e2e/e2etests/test_pause_erc20_custody.go:65-68
Timestamp: 2024-11-01T17:07:59.584Z
Learning: In the file `e2e/e2etests/test_pause_erc20_custody.go`, prefer verbosity and avoid extracting common event handling logic into helper functions to enhance readability and ease future refactoring.
Applied to files:
cmd/zetae2e/local/sui.gopkg/contracts/sui/withdraw_and_call_test.gopkg/contracts/sui/withdraw_and_call.gocmd/zetae2e/local/local.goe2e/runner/sui.gozetaclient/chains/sui/signer/signer_tx.gopkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/sui/signer/withdraw_and_call.goe2e/runner/setup_sui.go
📚 Learning: 2024-10-10T18:50:23.406Z
Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/codec_abi.go:0-0
Timestamp: 2024-10-10T18:50:23.406Z
Learning: The constant `ABIAlignment` has been moved from `pkg/memo/codec_abi.go` to the `testutil` package.
Applied to files:
cmd/zetae2e/local/sui.gopkg/contracts/sui/withdraw_and_call_test.go
📚 Learning: 2024-09-13T22:29:09.747Z
Learnt from: ws4charlie
PR: zeta-chain/node#2870
File: zetaclient/orchestrator/orchestrator.go:413-413
Timestamp: 2024-09-13T22:29:09.747Z
Learning: When a method is renamed (e.g., `IsUTXO()` to `IsBitcoin()`), and existing tests cover the affected code paths, do not request additional tests for the renamed methods.
Applied to files:
cmd/zetae2e/local/sui.gopkg/contracts/sui/withdraw_and_call_test.gocmd/zetae2e/local/local.gozetaclient/chains/sui/signer/signer_test.go
📚 Learning: 2024-10-31T21:15:55.881Z
Learnt from: gartnera
PR: zeta-chain/node#3077
File: cmd/zetae2e/local/local.go:188-191
Timestamp: 2024-10-31T21:15:55.881Z
Learning: In Go file `cmd/zetae2e/local/local.go`, the network is fully functional before calling `FundEmissionsPool()`, so retry logic is unnecessary.
Applied to files:
cmd/zetae2e/local/sui.go
📚 Learning: 2024-09-24T18:43:18.488Z
Learnt from: gartnera
PR: zeta-chain/node#2817
File: contrib/rpcimportable/rpcimportable_test.go:9-11
Timestamp: 2024-09-24T18:43:18.488Z
Learning: When reviewing test functions intended solely to verify package importability, avoid suggesting additional assertions or checks that are beyond the intended scope.
Applied to files:
cmd/zetae2e/local/sui.go
📚 Learning: 2024-12-11T17:10:18.193Z
Learnt from: gartnera
PR: zeta-chain/node#3277
File: cmd/zetae2e/get_zetaclient_bootstrap.go:62-66
Timestamp: 2024-12-11T17:10:18.193Z
Learning: In the `getZetaclientBootstrap` function within `cmd/zetae2e/get_zetaclient_bootstrap.go`, `Validator` and `Description` in `validatorRes` are not pointers. An error is returned if `validatorRes` is nil (not found), so additional nil checks for these fields are unnecessary.
Applied to files:
cmd/zetae2e/local/sui.go
📚 Learning: 2024-11-06T21:10:14.301Z
Learnt from: gartnera
PR: zeta-chain/node#3105
File: e2e/runner/setup_bitcoin.go:51-69
Timestamp: 2024-11-06T21:10:14.301Z
Learning: In test code (`e2e/runner/setup_bitcoin.go`), adding security measures for private key handling in the `GetBtcAddress` method is not required.
Applied to files:
cmd/zetae2e/local/sui.gocmd/zetae2e/local/local.goe2e/runner/sui.goe2e/runner/setup_sui.go
📚 Learning: 2024-07-05T00:02:31.446Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/chain_activate.go:184-247
Timestamp: 2024-07-05T00:02:31.446Z
Learning: The `CreateSignerObserverBTC` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.
Applied to files:
cmd/zetae2e/local/sui.gozetaclient/chains/sui/signer/signer.gopkg/contracts/sui/withdraw_and_call_test.gocmd/zetae2e/local/local.goe2e/runner/sui.gozetaclient/chains/sui/signer/tss_owned_object_test.gozetaclient/chains/sui/signer/signer_tx.gopkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/tss_owned_object.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/sui/signer/withdraw_and_call.go
📚 Learning: 2024-07-04T23:46:38.428Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/orchestrator.go:192-217
Timestamp: 2024-07-04T23:46:38.428Z
Learning: The `GetUpdatedSigner` method in `zetaclient/orchestrator/orchestrator.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go` and `zetaclient/orchestrator/orchestrator_test.go`.
Applied to files:
cmd/zetae2e/local/sui.gozetaclient/chains/sui/signer/signer.gocmd/zetae2e/local/local.gozetaclient/chains/sui/signer/tss_owned_object_test.gozetaclient/chains/sui/signer/signer_tx.gopkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/tss_owned_object.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/sui/signer/withdraw_and_call.go
📚 Learning: 2024-10-31T16:23:17.250Z
Learnt from: gartnera
PR: zeta-chain/node#3071
File: e2e/e2etests/test_stress_eth_withdraw.go:41-42
Timestamp: 2024-10-31T16:23:17.250Z
Learning: In `e2e/e2etests/test_stress_eth_withdraw.go`, since some goroutines may fail, we should use a mutex to append durations of successful withdrawals for accurate latency reporting.
Applied to files:
cmd/zetae2e/local/sui.gocmd/zetae2e/local/local.go
📚 Learning: 2024-07-05T00:02:36.493Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/chain_activate.go:116-181
Timestamp: 2024-07-05T00:02:36.493Z
Learning: The `CreateSignerObserverEVM` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.
Applied to files:
cmd/zetae2e/local/sui.gozetaclient/chains/sui/signer/signer.gocmd/zetae2e/local/local.gozetaclient/chains/sui/signer/tss_owned_object_test.gopkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/tss_owned_object.gozetaclient/chains/sui/signer/signer_test.go
📚 Learning: 2025-03-04T22:39:58.395Z
Learnt from: gartnera
PR: zeta-chain/node#3632
File: zetaclient/chains/solana/signer/signer.go:304-304
Timestamp: 2025-03-04T22:39:58.395Z
Learning: The Solana signer implementation in zetaclient/chains/solana/signer/signer.go has limited test coverage, particularly for the transaction broadcasting logic with fallback scenarios. Adding this coverage has been acknowledged as a potential future improvement outside the scope of immediate fixes.
Applied to files:
cmd/zetae2e/local/sui.gozetaclient/chains/sui/signer/signer.gozetaclient/chains/sui/signer/tss_owned_object_test.gozetaclient/chains/sui/signer/signer_tx.gozetaclient/chains/sui/signer/tss_owned_object.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/sui/signer/withdraw_and_call.go
📚 Learning: 2024-07-04T23:47:56.072Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/orchestrator.go:222-237
Timestamp: 2024-07-04T23:47:56.072Z
Learning: The `GetUpdatedChainObserver` method in the `Orchestrator` class is covered by unit tests in `zetaclient/orchestrator/orchestrator_test.go` and `zetaclient/orchestrator/chain_activate_test.go`.
Applied to files:
cmd/zetae2e/local/sui.gocmd/zetae2e/local/local.gozetaclient/chains/sui/signer/tss_owned_object_test.gopkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/signer_test.go
📚 Learning: 2025-02-06T16:29:58.925Z
Learnt from: gartnera
PR: zeta-chain/node#3485
File: e2e/utils/sui/signer.go:24-35
Timestamp: 2025-02-06T16:29:58.925Z
Learning: The Sui blockchain requires signatures in [R || S || V] format, which is best generated using go-ethereum's crypto.Sign function that takes an ecdsa.PrivateKey.
Applied to files:
zetaclient/chains/sui/signer/signer.goe2e/runner/sui.gozetaclient/chains/sui/signer/tss_owned_object.goe2e/runner/setup_sui.go
📚 Learning: 2024-11-26T15:01:35.685Z
Learnt from: skosito
PR: zeta-chain/node#3217
File: cmd/zetae2e/config/local.yml:6-7
Timestamp: 2024-11-26T15:01:35.685Z
Learning: In `cmd/zetae2e/config/local.yml`, including private keys is acceptable because the file is used only for local end-to-end tests and already includes other private keys.
Applied to files:
contrib/localnet/orchestrator/Dockerfile.fastbuild
📚 Learning: 2024-10-08T15:34:48.217Z
Learnt from: ws4charlie
PR: zeta-chain/node#2907
File: zetaclient/chains/bitcoin/observer/outbound_test.go:81-82
Timestamp: 2024-10-08T15:34:48.217Z
Learning: In the `mineTxNSetNonceMark` function within `bitcoin/observer/outbound_test.go`, it's acceptable to hardcode the chain ID, as the tests do not require varying chain IDs.
Applied to files:
pkg/contracts/sui/withdraw_and_call_test.gozetaclient/chains/sui/signer/tss_owned_object_test.gozetaclient/chains/sui/signer/signer_tx.gozetaclient/chains/sui/signer/signer_test.go
📚 Learning: 2024-10-10T18:54:33.554Z
Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: testutil/sample/memo.go:0-0
Timestamp: 2024-10-10T18:54:33.554Z
Learning: In the `testutil/sample/memo.go` file, unchecked type assertions in the `ABIPack` function are acceptable because it is designed for unit tests and simplicity.
Applied to files:
pkg/contracts/sui/withdraw_and_call_test.gozetaclient/chains/sui/signer/tss_owned_object_test.gopkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/signer_test.go
📚 Learning: 2024-10-10T19:29:59.300Z
Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/fields_v0_test.go:270-320
Timestamp: 2024-10-10T19:29:59.300Z
Learning: In the `FieldsV0` struct of the `memo` package, `RevertAddress` may be left empty when `CallOnRevert` is set to true.
Applied to files:
pkg/contracts/sui/withdraw_and_call_test.go
📚 Learning: 2024-10-10T19:11:53.045Z
Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/codec_abi_test.go:13-24
Timestamp: 2024-10-10T19:11:53.045Z
Learning: In `pkg/memo/codec_abi_test.go`, `newArgInstance` intentionally returns `nil` for unsupported types to facilitate testing of invalid type handling.
Applied to files:
pkg/contracts/sui/withdraw_and_call_test.go
📚 Learning: 2025-05-30T16:31:30.275Z
Learnt from: skosito
PR: zeta-chain/node#3939
File: go.mod:52-52
Timestamp: 2025-05-30T16:31:30.275Z
Learning: The ethermint dependency updates in the zeta-chain/node repository are typically moves between feature branches and main branch of the same fork, not breaking API changes. CI status should be verified before assuming compilation issues.
Applied to files:
changelog.md
📚 Learning: 2025-02-06T15:31:32.723Z
Learnt from: gartnera
PR: zeta-chain/node#3489
File: pkg/chains/chains.go:0-0
Timestamp: 2025-02-06T15:31:32.723Z
Learning: SuiMainnet uses chain ID 105 (temporarily) instead of 101 to avoid collision with ZetaChainPrivnet. This is tracked in issue #3491 for proper resolution.
Applied to files:
changelog.md
📚 Learning: 2024-11-27T22:02:48.034Z
Learnt from: gartnera
PR: zeta-chain/node#3228
File: cmd/zetaclientd/start.go:222-231
Timestamp: 2024-11-27T22:02:48.034Z
Learning: In the `zetaclient` codebase, port numbers like `26657` are hardcoded, and changing them to be configurable via the config struct is considered unrelated refactoring.
Applied to files:
changelog.md
📚 Learning: 2025-01-22T22:46:58.820Z
Learnt from: gartnera
PR: zeta-chain/node#3395
File: .github/workflows/reusable-sim.yml:29-30
Timestamp: 2025-01-22T22:46:58.820Z
Learning: The zeta-chain/node repository uses Go version >= 1.22. Do not suggest downgrading to earlier versions like 1.21.
Applied to files:
changelog.md
📚 Learning: 2025-04-22T15:41:33.611Z
Learnt from: ws4charlie
PR: zeta-chain/node#3793
File: zetaclient/chains/sui/signer/withdraw_and_call.go:228-238
Timestamp: 2025-04-22T15:41:33.611Z
Learning: The Sui API's SuiMultiGetObjects method returns an error if any requested object is not found, rather than returning partial results.
Applied to files:
zetaclient/testutils/mocks/sui_gen.go
📚 Learning: 2025-01-14T03:37:18.430Z
Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: pkg/math/integer_test.go:0-0
Timestamp: 2025-01-14T03:37:18.430Z
Learning: Use big.Int for handling large number calculations and edge cases to avoid integer overflow issues.
Applied to files:
pkg/contracts/sui/gateway.go
📚 Learning: 2024-12-06T16:21:15.465Z
Learnt from: gartnera
PR: zeta-chain/node#3252
File: x/observer/keeper/operational_flags.go:24-25
Timestamp: 2024-12-06T16:21:15.465Z
Learning: In this codebase, prefer using `MustUnmarshal` for unmarshal operations instead of handling errors explicitly.
Applied to files:
pkg/contracts/sui/gateway.gopkg/contracts/sui/gateway_test.go
📚 Learning: 2024-09-13T22:51:02.192Z
Learnt from: ws4charlie
PR: zeta-chain/node#2870
File: zetaclient/orchestrator/bootstrap.go:142-142
Timestamp: 2024-09-13T22:51:02.192Z
Learning: When code changes involve only renaming without functional changes, and static analysis tools flag missing test coverage, acknowledge that existing tests likely already cover the functionality, and additional tests may not be necessary.
Applied to files:
cmd/zetae2e/local/local.go
📚 Learning: 2025-07-28T18:08:13.883Z
Learnt from: ws4charlie
PR: zeta-chain/node#4053
File: e2e/e2etests/test_bitcoin_std_deposit.go:42-42
Timestamp: 2025-07-28T18:08:13.883Z
Learning: In Bitcoin deposit E2E tests for the ZetaChain project, `DepositBTCWithAmount` is preferred over `DepositBTCWithExactAmount` because depositing exact amounts to a ZEVM receiver is complex. The tests use rough amounts and then calculate the actual received amount from the raw Bitcoin transaction to verify balance changes, making the tests more robust and less flaky.
Applied to files:
cmd/zetae2e/local/local.go
📚 Learning: 2025-04-22T18:22:56.444Z
Learnt from: ws4charlie
PR: zeta-chain/node#3793
File: pkg/contracts/sui/ptb_argument.go:39-48
Timestamp: 2025-04-22T18:22:56.444Z
Learning: The `sui.AddressFromHex` function in the github.com/pattonkan/sui-go package handles both prefixed and non-prefixed addresses by checking for and removing "0x" or "0X" prefixes if present before parsing.
Applied to files:
e2e/runner/sui.go
📚 Learning: 2025-01-14T03:39:29.764Z
Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: zetaclient/chains/bitcoin/signer/sign.go:225-233
Timestamp: 2025-01-14T03:39:29.764Z
Learning: The signature hash calculation in Bitcoin TSS transactions using `txscript.NewCannedPrevOutputFetcher([]byte{}, 0)` with correct input amounts has been proven to work reliably in production, despite theoretical concerns about empty previous output fetcher.
Applied to files:
e2e/runner/sui.go
📚 Learning: 2025-01-23T20:29:05.877Z
Learnt from: gartnera
PR: zeta-chain/node#3406
File: cmd/zetae2e/local/local.go:199-199
Timestamp: 2025-01-23T20:29:05.877Z
Learning: The function `monitorBlockProductionExit` in cmd/zetae2e/local/local.go uses context cancellation to handle errors, not os.Exit, and should ideally be named `monitorBlockProductionCancel` to better reflect its behavior.
Applied to files:
zetaclient/chains/sui/signer/signer_tx.go
📚 Learning: 2024-11-06T21:11:34.420Z
Learnt from: gartnera
PR: zeta-chain/node#3105
File: cmd/zetae2e/local/bitcoin.go:8-8
Timestamp: 2024-11-06T21:11:34.420Z
Learning: In the `e2e` codebase, it's acceptable to use `github.com/stretchr/testify/require` outside of test files.
Applied to files:
pkg/contracts/sui/gateway_test.gozetaclient/chains/sui/signer/tss_owned_object.go
📚 Learning: 2025-07-14T21:05:38.534Z
Learnt from: ws4charlie
PR: zeta-chain/node#4007
File: e2e/contracts/sui/example-authenticated-call/sources/example.move:69-71
Timestamp: 2025-07-14T21:05:38.534Z
Learning: In Sui Move test contracts for the ZetaChain project, it's acceptable to define generic structs with phantom type parameters for testing type argument functionality without fully implementing their usage in entry functions. The goal is to validate the type system behavior, not to provide complete operational functionality.
Applied to files:
zetaclient/chains/sui/signer/signer_test.go
📚 Learning: 2025-07-14T21:08:08.725Z
Learnt from: ws4charlie
PR: zeta-chain/node#4007
File: e2e/runner/sui.go:237-274
Timestamp: 2025-07-14T21:08:08.725Z
Learning: In test code for the ZetaChain project, it's acceptable to use constants for EVM and Sui address lengths rather than adding complex validation logic. This applies to functions like payload construction in E2E tests where the expected lengths are well-defined and documented.
Applied to files:
e2e/contracts/sui/protocol-contracts-sui-upgrade/sources/gateway.move
🔇 Additional comments (34)
changelog.md (1)
14-14: LGTM! The changelog entry accurately reflects the PR objectives.The entry properly documents the re-enabling of Sui authenticated call functionality and the adoption of MessageContext ID as a gateway dynamic field, which aligns with the stated PR objectives.
cmd/zetae2e/local/sui.go (1)
65-65: LGTM! Simplification improves consistency.The removal of the conditional check ensures that the SUI TSS balance is always verified after running tests, which is more consistent and aligns with the cleanup of legacy upgrade-related code paths.
e2e/runner/sui_gateway_upgrade.go (1)
64-64: LGTM! Enhanced error reporting provides valuable debugging information.Including the command output in the error message when the upgrade fails will significantly improve troubleshooting capabilities.
zetaclient/testutils/mocks/sui_gen.go (1)
27-30: LGTM! Interface extension properly supports dynamic field queries.The addition of
SuiXGetDynamicFieldObjectmethod to the interface correctly supports the new dynamic field-based MessageContext ID retrieval functionality. The method signature is appropriate and follows the established patterns.zetaclient/chains/sui/signer/signer.go (1)
34-37: LGTM! RPC interface extension enables dynamic field retrieval.The addition of
SuiXGetDynamicFieldObjectmethod to the RPC interface is essential for supporting the new dynamic field-based MessageContext ID management. The method signature is consistent with the corresponding mock interface.contrib/localnet/orchestrator/Dockerfile.fastbuild (1)
17-18: Path simplification looks appropriate.The directory structure changes remove legacy contract references and streamline the build process, aligning with the PR's objective to eliminate legacy Sui gateway components.
cmd/zetae2e/local/local.go (1)
488-491: Test activation properly replaces legacy implementations.The transition from legacy to current test implementations supports the PR's objective to re-enable authenticated call functionality while removing legacy non-authenticated call tests.
pkg/contracts/sui/withdraw_and_call_test.go (1)
271-278: Message context commands appropriately re-enabled.The restoration of
set_message_contextandreset_message_contextMoveCall commands in the test response aligns with the PR's objective to re-enable authenticated call functionality with dynamic field-based message context management.Also applies to: 287-294
pkg/contracts/sui/withdraw_and_call.go (2)
17-19: New message context function constant properly defined.The addition of
FuncIssueMessageContextsupports the re-enabled authenticated call functionality with appropriate naming convention consistency.
37-37: Command count update reflects restored functionality.The increase from 3 to 5 commands in
ptbWithdrawAndCallCmdCountaccurately accounts for the re-enabledset_message_contextandreset_message_contextoperations in the programmable transaction builder flow.zetaclient/chains/sui/signer/signer_tx.go (2)
98-101: Message context retrieval appropriately restored.The re-enablement of
getMessageContextIDCachedsupports the dynamic field-based message context management that aligns with the updated gateway contract design.
309-309: Legacy error handling properly updated.The transition from
IsRetryableExecutionErrorLegacytoIsRetryableExecutionErrorremoves legacy code while maintaining proper error handling functionality.zetaclient/testutils/mocks/sui_client.go (1)
345-371: LGTM: Mock method follows established patterns.The
SuiXGetDynamicFieldObjectmethod implementation is consistent with other mock methods in the file, correctly handling both function-based and direct return values with appropriate type assertions and error handling.zetaclient/chains/sui/signer/signer_test.go (2)
61-62: LGTM: Re-enables message context ID mocking for authenticated calls.The re-activation of the
MockMessageContextIDfunctionality aligns with the PR objective to restore authenticated call support in the Sui signer.
377-387: LGTM: Updated mock correctly simulates dynamic field retrieval.The
MockMessageContextIDimplementation has been properly updated to mock theSuiXGetDynamicFieldObjectmethod with the correct response structure, reflecting the transition to dynamic field-based message context handling.zetaclient/chains/sui/signer/tss_owned_object_test.go (1)
12-91: LGTM: Comprehensive test coverage for dynamic field retrieval.The test function provides excellent coverage of the
getMessageContextIDmethod, including success scenarios and various error conditions. The table-driven approach with clear test cases enhances maintainability and readability.e2e/runner/sui.go (1)
447-457: LGTM: Enhanced transaction execution with better debugging support.The formatting improvements and addition of
ShowObjectChanges: trueenhance code readability and provide valuable debugging information. The enhanced error message in the assertion will aid in troubleshooting transaction failures.pkg/contracts/sui/gateway_test.go (2)
16-22: LGTM: Validates dynamic field name encoding correctly.The test properly verifies that
ActiveMessageContextDynamicFieldName()returns the expected JSON-encoded byte array representation of the "active_message_context" field name.
565-616: LGTM: Comprehensive test coverage for dynamic field value parsing.The table-driven test effectively validates the
ParseDynamicFieldValueStrfunction with appropriate success and error scenarios, including missing field and type mismatch cases.pkg/contracts/sui/gateway.go (2)
55-58: LGTM! Clean implementation of dynamic field name encoding.The function correctly delegates to the helper function for JSON array encoding.
426-455: LGTM! Well-documented helper function with clear rationale.The implementation correctly handles the Sui JSON-RPC API requirement for byte arrays as integer arrays, with excellent documentation explaining the necessity.
zetaclient/chains/sui/signer/tss_owned_object.go (2)
77-94: LGTM! Consistent caching implementation.The caching logic follows the same pattern as
getWithdrawCapIDCached, maintaining consistency in the codebase.
97-124: LGTM! Robust implementation of dynamic field retrieval.The function correctly queries the dynamic field using the proper RPC method and includes comprehensive error handling for all potential failure points.
e2e/runner/setup_sui.go (3)
35-46: LGTM! Path updates align with removal of legacy contracts.The transition from legacy paths to current paths is consistent with the PR objective of removing legacy contracts.
173-185: LGTM! Proper configuration patching for example package build.The function correctly patches Move.toml files with the actual gateway addresses, ensuring successful compilation and deployment.
545-562: LGTM! Clean utility function for owned object queries.The helper function provides a clean interface for querying owned objects with proper error handling.
e2e/contracts/sui/protocol-contracts-sui-upgrade/sources/gateway.move (4)
29-31: LGTM! Appropriate constant for dynamic field key.The constant clearly identifies the dynamic field for active message context storage.
306-325: LGTM! Elegant implementation reusing existing deposit logic.The donate function efficiently reuses the deposit infrastructure while maintaining a clear separation of concerns through the distinct event type.
415-433: LGTM! Proper dynamic field lifecycle management.The implementation correctly removes any existing dynamic field before adding the new one, preventing orphaned entries.
457-463: LGTM! Robust getter with proper fallback.The function correctly handles both the presence and absence of the dynamic field, returning a zero address ID as a sensible default.
zetaclient/chains/sui/signer/withdraw_and_call.go (4)
190-199: LGTM! Proper inclusion of message context in object references.The function correctly includes the message context ID in the object list and adjusts the index for on-call objects accordingly.
238-248: LGTM! Correct version handling for owned vs shared objects.The logic properly uses current versions for owned objects (withdraw cap and message context) while using initial shared versions for other objects.
380-448: LGTM! Complete message context lifecycle management.The function correctly implements the full lifecycle of message context handling: setting it before the call and resetting it afterward, ensuring proper authentication state management.
450-505: LGTM! Well-structured helper functions for message context commands.Both helper functions follow established patterns and include comprehensive error handling for argument creation and validation.
lumtis
reviewed
Aug 8, 2025
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
Let's keep in draft for now as it will come after the v33 release
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
5 tasks
5 tasks
lumtis
approved these changes
Aug 22, 2025
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
Can you please attach to this PR the security issues that were fixed by this PR?
5 tasks
skosito
approved these changes
Aug 27, 2025
Contributor
Author
Attached links to the security issues. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2026
* fix: ratelimiting race condition vuln (#4072) * fix: ratelimiting race condition vuln * fix: ratelimiting race condition vuln - Fix race condition in RateLimiter.Release() function - Replace non-atomic check-then-act with atomic decrement and bounds checking - Add comprehensive test suite to verify the fix - Update changelog with PR #4072 * fix: correct atomic implementation to prevent underflow - Replace flawed Add(-1) approach with proper CompareAndSwap - Fix underflow detection issue where uint32 wrap-around was missed - Add TestRateLimiterUnderflowProtection to verify the fix - Ensure Release() never causes negative counters or semaphore over-release * refactor: simplify rate limiter Release() implementation - Remove unnecessary infinite loop in CAS operation - Single CAS attempt is sufficient for race condition protection - Maintains thread-safety while being more efficient - All tests still pass with simplified implementation * fix: correct order of operations in rate limiter Release() - Fix race condition by decrementing counter before releasing semaphore - Ensure pending counter accurately reflects semaphore state - Simplify implementation by using correct operation order - All tests pass with cleaner, more logical approach * test: add tests that reproduce the original race condition vulnerability - Add BuggyRateLimiter that implements the original vulnerable code - Add TestBuggyRateLimiterRaceCondition to demonstrate the race condition - Add TestBuggyRateLimiterStressTest to stress test the vulnerability - Add TestVulnerabilityDemonstration to show before/after comparison - Add TestBuggyRateLimiterExcessiveReleases to show excessive release issues - These tests demonstrate the theoretical vulnerability even if timing makes it hard to reproduce consistently * fix: address race condition and underflow issues in RateLimiter - Fix race condition in Release() by reordering operations (decrement pending first, then release semaphore) - Fix Pending() function to handle negative atomic.Int32 values correctly - Add comprehensive tests to verify fixes - Remove buggy code from tests as requested by reviewers - Document original vulnerability in test comments The original race condition allowed multiple goroutines to release more permits than acquired. The Pending() function could return incorrect values due to negative atomic.Int32 conversion. Fixes: #4072 * refactor: rename test and update changelog to reflect actual improvements - Rename TestVulnerabilityDemonstration to TestRateLimiterRobustness - Update test description to reflect code quality improvements rather than vulnerability fixes - Update changelog entry to match actual changes - Tests still pass, confirming the improvements are working correctly The reviewer correctly pointed out that if tests pass on develop without fixes, then we're improving robustness rather than fixing vulnerabilities. * refactor: remove support for v1 revert address for BTC (#4070) * remove support for v1 revert address for BTC * add changelog --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * feat: add support for withdraw using v2 connector contract (#4064) * update go mod * add a new message for migrating funds * add migrate funds to e2e * rebase from develop * add v2 e2e test to check flow * add zeta gateway deposit to zetaclient * add github workflow * update comments * fix code formating * fix code formating * fix code formating * fix unit tests * fix unit tests * revert to old command to start e2e test * remove message for migration and refactor to using contract directly * add changelog * generate files after removing new message * update generated files * update generated files * update go mod * update deposit * add unit tests * add unit tests * generate files * generate files * undo changes based on develop * update deposit and revert smart contract call * rename zeta deposit test file * rename zeta deposit test file * add abort and revert tests * add TestZetaDepositAndCallNoMessage * add TestZetaDepositAndCallNoMessage * remove payable from TestAbort contract * rename to LegacyZETADepositAndCallContract * improve unit test coverage * fix unit tests * add some delay in TestZetacore_SubscribeNewBlocks * update comment for handling zeta token zrc20 * add e2e test * add e2e test for withdraw * refactor ProcessZEVMInboundV2 * add core registry to setup * refactor e2e test helper functions * add unit test for zeta withdraw * add unit test for withdraw and call * resolve comments 1 * add unit test for ProcessRevert * add unit test for ProcessRevert * add unit test for ProcessRevert * improve abort tests * improve abort tests * resolve comments * resolve comments 2 * update upgrade height to 280 to allow the first test to run the entire cycle * wrap zeta mints in tmp context * wrap zeta mint in temp context * rebase * add changelog * add changelog * adjust comments * Update cmd/zetae2e/config/contracts.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix gas pool zeta calcualation * add unit test for executeWithMintedZeta * fix comments 1 * add unit tests * update test dapp to use zeta token for consuming gas * add core registry to zeta e2e post upgrade handler * revert legacy test * update changes based on comments 1 --------- Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: print error message in detail if unable to decode Bitcoin memo (#4090) * print error message detail when memo decoding failed * add changelog entry * keep invalid memo log on Info level --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * test(e2e): update admin e2e tests to use v2 connector (#4071) * update go mod * add a new message for migrating funds * add migrate funds to e2e * rebase from develop * add v2 e2e test to check flow * add zeta gateway deposit to zetaclient * add github workflow * update comments * fix code formating * fix code formating * fix code formating * fix unit tests * fix unit tests * revert to old command to start e2e test * remove message for migration and refactor to using contract directly * add changelog * generate files after removing new message * update generated files * update generated files * update go mod * update deposit * add unit tests * add unit tests * generate files * generate files * undo changes based on develop * update deposit and revert smart contract call * rename zeta deposit test file * rename zeta deposit test file * add abort and revert tests * add TestZetaDepositAndCallNoMessage * add TestZetaDepositAndCallNoMessage * remove payable from TestAbort contract * rename to LegacyZETADepositAndCallContract * improve unit test coverage * fix unit tests * add some delay in TestZetacore_SubscribeNewBlocks * update comment for handling zeta token zrc20 * add e2e test * add e2e test for withdraw * refactor ProcessZEVMInboundV2 * add core registry to setup * refactor e2e test helper functions * add unit test for zeta withdraw * add unit test for withdraw and call * resolve comments 1 * add unit test for ProcessRevert * add unit test for ProcessRevert * add unit test for ProcessRevert * improve abort tests * improve abort tests * resolve comments * resolve comments 2 * update upgrade height to 280 to allow the first test to run the entire cycle * wrap zeta mints in tmp context * wrap zeta mint in temp context * rebase * add changelog * add changelog * adjust comments * Update cmd/zetae2e/config/contracts.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix gas pool zeta calcualation * add unit test for executeWithMintedZeta * fix comments 1 * add unit tests * update admin * revert unncessary changes * disable account balance verification for admin tests * improve naming for deposit functions * add changelog * update comments * update test legacy test zeta to use EVMAddress * remove skipping admin in upgrade setup --------- Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * test: fix eth deposit test to check balance after deposit (#4118) * check balance after eth deposit test * fix typo * fix import * test: fix flaky Solana depositAndCall tests (#4113) * fix flaky solana depositAndCall tests * add changelog entry * add wait logic inside AssertTestDAppEVMCalled * chore: bump cosmos evm to support querying legacy proposals of type MsgUpdateParams (#4094) * update zeta evm * update commit * fix: use evm chain id from eth config in rpc backend (#4096) * fix: cancel solana WaC if tx size is too large (#4098) * cancel solana WaC if tx size is too large * align the comments with the code * fix: nil reference in trace block (#4093) * update to commit be548f7691876e656ec61aa46e31ed337be92f4e , on branch release/v34 --------- Co-authored-by: skosito <skostic9242@gmail.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: morde08 <peter@zetachain.com> * fix: error when deploying contracts on testnet (#4112) * dont return err if tx is not found in get tx receipt * fix tests * changelog * feat: support hostname in addition to public IP for zetaclient to connect to zetacore (#4068) * save initial work to remote * add unit test and live test for zetacore hostname support * add changelog entry; fix gosec and clean unused code * fix CI upgrade test --------- Co-authored-by: Tanmay <tanmay@zetachain.com> * fix: dbg trace block by number gas limit legacy (#4121) * fix dbg trace by block * PR comments * changelog * fix(cherry-pick): cancel solana WaC if tx size is too large (#4111) * cancel solana WaC if tx size is too large * add changelog entry * chore: remove tx suffix in vote inbound and outbound message names (#4110) * fix(`crosschain`): remove confirmation mode from outbound and inbound digest (#4116) * inbound * . * changelog * refactor(zetacore): overwrite consensus config values for all timeout deltas on startup. (#4097) * update 1 * add start-skip-consensus-overwrite-test * generate files * update tests * add unit tests * add unit tests for GenesisChainID * add unit tests for GenesisChainID * rename genesisChainID * fix typo * remove testnet from overwrite check * refactor: replace []byte(fmt.Sprintf) with fmt.Appendf (#4131) Signed-off-by: yinwenyu6 <yinwenyu6@outlook.com> * feat: Sui message context ID as dynamic field (#4087) * re-enable sui authenticated call * integrate message context ID as dynamic field * add changelog entry * make issueMessageContext function self-contained * fix unit test * remove --skip-dependency-verification in sui gateway upgrade test * cancel withdrawAndCall on invalid payload * adopt new increase_nonce signature to adopt gas refund logic when cancelling a CCTX * apply stringent check on Sui transaction's checkpoint * apply status check on Sui inbound * fix CI upgrade test * fix unit test * chore: fix some function names in comment (#4129) Signed-off-by: pxwanglu <pxwanglu@icloud.com> * chore: fix some observer message names (#4141) * test: fix flaky Solana SPL deposit balance check (#4142) * fix solana e2e SPL balance check by waiting maximum 30 seconds * add changelog entry * refactor: remove intx and outtx deprecated queries (#4150) * refactor: remove intx and outtx deprecated queries * fixes in e2e * chore: remove redundant word in comment (#4149) Signed-off-by: wmypku <wmypku@outlook.com> * test(`e2e`): improve logs for CCTX status assertion (#4147) * improve require status logs * update usage in tests * lint * cursor comment * chore: fix some typos in comment (#4146) Signed-off-by: tzchenxixi <tzchenxixi@icloud.com> * chore: set v35 as upgrade test reference and various clean up (#4115) * add back precompiles * add abci field to proposal * test * enable back * test no creating proposasl * disable zeta-ante * cleanup v33 upgrade helper * add v35 as reference * remove gas stability pool temporary * update to v36 and disable fast confirmation test * bitcoin fast confirmation * increase ersion for zeta * remove erc20 init handler * disable zevm to evm revert for older version * disable zevm to evm revert abort for older version * increase upgrade height * feat: make the gas limit used for gateway calls on ZEVM a configurable parameter (#4153) * add GatewayGasLimit to state * refactor function name from MustGetGatewayGasLimit to GetGatewayGasLimitSafe * update unit tests * update unit tests * update proto files * replace big int with uint64 * changelog * add check of older value * add v4 migration back for authority module * update setup handler to remove setting erc20 module * test changes * revert to using v32 as base branch for upgrades --------- Co-authored-by: lumtis <lucas.bertrand.22@gmail.com> * test(`e2e`): add a gas limit option for ZEVM to EVM call tests (#4145) * add gas limit option * use option for tests * increase further upgrade height * test: use pre-deployed example dapp V2 contract in e2e tests (#4158) * do not deploy example contract in e2e tests, use pre-deployed example dapp V2 instead * add changelog entry * clean up debugging log * remove commented code * add back extra zrc20 SPL balance check * chore(`e2e`): cleanup unused contracts (#4161) * remove contextapp * remove distribute * test: fix flaky depositAndCall test that failed on sender assertion (#4165) * fix flaky depositAndCall caused by sender assertion * add changelog entry * chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4148) Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9. - [Release notes](https://github.com/hashicorp/go-getter/releases) - [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml) - [Commits](hashicorp/go-getter@v1.7.8...v1.7.9) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-getter dependency-version: 1.7.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4172) Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14. - [Commits](ulikunitz/xz@v0.5.11...v0.5.14) --- updated-dependencies: - dependency-name: github.com/ulikunitz/xz dependency-version: 0.5.14 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4173) chore(deps): bump github.com/go-viper/mapstructure/v2 Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0. - [Release notes](https://github.com/go-viper/mapstructure/releases) - [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md) - [Commits](go-viper/mapstructure@v2.2.1...v2.4.0) --- updated-dependencies: - dependency-name: github.com/go-viper/mapstructure/v2 dependency-version: 2.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor: standardize zetaclient logging (#4144) * chore: remove unused DynamicTicker from zetaclient/types * refactor: remove Msgf and refactor zerolog uses * Replace Msgf for Msg * Use '_' instead of '.' * Start logs with lowercase instead of uppercase characters * Use the constants in the logs module * Use With().Logger() instead of log fields when possible * fix: improve zetatool (#4175) * scan gateway events by default for all inbound hashes * scan gateway events by default for all inbound hashes * test(`e2e`): add a E2E test to test depositAndCall with high gas consumption (#4177) * set gas limit to 4m in localnet * add high usage test * changelog * Update changelog.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update e2e/e2etests/e2etests.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * test(`e2e`): add all chains by default in `start-localnet` (#4163) * chore: add Solana to start-localnet to allow to run local tests * add sui and ton * Update cmd/zetae2e/local/local.go Co-authored-by: Tanmay <tanmay@zetachain.com> --------- Co-authored-by: Tanmay <tanmay@zetachain.com> * chore: remove redundant words (#4179) Signed-off-by: keeghcet <keeghcet@outlook.com> * refactor: omit unnecessary reassignment (#4184) Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com> * fix: force rescan if inbound vote monitoring fails (#4183) * add monitoringErr channel * update to InboundBlockHeight - 1 , for reseting the block * fix unit tests * implement error interface * rename to ErrTxMonitor * add forceResetLastScanned flag * add forceResetLastScanned flag * add mutex to force scan * add changelog * add changelog * update name to wasForceReset * wrap UpdateForceResetLastScanned in mutex * add a bound check to InboundBlockHeight to be safe * Update zetaclient/chains/base/confirmation.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/chains/base/observer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * force update for in memory value if forceResetLastScanned is true * add a lock on reading block height * update error message * update changelog * wait till end of scan cycle to toggle the forceUpdateFlag --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: remove duplicate solana post-gas-price goroutine (#4194) * feat: observe inbound from previous gateway package after upgrade (#4138) * observe inbound from old gateway package optionally * add changelog entry * add sui inbound cursor migration; add post-upgrade deposit tests * improve comments, logs and naming; fix post-upgrade withdraw failure * protect anyStringMap * add support for <withdrawcap-id> to Sui gateway address * fix CI upgrade test failure * use name previousPackageID and keep name PairID; rename AnyString and cursor migration function; improve test, comments, etc. * replaced assert by require in sui unit test * add support for original packageID in Sui gateway address * avoid wrapping nil error * use previous package ID in post-upgrade Sui deposit test * add support for previous package deprecation and fix upgrade test * fix unit test * add a note to clarify the PackageID argument used for event query * add documents to explain Sui gateway address format in the chain params * refactor: remove unused loggers and log fields (#4180) * chore: remove unused Headers logger * refactor: remove (mostly) unused GasPrice logger * refactor: replace logs.FieldMethod with With().Caller() and standardize logs.FieldModule values * refactor: remove (mostly) unused log fields FieldTracker and FieldConfirmationMode * refactor: replace missed log instances of '.' for '_' * fix: unpack bitcoin revert message without considering 'CallOnRevert' flag (#4169) * enable bitcoin revertMessage and ignore CallOnRevert flag * add changelog entry * update standard memo doc; improve abort address validation * skip incompatible e2e test to allow CI upgrade test to pass * fix: add timeout to monitoring routine (#4196) * add a timeout for vote monitoring thread * add a timeout for vote monitoring thread * add comments * remove typo for cancel call * fix unit tests * Update zetaclient/zetacore/client_vote.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/chains/base/observer.go Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> * refactor: use maps.Copy for cleaner map handling (#4198) Signed-off-by: joemicky <joemickychang@outlook.com> * chore: fix some comments (#4208) Signed-off-by: zhoujiaweii <zjwustc@outlook.com> * fix: update evm version for missing tx types (#4216) * refactor: replace HasPrefix+TrimPrefix with CutPrefix (#4215) Signed-off-by: quantpoet <quantway@outlook.com> * refactor: remove `LastBlockHeight` state variable (#4200) * proto * remove other references * changelog * refactor: add documentation for ZetaClient logging fields (#4174) * refactor: use coin.CoinType for compliance logging * refactor: add documentation for zetaclient logging fields * fix: remove ZetaChain chain ID from GasStabilityPoolBalances query (#4217) * fix query * add test * changelog * add commment * lint * remove gas token address * change error type * refactor: remove index field in ballot (#4205) * refactor: remove index field in ballot * changelog * fix unit tests * refactor: remove `MsgUpdateERC20CustodyPauseStatus` and `MsgMigrateERC20CustodyFunds` (#4199) * make message legacy * remove other reference * changelog * refactor: rename whitelistERC20 into whitelistAsset (#4203) * refactor: rename whitelistERC20 into whitelistAsset * e2e test * e2e test * fix event * simulation * changelogs * update auth list * add migration script * apply comment * feat: provide error information in CCTX struct when Bitcoin deposit fail (#4211) * add error message to CCTX struct when Bitcoin deposit failed * add changelog entry * fix unit test; improve function naming * add unit test for inbound vote digest * exclude inbound observation error message from digest * fix: re-check for finalized ballot when executing inbound vote to create cctx (#4197) * check for finalized block after ballot is finalized * fix unit tests and add changelog * adjust comments * Apply suggestion from @lumtis Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Apply suggestion from @lumtis Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * refactor check finalized ballot check to be done before adding the finalizing vote to the ballot * adjust comments * adjust comments * fix comments 2 --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: set zeta ante to true in upgrade tests (#4225) * add zeta ante * add to upgrade test regular * add to upgrade test regular * update out of gas test * update out of gas test * fix tss migration test * fix lint issues 1 * update v2 zeta version * chore: resync changelogs with v36 changes (#4223) * fix: skip writing config file to the filesystem (#4210) * comment out writing files to the state * ad changelog * remove commented code * return error from fetching FlagSkipConfigOverwrite * refactor(`observer`): remove deprecated code (#4192) * update proto * update code * changelogs * fix changelog * fix gas limit issue in upgrade test * use ante-zetae2e for admin upgrade tests * test fix * refactor: prepare the client interfaces used by the observer-signers for dry-mode (#4213) refactor: prepare the client interfaces of the observer-signers for dry-mode * feat: enable NoAssetCall from Bitcoin (#4218) * enable NoAssetCall from Bitcoin * add changelog entry * improve comment and log print * revert bitcoin NoAssetCall that carries large excessive funds * adjust btc inbound parsing order; fix test name * improve function and variable names * feat: multiple evm calls in single tx (#4157) * bump protocol contracts * use newer geth version with cancun support * e2e test with 2 deposits in same tx * e2e tests * inbound trackers for multiple events * changelog * generate * fix e2e tests * inbound trackers e2e test * bump protocol contracts * PR comments * PR comment * PR comments * PR comment * lower upgrade height in upgrade tests * try diff upgrade height * upgrade additional fee in upgrade v36 handler * chore: fix function name in comment (#4238) Signed-off-by: russcoss <russcoss@outlook.com> * revert: add timeout to monitoring routine" (#4244) Revert "fix: add timeout to monitoring routine (#4196)" This reverts commit 65f227b. * fix(e2e): check test contracts deployment (#4251) * fix(e2e): check test contracts deployment * add other contracts * changelog * fix chain to wait tx from * revert: force rescan if inbound vote monitoring fails (#4250) * feat: refund a portion of remaining unused tokens to user (#3734) * add new field to cctx structure to track user gas burned * add unit tests * add doc * add unit test for migration * add check for pre upgrade cctxs * add older logic for handling cctxs created before upgrade * remove LegacyChainParams * add unit test for refund gas fee * remove old migration * add temp note for PR review * fix typo * fix typo * generate files * add missing test case * add missing test case * refactor based on comments * update EtherWithdrawRestricted test * update EtherWithdrawRestricted test * update EtherWithdrawRestricted test * enable all tests * update module version for observer migration * generated docs * generated docs * remove deprecated comments * use older chainparams for upgrade tests * use older chainparams for upgrade tests * changes based on comments 1 * add addition param to CallZRC20Deposit * update comments for legacy cctx and refactor unit tests to use the parent function ManageUnusedGasFee * adjust non zevm chain test cases * fix lint errors * fix comments and rebase develop * add statement to ErrParamsStabilityPoolPercentage * Update x/crosschain/keeper/msg_server_vote_outbound.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix comments 3 * rebase develop 2 * rebase develop 2 * update admin test --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * test: add zetaclient only upgrade tests (#4310) * add file based trigger for zetaclient binary download * update zetae2e * add new makefile commands * update comments * remove wait for upgrade height * upgrade contracts on zetaclient test * fixes 1 * add issue to track sui upgrade tests * add issue to track sui upgrade tests * add nosec * fix(`zetatool`): add missing networks (#4424) * add missing networks * add worldchain config * add world chain to unit tests * update tests * add zetaclient changes from main * disable e2e tests not working in the first test run * set light upgrade tests as default for zetaclient label * update rpc import * update contract copy * fix update for removing nonces only if the tx is finalized * fix update for removing nonces only if the tx is finalized * update changelog * rebase develop * rebase develop * generate files * reduced upgrade height for connector-migration-test * update comment for tss migration test --------- Signed-off-by: yinwenyu6 <yinwenyu6@outlook.com> Signed-off-by: pxwanglu <pxwanglu@icloud.com> Signed-off-by: wmypku <wmypku@outlook.com> Signed-off-by: tzchenxixi <tzchenxixi@icloud.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: keeghcet <keeghcet@outlook.com> Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com> Signed-off-by: joemicky <joemickychang@outlook.com> Signed-off-by: zhoujiaweii <zjwustc@outlook.com> Signed-off-by: quantpoet <quantway@outlook.com> Signed-off-by: russcoss <russcoss@outlook.com> Co-authored-by: 0xM3R <omer@zetachain.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: morde08 <peter@zetachain.com> Co-authored-by: skosito <skostic9242@gmail.com> Co-authored-by: yinwenyu6 <yinwenyu6@outlook.com> Co-authored-by: pxwanglu <pxwanglu@icloud.com> Co-authored-by: wmypku <wmypku@outlook.com> Co-authored-by: tzchenxixi <tzchenxixi@icloud.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Renan <renan.061@gmail.com> Co-authored-by: keeghcet <keeghcet@outlook.com> Co-authored-by: fengyuchuanshen <fengyuchuanshen@outlook.com> Co-authored-by: Renan <renan@zetachain.com> Co-authored-by: joemicky <joemickychang@outlook.com> Co-authored-by: zhoujiaweii <zjwustc@outlook.com> Co-authored-by: quantpoet <quantway@outlook.com> Co-authored-by: russcoss <russcoss@outlook.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
* fix: use evm chain id from eth config in rpc backend (#4096)
* fix: cancel solana WaC if tx size is too large (#4098)
* cancel solana WaC if tx size is too large
* align the comments with the code
* fix: nil reference in trace block (#4093)
* chore : bump cosmos evm to support querying legacy proposals of type MsgUpdateParams (#4095)
* update zeta evm
* update commit
* update to commit be548f7691876e656ec61aa46e31ed337be92f4e , on branch release/v34
---------
Co-authored-by: morde08 <peter@zetachain.com>
* fix: remove store initilization for erc20 module (#4103)
* fix(v34-only): use SAFE confirmation mode for all inbound votes (#4117)
* use SAFE confirmation mode for all inbound votes
* move confirmation mode update logic right before signing the inbound vote message
* fix: port Bitcoin memo decoding error log print to v34 (#4100)
port PR 4090 to v34
* fix: backport dbg trace block by number gas limit legacy (#4119)
* fix: backport error when deploying contracts on testnet (#4120)
* refactor(backport): overwrite consensus config values for all timeout deltas on startup (#4126)
* feat: add conditional logic for adding erc20 module based on chain id (#4125)
* add conditional logic for erc20 module upgrade
* bump cosmos version to run evm migration 6 to 7
* add unit tests
* update handler to panic
* add changelog
* format files
* update changelog
* bump cosmos/evm to release/v35
* add back comments for IBC
* add back comments for IBC
* feat(backport/v36): make the gas limit used for gateway calls on ZEVM a configurable parameter (#4154)
* cherry pick
* cherry pick
* update unit tests
* update unit tests
* cherry pick
* replace big int with uint64
* add check of older value
* update upgrade test and changelog
* fix function call
* add v4 migration back for authority module
* add v4 migration back for authority module
---------
Co-authored-by: Tanmay <tanmay.bhattacharya.smit@gmail.com>
* fix: skip writing config file to the filesystem (#4206)
* skip writing config file
* use the value of skip-config-overwrite flag without restrictions for mainnet
* add comments
* remove unused functions
* remove unit tests for unused functions
* fix(backport/v36): unpack bitcoin revert message without considering 'CallOnRevert' flag (#4181)
* unpack revert message from Bitcoin memo without considering flag
* skip incompatible e2e test to allow CI upgrade test to pass
* fix(backport): force rescan if inbound vote monitoring fails using a context that can timeout (#4202)
* backport changes for rescan logic
* remove changelog
* format files
* use context with timeout
* change error message
* cherry pick changes for context with timeout
* format package and fix lint
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* chore(backport/v36): cherry pick e2e tests changes for live networks (#4220)
* fix: add a simple check for finalizing vote (#4236)
* revert: add a simple check for finalizing vote (#4240)
Revert "fix: add a simple check for finalizing vote (#4236)"
This reverts commit d8dc5bac363cbfeb8267705a378fc5a7803e24df.
* revert: force rescan if inbound vote monitoring fails using a context that can timeout (#4241)
Revert "fix(backport): force rescan if inbound vote monitoring fails using a…"
This reverts commit 70ab2a724f96bcf48d2ece29674a8bfbf9bb4469.
* fix(e2e): check test contracts deployment (#4252)
* fix(e2e): check test contracts deployment
* add other contracts
* fix chain to wait tx from
* fix check
* docs: add release lifecycle in the documentation (#4265)
* add a note for releases
* add release lifecycle docs
* refactor: omit unnecessary reassignment (#4264)
Signed-off-by: letreturn <letreturn@outlook.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* refactor(backport): standardize zetaclient logging (#4144) (#4267)
* chore: remove unused DynamicTicker from zetaclient/types
* refactor: remove Msgf and refactor zerolog uses
* Replace Msgf for Msg
* Use '_' instead of '.'
* Start logs with lowercase instead of uppercase characters
* Use the constants in the logs module
* Use With().Logger() instead of log fields when possible
* fix(backport): remove duplicate solana post-gas-price goroutine (#4194) (#4268)
* refactor(backport): remove unused loggers and log fields (#4180) (#4269)
* chore: remove unused Headers logger
* refactor: remove (mostly) unused GasPrice logger
* refactor: replace logs.FieldMethod with With().Caller() and standardize logs.FieldModule values
* refactor: remove (mostly) unused log fields FieldTracker and FieldConfirmationMode
* refactor: replace missed log instances of '.' for '_'
* refactor(backport): add documentation for ZetaClient logging fields (… (#4270)
refactor(backport): add documentation for ZetaClient logging fields (#4174)
* refactor: use coin.CoinType for compliance logging
* refactor: add documentation for zetaclient logging fields
* chore: fix some function names (#4273)
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
* refactor(backport): prepare the client interfaces used by the observe… (#4271)
refactor(backport): prepare the client interfaces used by the observer-signers for dry-mode (#4213)
refactor: prepare the client interfaces of the observer-signers for dry-mode
* refactor: replace the deprecated function in the ioutil package (#4275)
Signed-off-by: mickychang9 <mickychang9@outlook.com>
* feat: multiple evm calls (#4274)
* multiple evm calls in single tx
* gen testdappv2
* cleanup after merge
* ensure gateway proxy is deployed in e2e tests
* fix upgrade tests
* changelog
* PR comments
* feat: add dry-mode support for TON (#4277)
* feat: add dry-mode support for TON
* fix: address review comments
* ci: increase timeout for solana e2e tests (#4276)
* Increase timeout for solana e2e tests
* Remove timeout, but run the test one hour earlier.
* extend timeout for solana
* feat: add feature flag for multiple evm calls (#4288)
* add feature flag for multiple evm calls
* add feature flag to inbound tracker processing
* fix e2e test inbound trackers
* PR review and refactoring
* add todo with issue
* changelog
* use zetae2e ante for upgrade tests
* chore: increase upgrade test height (#4303)
* chore: increase upgrade test height
* test even higher block
* try 300 block height
* refactor: add `zrepo` package to zetaclient with dry-mode (#4296)
refactor: add zrepo package to zetaclient with dry-mode
* ci: remove upgrade tests from merge queue ci (#4309)
* test(`e2e`): improve local stress tests to replicate better live networks (#4293)
* update params
* fix gas limit
* set gas limit to 4m in localnet
* add high usage test
* typo
* set mem pool
* add stress zevm test
* some tests
* send zevm stress tx as batch
* add batch support
* revert back local config
* chore: add Solana to start-localnet to allow to run local tests
* add sui and ton
* improve eth withdraw stress
* use batch model for deposit stress tests
* improve retry logic
* remove unnecessary logs
* fix lint
* fix deposit
* changelogs
* add nosec
* Update changelog.md
Co-authored-by: skosito <skostic9242@gmail.com>
* apply comments
* use deposit and call
* fix last comments
* use 50m for block size
* revert back 30m block
---------
Co-authored-by: skosito <skostic9242@gmail.com>
* chore: fix inconsistent function name in comment (#4297)
Signed-off-by: russcoss <russcoss@outlook.com>
* fix: stop ProcessOutboundTrackers from breaking when it finds an error (#4305)
* feat: localnet monitoring and observability improvements (#4314)
* make PR against develop branch
* add monitoring profile to makefile
* update dashboards
* update grafana image
* fix dashboards
* update namespace to cometbft
* fix dashboard typo
* update dashboard defaults
* fix: adjust inbound retry gas limit; stop broadcasting tx if mempool is congested or base fee too high (#4291)
* adjust inbound retry gas limit; stop broadcasting tx if mempool is congested
* add changelog entry
* use write lock for delete
* add unconfirmed txs count to config and AppContext; skip observation if mempool is congested
* rename functions
* improve naming and documentation; add log print when skipping observation
* add detailed description for inbound retry gas limit adjustment
* do not consider zetacore mempool congestion by default
* consolidate observation skipper functions; print sampled Info logger when observation is skipped
* unit test observation skipper
* rename Bitcoin mempool monitoring goroutine and improve observation skipper description
* configure maximum base fee
* fix gas price observation skipper
* convert Gwei to wei for the max base fee check
* add changelog description for MaxBaseFee
* fix unit test compile
* fix unit test
* feat: add support for Solana Address Lookup Table in withdraw and call (#4266)
* add support for ALT
* split legacy withdraw and call alt to separate test
* fix compile after merge
* add spl e2e test
* ci fixes
* add outbound tests for alt msgs
* PR comments coderabbit
* PR comments
* add feature flag for solana alt
* lint
* fix e2e test
* fix e2e test
* PR comments
* Trigger rebuild
* feat: monitor failed inbound vote and add to an inbound tracker cache (#4295)
* partially cherry-pick PR 4183 and 4196 to monitor failed inbound vote
* implement the backlog for failed inbound vote
* add changelog entry
* fix changelog grammar
* use the internal tracker terminology; use separate goroutine to process internal trackers
* fix internal tracker unit test and update changelog description
* put a limit on number of inbound trackers to process per ticker
* remove unused constant
* fix generte
* remove internal tracker if it was already voted by the observer
* fix unit test
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add dry-mode to Sui and add client wrappers to Sui and TON (#4313)
* feat: add dry-mode to Sui
* refactor: add client wrappers to Sui and TON
* refactor: improve logging messages and code comments
* feat: add dry-mode to Solana (#4317)
* chore: adding ABI used by precompiles. (#4311)
* Adding ABI for precompiles
* added readmes
* refactor: use maps.Clone to simplify code (#4319)
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
* chore: fix some comments (#4331)
Signed-off-by: letreturn <letreturn@outlook.com>
* test(e2e): update local chain params for more performant outbound processing (#4318)
* remove useless comment
* improve parameters
* update for local bitcoin
* increase max block size
* revert chain param changes
* update chain params in e2e setup
* feat: add dry-mode to Bitcoin (#4325)
* feat: add dry-mode to EVM (#4326)
* feat: add TSS client dry-wrapper (#4330)
* chore: upgrade cometbft patch version (#4337)
* chore: upgrade cometbft patch version
* chore: run go mod tidy
* refactor: set verbose logs for event parsing error as debug (#4345)
* change invalid event to debug
* skip ton log if zero logs
* generate
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4334)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4333)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4332)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test: skip spawning Solana and Sui for ETH stress tests (#4346)
* update docker compose
* update init condition
* fix: update zetachain-exporter to v4.11.0 for localnet support (#4341)
* update zetachain-exporter to v4.11.0 for localnet support
* Update Makefile
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: add precompile metadata for blockscout explorer (#4350)
* Adding ABI for precompiles
* added readmes
* updated metadata for bs
* fixed precompile version in metadata
* fixed abi format
* fixed compiler version
* test: fix eth stress test timeout (#4321)
* fix eth stress test timeout
* decrease default mempool threshold
* add minimum retry interval logic to internal tracker
* set PostVoteInboundGasLimit back to 500K; set block max gas to 50M
* avoid adding finalized or voted ballot to internal tracker cache
* rename DefaultMempoolSize as DefaultAppMempoolSize
* add changelog entry
* update time stamp only for first MaxInboundTrackersPerScan internal trackers
* print RPC error logs from ballotIsFinalizedOrVoted instead of ignore
* chore: upgrade cometbft patch version (#4337)
* chore: upgrade cometbft patch version
* chore: run go mod tidy
* refactor: set verbose logs for event parsing error as debug (#4345)
* change invalid event to debug
* skip ton log if zero logs
* generate
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4334)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4333)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4332)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test: skip spawning Solana and Sui for ETH stress tests (#4346)
* update docker compose
* update init condition
* fix: update zetachain-exporter to v4.11.0 for localnet support (#4341)
* update zetachain-exporter to v4.11.0 for localnet support
* Update Makefile
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: add precompile metadata for blockscout explorer (#4350)
* Adding ABI for precompiles
* added readmes
* updated metadata for bs
* fixed precompile version in metadata
* fixed abi format
* fixed compiler version
* renan comments
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Charlie <31941002+CharlieMc0@users.noreply.github.com>
* feat: add dry-wrappers to zetacore client (#4323)
* feat: add dry-wrappers to zetacore client
* fix: address reviews
* fix: iterate all sui outbound tracker hashes (#4340)
* iterate all sui outbound tracker hashes
* add changelog entry
* remove log message by using Send
* feat: missing fields in msg hash for solana outbounds (#4328)
* missing fields in msg hash for solana outbounds
* changelog
* lint
* update gateway so file
* feat: add dry-mode configuration (#4348)
* feat: add mode option in ZetaClient configuration
* fix: address reviews
* test: fix too many internal trackers in 'start-stress-test-eth' (#4351)
* fix many internal trackers in eth stress test
* add changelog entry
* add description for newly added constant for readibility; improve changelog
* test: add tests related to dry-mode (#4347)
* feat: add metrics for monitoring inbound voting through blockscan and trackers (internal / external) (#4342)
* update metric definations
* add metrics update
* update comments for evm
* add unit test for metrics
* add changelog
* update comments
* format files
* update naming
* add a grafana dashboard for localnet
* update dashboard
* add section for internal trackers
* update docker compose
* update prometheus to scrape data from all zetaclient nodes
* update susccess rate
* use absent in success rate
* make success rate simpler
* remove monitoring for e2e test
---------
Co-authored-by: Renan <renan@zetachain.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* ci: create a separate release workflow for zetaclient and zetacore (#4329)
* publish release actions
* gorelease new files
* fix security warning
* fix coderabbit comments
* reorganize workflow
* Update .github/workflows/release-template.yml
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
* Update .github/workflows/release-template.yml
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
---------
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
* chore: fix function name in comment (#4364)
Signed-off-by: vastonus <vastonus@outlook.com>
* feat: add support for zetaclient external DNS name (#4254)
* add support for zetaclient external DNS name
* add changelog entry
* point to go-tss tag; fix changelog PR # and add zetaclient config description
* add zetaclient config file validation method
* chore: Update Twitter link to new handle (#4366)
* refactor: set propose/prevote/precommit delta timeouts to 200ms (#4360)
* Initial plan
* consensus: set timeout_*_delta to 200ms in test/localnet configs
Co-authored-by: CharlieMc0 <31941002+CharlieMc0@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: CharlieMc0 <31941002+CharlieMc0@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
* feat: Sui message context ID as dynamic field (#4127)
* backport PR 4087 to v35
* fix CI upgrade test
* fix unit test
* avoid wrapping nil error
* update the TODO comment for broken Sui e2e test in the upgrade
* feat: observe inbound from previous gateway package after upgrade (#4182)
* backport PR 4087 to v35
* fix CI upgrade test
* fix unit test
* avoid wrapping nil error
* backport PR 4138
* fix compile error
* add support for previous package deprecation; fix upgrade test and unit test
* add a note to clarify the PackageID argument used for event query
* add documents to explain Sui gateway address format in the chain params
* update the TODO comment for broken Sui e2e test in the upgrade
* chore: remove repetitive words in comment (#4353)
Signed-off-by: withtimezone <with_timezone@outlook.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* chore: combine metadata file for precompile ABI (#4369)
* adding combined file for BS
* adding combined file for BS
* docs: add documentation for ZetaClient execution modes (#4358)
* docs: add documentation for ZetaClient execution modes
* fix: address reviews
* docs: add version table and update release process (#4365)
* revamp version file
* update links
* add a few links
* update release lifecycle do
* Apply suggestion from @coderabbitai[bot]
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* apply comments
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* refactor: replace mock generation with (broadned) Go file generation (#4367)
* fix(monitoring): update zetachain-exporter to fix bug with localnet mode (#4370)
add signer sync localnet dashboard, fix bug with localnet mode for zetachain-exporter
* fix: upgrade test on develop (#4375)
* remove default gas limit from genesis
* fix keygen in upgrade test
* fix lint
---------
Co-authored-by: Charlie Chen <charliec@zetachain.com>
* test(e2e): json rpc checks during e2e and upgrade tests (#4357)
* add e2e test to check most important rpc methods before and after upgrade
* ci fixes
* lint
* PR comments
* PR comments
* test(backport): add zetaclient only upgrade tests (#4376)
* add zetaclient upgrade tests
* update comment
* use temp file
* refactor: upgrade protocol contract to repo `protocol-contracts-evm` and v15 (#4356)
* update go mod
* update all imports
* update go mod
* fix binding and comment some tests
* conflicts fixes
* changelogs
* disable zeta v2 e2e tests
* disable e2e test for zeta v2
* conflict fixes
* upgrade contract version
* update commit -
* update commit with release
* feat: disable TSS service in dry mode (#4384)
* fix: filter out nil address to prevent error logs (#4386)
* filter out nil address to filter nil connections
* add changelog
* feat: add chaos mode (#4359)
* feat: add chaos mode
* fix: address reviews (kingpinXD)
* fix: address reviews (lumtis)
* ci: fix duplicate env in the release workflow (#4385)
fix env error
* feat: shutdown zetaclient if zetacore is in syncing status (#4362)
* add a listner to check sync status
* add oncomplete
* add changelog
* add unit test
* add comments
* rebase develop
* rebase develop
* update function name to wait until syncing
* update function name to wait until syncing
* add unit test
shutdown cancelled if zetacore stops syncing before timeout
* increase assert timer for test
* Update zetaclient/maintenance/shutdown_listener.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add number of connected peers to tss keygen log (#4378)
* add number of peers to keygen log
* update pr id
* update log output
* update log output
* reset to older log lines
* generate files
* refactor: base validation on zetaclient config file (#4361)
* add support for zetaclient external DNS name
* add changelog entry
* point to go-tss tag; fix changelog PR # and add zetaclient config description
* add zetaclient config file validation method
* add basic validation on zetaclient config file
* add changelog entry
* add description to zetaclient config unit test and minor improvement
* standardize config file error message format
* configure cosmos sdk config in zetaclient supervisor and unit test
* fix format
* fix CI simulation test
* feat: Add test binaries build workflow (#4383)
* feat: Add test build release workflow
* test
* fix: make
* feat: add checks and notifs
* fix: refactor
* feat: refactor into multiple jobs
* fix: refactor
* fix: add description comment
* fix: remove bucket name from summary
* test: update e2e to set higher timeouts when running stress test (#4395)
* update to using higher timeouts when running stress tests
* add changelog
* docs: update matrix table with new released versions (#4390)
* update matrix table
* add note for release
* update last updated
* comments
* chore: remove repetitive words (#4388)
* chore: remove repetitive words
Signed-off-by: findmyhappy <findhappy@sohu.com>
* Update .github/workflows/semgrep.yml
Co-authored-by: Renan <renan.061@gmail.com>
---------
Signed-off-by: findmyhappy <findhappy@sohu.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Renan <renan.061@gmail.com>
Co-authored-by: Renan <renan@zetachain.com>
* feat: add new dry zetaclient to localnet (#4387)
* feat: add new dry zetaclient to localnet
* fix: address reviews (lumtis)
* fix: address reviews (skosito)
* refactor: change client mode config (#4391)
* refactor: change client mode config
* fix: address reviews (skosito)
* fix: address reviews (lumtis)
* fix: address reviews (coderabbitai)
* fix: address reviews (lumtis)
* ci: fix branch name rule to include all release branches (#4398)
ci(backport/zetaclient_v37): fix branch name rule to include all release branches
* docs: add documentation for gas and fees with ZetaChain (#4394)
* recreate docs
* add link to readme
* start deposit sections
* add bitcoin fee
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: Renan <renan@zetachain.com>
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: Tanmay <tanmay@zetachain.com>
* apply comments
* add Solana network fees
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Renan <renan@zetachain.com>
Co-authored-by: Tanmay <tanmay@zetachain.com>
* fix: wrong error usage for aborted cctx error message (#4405)
* chore: fix some typos in comments (#4409)
Signed-off-by: claudecodering <claudecoder@outlook.com>
* test: add chaos mode capabilities to zetaclient localnet (#4408)
* feat: add chaos mode capabilities to zetaclient localnet
* fix: address reviews (coderabbitai)
* fix: address reviews (lumtis)
* feat: Add ref to test binaries workflow (#4410)
* feat: Add ref to test binaries workflow
* docs: move to further reading section
* fix: load inbound cursors for each supported packages from db (#4403)
* load inbound cursors for each packages from database
* add changelog entry
* fix: retry Sui inbound if the inbound vote RPC failed (#4401)
* do not skip inbound when vote inbound RPC failed
* add changelog entry
* wraps two errors into one without convert the second into string
* chore(deps): bump github.com/consensys/gnark-crypto from 0.16.0 to 0.18.1 (#4404)
chore(deps): bump github.com/consensys/gnark-crypto
Bumps [github.com/consensys/gnark-crypto](https://github.com/consensys/gnark-crypto) from 0.16.0 to 0.18.1.
- [Release notes](https://github.com/consensys/gnark-crypto/releases)
- [Changelog](https://github.com/Consensys/gnark-crypto/blob/v0.18.1/CHANGELOG.md)
- [Commits](https://github.com/consensys/gnark-crypto/compare/v0.16.0...v0.18.1)
---
updated-dependencies:
- dependency-name: github.com/consensys/gnark-crypto
dependency-version: 0.18.1
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: fix the inconsistent method names in the comments (#4421)
Signed-off-by: rustversion <rustverion@outlook.com>
* feat: add devnet command to create a fork from existing node data (#4419)
* refactor start command
* update error messages
* update error messages
* generate files
* modify slashing info
* update node shutdown to add grace duration
* add changelog
* add changelog
* generate files
* start json rpc server in sync
* add python script to start a forked node
* replace fmt.Errorf with error.wrap
* rename import to codectypes
* rename testnet to devnet
* rename testnet to devnet
* generate files
* fix gosec warnings
* ignore close error for cleanup
* chore: fix a large number of spelling issues (#4432)
* chore: fix a large number of spelling issues
Signed-off-by: tinyfoolish <tinyfoolish@outlook.com>
* Update cmd/zetatool/cli/cctx_tracker.go
* Update e2e/e2etests/test_bitcoin_deposit_and_withdraw_with_dust.go
* Update e2e/e2etests/test_bitcoin_deposit_and_withdraw_with_dust.go
---------
Signed-off-by: tinyfoolish <tinyfoolish@outlook.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: temporarily disable zetaclient public DNS usage to avoid start failure (#4434)
* temporarily disable zetaclient public DNS usage
* add changelog entry
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: bump sol contracts with remove max payload check change (#4416)
bump sol contracts to remove max payload check
* refactor: replace interface{} with any for clarity and modernization (#4435)
Signed-off-by: sunnyraindy <sunnyraindy@outlook.com>
* fix: resolve IP address from public DNS and then pass it to go-tss (#4437)
* resolve IP address from public DNS and then pass it to go-tss
* add changelog entry
* sort IP addresses to be deterministic
* return error if both public IP or DNS are missing
* clean up TODO github link
* feat: add an option to trigger upgrade script after forking a network (#4428)
* refactor start command
* update error messages
* update error messages
* generate files
* modify slashing info
* update node shutdown to add grace duration
* add changelog
* add changelog
* generate files
* start json rpc server in sync
* add optional upgrade trigger
* add python script to start a forked node
* replace fmt.Errorf with error.wrap
* rename import to codectypes
* update python script to include upgrade trigger
* cache testnet snapshot for testing
* add upgrade scheduling to devnet
* use dvent for upgrade script
* add unit test for download info
* suppress nosec warnings
* ignore error on cleanup
* add os to the downloadInfo json
* add a constant for DefaultUpgradeHeighOffset
* fixes for comments
* added checksum to the sample script
* fix: update effective gas price calculation (#4443)
* update effective gas price calcualtion
* fix unit tests
* add changelog
* update comments
* add explicit error handling for all tx types that support EIP 1559 style gas prices
* set nil value for effective gas price
* undo setting effective gas price to nil
* test: add new chaos mode profiles (#4440)
* test profiles
* fix solana chaos test
* add back generated files
* add back generated files
* add changelog
* use any instead of interface
* fix naming
* add chaos stress test
* fix: fix Sui example deployment by removing gateway object reference (#4414)
* remove gateway object reference from Sui example package
* add changelog entry
* remove unused error from sui example
* feat: a sequential batch TSS keysign scheduler for EVM chain (#4427)
* initial PoC of batch keysign for eth chain
* add comments in functions; consolidate AddKeysignInfo and GetSignature into one method
* improved code quality using separate files; refined batch keysign logic
* refined batch keysign logic to achieve stable performance
* use TSS nonce as starting point for keysign; improve code description
* use artificial height for batch keysign
* remove cctx height from keysign information
* improve function name and comments
* add changelog entry and update existing unit tests
* fix gosec and lint
* remove unused height; remove unused context from evm signer methods; improve comment
* add unit tests for batch keysign and tss service
* add a few more log messages in batch keysign
* add a few more fields to batch keysign log messages
* loop directly on nonce range other than on map
* split func PrepareForKeysign into two separate method, one for reading one for writing
* refactor: omit unnecessary reassignment (#4447)
Signed-off-by: liuyueyangxmu <liuyueyangxmu@outlook.com>
* test: update tss migration test migrate btc fund in two chunks (#4463)
* migrate btc funds twice
* update spacing to fix lint
* add comment to explain reason for chunking BTC funds migration
* fix: accept uppercase receiver address in Bitcoin withdrawal (#4471)
* allow uppercase receiver address in Bitcoin withdrawal
* add changelog entry
* test: add separate versions for zetaclient ,zetacore and zetae2e binaries when used in e2e tests (#4476)
* create an optional alternate version for zetaclient in upgrade tests
* create an optional alternate version for zetaclient in upgrade tests
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* use old version for zetacored version directly
* ignore overwrite errors for config file
* split versioning for zetacored ,zetaclient and zetae2e
* simplify second run check
* update changelog
* update changelog
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: prevent zetaclient from running if minimum version check failed (#4474)
* add e2e test for zetaclient minimum version
* block zetaclient to run if minimum version is not set
* revert the check on empty minimum version
* add changelog entry
* continue monitoring if operational flags RPC query failed
* docs: update protocol contracts EVM link in readme (#4458)
* feat: add MsgRemoveObserver (#4479)
* add tss migration for remove obdservers
* update tests and add changelog
* use uint for len of observer set
* remove stree for add observers
* set last update height for observer set
* add check for len of observer set in e2e test
* make TSS_MIGRATION_FLAG optional
* feat: add an option to create zetaclient dry node for tesntet/mainnet (#4453)
* add shell script to demonstrate zetaclient-dry
* verify zetacore and zetaclient binaries
* docker testnet node
* refactor zetaclient dry to use python entrypoint and make it configurable
* remove config
* add rpc nodes
* add changelog
* add changelog
* update comments
* update puthon scripts to use toml files directly
* simplify logic in scripts
* simplify logic in scripts
* copy scripts into docker container directly
* add profile to testnet and mainnet nodes
* add separate versioning for dry containers
* chore: fix some spelling issues in comments (#4480)
Signed-off-by: xiaolinny <xiaolincode@outlook.com>
Co-authored-by: morde08 <peter@zetachain.com>
* test: add sui to tss migration tests (#4488)
* add tss migration for sui
* add changelog
* debug changes
* update message context
* update comments
* remove unused functions
* feat: change params for 2s block time (#4484)
* change params for 2s block time
* changelog
* remove todo
* change default params
* test fixes
* fix migration test
* fix distributions test
* feat: Add action to build & push zetanode image internally (#4482)
* feat: Add action to build zetanode and deploy in dry-run mode
* Add pr trigger
* fix: remove snapshotter
* add pr trigger
* try new flow
* test docker availability
* fix variables and refactor
* add test to tag
* update action
* trigger
* push latest only if no version
* revert to version
* fix: remove PR trigger
* fix: concurrency and fallback
* fix: Add timeout and cleanup
* feat: enable ALT in solana inbounds (#4493)
* enable ALT in solana inbounds
* lint
* changelog
* PR comments
* fmt
* run ci
* fix: bring back the support for tracerConfig object in zevm debug API (#4490)
* bring back the support for tracerConfig object in evm debug API
* add changelog entry
* add unit test for traceConfig object
* fix: port sui outbound schedule interval (#4509)
* fix: sui outbound schedule interval (#4506)
* changelog
* fix: false mempool is congested warning (#4511)
* fix false mempool is congested warning
* changelog
* PR comment
* PR comment
* fix(backport): reindex txlogs if duplicate indexes are present (#4498)
* update needs reindex function to check for log index across all groups
* add changelog
* use uint for index
* test: add e2e test to replace observer (#4503)
* add e2e test to replace observer
* update changelog
* add replace observer label check
* fix: Add solana image dependency
* Update cmd/zetae2e/local/replace_observer.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* add a comments to improve readibilty
---------
Co-authored-by: Hazim <hazim_malik@hotmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: add-ton-tss-migration (#4491)
* add tss migration for sui
* add changelog
* debug changes
* update message context
* update comments
* remove unused functions
* add ton to tss migration
* update comments
* update backoff
* update wait blocks for sui
* chore: fix function name in comment for batchLogger (#4504)
Signed-off-by: boqishan <boqishan@126.com>
Co-authored-by: Tanmay <tanmay@zetachain.com>
* feat: add migration script to add an authorization for MsgRemoveObserver (#4492)
* add migration script
* updae changelog
* feat: add a tool to list tss balances across all supported chains (#4507)
* add tss balance check
* update to using supported chains list from network
* update comments
* remove sample config file from repository
* update identifier chainRpc to chainRPC
* feat: move gas price multiplier to chain params (#4485)
* move gas price multiplier to chain params
* add changelog entry
* add breaking change description in changelog
* fix nil chainParams check in migration script; fix typo and make gas multiplier validation less strict; update changelog
* describe the impact of newly added field gas multiplier; fix typo in zetatool inbound
* fix unit test
* chore: merge main into develop (#4512)
* fix: ratelimiting race condition vuln (#4072)
* fix: ratelimiting race condition vuln
* fix: ratelimiting race condition vuln
- Fix race condition in RateLimiter.Release() function
- Replace non-atomic check-then-act with atomic decrement and bounds checking
- Add comprehensive test suite to verify the fix
- Update changelog with PR #4072
* fix: correct atomic implementation to prevent underflow
- Replace flawed Add(-1) approach with proper CompareAndSwap
- Fix underflow detection issue where uint32 wrap-around was missed
- Add TestRateLimiterUnderflowProtection to verify the fix
- Ensure Release() never causes negative counters or semaphore over-release
* refactor: simplify rate limiter Release() implementation
- Remove unnecessary infinite loop in CAS operation
- Single CAS attempt is sufficient for race condition protection
- Maintains thread-safety while being more efficient
- All tests still pass with simplified implementation
* fix: correct order of operations in rate limiter Release()
- Fix race condition by decrementing counter before releasing semaphore
- Ensure pending counter accurately reflects semaphore state
- Simplify implementation by using correct operation order
- All tests pass with cleaner, more logical approach
* test: add tests that reproduce the original race condition vulnerability
- Add BuggyRateLimiter that implements the original vulnerable code
- Add TestBuggyRateLimiterRaceCondition to demonstrate the race condition
- Add TestBuggyRateLimiterStressTest to stress test the vulnerability
- Add TestVulnerabilityDemonstration to show before/after comparison
- Add TestBuggyRateLimiterExcessiveReleases to show excessive release issues
- These tests demonstrate the theoretical vulnerability even if timing makes it hard to reproduce consistently
* fix: address race condition and underflow issues in RateLimiter
- Fix race condition in Release() by reordering operations (decrement pending first, then release semaphore)
- Fix Pending() function to handle negative atomic.Int32 values correctly
- Add comprehensive tests to verify fixes
- Remove buggy code from tests as requested by reviewers
- Document original vulnerability in test comments
The original race condition allowed multiple goroutines to release more permits than acquired.
The Pending() function could return incorrect values due to negative atomic.Int32 conversion.
Fixes: #4072
* refactor: rename test and update changelog to reflect actual improvements
- Rename TestVulnerabilityDemonstration to TestRateLimiterRobustness
- Update test description to reflect code quality improvements rather than vulnerability fixes
- Update changelog entry to match actual changes
- Tests still pass, confirming the improvements are working correctly
The reviewer correctly pointed out that if tests pass on develop without fixes,
then we're improving robustness rather than fixing vulnerabilities.
* refactor: remove support for v1 revert address for BTC (#4070)
* remove support for v1 revert address for BTC
* add changelog
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add support for withdraw using v2 connector contract (#4064)
* update go mod
* add a new message for migrating funds
* add migrate funds to e2e
* rebase from develop
* add v2 e2e test to check flow
* add zeta gateway deposit to zetaclient
* add github workflow
* update comments
* fix code formating
* fix code formating
* fix code formating
* fix unit tests
* fix unit tests
* revert to old command to start e2e test
* remove message for migration and refactor to using contract directly
* add changelog
* generate files after removing new message
* update generated files
* update generated files
* update go mod
* update deposit
* add unit tests
* add unit tests
* generate files
* generate files
* undo changes based on develop
* update deposit and revert smart contract call
* rename zeta deposit test file
* rename zeta deposit test file
* add abort and revert tests
* add TestZetaDepositAndCallNoMessage
* add TestZetaDepositAndCallNoMessage
* remove payable from TestAbort contract
* rename to LegacyZETADepositAndCallContract
* improve unit test coverage
* fix unit tests
* add some delay in TestZetacore_SubscribeNewBlocks
* update comment for handling zeta token zrc20
* add e2e test
* add e2e test for withdraw
* refactor ProcessZEVMInboundV2
* add core registry to setup
* refactor e2e test helper functions
* add unit test for zeta withdraw
* add unit test for withdraw and call
* resolve comments 1
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* improve abort tests
* improve abort tests
* resolve comments
* resolve comments 2
* update upgrade height to 280 to allow the first test to run the entire cycle
* wrap zeta mints in tmp context
* wrap zeta mint in temp context
* rebase
* add changelog
* add changelog
* adjust comments
* Update cmd/zetae2e/config/contracts.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix gas pool zeta calcualation
* add unit test for executeWithMintedZeta
* fix comments 1
* add unit tests
* update test dapp to use zeta token for consuming gas
* add core registry to zeta e2e post upgrade handler
* revert legacy test
* update changes based on comments 1
---------
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix: print error message in detail if unable to decode Bitcoin memo (#4090)
* print error message detail when memo decoding failed
* add changelog entry
* keep invalid memo log on Info level
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* test(e2e): update admin e2e tests to use v2 connector (#4071)
* update go mod
* add a new message for migrating funds
* add migrate funds to e2e
* rebase from develop
* add v2 e2e test to check flow
* add zeta gateway deposit to zetaclient
* add github workflow
* update comments
* fix code formating
* fix code formating
* fix code formating
* fix unit tests
* fix unit tests
* revert to old command to start e2e test
* remove message for migration and refactor to using contract directly
* add changelog
* generate files after removing new message
* update generated files
* update generated files
* update go mod
* update deposit
* add unit tests
* add unit tests
* generate files
* generate files
* undo changes based on develop
* update deposit and revert smart contract call
* rename zeta deposit test file
* rename zeta deposit test file
* add abort and revert tests
* add TestZetaDepositAndCallNoMessage
* add TestZetaDepositAndCallNoMessage
* remove payable from TestAbort contract
* rename to LegacyZETADepositAndCallContract
* improve unit test coverage
* fix unit tests
* add some delay in TestZetacore_SubscribeNewBlocks
* update comment for handling zeta token zrc20
* add e2e test
* add e2e test for withdraw
* refactor ProcessZEVMInboundV2
* add core registry to setup
* refactor e2e test helper functions
* add unit test for zeta withdraw
* add unit test for withdraw and call
* resolve comments 1
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* improve abort tests
* improve abort tests
* resolve comments
* resolve comments 2
* update upgrade height to 280 to allow the first test to run the entire cycle
* wrap zeta mints in tmp context
* wrap zeta mint in temp context
* rebase
* add changelog
* add changelog
* adjust comments
* Update cmd/zetae2e/config/contracts.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix gas pool zeta calcualation
* add unit test for executeWithMintedZeta
* fix comments 1
* add unit tests
* update admin
* revert unncessary changes
* disable account balance verification for admin tests
* improve naming for deposit functions
* add changelog
* update comments
* update test legacy test zeta to use EVMAddress
* remove skipping admin in upgrade setup
---------
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: fix eth deposit test to check balance after deposit (#4118)
* check balance after eth deposit test
* fix typo
* fix import
* test: fix flaky Solana depositAndCall tests (#4113)
* fix flaky solana depositAndCall tests
* add changelog entry
* add wait logic inside AssertTestDAppEVMCalled
* chore: bump cosmos evm to support querying legacy proposals of type MsgUpdateParams (#4094)
* update zeta evm
* update commit
* fix: use evm chain id from eth config in rpc backend (#4096)
* fix: cancel solana WaC if tx size is too large (#4098)
* cancel solana WaC if tx size is too large
* align the comments with the code
* fix: nil reference in trace block (#4093)
* update to commit be548f7691876e656ec61aa46e31ed337be92f4e , on branch release/v34
---------
Co-authored-by: skosito <skostic9242@gmail.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
* fix: error when deploying contracts on testnet (#4112)
* dont return err if tx is not found in get tx receipt
* fix tests
* changelog
* feat: support hostname in addition to public IP for zetaclient to connect to zetacore (#4068)
* save initial work to remote
* add unit test and live test for zetacore hostname support
* add changelog entry; fix gosec and clean unused code
* fix CI upgrade test
---------
Co-authored-by: Tanmay <tanmay@zetachain.com>
* fix: dbg trace block by number gas limit legacy (#4121)
* fix dbg trace by block
* PR comments
* changelog
* fix(cherry-pick): cancel solana WaC if tx size is too large (#4111)
* cancel solana WaC if tx size is too large
* add changelog entry
* chore: remove tx suffix in vote inbound and outbound message names (#4110)
* fix(`crosschain`): remove confirmation mode from outbound and inbound digest (#4116)
* inbound
* .
* changelog
* refactor(zetacore): overwrite consensus config values for all timeout deltas on startup. (#4097)
* update 1
* add start-skip-consensus-overwrite-test
* generate files
* update tests
* add unit tests
* add unit tests for GenesisChainID
* add unit tests for GenesisChainID
* rename genesisChainID
* fix typo
* remove testnet from overwrite check
* refactor: replace []byte(fmt.Sprintf) with fmt.Appendf (#4131)
Signed-off-by: yinwenyu6 <yinwenyu6@outlook.com>
* feat: Sui message context ID as dynamic field (#4087)
* re-enable sui authenticated call
* integrate message context ID as dynamic field
* add changelog entry
* make issueMessageContext function self-contained
* fix unit test
* remove --skip-dependency-verification in sui gateway upgrade test
* cancel withdrawAndCall on invalid payload
* adopt new increase_nonce signature to adopt gas refund logic when cancelling a CCTX
* apply stringent check on Sui transaction's checkpoint
* apply status check on Sui inbound
* fix CI upgrade test
* fix unit test
* chore: fix some function names in comment (#4129)
Signed-off-by: pxwanglu <pxwanglu@icloud.com>
* chore: fix some observer message names (#4141)
* test: fix flaky Solana SPL deposit balance check (#4142)
* fix solana e2e SPL balance check by waiting maximum 30 seconds
* add changelog entry
* refactor: remove intx and outtx deprecated queries (#4150)
* refactor: remove intx and outtx deprecated queries
* fixes in e2e
* chore: remove redundant word in comment (#4149)
Signed-off-by: wmypku <wmypku@outlook.com>
* test(`e2e`): improve logs for CCTX status assertion (#4147)
* improve require status logs
* update usage in tests
* lint
* cursor comment
* chore: fix some typos in comment (#4146)
Signed-off-by: tzchenxixi <tzchenxixi@icloud.com>
* chore: set v35 as upgrade test reference and various clean up (#4115)
* add back precompiles
* add abci field to proposal
* test
* enable back
* test no creating proposasl
* disable zeta-ante
* cleanup v33 upgrade helper
* add v35 as reference
* remove gas stability pool temporary
* update to v36 and disable fast confirmation test
* bitcoin fast confirmation
* increase ersion for zeta
* remove erc20 init handler
* disable zevm to evm revert for older version
* disable zevm to evm revert abort for older version
* increase upgrade height
* feat: make the gas limit used for gateway calls on ZEVM a configurable parameter (#4153)
* add GatewayGasLimit to state
* refactor function name from MustGetGatewayGasLimit to GetGatewayGasLimitSafe
* update unit tests
* update unit tests
* update proto files
* replace big int with uint64
* changelog
* add check of older value
* add v4 migration back for authority module
* update setup handler to remove setting erc20 module
* test changes
* revert to using v32 as base branch for upgrades
---------
Co-authored-by: lumtis <lucas.bertrand.22@gmail.com>
* test(`e2e`): add a gas limit option for ZEVM to EVM call tests (#4145)
* add gas limit option
* use option for tests
* increase further upgrade height
* test: use pre-deployed example dapp V2 contract in e2e tests (#4158)
* do not deploy example contract in e2e tests, use pre-deployed example dapp V2 instead
* add changelog entry
* clean up debugging log
* remove commented code
* add back extra zrc20 SPL balance check
* chore(`e2e`): cleanup unused contracts (#4161)
* remove contextapp
* remove distribute
* test: fix flaky depositAndCall test that failed on sender assertion (#4165)
* fix flaky depositAndCall caused by sender assertion
* add changelog entry
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4148)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4172)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4173)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: standardize zetaclient logging (#4144)
* chore: remove unused DynamicTicker from zetaclient/types
* refactor: remove Msgf and refactor zerolog uses
* Replace Msgf for Msg
* Use '_' instead of '.'
* Start logs with lowercase instead of uppercase characters
* Use the constants in the logs module
* Use With().Logger() instead of log fields when possible
* fix: improve zetatool (#4175)
* scan gateway events by default for all inbound hashes
* scan gateway events by default for all inbound hashes
* test(`e2e`): add a E2E test to test depositAndCall with high gas consumption (#4177)
* set gas limit to 4m in localnet
* add high usage test
* changelog
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Update e2e/e2etests/e2etests.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test(`e2e`): add all chains by default in `start-localnet` (#4163)
* chore: add Solana to start-localnet to allow to run local tests
* add sui and ton
* Update cmd/zetae2e/local/local.go
Co-authored-by: Tanmay <tanmay@zetachain.com>
---------
Co-authored-by: Tanmay <tanmay@zetachain.com>
* chore: remove redundant words (#4179)
Signed-off-by: keeghcet <keeghcet@outlook.com>
* refactor: omit unnecessary reassignment (#4184)
Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com>
* fix: force rescan if inbound vote monitoring fails (#4183)
* add monitoringErr channel
* update to InboundBlockHeight - 1 , for reseting the block
* fix unit tests
* implement error interface
* rename to ErrTxMonitor
* add forceResetLastScanned flag
* add forceResetLastScanned flag
* add mutex to force scan
* add changelog
* add changelog
* update name to wasForceReset
* wrap UpdateForceResetLastScanned in mutex
* add a bound check to InboundBlockHeight to be safe
* Update zetaclient/chains/base/confirmation.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Update zetaclient/chains/base/observer.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* force update for in memory value if forceResetLastScanned is true
* add a lock on reading block height
* update error message
* update changelog
* wait till end of scan cycle to toggle the forceUpdateFlag
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: remove duplicate solana post-gas-price goroutine (#4194)
* feat: observe inbound from previous gateway package after upgrade (#4138)
* observe inbound from old gateway package optionally
* add changelog entry
* add sui inbound cursor migration; add post-upgrade deposit tests
* improve comments, logs and naming; fix post-upgrade withdraw failure
* protect anyStringMap
* add support for <withdrawcap-id> to Sui gateway address
* fix CI upgrade test failure
* use name previousPackageID and keep name PairID; rename AnyString and cursor migration function; improve test, comments, etc.
* replaced assert by require in sui unit test
* add support for original packageID in Sui gateway address
* avoid wrapping nil error
* use previous package ID in post-upgrade Sui deposit test
* add support for previous package deprecation and fix upgrade test
* fix unit test
* add a note to clarify the PackageID argument used for event query
* add documents to explain Sui gateway address format in the chain params
* refactor: remove unused loggers and log fields (#4180)
* chore: remove unused Headers logger
* refactor: remove (mostly) unused GasPrice logger
* refactor: replace logs.FieldMethod with With().Caller() and standardize logs.FieldModule values
* refactor: remove (mostly) unused log fields FieldTracker and FieldConfirmationMode
* refactor: replace missed log instances of '.' for '_'
* fix: unpack bitcoin revert message without considering 'CallOnRevert' flag (#4169)
* enable bitcoin revertMessage and ignore CallOnRevert flag
* add changelog entry
* update standard memo doc; improve abort address validation
* skip incompatible e2e test to allow CI upgrade test to pass
* fix: add timeout to monitoring routine (#4196)
* add a timeout for vote monitoring thread
* add a timeout for vote monitoring thread
* add comments
* remove typo for cancel call
* fix unit tests
* Update zetaclient/zetacore/client_vote.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Update zetaclient/chains/base/observer.go
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* refactor: use maps.Copy for cleaner map handling (#4198)
Signed-off-by: joemicky <joemickychang@outlook.com>
* chore: fix some comments (#4208)
Signed-off-by: zhoujiaweii <zjwustc@outlook.com>
* fix: update evm version for missing tx types (#4216)
* refactor: replace HasPrefix+TrimPrefix with CutPrefix (#4215)
Signed-off-by: quantpoet <quantway@outlook.com>
* refactor: remove `LastBlockHeight` state variable (#4200)
* proto
* remove other references
* changelog
* refactor: add documentation for ZetaClient logging fields (#4174)
* refactor: use coin.CoinType for compliance logging
* refactor: add documentation for zetaclient logging fields
* fix: remove ZetaChain chain ID from GasStabilityPoolBalances query (#4217)
* fix query
* add test
* changelog
* add commment
* lint
* remove gas token address
* change error type
* refactor: remove index field in ballot (#4205)
* refactor: remove index field in ballot
* changelog
* fix unit tests
* refactor: remove `MsgUpdateERC20CustodyPauseStatus` and `MsgMigrateERC20CustodyFunds` (#4199)
* make message legacy
* remove other reference
* changelog
* refactor: rename whitelistERC20 into whitelistAsset (#4203)
* refactor: rename whitelistERC20 into whitelistAsset
* e2e test
* e2e test
* fix event
* simulation
* changelogs
* update auth list
* add migration script
* apply comment
* feat: provide error information in CCTX struct when Bitcoin deposit fail (#4211)
* add error message to CCTX struct when Bitcoin deposit failed
* add changelog entry
* fix unit test; improve function naming
* add unit test for inbound vote digest
* exclude inbound observation error message from digest
* fix: re-check for finalized ballot when executing inbound vote to create cctx (#4197)
* check for finalized block after ballot is finalized
* fix unit tests and add changelog
* adjust comments
* Apply suggestion from @lumtis
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Apply suggestion from @lumtis
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* refactor check finalized ballot check to be done before adding the finalizing vote to the ballot
* adjust comments
* adjust comments
* fix comments 2
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: set zeta ante to true in upgrade tests (#4225)
* add zeta ante
* add to upgrade test regular
* add to upgrade test regular
* update out of gas test
* update out of gas test
* fix tss migration test
* fix lint issues 1
* update v2 zeta version
* chore: resync changelogs with v36 changes (#4223)
* fix: skip writing config file to the filesystem (#4210)
* comment out writing files to the state
* ad changelog
* remove commented code
* return error from fetching FlagSkipConfigOverwrite
* refactor(`observer`): remove deprecated code (#4192)
* update proto
* update code
* changelogs
* fix changelog
* fix gas limit issue in upgrade test
* use ante-zetae2e for admin upgrade tests
* test fix
* refactor: prepare the client interfaces used by the observer-signers for dry-mode (#4213)
refactor: prepare the client interfaces of the observer-signers for dry-mode
* feat: enable NoAssetCall from Bitcoin (#4218)
* enable NoAssetCall from Bitcoin
* add changelog entry
* improve comment and log print
* revert bitcoin NoAssetCall that carries large excessive funds
* adjust btc inbound parsing order; fix test name
* improve function and variable names
* feat: multiple evm calls in single tx (#4157)
* bump protocol contracts
* use newer geth version with cancun support
* e2e test with 2 deposits in same tx
* e2e tests
* inbound trackers for multiple events
* changelog
* generate
* fix e2e tests
* inbound trackers e2e test
* bump protocol contracts
* PR comments
* PR comment
* PR comments
* PR comment
* lower upgrade height in upgrade tests
* try diff upgrade height
* upgrade additional fee in upgrade v36 handler
* chore: fix function name in comment (#4238)
Signed-off-by: russcoss <russcoss@outlook.com>
* revert: add timeout to monitoring routine" (#4244)
Revert "fix: add timeout to monitoring routine (#4196)"
This reverts commit 65f227bbfa585adb408f31d15a5bcf71243d1e52.
* fix(e2e): check test contracts deployment (#4251)
* fix(e2e): check test contracts deployment
* add other contracts
* changelog
* fix chain to wait tx from
* revert: force rescan if inbound vote monitoring fails (#4250)
* feat: refund a portion of remaining unused tokens to user (#3734)
* add new field to cctx structure to track user gas burned
* add unit tests
* add doc
* add unit test for migration
* add check for pre upgrade cctxs
* add older logic for handling cctxs created before upgrade
* remove LegacyChainParams
* add unit test for refund gas fee
* remove old migration
* add temp note for PR review
* fix typo
* fix typo
* generate files
* add missing test case
* add missing test case
* refactor based on comments
* update EtherWithdrawRestricted test
* update EtherWithdrawRest…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main contents of this PR:
zetaclientand E2E logic to adoptMessageContextID as a gateway's dynamic field.The gateway
IncompatibleUpgradeerror below went away in local manual test, which means the new gateway is now compatible with the deployed ones in testnet and mainnet.Closes #4066
It also fixes two security issues:
How Has This Been Tested?
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests
Chores