fix: print error message in detail if unable to decode Bitcoin memo

[ws4charlie]

Description

1. no memo:

2. empty memo:

3. invalid memo:

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Summary by CodeRabbit

• Bug Fixes

  • Improved error logging to display detailed messages when a Bitcoin memo cannot be decoded.
  • Enhanced test coverage to validate rejection of Bitcoin deposits with invalid standard memos.

• Documentation

  • Updated the changelog with an "UNRELEASED" section documenting the fix for detailed Bitcoin memo error messages.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

A new unreleased changelog entry was added documenting improved error logging for invalid Bitcoin memos. The Bitcoin observer now logs error details when memo decoding fails. The end-to-end test for invalid Bitcoin deposit memos was expanded to include a case for malformed standard memos, ensuring such errors are properly detected and logged.

Changes

Cohort / File(s)	Change Summary
Changelog Update changelog.md	Added "UNRELEASED" section noting improved error logging for invalid Bitcoin memos (PR #4090).
Bitcoin Observer Logging zetaclient/chains/bitcoin/observer/inbound.go	Enhanced error logging to include decoding error details when invalid memos are encountered.
Bitcoin Invalid Memo Tests e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go	Added a new test case for invalid standard memos; clarified comments; no changes to public interfaces.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BitcoinNode
    participant Observer
    participant Logger

    User->>BitcoinNode: Submit BTC deposit with memo
    BitcoinNode->>Observer: Emit BTC deposit event
    Observer->>Observer: Decode memo
    alt Memo decoding fails
        Observer->>Logger: Log "invalid memo" with error details
        Observer->>Observer: Mark inbound status as INVALID_MEMO
    else Memo decoding succeeds
        Observer->>Observer: Continue normal processing
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Add more information to logs when Bitcoin deposit fails with invalid memo (#4074)	✅
Include error details in invalid memo log statements in observer (#4074)	✅
No consensus/state-breaking changes, only log improvements as per temporary solution (#4074)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were detected. All modifications are directly aligned with the objectives of improving error visibility for invalid Bitcoin memos.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch btc-print-invalid-memo-error-detail

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.97%. Comparing base (7f56eb5) to head (6619331).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4090   +/-   ##
========================================
  Coverage    65.97%   65.97%           
========================================
  Files          454      454           
  Lines        33550    33550           
========================================
  Hits         22133    22133           
  Misses       10452    10452           
  Partials       965      965           

Files with missing lines	Coverage Δ
zetaclient/chains/bitcoin/observer/inbound.go	46.07% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

zetaclient/chains/bitcoin/observer/inbound.go (1)

198-202: Prefer structured fields and a warning level for invalid memo logs

Good addition of Err(err). For machine-parsable logs and easier querying, avoid embedding the memo hex in the message. Use structured fields and consider Warn level since this indicates an invalid user input that triggers a revert.

Apply this diff:

- ob.Logger().Inbound.Info().Err(err).Fields(lf).Msgf("invalid memo: %s", hex.EncodeToString(event.MemoBytes))
+ ob.Logger().Inbound.
+   Warn().
+   Err(err).
+   Fields(lf).
+   Str("memo_hex", hex.EncodeToString(event.MemoBytes)).
+   Bool("std_format", event.MemoStd != nil).
+   Msg("invalid memo")

changelog.md (1)

3-8: Changelog entry reads well

The UNRELEASED fix succinctly documents the improvement and references the PR. Consider referencing the related issue for traceability (optional).

-* [4090](https://github.com/zeta-chain/node/pull/4090) - print error message in detail if unable to decode Bitcoin memo
+* [4090](https://github.com/zeta-chain/node/pull/4090) - print detailed error message if unable to decode Bitcoin memo (see also [#4074](https://github.com/zeta-chain/node/issues/4074))

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be79663 and 70d5197.

📒 Files selected for processing (3)

• changelog.md (1 hunks)
• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go (3 hunks)
• zetaclient/chains/bitcoin/observer/inbound.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.go

⚙️ CodeRabbit Configuration File

Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

Files:

• zetaclient/chains/bitcoin/observer/inbound.go
• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

🧠 Learnings (31)

📓 Common learnings

Learnt from: gartnera
PR: zeta-chain/node#3070
File: cmd/zetae2e/init.go:0-0
Timestamp: 2024-10-30T17:56:16.341Z
Learning: In code reviews for Go files like `cmd/zetae2e/init.go` in the ZetaChain project, avoid suggesting unrelated refactoring. Focus comments on changes relevant to the PR objectives.

Learnt from: ws4charlie
PR: zeta-chain/node#3025
File: zetaclient/chains/bitcoin/observer/event.go:110-115
Timestamp: 2024-10-23T17:30:57.328Z
Learning: In the `DecodeEventMemoBytes` function, a non-nil `memoStd` with a non-nil `err` indicates that the memo bytes are well-formatted as a memo but contain improper data.

Learnt from: ws4charlie
PR: zeta-chain/node#4053
File: e2e/e2etests/test_bitcoin_std_deposit.go:42-42
Timestamp: 2025-07-28T18:08:13.883Z
Learning: In Bitcoin deposit E2E tests for the ZetaChain project, `DepositBTCWithAmount` is preferred over `DepositBTCWithExactAmount` because depositing exact amounts to a ZEVM receiver is complex. The tests use rough amounts and then calculate the actual received amount from the raw Bitcoin transaction to verify balance changes, making the tests more robust and less flaky.

Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: zetaclient/chains/bitcoin/observer/db.go:11-25
Timestamp: 2025-01-14T00:09:01.416Z
Learning: In Bitcoin observer, non-critical DB operations (like saving broadcasted transactions) should log errors but not return them to callers, as the errors are already handled appropriately through logging and don't affect the critical in-memory state.

Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: zetaclient/chains/bitcoin/observer/outbound.go:28-32
Timestamp: 2025-01-13T23:51:09.334Z
Learning: In Bitcoin observer, `minTxConfirmations` is set to 0 to allow observing mempool transactions without waiting for block confirmations, which is necessary due to Bitcoin's 10-minute block time. This is a deliberate design choice despite potential security implications, as other safety checks are in place through TSS validation.

📚 Learning: 2024-09-19T18:22:35.964Z

Learnt from: ws4charlie
PR: zeta-chain/node#2899
File: zetaclient/chains/bitcoin/observer/inbound.go:37-38
Timestamp: 2024-09-19T18:22:35.964Z
Learning: In `BTCInboundEvent`, it's acceptable to use `float64` for monetary values (`Value` and `DepositorFee`) because precision is ensured through conversion to integer when building the vote message.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go

📚 Learning: 2024-10-23T17:30:57.328Z

Learnt from: ws4charlie
PR: zeta-chain/node#3025
File: zetaclient/chains/bitcoin/observer/event.go:110-115
Timestamp: 2024-10-23T17:30:57.328Z
Learning: In the `DecodeEventMemoBytes` function, a non-nil `memoStd` with a non-nil `err` indicates that the memo bytes are well-formatted as a memo but contain improper data.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go
• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-08-01T18:08:13.681Z

Learnt from: kingpinXD
PR: zeta-chain/node#2615
File: x/crosschain/keeper/msg_server_vote_outbound_tx_test.go:472-472
Timestamp: 2024-08-01T18:08:13.681Z
Learning: The `SaveFailedOutbound` function in `x/crosschain/keeper/msg_server_vote_outbound_tx.go` requires a string argument for the error message.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go

📚 Learning: 2025-01-14T00:09:01.416Z

Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: zetaclient/chains/bitcoin/observer/db.go:11-25
Timestamp: 2025-01-14T00:09:01.416Z
Learning: In Bitcoin observer, non-critical DB operations (like saving broadcasted transactions) should log errors but not return them to callers, as the errors are already handled appropriately through logging and don't affect the critical in-memory state.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go

📚 Learning: 2024-11-01T17:07:59.584Z

Learnt from: gartnera
PR: zeta-chain/node#3079
File: e2e/e2etests/test_pause_erc20_custody.go:65-68
Timestamp: 2024-11-01T17:07:59.584Z
Learning: In the file `e2e/e2etests/test_pause_erc20_custody.go`, prefer verbosity and avoid extracting common event handling logic into helper functions to enhance readability and ease future refactoring.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go
• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-31T16:21:47.362Z

Learnt from: gartnera
PR: zeta-chain/node#3071
File: e2e/e2etests/test_stress_eth_withdraw.go:0-0
Timestamp: 2024-10-31T16:21:47.362Z
Learning: In `e2e/e2etests/test_stress_eth_withdraw.go`, when handling the error returned by `stats.Describe` in the `TestStressEtherWithdraw` function, log the error instead of failing the test.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go
• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T18:25:31.358Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/memo.go:44-44
Timestamp: 2024-10-10T18:25:31.358Z
Learning: In the `pkg/memo/memo.go` file, within the `InboundMemo.EncodeToBytes` method, the `head` slice returned by `m.Header.EncodeToBytes()` is guaranteed to have at least 4 bytes, so it's safe to access `head[3]` without additional length checks.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go
• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-09-23T19:51:43.360Z

Learnt from: ws4charlie
PR: zeta-chain/node#2907
File: zetaclient/chains/bitcoin/observer/outbound_test.go:81-82
Timestamp: 2024-09-23T19:51:43.360Z
Learning: In the `mineTxNSetNonceMark` function within `bitcoin/observer/outbound_test.go`, it's acceptable to hardcode the chain ID, as the tests do not require varying chain IDs.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go
• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T18:54:33.554Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: testutil/sample/memo.go:0-0
Timestamp: 2024-10-10T18:54:33.554Z
Learning: In the `testutil/sample/memo.go` file, unchecked type assertions in the `ABIPack` function are acceptable because it is designed for unit tests and simplicity.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go
• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T19:04:27.123Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/fields_v0.go:135-173
Timestamp: 2024-10-10T19:04:27.123Z
Learning: In `pkg/memo/fields_v0.go`, resetting fields before unpacking in `FieldsV0` is unnecessary because the logic to reset fields is already handled in `memo.go`, specifically in the `DecodeFromBytes` function.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go

📚 Learning: 2024-12-06T16:23:31.240Z

Learnt from: gartnera
PR: zeta-chain/node#3252
File: x/observer/keeper/operational_flags.go:16-26
Timestamp: 2024-12-06T16:23:31.240Z
Learning: In the ZetaChain Go codebase, within the `GetOperationalFlags` method in `x/observer/keeper/operational_flags.go`, it's acceptable to use `MustUnmarshal` without additional error handling, as an unmarshalling failure indicates a critical issue that should never occur.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go

📚 Learning: 2025-02-04T06:03:54.382Z

Learnt from: ws4charlie
PR: zeta-chain/node#3461
File: x/observer/migrations/v10/migrate.go:29-34
Timestamp: 2025-02-04T06:03:54.382Z
Learning: In the observer module's ChainParams struct, the Confirmation field is a value type (not a pointer), so nil checks are not needed.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound.go

📚 Learning: 2025-07-28T18:08:13.883Z

Learnt from: ws4charlie
PR: zeta-chain/node#4053
File: e2e/e2etests/test_bitcoin_std_deposit.go:42-42
Timestamp: 2025-07-28T18:08:13.883Z
Learning: In Bitcoin deposit E2E tests for the ZetaChain project, `DepositBTCWithAmount` is preferred over `DepositBTCWithExactAmount` because depositing exact amounts to a ZEVM receiver is complex. The tests use rough amounts and then calculate the actual received amount from the raw Bitcoin transaction to verify balance changes, making the tests more robust and less flaky.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-09-13T22:29:09.747Z

Learnt from: ws4charlie
PR: zeta-chain/node#2870
File: zetaclient/orchestrator/orchestrator.go:413-413
Timestamp: 2024-09-13T22:29:09.747Z
Learning: When a method is renamed (e.g., `IsUTXO()` to `IsBitcoin()`), and existing tests cover the affected code paths, do not request additional tests for the renamed methods.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-09-19T18:28:58.296Z

Learnt from: ws4charlie
PR: zeta-chain/node#2899
File: zetaclient/chains/bitcoin/observer/inbound.go:366-371
Timestamp: 2024-09-19T18:28:58.296Z
Learning: The `bitcoin.CalcDepositorFee` function is covered by live tests.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-11-06T21:10:14.301Z

Learnt from: gartnera
PR: zeta-chain/node#3105
File: e2e/runner/setup_bitcoin.go:51-69
Timestamp: 2024-11-06T21:10:14.301Z
Learning: In test code (`e2e/runner/setup_bitcoin.go`), adding security measures for private key handling in the `GetBtcAddress` method is not required.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-07-05T00:02:31.446Z

Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/chain_activate.go:184-247
Timestamp: 2024-07-05T00:02:31.446Z
Learning: The `CreateSignerObserverBTC` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T18:18:17.785Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/codec.go:55-64
Timestamp: 2024-10-10T18:18:17.785Z
Learning: In the `pkg/memo` package, the functions `NewCodecABI` and `NewCodecCompact` are defined and accessible within the package scope, eliminating the need for explicit import statements in this file.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T18:17:38.781Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/codec.go:31-33
Timestamp: 2024-10-10T18:17:38.781Z
Learning: In the `pkg/memo` package, the `CodecArg` type is defined and accessible within the package scope, eliminating the need for explicit import statements in each file.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T17:51:34.102Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/arg.go:3-11
Timestamp: 2024-10-10T17:51:34.102Z
Learning: In the `pkg/memo/arg.go` file, the `ArgType` constants are created to map directly to ABI corresponding type names.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T19:00:07.093Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: testutil/sample/memo.go:108-109
Timestamp: 2024-10-10T19:00:07.093Z
Learning: In `testutil/sample/memo.go`, BigEndian is used for ABI encoding functions, consistent with ABI specifications, whereas LittleEndian is used in compact encoding functions as appropriate.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-11-06T21:11:34.420Z

Learnt from: gartnera
PR: zeta-chain/node#3105
File: cmd/zetae2e/local/bitcoin.go:8-8
Timestamp: 2024-11-06T21:11:34.420Z
Learning: In the `e2e` codebase, it's acceptable to use `github.com/stretchr/testify/require` outside of test files.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T19:11:53.045Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/codec_abi_test.go:13-24
Timestamp: 2024-10-10T19:11:53.045Z
Learning: In `pkg/memo/codec_abi_test.go`, `newArgInstance` intentionally returns `nil` for unsupported types to facilitate testing of invalid type handling.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T18:34:29.749Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/codec_abi.go:88-92
Timestamp: 2024-10-10T18:34:29.749Z
Learning: In the `pkg/memo/codec_abi.go` file, the `parsedABI` method in the `CodecABI` struct uses the same list of ABI types for both inputs and outputs in the ABI definition, as the `codec` method encodes inputs and decodes outputs using the same types.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T18:50:23.406Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/codec_abi.go:0-0
Timestamp: 2024-10-10T18:50:23.406Z
Learning: The constant `ABIAlignment` has been moved from `pkg/memo/codec_abi.go` to the `testutil` package.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-31T16:19:26.038Z

Learnt from: gartnera
PR: zeta-chain/node#3071
File: e2e/e2etests/test_stress_eth_withdraw.go:58-59
Timestamp: 2024-10-31T16:19:26.038Z
Learning: In the Go code within `e2e/utils/zetacore.go`, the function `WaitCctxMinedByInboundHash` does not return an error.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-10T19:29:59.300Z

Learnt from: ws4charlie
PR: zeta-chain/node#2987
File: pkg/memo/fields_v0_test.go:270-320
Timestamp: 2024-10-10T19:29:59.300Z
Learning: In the `FieldsV0` struct of the `memo` package, `RevertAddress` may be left empty when `CallOnRevert` is set to true.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2024-10-31T16:23:17.250Z

Learnt from: gartnera
PR: zeta-chain/node#3071
File: e2e/e2etests/test_stress_eth_withdraw.go:41-42
Timestamp: 2024-10-31T16:23:17.250Z
Learning: In `e2e/e2etests/test_stress_eth_withdraw.go`, since some goroutines may fail, we should use a mutex to append durations of successful withdrawals for accurate latency reporting.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2025-01-14T03:39:29.764Z

Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: zetaclient/chains/bitcoin/signer/sign.go:225-233
Timestamp: 2025-01-14T03:39:29.764Z
Learning: The signature hash calculation in Bitcoin TSS transactions using `txscript.NewCannedPrevOutputFetcher([]byte{}, 0)` with correct input amounts has been proven to work reliably in production, despite theoretical concerns about empty previous output fetcher.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

📚 Learning: 2025-08-06T01:54:04.100Z

Learnt from: kingpinXD
PR: zeta-chain/node#4064
File: cmd/zetae2e/local/solana.go:0-0
Timestamp: 2025-08-06T01:54:04.100Z
Learning: The `CheckSolanaTSSBalance()` method in e2e/runner has been refactored to not return an error. Instead, it uses internal assertions (require statements) to fail the test immediately if balance checks fail. This is part of a broader refactoring pattern in the E2E runner where balance check methods were changed from error-returning to assertion-based approaches.

Applied to files:

• e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: build-zetanode
• GitHub Check: gosec
• GitHub Check: build-and-test
• GitHub Check: lint
• GitHub Check: analyze (go)
• GitHub Check: build

🔇 Additional comments (1)

e2e/e2etests/test_bitcoin_deposit_invalid_memo_revert.go (1)

24-29: LGTM: assertions now explicitly expect reverts

Clarifying to “wait for the cctx to be reverted” and asserting Reverted with INVALID_MEMO is correct and aligned with behavior.

Also applies to: 35-40, 46-51

[lumtis]

Looks good to me but let's remove #4074 from the closed issue.

The finality of the issue is to include the error in the CCTX data so it can directly be displayed to the user.
This is a first step to allow better debugging on our side.