Merged
Conversation
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes introduce a TON encoder and repository, refactor TON observer and signer flows, add client mode (including DryMode), and migrate Zetacore client types to zrepo across packages. Tests and orchestrator bootstrap are updated accordingly. Legacy TON RPC hash helpers are removed and replaced with encoder utilities. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Scheduler as TON Scheduler
participant Observer as TON Observer
participant TONRepo as TON Repo
participant ZetaRepo as Zeta Repo
participant Zetacore as Zetacore
rect rgba(230,245,255,0.5)
Note right of Observer: ObserveInbounds (new)
Scheduler->>Observer: ObserveInbounds(ctx)
Observer->>TONRepo: GetNextTransactions(ctx, lastTx)
TONRepo-->>Observer: []Transactions
loop For each transaction
Observer->>Observer: parseTransaction(tx)
alt Outbound
Observer->>ZetaRepo: GetCCTX(ctx, nonce)
ZetaRepo-->>Observer: CCTX/err
Observer->>Observer: cache Outbound{tx,status,nonce}
else Inbound (compliant)
Observer->>ZetaRepo: VoteOutbound(...)? No<br/>VoteInbound via zetacore client (internal)
else Unparseable/Failed/Non-compliant
Observer-->>Observer: skip with log
end
end
Observer->>Observer: saveLastScannedTransaction
end
sequenceDiagram
autonumber
participant Orchestrator
participant Signer as TON Signer
participant ZetaRepo as Zeta Repo
participant TONRepo as TON Repo
participant Zetacore
rect rgba(240,255,240,0.5)
Note over Signer: processOutbound (renamed)<br/>DryMode branch (new)
Orchestrator->>Signer: TryProcessOutbound(ctx, cctx, zrepoClient, zetaHeight)
Signer->>Signer: processOutbound(ctx,...)
alt ClientMode == DryMode
Signer-->>Orchestrator: Outcome=Success (no-op)
else Standard/Chaos
Signer->>TONRepo: Fetch/derive outbound tx
TONRepo-->>Signer: Transaction
Signer->>ZetaRepo: Post tracker / Vote outbound as needed
ZetaRepo-->>Signer: Ack/err
Signer-->>Orchestrator: Outcome / error
end
end
sequenceDiagram
autonumber
participant Observer as TON Observer
participant TONRepo as TON Repo
participant ZetaRepo as Zeta Repo
participant Zetacore
rect rgba(255,245,230,0.5)
Note right of Observer: ObserveGasPrice (new)
Observer->>TONRepo: GetGasPrice(ctx)
TONRepo-->>Observer: gasPrice, blockNumber
Observer->>ZetaRepo: VoteOutboundGasPrice (via client)
ZetaRepo-->>Observer: Result/err
Observer->>Observer: setLatestGasPrice
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
5 tasks
renan061
force-pushed
the
feature/dry-mode-ton
branch
3 times, most recently
from
3c9ee4e to
e516cdb
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 12
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
zetaclient/chains/base/observer.go (1)
236-253: Data race risk on lastTxScanned read/write.WithLastTxScanned uses ob.mu while LastTxScanned reads without locking. Under concurrent access this is racy.
Apply:
func (ob *Observer) LastTxScanned() string { - return ob.lastTxScanned + ob.mu.Lock() + defer ob.mu.Unlock() + return ob.lastTxScanned }Alternatively, use atomic.Value for lock‑free reads.
zetaclient/chains/solana/signer/outbound_tracker_reporter.go (1)
50-60: Prevent nil-deref on tx/meta, honor context cancellation, and return after successful tracker report.
- GetTransaction may return a nil result (or nil Meta). Accessing tx.Meta.Err can panic.
- If ctx is cancelled, the loop should exit promptly.
- After PostOutboundTracker succeeds (non-empty zetaHash), the goroutine should return to avoid redundant re-posting.
Apply this diff:
@@ - start := time.Now() - for { + start := time.Now() + for { + if ctx.Err() != nil { + logger.Info().Msg("tracker reporter context canceled") + return nil + } // Solana block time is 0.4~0.8 seconds; wait 5 seconds between each check time.Sleep(5 * time.Second) @@ - tx, err := signer.solanaClient.GetTransaction(ctx, txSig, &rpc.GetTransactionOpts{ + tx, err := signer.solanaClient.GetTransaction(ctx, txSig, &rpc.GetTransactionOpts{ // commitment "processed" seems to be a better choice but it's not supported // see: https://solana.com/docs/rpc/http/gettransaction Commitment: rpc.CommitmentConfirmed, }) - if err != nil { - continue - } + if err != nil { + logger.Debug().Err(err).Msg("GetTransaction error; will retry") + continue + } + if tx == nil || tx.Meta == nil { + logger.Debug().Msg("transaction not yet available at confirmed commitment; will retry") + continue + } @@ - } else if zetaHash != "" { - logger.Info().Str(logs.FieldZetaTx, zetaHash).Msg("added outbound to tracker") + } else if zetaHash != "" { + logger.Info().Str(logs.FieldZetaTx, zetaHash).Msg("added outbound to tracker") + return nil } else { // exit goroutine until the tracker contains the hash (reported by either this or other signers) logger.Info().Msg("outbound now exists in tracker") return nil }Also applies to: 61-69, 71-82, 84-95
zetaclient/chains/solana/signer/signer.go (2)
344-352: Invalid loop: range over an int is not supported.Use a counted loop to honor broadcastRetries.
Apply this diff:
- backOff := broadcastBackoff - for range broadcastRetries { + backOff := broadcastBackoff + for i := 0; i < broadcastRetries; i++ { time.Sleep(backOff)
541-545: Bug: errors.Wrapf(nil, ...) returns nil; error path is lost.When pdaNonce > nonce, wrap is passed a nil err, producing nil. Return a concrete error instead.
Apply this diff:
- case pdaNonce > nonce: - return errors.Wrapf(err, "PDA nonce %d is greater than outbound nonce %d", pdaNonce, nonce) + case pdaNonce > nonce: + return errors.Errorf("PDA nonce %d is greater than outbound nonce %d", pdaNonce, nonce)
🧹 Nitpick comments (36)
e2e/e2etests/test_ton_withdraw_masterchain.go (1)
15-15: Decoder migration LGTM; optional robustness check.Switch to encoder.DecodeHash is correct and aligns with the new helpers. Optionally, assert that OutboundParams[0] corresponds to TON to avoid order fragility in future refactors.
Also applies to: 60-61
zetaclient/mode/mode.go (1)
5-9: Stabilize ClientMode and add String/Parse helpers.
- Using iota is fine now, but inserting new constants earlier may shift numeric values. If modes are persisted or parsed from config/env, consider explicit values.
- Provide String() and ParseClientMode() to ease logging/config handling.
Example:
type ClientMode uint8 const ( - StandardMode ClientMode = iota - DryMode - ChaosMode + StandardMode ClientMode = 0 + DryMode ClientMode = 1 + ChaosMode ClientMode = 2 ) + +func (m ClientMode) String() string { + switch m { + case StandardMode: + return "standard" + case DryMode: + return "dry" + case ChaosMode: + return "chaos" + default: + return "unknown" + } +} + +func ParseClientMode(s string) (ClientMode, error) { + switch strings.ToLower(s) { + case "standard", "std": + return StandardMode, nil + case "dry": + return DryMode, nil + case "chaos": + return ChaosMode, nil + default: + return 0, fmt.Errorf("invalid client mode: %s", s) + } +}zetaclient/chains/zrepo/errors.go (1)
5-7: Good sentinel; wrap consistently with context.Define how this is used: prefer fmt.Errorf("%w: context", ErrGetOutboundTrackers) at call sites for inspectable errors. If multiple repository ops are added, consider a small, consistent set of sentinel errors in this package (e.g., ErrGetCCTX, ErrVoteOutbound) for uniform handling.
zetaclient/chains/base/observer_test.go (2)
21-26: Interface migration looks right; add compile-time assertion for mocks.Ensure the mock matches the new interface to prevent silent drift:
import ( + _ "github.com/zeta-chain/node/zetaclient/chains/zrepo" // keep import if needed ... "github.com/zeta-chain/node/zetaclient/testutils/mocks" ) + +// compile-time contract: mocks.ZetacoreClient implements zrepo.ZetacoreClient +var _ zrepo.ZetacoreClient = (*mocks.ZetacoreClient)(nil)
89-90: Add DryMode coverage for PostVoteInbound behavior.The PR introduces “no vote in dry-mode”. Please add a subtest that constructs the observer with mode.DryMode and asserts no vote attempt occurs (e.g., no call to PostVoteInbound on the mock and empty ballot).
Minimal example:
t.Run("should not post vote inbound in DryMode", func(t *testing.T) { // arrange chain := chains.Ethereum chainParams := *sample.ChainParams(chain.ChainId) database := createDatabase(t) zetacoreClient := mocks.NewZetacoreClient(t) tss := mocks.NewTSS(t) ob, err := base.NewObserver( chain, chainParams, zetacoreClient, tss, base.DefaultBlockCacheSize, nil, database, base.DefaultLogger(), mode.DryMode, ) require.NoError(t, err) // act msg := sample.InboundVote(coin.CoinType_Gas, chains.Ethereum.ChainId, chains.ZetaChainMainnet.ChainId) ballot, err := ob.PostVoteInbound(context.TODO(), &msg, 100000) // assert: no error, no ballot, and mock received no PostVoteInbound call require.NoError(t, err) require.Empty(t, ballot) zetacoreClient.AssertNotCalled(t, "PostVoteInbound", mock.Anything, mock.Anything) })Also applies to: 159-160
zetaclient/chains/solana/observer/observer_test.go (1)
68-70: Tidy up test resources and error handling.
- Close the in‑memory DB via the observer to avoid leaks.
- Check WriteLastTxScannedToDB error to make failures explicit.
Apply:
- ob := MockSolanaObserver(t, chain, nil, *params, nil, nil) + ob := MockSolanaObserver(t, chain, nil, *params, nil, nil) + defer ob.Stop() @@ - ob.WriteLastTxScannedToDB(lastTx) + require.NoError(t, ob.WriteLastTxScannedToDB(lastTx))zetaclient/chains/ton/signer/signer_test.go (1)
30-33: Add a DryMode test to prevent regressions.Ensure no broadcast or tracker when client mode is DryMode.
Proposed test:
@@ func TestSigner(t *testing.T) { // existing test... } + +func TestSigner_DryMode_SkipBroadcastAndTracker(t *testing.T) { + ts := newTestSuite(t) + // Rebuild signer in DryMode + testLogger := zerolog.New(zerolog.NewTestWriter(t)) + logger := base.Logger{Std: testLogger, Compliance: testLogger} + ts.baseSigner = base.NewSigner(ts.chain, ts.tss, logger, mode.DryMode) + signer := New(ts.baseSigner, ts.rpc, ts.gw) + + // Minimal outbound + receiver := ton.MustParseAccountID("0QAyaVdkvWSuax8luWhDXY_0X9Am1ASWlJz4OI7M-jqcM5wK") + amount := tonCoins(t, "1") + cctx := sample.CrossChainTx(t, "dry") + cctx.InboundParams.CoinType = coin.CoinType_Gas + cctx.OutboundParams = []*cc.OutboundParams{{ + Receiver: receiver.ToRaw(), + ReceiverChainId: ts.chain.ChainId, + CoinType: coin.CoinType_Gas, + Amount: amount, + TssNonce: 1, + }} + + signer.TryProcessOutbound(ts.ctx, cctx, ts.zetacore, 100) + + // Assert no broadcast and no tracker in DryMode + require.Len(t, ts.trackerBag, 0) + ts.rpc.AssertNotCalled(t, "SendMessage", mock.Anything, mock.Anything) + ts.zetacore.AssertNotCalled(t, "PostOutboundTracker", mock.Anything, mock.Anything, mock.Anything, mock.Anything) +}zetaclient/chains/base/observer.go (4)
82-83: Client mode field added — consider accessor/export consistency.Signer exposes ClientMode (exported) while Observer keeps clientMode (unexported). If external inspection is useful (e.g., tests, orchestrator), expose a getter for symmetry.
+// ClientMode returns the current client mode. +func (ob *Observer) ClientMode() mode.ClientMode { return ob.clientMode }
121-124: Minor: Lock/Unlock style consistency.You lock with ob.mu but defer ob.Mu().Unlock(). Prefer a single access pattern.
- ob.mu.Lock() - defer ob.Mu().Unlock() + ob.mu.Lock() + defer ob.mu.Unlock()
449-452: Dry-mode: add explicit log (and consider returning the digest).Currently this silently no-ops. Log the skip for observability; optionally return msg.Digest() to aid correlation (confirm caller expectations first).
- // Does not vote in dry mode. - if ob.clientMode == mode.DryMode { - return "", nil - } + // Dry mode: skip voting for inbound. + if ob.clientMode == mode.DryMode { + logger.Info().Msg("dry-mode: skipping inbound vote") + return cctxIndex, nil // Optional: if callers expect a non-empty identifier; confirm. + }
11-13: Prefer stdlib error wrapping over pkg/errors.pkg/errors is archived; use fmt.Errorf("%w") and errors.Is/As.
-import ( - lru "github.com/hashicorp/golang-lru" - "github.com/pkg/errors" +import ( + lru "github.com/hashicorp/golang-lru" @@ - blockCache, err := lru.New(blockCacheSize) + blockCache, err := lru.New(blockCacheSize) if err != nil { - return nil, errors.Wrap(err, "error creating block cache") + return nil, fmt.Errorf("error creating block cache: %w", err) } @@ - if err != nil { - return errors.Wrapf(err, "unable to parse block number from ENV %s=%s", envvar, scanFromBlock) + if err != nil { + return fmt.Errorf("unable to parse block number from ENV %s=%s: %w", envvar, scanFromBlock, err) }This will also let you drop the third‑party errors import.
Also applies to: 97-100, 310-314
zetaclient/orchestrator/bootstrap.go (1)
72-72: Avoid hardcoding StandardMode; plumb the configured client mode (enable TON dry-mode).Hardcoding mode.StandardMode at construction time prevents activating DryMode from configuration/flags. Source the desired mode once (e.g., from app config/deps) and pass it through to all newBaseObserver/newBaseSigner call sites.
If you already have a config/flag for mode, please confirm the intended wiring path so we can adjust bootstrap accordingly.
Also applies to: 82-82, 110-110, 127-127, 156-156, 182-182, 218-218, 225-225, 270-270, 281-281
zetaclient/chains/ton/repo/errors.go (1)
5-20: Good sentinel errors; ensure callers wrap underlying causes.Keep using these as classifiers, but when returning from repo methods, wrap underlying errors with additional context using %w so callers can inspect both the sentinel and root cause.
zetaclient/chains/solana/signer/signer.go (2)
339-343: Keep logs aligned with the actual tx being sent (update FieldTx after fallback).FieldTx is computed before the loop; after switching to fallbackTx, logs keep showing the original signature.
Apply this diff:
- lf := map[string]any{ - logs.FieldNonce: nonce, - logs.FieldTx: tx.Signatures[0].String(), - } + lf := map[string]any{ + logs.FieldNonce: nonce, + } // try broacasting tx with increasing backoff (1s, 2s, 4s, 8s, 16s, 32s, 64s) @@ + // reflect the current tx signature in logs every iteration + lf[logs.FieldTx] = tx.Signatures[0].String() // query the gateway PDA nonce @@ - if outbound.FallbackMsg != nil && shouldUseFallbackTx { + if outbound.FallbackMsg != nil && shouldUseFallbackTx { // create and sign fallback transaction @@ - tx = fallbackTx + tx = fallbackTx + lf[logs.FieldTx] = tx.Signatures[0].String() }Also applies to: 383-389
199-201: Avoid variable shadowing for isRevert inside switch.The inner isRevert shadows the outer variable, reducing clarity.
Rename the inner binding or reuse the outer isRevert.
zetaclient/chains/ton/observer/outbound_test.go (1)
71-72: Minor assertion nit.Prefer assert.True(t, res.tx.IsSuccess()) over assert.Equal(t, true, ... ) for clarity.
zetaclient/chains/ton/encoder/encoder.go (2)
30-48: Harden DecodeHash parsing; accept common variants and reduce allocations.Use strings.Cut and TrimSpace to avoid multi-split allocations and to be resilient to accidental whitespace. Consider accepting an optional "0x" prefix for the hash to maximize compatibility with external sources.
- func DecodeHash(encoded string) (lt uint64, hash ton.Bits256, err error) { - parts := strings.Split(encoded, ":") - if len(parts) != 2 { - return lt, hash, fmt.Errorf("%w: %q", ErrInvalidString, encoded) - } - - lt, err = strconv.ParseUint(parts[0], 10, 64) + func DecodeHash(encoded string) (lt uint64, hash ton.Bits256, err error) { + ltPart, hashPart, ok := strings.Cut(strings.TrimSpace(encoded), ":") + if !ok { + return lt, hash, fmt.Errorf("%w: %q", ErrInvalidString, encoded) + } + + lt, err = strconv.ParseUint(strings.TrimSpace(ltPart), 10, 64) if err != nil { return lt, hash, fmt.Errorf("%w: %w", ErrInvalidLT, err) } - err = hash.FromHex(parts[1]) + hp := strings.TrimSpace(hashPart) + if strings.HasPrefix(hp, "0x") || strings.HasPrefix(hp, "0X") { + hp = hp[2:] + } + err = hash.FromHex(hp) if err != nil { return lt, hash, fmt.Errorf("%w: %w", ErrInvalidHash, err) } return lt, hash, nil }
25-29: Micro: avoid fmt for hot path.If this sits on a hot path, replace fmt.Sprintf with strconv.AppendUint + buffer to reduce allocations. Otherwise, current code is fine.
zetaclient/chains/ton/observer/observer.go (1)
81-89: Zero as “not set” sentinel may be ambiguous.If 0 could ever be valid, track initialization separately (e.g., an atomic.Bool) to disambiguate “unset” vs “zero”.
+ // add to struct: + // initializedGasPrice atomic.Bool func (ob *Observer) getLatestGasPrice() (uint64, error) { - price := ob.latestGasPrice.Load() - if price > 0 { + price := ob.latestGasPrice.Load() + if ob.initializedGasPrice.Load() { return price, nil } return 0, errors.New("latest gas price is not set") } func (ob *Observer) setLatestGasPrice(price uint64) { - ob.latestGasPrice.Store(price) + ob.latestGasPrice.Store(price) + ob.initializedGasPrice.Store(true) }zetaclient/chains/zrepo/zrepo.go (3)
25-27: Add context to returned errors for GetCCTX.Wrap with a sentinel/context to aid triage (similar to
ErrGetOutboundTrackers), including the chain ID and nonce.func (repo *ZetaRepo) GetCCTX(ctx context.Context, nonce uint64) (*types.CrossChainTx, error) { - return repo.client.GetCctxByNonce(ctx, repo.connectedChain.ChainId, nonce) + cctx, err := repo.client.GetCctxByNonce(ctx, repo.connectedChain.ChainId, nonce) + if err != nil { + return nil, errors.Join( + errors.New("failed to get CCTX"), + fmt.Errorf("chain_id=%d nonce=%d", repo.connectedChain.ChainId, nonce), + err, + ) + } + return cctx, nil }Note: requires
fmtimport.
29-35: Include chain context when wrapping GetOutboundTrackers errors.Add chain ID to the joined error so logs and Sentry breadcrumbs are actionable.
- if err != nil { - return nil, errors.Join(ErrGetOutboundTrackers, err) - } + if err != nil { + return nil, errors.Join( + ErrGetOutboundTrackers, + fmt.Errorf("chain_id=%d", repo.connectedChain.ChainId), + err, + ) + }Note: requires
fmtimport.
37-43: Nil‑safety for VoteOutbound message.Validate
msgto avoid downstream nil dereference and return a clear error early.func (repo *ZetaRepo) VoteOutbound(ctx context.Context, gasLimit uint64, retryGasLimit uint64, msg *types.MsgVoteOutbound, ) (string, string, error) { - return repo.client.PostVoteOutbound(ctx, gasLimit, retryGasLimit, msg) + if msg == nil { + return "", "", errors.New("nil MsgVoteOutbound") + } + return repo.client.PostVoteOutbound(ctx, gasLimit, retryGasLimit, msg) }zetaclient/chains/evm/signer/signer.go (1)
497-506: Utility placement nit: consider moving IsPendingOutboundFromZetaChain.This helper is generic CCTX logic; relocating to a shared cctx/util package would improve reuse and testability.
zetaclient/chains/ton/signer/signer.go (2)
76-80: Minor: log message references old exported name.Message says “ProcessOutbound” but the method is now
processOutbound. Align for consistency.-logger.Error().Err(err).Msg("error calling ProcessOutbound") +logger.Error().Err(err).Msg("error calling processOutbound")
137-142: Add unit tests to verify DryMode behavior
Ensure that whenClientMode == mode.DryMode, neitherSignMessagenorSendExternalMessagenortrackOutboundis invoked.zetaclient/chains/ton/repo/repo.go (3)
27-36: Constructor: avoid unused state and clarify invariants
- connectedChain is stored but unused; either use it (e.g., for logging/metrics) or drop it to avoid dead state.
- Methods dereference repo.gateway; NewTONRepo accepts nil and the repo has no guard. Either enforce non-nil in the constructor or document the precondition where the repo is only used behind observer.New’s gateway validation.
Would you like me to add a defensive nil check in methods that dereference repo.gateway, or make NewTONRepo return an error on invalid input?
121-130: Lower log level and enrich context for pagination trimmingLogging every poll at Info may be noisy. Recommend Debug and include account/anchor to aid triage.
Apply this diff:
- numberOfTransactions := len(txs) - logger.Info().Int("transactions", numberOfTransactions).Msg("observed some transactions") + numberOfTransactions := len(txs) + logger.Debug(). + Int("transactions", numberOfTransactions). + Str("account", repo.gateway.AccountID().ToRaw()). + Msg("observed transactions") @@ - if numberOfTransactions > PaginationLimit { - logger.Info(). + if numberOfTransactions > PaginationLimit { + logger.Debug(). Int("transactions", numberOfTransactions). Int("limit", PaginationLimit). - Msg("number of transactions exceeds pagination limit; processing only some") + Msg("transactions exceed pagination limit; truncating") txs = txs[:PaginationLimit] }
38-49: Standardize error wrapping using Go stdlib
Replace allgithub.com/pkg/errorsimports anderrors.Wrap|Wrapfcalls withfmt.Errorf("%w", …)orerrors.Joinacross the zetaclient/chains/ton package to remove the deprecated dependency and ensure consistent error handling.zetaclient/chains/ton/ton.go (2)
121-127: Error wrapping consistencyReworded errors in scheduleCCTX read better; consider using errors.New for static strings (e.g., Line 47) to avoid unnecessary formatting. Minor.
Apply this diff:
- return errors.Errorf("observer is already started") + return errors.New("observer is already started")
153-171: Goroutine per CCTX may grow unboundedSpawning a goroutine for each pending CCTX can lead to bursts and memory pressure under backlog. Consider a bounded worker pool or semaphore to cap concurrency.
Example (conceptual):
// at TON struct sem := make(chan struct{}, maxConcurrent) // before go: sem <- struct{}{} go func() { defer func(){ <-sem }() t.signer.TryProcessOutbound(ctx, cctx, t.observer.ZetacoreClient(), zetaHeight) }()No behavior change; improves back-pressure and stability.
zetaclient/chains/ton/observer/inbound_test.go (3)
33-36: Repository injectionShifting to repo.NewTONRepo aligns tests with new abstractions. LGTM. Note: Observer.New also receives gateway; this duplicates the dependency held by TONRepo and risks divergence if mismatched. Consider having Observer consume gateway solely via TONRepo.
242-253: Global config mutation without cleanup can leak between testsSetRestrictedAddressesFromConfig mutates global state; add t.Cleanup to restore defaults to avoid cross-test flakiness.
Apply this diff:
- config.SetRestrictedAddressesFromConfig(config.Config{ + // capture and restore after test + t.Cleanup(func() { + config.SetRestrictedAddressesFromConfig(config.Config{}) // restore defaults + }) + config.SetRestrictedAddressesFromConfig(config.Config{ ComplianceConfig: config.ComplianceConfig{ RestrictedAddresses: []string{sender.ToRaw()}, }, })Also applies to: 286-288
33-36: Test setup duplicationTONRepo + Observer construction is repeated. Extract a small helper (e.g., newObserver(ts)) to reduce duplication and ease future constructor changes.
Also applies to: 71-73, 128-130, 189-191, 258-260, 296-298, 345-347, 441-443
zetaclient/chains/ton/observer/outbound.go (1)
204-208: Unify transaction parsing with parseTransaction; remove divergent code path.processOutboundTracker bypasses parseTransaction and re-implements parsing, contradicting the stated behavior and TODO.
Replace direct gateway parsing with the shared helper and handle nil:
- // TODO: why the different behavior from parseTransaction? - tx, err := ob.gateway.ParseTransaction(*rawTx) + tx, err := ob.parseTransaction(*rawTx) if err != nil { - return errors.Wrap(err, "unable to parse transaction") + return errors.Wrap(err, "unexpected parsing error") } + if tx == nil { + return errors.Errorf("unparseable outbound transaction: %s", encodedHash) + }zetaclient/chains/ton/observer/inbound.go (2)
47-51: Do not abort the scan on a single unexpected parse error.Returning an error stops ObserveInbounds entirely. Log, advance the cursor, and continue.
Apply:
- tx, err := ob.parseTransaction(rawTx) - if err != nil { - return err - } + tx, err := ob.parseTransaction(rawTx) + if err != nil { + encoded := encoder.EncodeTx(rawTx) + ob.saveLastScannedTransaction(&toncontracts.Transaction{Transaction: rawTx}) + logger.Error().Err(err).Str(logs.FieldTx, encoded). + Msg("skipping transaction due to unexpected parse error") + continue + }
258-259: Production log tone.Consider toning down the donation message for production logs.
Example: "skipping donation inbound".
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (56)
changelog.md(1 hunks)e2e/e2etests/test_ton_deposit_restricted_address.go(2 hunks)e2e/e2etests/test_ton_withdraw_masterchain.go(2 hunks)e2e/e2etests/test_ton_withdraw_restricted.go(2 hunks)e2e/e2etests/test_ton_withdrawal.go(2 hunks)e2e/runner/ton.go(5 hunks)zetaclient/chains/base/observer.go(9 hunks)zetaclient/chains/base/observer_test.go(4 hunks)zetaclient/chains/base/signer.go(4 hunks)zetaclient/chains/base/signer_test.go(2 hunks)zetaclient/chains/bitcoin/observer/observer_test.go(5 hunks)zetaclient/chains/bitcoin/observer/outbound_test.go(2 hunks)zetaclient/chains/bitcoin/signer/sign_test.go(2 hunks)zetaclient/chains/bitcoin/signer/signer_test.go(3 hunks)zetaclient/chains/evm/observer/observer_test.go(3 hunks)zetaclient/chains/evm/signer/outbound_tracker_reporter.go(1 hunks)zetaclient/chains/evm/signer/signer.go(5 hunks)zetaclient/chains/evm/signer/signer_test.go(2 hunks)zetaclient/chains/solana/observer/inbound_test.go(3 hunks)zetaclient/chains/solana/observer/observer_test.go(3 hunks)zetaclient/chains/solana/observer/outbound_test.go(2 hunks)zetaclient/chains/solana/signer/outbound_tracker_reporter.go(2 hunks)zetaclient/chains/solana/signer/signer.go(4 hunks)zetaclient/chains/solana/signer/signer_test.go(5 hunks)zetaclient/chains/sui/observer/observer_test.go(2 hunks)zetaclient/chains/sui/signer/signer.go(2 hunks)zetaclient/chains/sui/signer/signer_test.go(2 hunks)zetaclient/chains/ton/client.go(1 hunks)zetaclient/chains/ton/encoder/encoder.go(1 hunks)zetaclient/chains/ton/encoder/encoder_test.go(1 hunks)zetaclient/chains/ton/observer/gas.go(1 hunks)zetaclient/chains/ton/observer/healthcheck.go(1 hunks)zetaclient/chains/ton/observer/inbound.go(1 hunks)zetaclient/chains/ton/observer/inbound_test.go(22 hunks)zetaclient/chains/ton/observer/observer.go(2 hunks)zetaclient/chains/ton/observer/observer_test.go(6 hunks)zetaclient/chains/ton/observer/outbound.go(1 hunks)zetaclient/chains/ton/observer/outbound_test.go(4 hunks)zetaclient/chains/ton/repo/client.go(1 hunks)zetaclient/chains/ton/repo/errors.go(1 hunks)zetaclient/chains/ton/repo/repo.go(1 hunks)zetaclient/chains/ton/rpc/types.go(0 hunks)zetaclient/chains/ton/signer/signer.go(5 hunks)zetaclient/chains/ton/signer/signer_test.go(3 hunks)zetaclient/chains/ton/signer/tracker.go(3 hunks)zetaclient/chains/ton/ton.go(4 hunks)zetaclient/chains/zrepo/client.go(1 hunks)zetaclient/chains/zrepo/dry.go(1 hunks)zetaclient/chains/zrepo/errors.go(1 hunks)zetaclient/chains/zrepo/zrepo.go(1 hunks)zetaclient/maintenance/shutdown_listener.go(2 hunks)zetaclient/maintenance/tss_listener.go(1 hunks)zetaclient/mode/mode.go(1 hunks)zetaclient/orchestrator/bootstrap.go(10 hunks)zetaclient/orchestrator/orchestrator.go(2 hunks)zetaclient/zetacore/client.go(1 hunks)
💤 Files with no reviewable changes (1)
- zetaclient/chains/ton/rpc/types.go
🧰 Additional context used
📓 Path-based instructions (1)
**/*.go
⚙️ CodeRabbit configuration file
Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Files:
zetaclient/chains/zrepo/dry.goe2e/e2etests/test_ton_withdraw_restricted.gozetaclient/chains/ton/client.gozetaclient/chains/solana/observer/inbound_test.gozetaclient/zetacore/client.gozetaclient/chains/zrepo/client.gozetaclient/chains/base/signer_test.gozetaclient/chains/evm/signer/outbound_tracker_reporter.gozetaclient/chains/ton/observer/healthcheck.gozetaclient/chains/ton/observer/gas.gozetaclient/chains/bitcoin/signer/sign_test.gozetaclient/chains/solana/signer/signer.gozetaclient/chains/base/observer.gozetaclient/chains/bitcoin/observer/observer_test.gozetaclient/chains/solana/observer/observer_test.gozetaclient/chains/evm/signer/signer_test.gozetaclient/chains/ton/repo/client.gozetaclient/orchestrator/orchestrator.gozetaclient/chains/evm/observer/observer_test.gozetaclient/chains/ton/observer/outbound_test.gozetaclient/chains/base/observer_test.gozetaclient/chains/ton/repo/errors.gozetaclient/chains/ton/ton.gozetaclient/chains/ton/signer/signer.gozetaclient/chains/sui/observer/observer_test.gozetaclient/chains/base/signer.gozetaclient/chains/ton/signer/tracker.gozetaclient/chains/ton/observer/outbound.gozetaclient/chains/bitcoin/signer/signer_test.goe2e/e2etests/test_ton_withdrawal.gozetaclient/maintenance/tss_listener.gozetaclient/chains/solana/signer/outbound_tracker_reporter.gozetaclient/chains/zrepo/errors.gozetaclient/chains/ton/observer/observer_test.gozetaclient/mode/mode.goe2e/e2etests/test_ton_withdraw_masterchain.gozetaclient/maintenance/shutdown_listener.gozetaclient/chains/evm/signer/signer.gozetaclient/chains/solana/observer/outbound_test.goe2e/runner/ton.gozetaclient/chains/solana/signer/signer_test.gozetaclient/chains/ton/encoder/encoder_test.gozetaclient/chains/ton/encoder/encoder.gozetaclient/chains/sui/signer/signer.gozetaclient/chains/ton/observer/observer.gozetaclient/chains/bitcoin/observer/outbound_test.gozetaclient/orchestrator/bootstrap.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/zrepo/zrepo.gozetaclient/chains/ton/repo/repo.gozetaclient/chains/ton/observer/inbound.gozetaclient/chains/ton/signer/signer_test.gozetaclient/chains/ton/observer/inbound_test.goe2e/e2etests/test_ton_deposit_restricted_address.go
🧠 Learnings (14)
📚 Learning: 2024-09-23T19:51:43.360Z
Learnt from: ws4charlie
PR: zeta-chain/node#2907
File: zetaclient/chains/bitcoin/observer/outbound_test.go:81-82
Timestamp: 2024-09-23T19:51:43.360Z
Learning: In the `mineTxNSetNonceMark` function within `bitcoin/observer/outbound_test.go`, it's acceptable to hardcode the chain ID, as the tests do not require varying chain IDs.
Applied to files:
e2e/e2etests/test_ton_withdraw_restricted.gozetaclient/chains/ton/observer/outbound_test.gozetaclient/chains/ton/observer/observer_test.goe2e/e2etests/test_ton_withdraw_masterchain.gozetaclient/chains/bitcoin/observer/outbound_test.gozetaclient/chains/ton/observer/inbound_test.go
📚 Learning: 2024-07-04T23:47:56.072Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/orchestrator.go:222-237
Timestamp: 2024-07-04T23:47:56.072Z
Learning: The `GetUpdatedChainObserver` method in the `Orchestrator` class is covered by unit tests in `zetaclient/orchestrator/orchestrator_test.go` and `zetaclient/orchestrator/chain_activate_test.go`.
Applied to files:
zetaclient/chains/solana/observer/inbound_test.gozetaclient/chains/bitcoin/observer/observer_test.gozetaclient/chains/solana/observer/observer_test.gozetaclient/chains/evm/observer/observer_test.gozetaclient/chains/ton/observer/outbound_test.gozetaclient/chains/base/observer_test.gozetaclient/chains/sui/observer/observer_test.gozetaclient/chains/bitcoin/signer/signer_test.gozetaclient/chains/ton/observer/observer_test.gozetaclient/chains/solana/observer/outbound_test.gozetaclient/chains/bitcoin/observer/outbound_test.gozetaclient/chains/ton/observer/inbound_test.go
📚 Learning: 2024-07-04T23:46:38.428Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/orchestrator.go:192-217
Timestamp: 2024-07-04T23:46:38.428Z
Learning: The `GetUpdatedSigner` method in `zetaclient/orchestrator/orchestrator.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go` and `zetaclient/orchestrator/orchestrator_test.go`.
Applied to files:
zetaclient/chains/base/signer_test.gozetaclient/chains/bitcoin/signer/sign_test.gozetaclient/chains/solana/signer/signer.gozetaclient/chains/evm/signer/signer_test.gozetaclient/chains/bitcoin/signer/signer_test.gozetaclient/chains/evm/signer/signer.gozetaclient/chains/solana/signer/signer_test.gozetaclient/chains/sui/signer/signer.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/ton/signer/signer_test.go
📚 Learning: 2025-03-04T22:39:58.395Z
Learnt from: gartnera
PR: zeta-chain/node#3632
File: zetaclient/chains/solana/signer/signer.go:304-304
Timestamp: 2025-03-04T22:39:58.395Z
Learning: The Solana signer implementation in zetaclient/chains/solana/signer/signer.go has limited test coverage, particularly for the transaction broadcasting logic with fallback scenarios. Adding this coverage has been acknowledged as a potential future improvement outside the scope of immediate fixes.
Applied to files:
zetaclient/chains/base/signer_test.gozetaclient/chains/evm/signer/outbound_tracker_reporter.gozetaclient/chains/bitcoin/signer/sign_test.gozetaclient/chains/solana/signer/signer.gozetaclient/chains/evm/signer/signer_test.gozetaclient/chains/ton/signer/signer.gozetaclient/chains/base/signer.gozetaclient/chains/ton/signer/tracker.gozetaclient/chains/bitcoin/signer/signer_test.gozetaclient/chains/solana/signer/outbound_tracker_reporter.gozetaclient/chains/evm/signer/signer.gozetaclient/chains/solana/signer/signer_test.gozetaclient/chains/sui/signer/signer.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/ton/signer/signer_test.go
📚 Learning: 2024-07-05T00:02:31.446Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/chain_activate.go:184-247
Timestamp: 2024-07-05T00:02:31.446Z
Learning: The `CreateSignerObserverBTC` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.
Applied to files:
zetaclient/chains/base/signer_test.gozetaclient/chains/bitcoin/signer/sign_test.gozetaclient/chains/bitcoin/observer/observer_test.gozetaclient/chains/solana/observer/observer_test.gozetaclient/chains/evm/signer/signer_test.gozetaclient/chains/evm/observer/observer_test.gozetaclient/chains/base/observer_test.gozetaclient/chains/bitcoin/signer/signer_test.gozetaclient/chains/ton/observer/observer_test.gozetaclient/chains/solana/observer/outbound_test.gozetaclient/chains/solana/signer/signer_test.gozetaclient/chains/bitcoin/observer/outbound_test.gozetaclient/orchestrator/bootstrap.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/ton/signer/signer_test.gozetaclient/chains/ton/observer/inbound_test.go
📚 Learning: 2024-07-05T00:02:36.493Z
Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/chain_activate.go:116-181
Timestamp: 2024-07-05T00:02:36.493Z
Learning: The `CreateSignerObserverEVM` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.
Applied to files:
zetaclient/chains/base/signer_test.gozetaclient/chains/bitcoin/signer/sign_test.gozetaclient/chains/bitcoin/observer/observer_test.gozetaclient/chains/solana/observer/observer_test.gozetaclient/chains/evm/signer/signer_test.gozetaclient/chains/evm/observer/observer_test.gozetaclient/chains/base/observer_test.gozetaclient/chains/bitcoin/signer/signer_test.gozetaclient/chains/evm/signer/signer.gozetaclient/chains/solana/signer/signer_test.gozetaclient/chains/bitcoin/observer/outbound_test.gozetaclient/orchestrator/bootstrap.gozetaclient/chains/sui/signer/signer_test.gozetaclient/chains/ton/signer/signer_test.go
📚 Learning: 2024-11-06T21:11:34.420Z
Learnt from: gartnera
PR: zeta-chain/node#3105
File: cmd/zetae2e/local/bitcoin.go:8-8
Timestamp: 2024-11-06T21:11:34.420Z
Learning: In the `e2e` codebase, it's acceptable to use `github.com/stretchr/testify/require` outside of test files.
Applied to files:
zetaclient/chains/bitcoin/signer/sign_test.gozetaclient/chains/bitcoin/observer/observer_test.gozetaclient/chains/bitcoin/observer/outbound_test.go
📚 Learning: 2024-11-27T22:01:49.732Z
Learnt from: gartnera
PR: zeta-chain/node#3228
File: zetaclient/orchestrator/orchestrator.go:388-401
Timestamp: 2024-11-27T22:01:49.732Z
Learning: When reviewing code changes in `zetaclient/orchestrator/orchestrator.go`, avoid suggesting refactoring that is unrelated to the current PR.
Applied to files:
zetaclient/orchestrator/orchestrator.go
📚 Learning: 2025-01-22T22:46:58.820Z
Learnt from: gartnera
PR: zeta-chain/node#3395
File: .github/workflows/reusable-sim.yml:29-30
Timestamp: 2025-01-22T22:46:58.820Z
Learning: The zeta-chain/node repository uses Go version >= 1.22. Do not suggest downgrading to earlier versions like 1.21.
Applied to files:
zetaclient/chains/solana/signer/outbound_tracker_reporter.go
📚 Learning: 2025-01-14T03:37:18.430Z
Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: pkg/math/integer_test.go:0-0
Timestamp: 2025-01-14T03:37:18.430Z
Learning: Use big.Int for handling large number calculations and edge cases to avoid integer overflow issues.
Applied to files:
zetaclient/chains/ton/observer/observer_test.go
📚 Learning: 2024-10-31T16:19:26.038Z
Learnt from: gartnera
PR: zeta-chain/node#3071
File: e2e/e2etests/test_stress_eth_withdraw.go:58-59
Timestamp: 2024-10-31T16:19:26.038Z
Learning: In the Go code within `e2e/utils/zetacore.go`, the function `WaitCctxMinedByInboundHash` does not return an error.
Applied to files:
e2e/runner/ton.go
📚 Learning: 2025-02-06T16:29:58.925Z
Learnt from: gartnera
PR: zeta-chain/node#3485
File: e2e/utils/sui/signer.go:24-35
Timestamp: 2025-02-06T16:29:58.925Z
Learning: The Sui blockchain requires signatures in [R || S || V] format, which is best generated using go-ethereum's crypto.Sign function that takes an ecdsa.PrivateKey.
Applied to files:
zetaclient/chains/sui/signer/signer.go
📚 Learning: 2024-09-19T18:25:57.534Z
Learnt from: ws4charlie
PR: zeta-chain/node#2899
File: zetaclient/chains/bitcoin/observer/inbound.go:131-132
Timestamp: 2024-09-19T18:25:57.534Z
Learning: ObserveInbound coverage will be improved in future refactor.
Applied to files:
zetaclient/chains/ton/observer/inbound.go
📚 Learning: 2025-07-28T18:08:13.883Z
Learnt from: ws4charlie
PR: zeta-chain/node#4053
File: e2e/e2etests/test_bitcoin_std_deposit.go:42-42
Timestamp: 2025-07-28T18:08:13.883Z
Learning: In Bitcoin deposit E2E tests for the ZetaChain project, `DepositBTCWithAmount` is preferred over `DepositBTCWithExactAmount` because depositing exact amounts to a ZEVM receiver is complex. The tests use rough amounts and then calculate the actual received amount from the raw Bitcoin transaction to verify balance changes, making the tests more robust and less flaky.
Applied to files:
zetaclient/chains/ton/observer/inbound_test.go
🧬 Code graph analysis (50)
e2e/e2etests/test_ton_withdraw_restricted.go (1)
zetaclient/chains/ton/encoder/encoder.go (1)
DecodeHash(31-48)
zetaclient/chains/ton/client.go (2)
zetaclient/chains/ton/repo/client.go (1)
TONClient(13-40)zetaclient/chains/ton/signer/signer.go (1)
TONClient(20-30)
zetaclient/chains/solana/observer/inbound_test.go (1)
zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/zetacore/client.go (1)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)
zetaclient/chains/base/signer_test.go (2)
zetaclient/chains/base/signer.go (1)
NewSigner(43-67)zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/chains/evm/signer/outbound_tracker_reporter.go (3)
zetaclient/chains/sui/signer/signer.go (1)
Signer(21-30)zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)
zetaclient/chains/ton/observer/healthcheck.go (3)
zetaclient/chains/base/observer.go (1)
Observer(41-83)zetaclient/chains/ton/observer/observer.go (1)
Observer(18-29)zetaclient/metrics/metrics.go (1)
ReportBlockLatency(301-304)
zetaclient/chains/ton/observer/gas.go (3)
zetaclient/chains/base/observer.go (1)
Observer(41-83)zetaclient/chains/ton/observer/observer.go (1)
Observer(18-29)zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)
zetaclient/chains/bitcoin/signer/sign_test.go (1)
zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/chains/solana/signer/signer.go (2)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)
zetaclient/chains/base/observer.go (3)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)zetaclient/mode/mode.go (2)
ClientMode(3-3)DryMode(7-7)
zetaclient/chains/bitcoin/observer/observer_test.go (3)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/chains/solana/observer/observer_test.go (3)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/chains/evm/signer/signer_test.go (3)
zetaclient/chains/base/signer.go (1)
NewSigner(43-67)zetaclient/chains/base/logger.go (1)
Logger(18-21)zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/chains/ton/repo/client.go (1)
zetaclient/chains/ton/rpc/types.go (3)
BlockIDExt(17-23)BlockHeader(29-33)MasterchainInfo(25-27)
zetaclient/orchestrator/orchestrator.go (3)
zetaclient/tss/service.go (1)
Zetacore(34-51)zetaclient/orchestrator/contextupdater.go (1)
Zetacore(16-26)zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)
zetaclient/chains/evm/observer/observer_test.go (2)
zetaclient/mode/mode.go (1)
StandardMode(6-6)zetaclient/chains/base/observer.go (1)
NewObserver(86-118)
zetaclient/chains/ton/observer/outbound_test.go (3)
zetaclient/chains/ton/repo/repo.go (1)
NewTONRepo(27-36)zetaclient/chains/ton/observer/observer.go (1)
New(32-63)zetaclient/chains/ton/encoder/encoder.go (1)
EncodeTx(21-23)
zetaclient/chains/base/observer_test.go (3)
zetaclient/mode/mode.go (1)
StandardMode(6-6)zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)
zetaclient/chains/ton/repo/errors.go (1)
zetaclient/chains/ton/observer/observer.go (1)
New(32-63)
zetaclient/chains/ton/ton.go (3)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)pkg/scheduler/context.go (1)
BlockFromContextWithDelay(27-41)zetaclient/chains/base/signer.go (1)
OutboundIDFromCCTX(195-198)
zetaclient/chains/ton/signer/signer.go (5)
zetaclient/chains/base/signer.go (2)
Signer(20-40)OutboundIDFromCCTX(195-198)zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/logs/fields.go (2)
FieldOutboundID(32-32)FieldNonce(19-19)zetaclient/mode/mode.go (2)
ClientMode(3-3)DryMode(7-7)pkg/contracts/ton/gateway_send.go (1)
ExternalMsg(25-33)
zetaclient/chains/sui/observer/observer_test.go (2)
zetaclient/chains/base/observer.go (1)
NewObserver(86-118)zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/chains/base/signer.go (2)
zetaclient/mode/mode.go (1)
ClientMode(3-3)zetaclient/chains/base/logger.go (1)
Logger(18-21)
zetaclient/chains/ton/signer/tracker.go (4)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/chains/ton/rpc/types.go (1)
Account(34-44)zetaclient/metrics/metrics.go (1)
NumTrackerReporters(203-207)zetaclient/chains/ton/encoder/encoder.go (1)
EncodeTx(21-23)
zetaclient/chains/ton/observer/outbound.go (7)
pkg/contracts/ton/gateway_tx.go (2)
Transaction(11-18)OutboundAuth(21-25)zetaclient/chains/base/observer.go (1)
Observer(41-83)zetaclient/chains/ton/observer/observer.go (2)
Observer(18-29)New(32-63)zetaclient/chains/ton/encoder/encoder.go (1)
EncodeTx(21-23)x/crosschain/types/message_vote_outbound.go (1)
NewMsgVoteOutbound(17-47)zetaclient/chains/zrepo/client.go (2)
ZetacoreClient(64-122)Nonce(20-20)zetaclient/zetacore/constant.go (3)
PostVoteOutboundGasLimit(35-35)PostVoteOutboundRetryGasLimit(42-42)PostVoteOutboundRevertGasLimit(39-39)
zetaclient/chains/bitcoin/signer/signer_test.go (3)
zetaclient/chains/base/signer.go (1)
NewSigner(43-67)zetaclient/mode/mode.go (1)
StandardMode(6-6)zetaclient/chains/base/observer.go (1)
NewObserver(86-118)
e2e/e2etests/test_ton_withdrawal.go (1)
zetaclient/chains/ton/encoder/encoder.go (1)
DecodeHash(31-48)
zetaclient/maintenance/tss_listener.go (2)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)
zetaclient/chains/solana/signer/outbound_tracker_reporter.go (2)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)
zetaclient/chains/zrepo/errors.go (2)
zetaclient/chains/ton/observer/observer.go (1)
New(32-63)zetaclient/chains/zrepo/zrepo.go (1)
New(18-23)
zetaclient/chains/ton/observer/observer_test.go (3)
zetaclient/mode/mode.go (1)
StandardMode(6-6)zetaclient/chains/ton/encoder/encoder.go (2)
EncodeHash(26-28)EncodeTx(21-23)zetaclient/chains/ton/rpc/types.go (1)
BlockIDExt(17-23)
e2e/e2etests/test_ton_withdraw_masterchain.go (1)
zetaclient/chains/ton/encoder/encoder.go (1)
DecodeHash(31-48)
zetaclient/maintenance/shutdown_listener.go (2)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)
zetaclient/chains/evm/signer/signer.go (2)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)
zetaclient/chains/solana/observer/outbound_test.go (2)
zetaclient/chains/base/observer.go (1)
NewObserver(86-118)zetaclient/mode/mode.go (1)
StandardMode(6-6)
e2e/runner/ton.go (1)
zetaclient/chains/ton/encoder/encoder.go (1)
EncodeTx(21-23)
zetaclient/chains/solana/signer/signer_test.go (3)
zetaclient/chains/base/signer.go (1)
NewSigner(43-67)zetaclient/mode/mode.go (1)
StandardMode(6-6)zetaclient/chains/base/logger.go (1)
DefaultLogger(24-29)
zetaclient/chains/ton/encoder/encoder_test.go (3)
testutil/sample/ton.go (2)
GenerateTONAccountID(251-258)TONDeposit(75-77)testutil/sample/crypto.go (2)
EthAddress(89-91)Hash(189-191)zetaclient/chains/ton/encoder/encoder.go (6)
DecodeHash(31-48)EncodeTx(21-23)EncodeHash(26-28)ErrInvalidString(15-15)ErrInvalidLT(16-16)ErrInvalidHash(17-17)
zetaclient/chains/sui/signer/signer.go (2)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/testutils/mocks/zetacore_client.go (1)
ZetacoreClient(31-33)
zetaclient/chains/ton/observer/observer.go (6)
zetaclient/chains/base/observer.go (1)
Observer(41-83)zetaclient/chains/ton/repo/repo.go (1)
TONRepo(19-25)zetaclient/chains/zrepo/zrepo.go (1)
ZetaRepo(12-16)pkg/contracts/ton/gateway.go (1)
Gateway(25-27)zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/chains/ton/observer/outbound.go (1)
Outbound(18-22)
zetaclient/chains/bitcoin/observer/outbound_test.go (2)
zetaclient/chains/base/observer.go (1)
NewObserver(86-118)zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/orchestrator/bootstrap.go (5)
zetaclient/mode/mode.go (2)
StandardMode(6-6)ClientMode(3-3)zetaclient/chains/ton/observer/observer.go (2)
New(32-63)Observer(18-29)zetaclient/chains/ton/repo/repo.go (1)
NewTONRepo(27-36)zetaclient/chains/base/observer.go (1)
Observer(41-83)zetaclient/chains/base/signer.go (2)
Signer(20-40)NewSigner(43-67)
zetaclient/chains/sui/signer/signer_test.go (2)
zetaclient/chains/base/signer.go (1)
NewSigner(43-67)zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/chains/zrepo/zrepo.go (3)
zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/chains/ton/observer/observer.go (1)
New(32-63)zetaclient/chains/zrepo/errors.go (1)
ErrGetOutboundTrackers(6-6)
zetaclient/chains/ton/repo/repo.go (4)
zetaclient/chains/ton/repo/client.go (1)
TONClient(13-40)zetaclient/chains/ton/rpc/config.go (2)
FetchGasConfigRPC(17-33)ParseGasPrice(47-73)zetaclient/chains/ton/repo/errors.go (9)
ErrFetchGasPrice(8-8)ErrParseGasPrice(9-9)ErrGetMasterchainInfo(10-10)ErrHealthCheck(6-6)ErrEncoding(19-19)ErrGetTransaction(13-13)ErrGetTransactions(14-14)ErrNoTransactions(18-18)ErrGetTransactionsSince(15-15)zetaclient/chains/ton/encoder/encoder.go (1)
DecodeHash(31-48)
zetaclient/chains/ton/observer/inbound.go (10)
zetaclient/chains/base/observer.go (1)
Observer(41-83)zetaclient/chains/ton/observer/observer.go (2)
Observer(18-29)New(32-63)pkg/contracts/ton/gateway_tx.go (1)
Transaction(11-18)zetaclient/chains/ton/encoder/encoder.go (1)
EncodeTx(21-23)zetaclient/logs/fields.go (1)
FieldTx(22-22)pkg/contracts/ton/gateway_msg.go (8)
ExitCode(35-35)OpDonate(20-20)OpDeposit(21-21)Deposit(59-63)OpDepositAndCall(22-22)DepositAndCall(73-76)OpCall(23-23)Call(86-90)zetaclient/chains/zrepo/client.go (1)
ZetacoreClient(64-122)zetaclient/compliance/compliance.go (1)
PrintComplianceLog(26-54)zetaclient/zetacore/constant.go (2)
PostVoteInboundExecutionGasLimit(20-20)PostVoteInboundCallOptionsGasLimit(26-26)zetaclient/config/config.go (1)
ContainRestrictedAddress(225-234)
zetaclient/chains/ton/signer/signer_test.go (3)
zetaclient/chains/ton/encoder/encoder.go (1)
EncodeTx(21-23)zetaclient/chains/base/signer.go (1)
NewSigner(43-67)zetaclient/mode/mode.go (1)
StandardMode(6-6)
zetaclient/chains/ton/observer/inbound_test.go (3)
zetaclient/chains/ton/repo/repo.go (1)
NewTONRepo(27-36)zetaclient/chains/ton/observer/observer.go (1)
New(32-63)zetaclient/chains/ton/encoder/encoder.go (3)
DecodeHash(31-48)EncodeHash(26-28)EncodeTx(21-23)
e2e/e2etests/test_ton_deposit_restricted_address.go (1)
zetaclient/chains/ton/encoder/encoder.go (1)
EncodeTx(21-23)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: build-zetanode
- GitHub Check: analyze (go)
- GitHub Check: lint
- GitHub Check: gosec
- GitHub Check: build-and-test
- GitHub Check: build
renan061
force-pushed
the
feature/dry-mode-ton
branch
from
e516cdb to
ca42000
Compare
renan061
added
zetaclient
renan061
force-pushed
the
feature/dry-mode-ton
branch
from
ca42000 to
c96c812
Compare
lumtis
reviewed
Sep 30, 2025
renan061
force-pushed
the
feature/dry-mode-ton
branch
from
f083ada to
6a1b652
Compare
Member
Author
|
@lumtis I addressed the review comments in a separate commit, so it's easier to re-review. |
renan061
force-pushed
the
feature/dry-mode-ton
branch
from
6a1b652 to
cb96c4f
Compare
ws4charlie
reviewed
Sep 30, 2025
ws4charlie
reviewed
Sep 30, 2025
ws4charlie
reviewed
Sep 30, 2025
ws4charlie
reviewed
Sep 30, 2025
ws4charlie
reviewed
Sep 30, 2025
Contributor
ws4charlie
left a comment
ws4charlie
left a comment
There was a problem hiding this comment.
I left a few comments.
If we want to visualize the feature clearly, it would be nice if we can to separate the code refactoring (not for this PR) from the feature self in future PRs (e.g. other chains' dry mode impl).
Member
Author
I agree. I'm doing this for the next PR. |
lumtis
approved these changes
Sep 30, 2025
Contributor
|
Great work! |
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
* fix: use evm chain id from eth config in rpc backend (#4096)
* fix: cancel solana WaC if tx size is too large (#4098)
* cancel solana WaC if tx size is too large
* align the comments with the code
* fix: nil reference in trace block (#4093)
* chore : bump cosmos evm to support querying legacy proposals of type MsgUpdateParams (#4095)
* update zeta evm
* update commit
* update to commit be548f7691876e656ec61aa46e31ed337be92f4e , on branch release/v34
---------
Co-authored-by: morde08 <peter@zetachain.com>
* fix: remove store initilization for erc20 module (#4103)
* fix(v34-only): use SAFE confirmation mode for all inbound votes (#4117)
* use SAFE confirmation mode for all inbound votes
* move confirmation mode update logic right before signing the inbound vote message
* fix: port Bitcoin memo decoding error log print to v34 (#4100)
port PR 4090 to v34
* fix: backport dbg trace block by number gas limit legacy (#4119)
* fix: backport error when deploying contracts on testnet (#4120)
* refactor(backport): overwrite consensus config values for all timeout deltas on startup (#4126)
* feat: add conditional logic for adding erc20 module based on chain id (#4125)
* add conditional logic for erc20 module upgrade
* bump cosmos version to run evm migration 6 to 7
* add unit tests
* update handler to panic
* add changelog
* format files
* update changelog
* bump cosmos/evm to release/v35
* add back comments for IBC
* add back comments for IBC
* feat(backport/v36): make the gas limit used for gateway calls on ZEVM a configurable parameter (#4154)
* cherry pick
* cherry pick
* update unit tests
* update unit tests
* cherry pick
* replace big int with uint64
* add check of older value
* update upgrade test and changelog
* fix function call
* add v4 migration back for authority module
* add v4 migration back for authority module
---------
Co-authored-by: Tanmay <tanmay.bhattacharya.smit@gmail.com>
* fix: skip writing config file to the filesystem (#4206)
* skip writing config file
* use the value of skip-config-overwrite flag without restrictions for mainnet
* add comments
* remove unused functions
* remove unit tests for unused functions
* fix(backport/v36): unpack bitcoin revert message without considering 'CallOnRevert' flag (#4181)
* unpack revert message from Bitcoin memo without considering flag
* skip incompatible e2e test to allow CI upgrade test to pass
* fix(backport): force rescan if inbound vote monitoring fails using a context that can timeout (#4202)
* backport changes for rescan logic
* remove changelog
* format files
* use context with timeout
* change error message
* cherry pick changes for context with timeout
* format package and fix lint
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* chore(backport/v36): cherry pick e2e tests changes for live networks (#4220)
* fix: add a simple check for finalizing vote (#4236)
* revert: add a simple check for finalizing vote (#4240)
Revert "fix: add a simple check for finalizing vote (#4236)"
This reverts commit d8dc5bac363cbfeb8267705a378fc5a7803e24df.
* revert: force rescan if inbound vote monitoring fails using a context that can timeout (#4241)
Revert "fix(backport): force rescan if inbound vote monitoring fails using a…"
This reverts commit 70ab2a724f96bcf48d2ece29674a8bfbf9bb4469.
* fix(e2e): check test contracts deployment (#4252)
* fix(e2e): check test contracts deployment
* add other contracts
* fix chain to wait tx from
* fix check
* docs: add release lifecycle in the documentation (#4265)
* add a note for releases
* add release lifecycle docs
* refactor: omit unnecessary reassignment (#4264)
Signed-off-by: letreturn <letreturn@outlook.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* refactor(backport): standardize zetaclient logging (#4144) (#4267)
* chore: remove unused DynamicTicker from zetaclient/types
* refactor: remove Msgf and refactor zerolog uses
* Replace Msgf for Msg
* Use '_' instead of '.'
* Start logs with lowercase instead of uppercase characters
* Use the constants in the logs module
* Use With().Logger() instead of log fields when possible
* fix(backport): remove duplicate solana post-gas-price goroutine (#4194) (#4268)
* refactor(backport): remove unused loggers and log fields (#4180) (#4269)
* chore: remove unused Headers logger
* refactor: remove (mostly) unused GasPrice logger
* refactor: replace logs.FieldMethod with With().Caller() and standardize logs.FieldModule values
* refactor: remove (mostly) unused log fields FieldTracker and FieldConfirmationMode
* refactor: replace missed log instances of '.' for '_'
* refactor(backport): add documentation for ZetaClient logging fields (… (#4270)
refactor(backport): add documentation for ZetaClient logging fields (#4174)
* refactor: use coin.CoinType for compliance logging
* refactor: add documentation for zetaclient logging fields
* chore: fix some function names (#4273)
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
* refactor(backport): prepare the client interfaces used by the observe… (#4271)
refactor(backport): prepare the client interfaces used by the observer-signers for dry-mode (#4213)
refactor: prepare the client interfaces of the observer-signers for dry-mode
* refactor: replace the deprecated function in the ioutil package (#4275)
Signed-off-by: mickychang9 <mickychang9@outlook.com>
* feat: multiple evm calls (#4274)
* multiple evm calls in single tx
* gen testdappv2
* cleanup after merge
* ensure gateway proxy is deployed in e2e tests
* fix upgrade tests
* changelog
* PR comments
* feat: add dry-mode support for TON (#4277)
* feat: add dry-mode support for TON
* fix: address review comments
* ci: increase timeout for solana e2e tests (#4276)
* Increase timeout for solana e2e tests
* Remove timeout, but run the test one hour earlier.
* extend timeout for solana
* feat: add feature flag for multiple evm calls (#4288)
* add feature flag for multiple evm calls
* add feature flag to inbound tracker processing
* fix e2e test inbound trackers
* PR review and refactoring
* add todo with issue
* changelog
* use zetae2e ante for upgrade tests
* chore: increase upgrade test height (#4303)
* chore: increase upgrade test height
* test even higher block
* try 300 block height
* refactor: add `zrepo` package to zetaclient with dry-mode (#4296)
refactor: add zrepo package to zetaclient with dry-mode
* ci: remove upgrade tests from merge queue ci (#4309)
* test(`e2e`): improve local stress tests to replicate better live networks (#4293)
* update params
* fix gas limit
* set gas limit to 4m in localnet
* add high usage test
* typo
* set mem pool
* add stress zevm test
* some tests
* send zevm stress tx as batch
* add batch support
* revert back local config
* chore: add Solana to start-localnet to allow to run local tests
* add sui and ton
* improve eth withdraw stress
* use batch model for deposit stress tests
* improve retry logic
* remove unnecessary logs
* fix lint
* fix deposit
* changelogs
* add nosec
* Update changelog.md
Co-authored-by: skosito <skostic9242@gmail.com>
* apply comments
* use deposit and call
* fix last comments
* use 50m for block size
* revert back 30m block
---------
Co-authored-by: skosito <skostic9242@gmail.com>
* chore: fix inconsistent function name in comment (#4297)
Signed-off-by: russcoss <russcoss@outlook.com>
* fix: stop ProcessOutboundTrackers from breaking when it finds an error (#4305)
* feat: localnet monitoring and observability improvements (#4314)
* make PR against develop branch
* add monitoring profile to makefile
* update dashboards
* update grafana image
* fix dashboards
* update namespace to cometbft
* fix dashboard typo
* update dashboard defaults
* fix: adjust inbound retry gas limit; stop broadcasting tx if mempool is congested or base fee too high (#4291)
* adjust inbound retry gas limit; stop broadcasting tx if mempool is congested
* add changelog entry
* use write lock for delete
* add unconfirmed txs count to config and AppContext; skip observation if mempool is congested
* rename functions
* improve naming and documentation; add log print when skipping observation
* add detailed description for inbound retry gas limit adjustment
* do not consider zetacore mempool congestion by default
* consolidate observation skipper functions; print sampled Info logger when observation is skipped
* unit test observation skipper
* rename Bitcoin mempool monitoring goroutine and improve observation skipper description
* configure maximum base fee
* fix gas price observation skipper
* convert Gwei to wei for the max base fee check
* add changelog description for MaxBaseFee
* fix unit test compile
* fix unit test
* feat: add support for Solana Address Lookup Table in withdraw and call (#4266)
* add support for ALT
* split legacy withdraw and call alt to separate test
* fix compile after merge
* add spl e2e test
* ci fixes
* add outbound tests for alt msgs
* PR comments coderabbit
* PR comments
* add feature flag for solana alt
* lint
* fix e2e test
* fix e2e test
* PR comments
* Trigger rebuild
* feat: monitor failed inbound vote and add to an inbound tracker cache (#4295)
* partially cherry-pick PR 4183 and 4196 to monitor failed inbound vote
* implement the backlog for failed inbound vote
* add changelog entry
* fix changelog grammar
* use the internal tracker terminology; use separate goroutine to process internal trackers
* fix internal tracker unit test and update changelog description
* put a limit on number of inbound trackers to process per ticker
* remove unused constant
* fix generte
* remove internal tracker if it was already voted by the observer
* fix unit test
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add dry-mode to Sui and add client wrappers to Sui and TON (#4313)
* feat: add dry-mode to Sui
* refactor: add client wrappers to Sui and TON
* refactor: improve logging messages and code comments
* feat: add dry-mode to Solana (#4317)
* chore: adding ABI used by precompiles. (#4311)
* Adding ABI for precompiles
* added readmes
* refactor: use maps.Clone to simplify code (#4319)
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
* chore: fix some comments (#4331)
Signed-off-by: letreturn <letreturn@outlook.com>
* test(e2e): update local chain params for more performant outbound processing (#4318)
* remove useless comment
* improve parameters
* update for local bitcoin
* increase max block size
* revert chain param changes
* update chain params in e2e setup
* feat: add dry-mode to Bitcoin (#4325)
* feat: add dry-mode to EVM (#4326)
* feat: add TSS client dry-wrapper (#4330)
* chore: upgrade cometbft patch version (#4337)
* chore: upgrade cometbft patch version
* chore: run go mod tidy
* refactor: set verbose logs for event parsing error as debug (#4345)
* change invalid event to debug
* skip ton log if zero logs
* generate
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4334)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4333)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4332)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test: skip spawning Solana and Sui for ETH stress tests (#4346)
* update docker compose
* update init condition
* fix: update zetachain-exporter to v4.11.0 for localnet support (#4341)
* update zetachain-exporter to v4.11.0 for localnet support
* Update Makefile
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: add precompile metadata for blockscout explorer (#4350)
* Adding ABI for precompiles
* added readmes
* updated metadata for bs
* fixed precompile version in metadata
* fixed abi format
* fixed compiler version
* test: fix eth stress test timeout (#4321)
* fix eth stress test timeout
* decrease default mempool threshold
* add minimum retry interval logic to internal tracker
* set PostVoteInboundGasLimit back to 500K; set block max gas to 50M
* avoid adding finalized or voted ballot to internal tracker cache
* rename DefaultMempoolSize as DefaultAppMempoolSize
* add changelog entry
* update time stamp only for first MaxInboundTrackersPerScan internal trackers
* print RPC error logs from ballotIsFinalizedOrVoted instead of ignore
* chore: upgrade cometbft patch version (#4337)
* chore: upgrade cometbft patch version
* chore: run go mod tidy
* refactor: set verbose logs for event parsing error as debug (#4345)
* change invalid event to debug
* skip ton log if zero logs
* generate
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4334)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4333)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4332)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test: skip spawning Solana and Sui for ETH stress tests (#4346)
* update docker compose
* update init condition
* fix: update zetachain-exporter to v4.11.0 for localnet support (#4341)
* update zetachain-exporter to v4.11.0 for localnet support
* Update Makefile
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: add precompile metadata for blockscout explorer (#4350)
* Adding ABI for precompiles
* added readmes
* updated metadata for bs
* fixed precompile version in metadata
* fixed abi format
* fixed compiler version
* renan comments
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Charlie <31941002+CharlieMc0@users.noreply.github.com>
* feat: add dry-wrappers to zetacore client (#4323)
* feat: add dry-wrappers to zetacore client
* fix: address reviews
* fix: iterate all sui outbound tracker hashes (#4340)
* iterate all sui outbound tracker hashes
* add changelog entry
* remove log message by using Send
* feat: missing fields in msg hash for solana outbounds (#4328)
* missing fields in msg hash for solana outbounds
* changelog
* lint
* update gateway so file
* feat: add dry-mode configuration (#4348)
* feat: add mode option in ZetaClient configuration
* fix: address reviews
* test: fix too many internal trackers in 'start-stress-test-eth' (#4351)
* fix many internal trackers in eth stress test
* add changelog entry
* add description for newly added constant for readibility; improve changelog
* test: add tests related to dry-mode (#4347)
* feat: add metrics for monitoring inbound voting through blockscan and trackers (internal / external) (#4342)
* update metric definations
* add metrics update
* update comments for evm
* add unit test for metrics
* add changelog
* update comments
* format files
* update naming
* add a grafana dashboard for localnet
* update dashboard
* add section for internal trackers
* update docker compose
* update prometheus to scrape data from all zetaclient nodes
* update susccess rate
* use absent in success rate
* make success rate simpler
* remove monitoring for e2e test
---------
Co-authored-by: Renan <renan@zetachain.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* ci: create a separate release workflow for zetaclient and zetacore (#4329)
* publish release actions
* gorelease new files
* fix security warning
* fix coderabbit comments
* reorganize workflow
* Update .github/workflows/release-template.yml
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
* Update .github/workflows/release-template.yml
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
---------
Co-authored-by: semgrep-code-zeta-chain[bot] <181804379+semgrep-code-zeta-chain[bot]@users.noreply.github.com>
* chore: fix function name in comment (#4364)
Signed-off-by: vastonus <vastonus@outlook.com>
* feat: add support for zetaclient external DNS name (#4254)
* add support for zetaclient external DNS name
* add changelog entry
* point to go-tss tag; fix changelog PR # and add zetaclient config description
* add zetaclient config file validation method
* chore: Update Twitter link to new handle (#4366)
* refactor: set propose/prevote/precommit delta timeouts to 200ms (#4360)
* Initial plan
* consensus: set timeout_*_delta to 200ms in test/localnet configs
Co-authored-by: CharlieMc0 <31941002+CharlieMc0@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: CharlieMc0 <31941002+CharlieMc0@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
* feat: Sui message context ID as dynamic field (#4127)
* backport PR 4087 to v35
* fix CI upgrade test
* fix unit test
* avoid wrapping nil error
* update the TODO comment for broken Sui e2e test in the upgrade
* feat: observe inbound from previous gateway package after upgrade (#4182)
* backport PR 4087 to v35
* fix CI upgrade test
* fix unit test
* avoid wrapping nil error
* backport PR 4138
* fix compile error
* add support for previous package deprecation; fix upgrade test and unit test
* add a note to clarify the PackageID argument used for event query
* add documents to explain Sui gateway address format in the chain params
* update the TODO comment for broken Sui e2e test in the upgrade
* chore: remove repetitive words in comment (#4353)
Signed-off-by: withtimezone <with_timezone@outlook.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* chore: combine metadata file for precompile ABI (#4369)
* adding combined file for BS
* adding combined file for BS
* docs: add documentation for ZetaClient execution modes (#4358)
* docs: add documentation for ZetaClient execution modes
* fix: address reviews
* docs: add version table and update release process (#4365)
* revamp version file
* update links
* add a few links
* update release lifecycle do
* Apply suggestion from @coderabbitai[bot]
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* apply comments
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* refactor: replace mock generation with (broadned) Go file generation (#4367)
* fix(monitoring): update zetachain-exporter to fix bug with localnet mode (#4370)
add signer sync localnet dashboard, fix bug with localnet mode for zetachain-exporter
* fix: upgrade test on develop (#4375)
* remove default gas limit from genesis
* fix keygen in upgrade test
* fix lint
---------
Co-authored-by: Charlie Chen <charliec@zetachain.com>
* test(e2e): json rpc checks during e2e and upgrade tests (#4357)
* add e2e test to check most important rpc methods before and after upgrade
* ci fixes
* lint
* PR comments
* PR comments
* test(backport): add zetaclient only upgrade tests (#4376)
* add zetaclient upgrade tests
* update comment
* use temp file
* refactor: upgrade protocol contract to repo `protocol-contracts-evm` and v15 (#4356)
* update go mod
* update all imports
* update go mod
* fix binding and comment some tests
* conflicts fixes
* changelogs
* disable zeta v2 e2e tests
* disable e2e test for zeta v2
* conflict fixes
* upgrade contract version
* update commit -
* update commit with release
* feat: disable TSS service in dry mode (#4384)
* fix: filter out nil address to prevent error logs (#4386)
* filter out nil address to filter nil connections
* add changelog
* feat: add chaos mode (#4359)
* feat: add chaos mode
* fix: address reviews (kingpinXD)
* fix: address reviews (lumtis)
* ci: fix duplicate env in the release workflow (#4385)
fix env error
* feat: shutdown zetaclient if zetacore is in syncing status (#4362)
* add a listner to check sync status
* add oncomplete
* add changelog
* add unit test
* add comments
* rebase develop
* rebase develop
* update function name to wait until syncing
* update function name to wait until syncing
* add unit test
shutdown cancelled if zetacore stops syncing before timeout
* increase assert timer for test
* Update zetaclient/maintenance/shutdown_listener.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add number of connected peers to tss keygen log (#4378)
* add number of peers to keygen log
* update pr id
* update log output
* update log output
* reset to older log lines
* generate files
* refactor: base validation on zetaclient config file (#4361)
* add support for zetaclient external DNS name
* add changelog entry
* point to go-tss tag; fix changelog PR # and add zetaclient config description
* add zetaclient config file validation method
* add basic validation on zetaclient config file
* add changelog entry
* add description to zetaclient config unit test and minor improvement
* standardize config file error message format
* configure cosmos sdk config in zetaclient supervisor and unit test
* fix format
* fix CI simulation test
* feat: Add test binaries build workflow (#4383)
* feat: Add test build release workflow
* test
* fix: make
* feat: add checks and notifs
* fix: refactor
* feat: refactor into multiple jobs
* fix: refactor
* fix: add description comment
* fix: remove bucket name from summary
* test: update e2e to set higher timeouts when running stress test (#4395)
* update to using higher timeouts when running stress tests
* add changelog
* docs: update matrix table with new released versions (#4390)
* update matrix table
* add note for release
* update last updated
* comments
* chore: remove repetitive words (#4388)
* chore: remove repetitive words
Signed-off-by: findmyhappy <findhappy@sohu.com>
* Update .github/workflows/semgrep.yml
Co-authored-by: Renan <renan.061@gmail.com>
---------
Signed-off-by: findmyhappy <findhappy@sohu.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Renan <renan.061@gmail.com>
Co-authored-by: Renan <renan@zetachain.com>
* feat: add new dry zetaclient to localnet (#4387)
* feat: add new dry zetaclient to localnet
* fix: address reviews (lumtis)
* fix: address reviews (skosito)
* refactor: change client mode config (#4391)
* refactor: change client mode config
* fix: address reviews (skosito)
* fix: address reviews (lumtis)
* fix: address reviews (coderabbitai)
* fix: address reviews (lumtis)
* ci: fix branch name rule to include all release branches (#4398)
ci(backport/zetaclient_v37): fix branch name rule to include all release branches
* docs: add documentation for gas and fees with ZetaChain (#4394)
* recreate docs
* add link to readme
* start deposit sections
* add bitcoin fee
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: Renan <renan@zetachain.com>
* Update docs/zetacore/gas_and_fees.md
Co-authored-by: Tanmay <tanmay@zetachain.com>
* apply comments
* add Solana network fees
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Renan <renan@zetachain.com>
Co-authored-by: Tanmay <tanmay@zetachain.com>
* fix: wrong error usage for aborted cctx error message (#4405)
* chore: fix some typos in comments (#4409)
Signed-off-by: claudecodering <claudecoder@outlook.com>
* test: add chaos mode capabilities to zetaclient localnet (#4408)
* feat: add chaos mode capabilities to zetaclient localnet
* fix: address reviews (coderabbitai)
* fix: address reviews (lumtis)
* feat: Add ref to test binaries workflow (#4410)
* feat: Add ref to test binaries workflow
* docs: move to further reading section
* fix: load inbound cursors for each supported packages from db (#4403)
* load inbound cursors for each packages from database
* add changelog entry
* fix: retry Sui inbound if the inbound vote RPC failed (#4401)
* do not skip inbound when vote inbound RPC failed
* add changelog entry
* wraps two errors into one without convert the second into string
* chore(deps): bump github.com/consensys/gnark-crypto from 0.16.0 to 0.18.1 (#4404)
chore(deps): bump github.com/consensys/gnark-crypto
Bumps [github.com/consensys/gnark-crypto](https://github.com/consensys/gnark-crypto) from 0.16.0 to 0.18.1.
- [Release notes](https://github.com/consensys/gnark-crypto/releases)
- [Changelog](https://github.com/Consensys/gnark-crypto/blob/v0.18.1/CHANGELOG.md)
- [Commits](https://github.com/consensys/gnark-crypto/compare/v0.16.0...v0.18.1)
---
updated-dependencies:
- dependency-name: github.com/consensys/gnark-crypto
dependency-version: 0.18.1
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: fix the inconsistent method names in the comments (#4421)
Signed-off-by: rustversion <rustverion@outlook.com>
* feat: add devnet command to create a fork from existing node data (#4419)
* refactor start command
* update error messages
* update error messages
* generate files
* modify slashing info
* update node shutdown to add grace duration
* add changelog
* add changelog
* generate files
* start json rpc server in sync
* add python script to start a forked node
* replace fmt.Errorf with error.wrap
* rename import to codectypes
* rename testnet to devnet
* rename testnet to devnet
* generate files
* fix gosec warnings
* ignore close error for cleanup
* chore: fix a large number of spelling issues (#4432)
* chore: fix a large number of spelling issues
Signed-off-by: tinyfoolish <tinyfoolish@outlook.com>
* Update cmd/zetatool/cli/cctx_tracker.go
* Update e2e/e2etests/test_bitcoin_deposit_and_withdraw_with_dust.go
* Update e2e/e2etests/test_bitcoin_deposit_and_withdraw_with_dust.go
---------
Signed-off-by: tinyfoolish <tinyfoolish@outlook.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: temporarily disable zetaclient public DNS usage to avoid start failure (#4434)
* temporarily disable zetaclient public DNS usage
* add changelog entry
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: bump sol contracts with remove max payload check change (#4416)
bump sol contracts to remove max payload check
* refactor: replace interface{} with any for clarity and modernization (#4435)
Signed-off-by: sunnyraindy <sunnyraindy@outlook.com>
* fix: resolve IP address from public DNS and then pass it to go-tss (#4437)
* resolve IP address from public DNS and then pass it to go-tss
* add changelog entry
* sort IP addresses to be deterministic
* return error if both public IP or DNS are missing
* clean up TODO github link
* feat: add an option to trigger upgrade script after forking a network (#4428)
* refactor start command
* update error messages
* update error messages
* generate files
* modify slashing info
* update node shutdown to add grace duration
* add changelog
* add changelog
* generate files
* start json rpc server in sync
* add optional upgrade trigger
* add python script to start a forked node
* replace fmt.Errorf with error.wrap
* rename import to codectypes
* update python script to include upgrade trigger
* cache testnet snapshot for testing
* add upgrade scheduling to devnet
* use dvent for upgrade script
* add unit test for download info
* suppress nosec warnings
* ignore error on cleanup
* add os to the downloadInfo json
* add a constant for DefaultUpgradeHeighOffset
* fixes for comments
* added checksum to the sample script
* fix: update effective gas price calculation (#4443)
* update effective gas price calcualtion
* fix unit tests
* add changelog
* update comments
* add explicit error handling for all tx types that support EIP 1559 style gas prices
* set nil value for effective gas price
* undo setting effective gas price to nil
* test: add new chaos mode profiles (#4440)
* test profiles
* fix solana chaos test
* add back generated files
* add back generated files
* add changelog
* use any instead of interface
* fix naming
* add chaos stress test
* fix: fix Sui example deployment by removing gateway object reference (#4414)
* remove gateway object reference from Sui example package
* add changelog entry
* remove unused error from sui example
* feat: a sequential batch TSS keysign scheduler for EVM chain (#4427)
* initial PoC of batch keysign for eth chain
* add comments in functions; consolidate AddKeysignInfo and GetSignature into one method
* improved code quality using separate files; refined batch keysign logic
* refined batch keysign logic to achieve stable performance
* use TSS nonce as starting point for keysign; improve code description
* use artificial height for batch keysign
* remove cctx height from keysign information
* improve function name and comments
* add changelog entry and update existing unit tests
* fix gosec and lint
* remove unused height; remove unused context from evm signer methods; improve comment
* add unit tests for batch keysign and tss service
* add a few more log messages in batch keysign
* add a few more fields to batch keysign log messages
* loop directly on nonce range other than on map
* split func PrepareForKeysign into two separate method, one for reading one for writing
* refactor: omit unnecessary reassignment (#4447)
Signed-off-by: liuyueyangxmu <liuyueyangxmu@outlook.com>
* test: update tss migration test migrate btc fund in two chunks (#4463)
* migrate btc funds twice
* update spacing to fix lint
* add comment to explain reason for chunking BTC funds migration
* fix: accept uppercase receiver address in Bitcoin withdrawal (#4471)
* allow uppercase receiver address in Bitcoin withdrawal
* add changelog entry
* test: add separate versions for zetaclient ,zetacore and zetae2e binaries when used in e2e tests (#4476)
* create an optional alternate version for zetaclient in upgrade tests
* create an optional alternate version for zetaclient in upgrade tests
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* use old version for zetacored version directly
* ignore overwrite errors for config file
* split versioning for zetacored ,zetaclient and zetae2e
* simplify second run check
* update changelog
* update changelog
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: prevent zetaclient from running if minimum version check failed (#4474)
* add e2e test for zetaclient minimum version
* block zetaclient to run if minimum version is not set
* revert the check on empty minimum version
* add changelog entry
* continue monitoring if operational flags RPC query failed
* docs: update protocol contracts EVM link in readme (#4458)
* feat: add MsgRemoveObserver (#4479)
* add tss migration for remove obdservers
* update tests and add changelog
* use uint for len of observer set
* remove stree for add observers
* set last update height for observer set
* add check for len of observer set in e2e test
* make TSS_MIGRATION_FLAG optional
* feat: add an option to create zetaclient dry node for tesntet/mainnet (#4453)
* add shell script to demonstrate zetaclient-dry
* verify zetacore and zetaclient binaries
* docker testnet node
* refactor zetaclient dry to use python entrypoint and make it configurable
* remove config
* add rpc nodes
* add changelog
* add changelog
* update comments
* update puthon scripts to use toml files directly
* simplify logic in scripts
* simplify logic in scripts
* copy scripts into docker container directly
* add profile to testnet and mainnet nodes
* add separate versioning for dry containers
* chore: fix some spelling issues in comments (#4480)
Signed-off-by: xiaolinny <xiaolincode@outlook.com>
Co-authored-by: morde08 <peter@zetachain.com>
* test: add sui to tss migration tests (#4488)
* add tss migration for sui
* add changelog
* debug changes
* update message context
* update comments
* remove unused functions
* feat: change params for 2s block time (#4484)
* change params for 2s block time
* changelog
* remove todo
* change default params
* test fixes
* fix migration test
* fix distributions test
* feat: Add action to build & push zetanode image internally (#4482)
* feat: Add action to build zetanode and deploy in dry-run mode
* Add pr trigger
* fix: remove snapshotter
* add pr trigger
* try new flow
* test docker availability
* fix variables and refactor
* add test to tag
* update action
* trigger
* push latest only if no version
* revert to version
* fix: remove PR trigger
* fix: concurrency and fallback
* fix: Add timeout and cleanup
* feat: enable ALT in solana inbounds (#4493)
* enable ALT in solana inbounds
* lint
* changelog
* PR comments
* fmt
* run ci
* fix: bring back the support for tracerConfig object in zevm debug API (#4490)
* bring back the support for tracerConfig object in evm debug API
* add changelog entry
* add unit test for traceConfig object
* fix: port sui outbound schedule interval (#4509)
* fix: sui outbound schedule interval (#4506)
* changelog
* fix: false mempool is congested warning (#4511)
* fix false mempool is congested warning
* changelog
* PR comment
* PR comment
* fix(backport): reindex txlogs if duplicate indexes are present (#4498)
* update needs reindex function to check for log index across all groups
* add changelog
* use uint for index
* test: add e2e test to replace observer (#4503)
* add e2e test to replace observer
* update changelog
* add replace observer label check
* fix: Add solana image dependency
* Update cmd/zetae2e/local/replace_observer.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* add a comments to improve readibilty
---------
Co-authored-by: Hazim <hazim_malik@hotmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: add-ton-tss-migration (#4491)
* add tss migration for sui
* add changelog
* debug changes
* update message context
* update comments
* remove unused functions
* add ton to tss migration
* update comments
* update backoff
* update wait blocks for sui
* chore: fix function name in comment for batchLogger (#4504)
Signed-off-by: boqishan <boqishan@126.com>
Co-authored-by: Tanmay <tanmay@zetachain.com>
* feat: add migration script to add an authorization for MsgRemoveObserver (#4492)
* add migration script
* updae changelog
* feat: add a tool to list tss balances across all supported chains (#4507)
* add tss balance check
* update to using supported chains list from network
* update comments
* remove sample config file from repository
* update identifier chainRpc to chainRPC
* feat: move gas price multiplier to chain params (#4485)
* move gas price multiplier to chain params
* add changelog entry
* add breaking change description in changelog
* fix nil chainParams check in migration script; fix typo and make gas multiplier validation less strict; update changelog
* describe the impact of newly added field gas multiplier; fix typo in zetatool inbound
* fix unit test
* chore: merge main into develop (#4512)
* fix: ratelimiting race condition vuln (#4072)
* fix: ratelimiting race condition vuln
* fix: ratelimiting race condition vuln
- Fix race condition in RateLimiter.Release() function
- Replace non-atomic check-then-act with atomic decrement and bounds checking
- Add comprehensive test suite to verify the fix
- Update changelog with PR #4072
* fix: correct atomic implementation to prevent underflow
- Replace flawed Add(-1) approach with proper CompareAndSwap
- Fix underflow detection issue where uint32 wrap-around was missed
- Add TestRateLimiterUnderflowProtection to verify the fix
- Ensure Release() never causes negative counters or semaphore over-release
* refactor: simplify rate limiter Release() implementation
- Remove unnecessary infinite loop in CAS operation
- Single CAS attempt is sufficient for race condition protection
- Maintains thread-safety while being more efficient
- All tests still pass with simplified implementation
* fix: correct order of operations in rate limiter Release()
- Fix race condition by decrementing counter before releasing semaphore
- Ensure pending counter accurately reflects semaphore state
- Simplify implementation by using correct operation order
- All tests pass with cleaner, more logical approach
* test: add tests that reproduce the original race condition vulnerability
- Add BuggyRateLimiter that implements the original vulnerable code
- Add TestBuggyRateLimiterRaceCondition to demonstrate the race condition
- Add TestBuggyRateLimiterStressTest to stress test the vulnerability
- Add TestVulnerabilityDemonstration to show before/after comparison
- Add TestBuggyRateLimiterExcessiveReleases to show excessive release issues
- These tests demonstrate the theoretical vulnerability even if timing makes it hard to reproduce consistently
* fix: address race condition and underflow issues in RateLimiter
- Fix race condition in Release() by reordering operations (decrement pending first, then release semaphore)
- Fix Pending() function to handle negative atomic.Int32 values correctly
- Add comprehensive tests to verify fixes
- Remove buggy code from tests as requested by reviewers
- Document original vulnerability in test comments
The original race condition allowed multiple goroutines to release more permits than acquired.
The Pending() function could return incorrect values due to negative atomic.Int32 conversion.
Fixes: #4072
* refactor: rename test and update changelog to reflect actual improvements
- Rename TestVulnerabilityDemonstration to TestRateLimiterRobustness
- Update test description to reflect code quality improvements rather than vulnerability fixes
- Update changelog entry to match actual changes
- Tests still pass, confirming the improvements are working correctly
The reviewer correctly pointed out that if tests pass on develop without fixes,
then we're improving robustness rather than fixing vulnerabilities.
* refactor: remove support for v1 revert address for BTC (#4070)
* remove support for v1 revert address for BTC
* add changelog
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* feat: add support for withdraw using v2 connector contract (#4064)
* update go mod
* add a new message for migrating funds
* add migrate funds to e2e
* rebase from develop
* add v2 e2e test to check flow
* add zeta gateway deposit to zetaclient
* add github workflow
* update comments
* fix code formating
* fix code formating
* fix code formating
* fix unit tests
* fix unit tests
* revert to old command to start e2e test
* remove message for migration and refactor to using contract directly
* add changelog
* generate files after removing new message
* update generated files
* update generated files
* update go mod
* update deposit
* add unit tests
* add unit tests
* generate files
* generate files
* undo changes based on develop
* update deposit and revert smart contract call
* rename zeta deposit test file
* rename zeta deposit test file
* add abort and revert tests
* add TestZetaDepositAndCallNoMessage
* add TestZetaDepositAndCallNoMessage
* remove payable from TestAbort contract
* rename to LegacyZETADepositAndCallContract
* improve unit test coverage
* fix unit tests
* add some delay in TestZetacore_SubscribeNewBlocks
* update comment for handling zeta token zrc20
* add e2e test
* add e2e test for withdraw
* refactor ProcessZEVMInboundV2
* add core registry to setup
* refactor e2e test helper functions
* add unit test for zeta withdraw
* add unit test for withdraw and call
* resolve comments 1
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* improve abort tests
* improve abort tests
* resolve comments
* resolve comments 2
* update upgrade height to 280 to allow the first test to run the entire cycle
* wrap zeta mints in tmp context
* wrap zeta mint in temp context
* rebase
* add changelog
* add changelog
* adjust comments
* Update cmd/zetae2e/config/contracts.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix gas pool zeta calcualation
* add unit test for executeWithMintedZeta
* fix comments 1
* add unit tests
* update test dapp to use zeta token for consuming gas
* add core registry to zeta e2e post upgrade handler
* revert legacy test
* update changes based on comments 1
---------
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix: print error message in detail if unable to decode Bitcoin memo (#4090)
* print error message detail when memo decoding failed
* add changelog entry
* keep invalid memo log on Info level
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* test(e2e): update admin e2e tests to use v2 connector (#4071)
* update go mod
* add a new message for migrating funds
* add migrate funds to e2e
* rebase from develop
* add v2 e2e test to check flow
* add zeta gateway deposit to zetaclient
* add github workflow
* update comments
* fix code formating
* fix code formating
* fix code formating
* fix unit tests
* fix unit tests
* revert to old command to start e2e test
* remove message for migration and refactor to using contract directly
* add changelog
* generate files after removing new message
* update generated files
* update generated files
* update go mod
* update deposit
* add unit tests
* add unit tests
* generate files
* generate files
* undo changes based on develop
* update deposit and revert smart contract call
* rename zeta deposit test file
* rename zeta deposit test file
* add abort and revert tests
* add TestZetaDepositAndCallNoMessage
* add TestZetaDepositAndCallNoMessage
* remove payable from TestAbort contract
* rename to LegacyZETADepositAndCallContract
* improve unit test coverage
* fix unit tests
* add some delay in TestZetacore_SubscribeNewBlocks
* update comment for handling zeta token zrc20
* add e2e test
* add e2e test for withdraw
* refactor ProcessZEVMInboundV2
* add core registry to setup
* refactor e2e test helper functions
* add unit test for zeta withdraw
* add unit test for withdraw and call
* resolve comments 1
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* add unit test for ProcessRevert
* improve abort tests
* improve abort tests
* resolve comments
* resolve comments 2
* update upgrade height to 280 to allow the first test to run the entire cycle
* wrap zeta mints in tmp context
* wrap zeta mint in temp context
* rebase
* add changelog
* add changelog
* adjust comments
* Update cmd/zetae2e/config/contracts.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix gas pool zeta calcualation
* add unit test for executeWithMintedZeta
* fix comments 1
* add unit tests
* update admin
* revert unncessary changes
* disable account balance verification for admin tests
* improve naming for deposit functions
* add changelog
* update comments
* update test legacy test zeta to use EVMAddress
* remove skipping admin in upgrade setup
---------
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test: fix eth deposit test to check balance after deposit (#4118)
* check balance after eth deposit test
* fix typo
* fix import
* test: fix flaky Solana depositAndCall tests (#4113)
* fix flaky solana depositAndCall tests
* add changelog entry
* add wait logic inside AssertTestDAppEVMCalled
* chore: bump cosmos evm to support querying legacy proposals of type MsgUpdateParams (#4094)
* update zeta evm
* update commit
* fix: use evm chain id from eth config in rpc backend (#4096)
* fix: cancel solana WaC if tx size is too large (#4098)
* cancel solana WaC if tx size is too large
* align the comments with the code
* fix: nil reference in trace block (#4093)
* update to commit be548f7691876e656ec61aa46e31ed337be92f4e , on branch release/v34
---------
Co-authored-by: skosito <skostic9242@gmail.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
* fix: error when deploying contracts on testnet (#4112)
* dont return err if tx is not found in get tx receipt
* fix tests
* changelog
* feat: support hostname in addition to public IP for zetaclient to connect to zetacore (#4068)
* save initial work to remote
* add unit test and live test for zetacore hostname support
* add changelog entry; fix gosec and clean unused code
* fix CI upgrade test
---------
Co-authored-by: Tanmay <tanmay@zetachain.com>
* fix: dbg trace block by number gas limit legacy (#4121)
* fix dbg trace by block
* PR comments
* changelog
* fix(cherry-pick): cancel solana WaC if tx size is too large (#4111)
* cancel solana WaC if tx size is too large
* add changelog entry
* chore: remove tx suffix in vote inbound and outbound message names (#4110)
* fix(`crosschain`): remove confirmation mode from outbound and inbound digest (#4116)
* inbound
* .
* changelog
* refactor(zetacore): overwrite consensus config values for all timeout deltas on startup. (#4097)
* update 1
* add start-skip-consensus-overwrite-test
* generate files
* update tests
* add unit tests
* add unit tests for GenesisChainID
* add unit tests for GenesisChainID
* rename genesisChainID
* fix typo
* remove testnet from overwrite check
* refactor: replace []byte(fmt.Sprintf) with fmt.Appendf (#4131)
Signed-off-by: yinwenyu6 <yinwenyu6@outlook.com>
* feat: Sui message context ID as dynamic field (#4087)
* re-enable sui authenticated call
* integrate message context ID as dynamic field
* add changelog entry
* make issueMessageContext function self-contained
* fix unit test
* remove --skip-dependency-verification in sui gateway upgrade test
* cancel withdrawAndCall on invalid payload
* adopt new increase_nonce signature to adopt gas refund logic when cancelling a CCTX
* apply stringent check on Sui transaction's checkpoint
* apply status check on Sui inbound
* fix CI upgrade test
* fix unit test
* chore: fix some function names in comment (#4129)
Signed-off-by: pxwanglu <pxwanglu@icloud.com>
* chore: fix some observer message names (#4141)
* test: fix flaky Solana SPL deposit balance check (#4142)
* fix solana e2e SPL balance check by waiting maximum 30 seconds
* add changelog entry
* refactor: remove intx and outtx deprecated queries (#4150)
* refactor: remove intx and outtx deprecated queries
* fixes in e2e
* chore: remove redundant word in comment (#4149)
Signed-off-by: wmypku <wmypku@outlook.com>
* test(`e2e`): improve logs for CCTX status assertion (#4147)
* improve require status logs
* update usage in tests
* lint
* cursor comment
* chore: fix some typos in comment (#4146)
Signed-off-by: tzchenxixi <tzchenxixi@icloud.com>
* chore: set v35 as upgrade test reference and various clean up (#4115)
* add back precompiles
* add abci field to proposal
* test
* enable back
* test no creating proposasl
* disable zeta-ante
* cleanup v33 upgrade helper
* add v35 as reference
* remove gas stability pool temporary
* update to v36 and disable fast confirmation test
* bitcoin fast confirmation
* increase ersion for zeta
* remove erc20 init handler
* disable zevm to evm revert for older version
* disable zevm to evm revert abort for older version
* increase upgrade height
* feat: make the gas limit used for gateway calls on ZEVM a configurable parameter (#4153)
* add GatewayGasLimit to state
* refactor function name from MustGetGatewayGasLimit to GetGatewayGasLimitSafe
* update unit tests
* update unit tests
* update proto files
* replace big int with uint64
* changelog
* add check of older value
* add v4 migration back for authority module
* update setup handler to remove setting erc20 module
* test changes
* revert to using v32 as base branch for upgrades
---------
Co-authored-by: lumtis <lucas.bertrand.22@gmail.com>
* test(`e2e`): add a gas limit option for ZEVM to EVM call tests (#4145)
* add gas limit option
* use option for tests
* increase further upgrade height
* test: use pre-deployed example dapp V2 contract in e2e tests (#4158)
* do not deploy example contract in e2e tests, use pre-deployed example dapp V2 instead
* add changelog entry
* clean up debugging log
* remove commented code
* add back extra zrc20 SPL balance check
* chore(`e2e`): cleanup unused contracts (#4161)
* remove contextapp
* remove distribute
* test: fix flaky depositAndCall test that failed on sender assertion (#4165)
* fix flaky depositAndCall caused by sender assertion
* add changelog entry
* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4148)
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.7.8...v1.7.9)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
dependency-version: 1.7.9
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4172)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](https://github.com/ulikunitz/xz/compare/v0.5.11...v0.5.14)
---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
dependency-version: 0.5.14
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4173)
chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.2.1...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: standardize zetaclient logging (#4144)
* chore: remove unused DynamicTicker from zetaclient/types
* refactor: remove Msgf and refactor zerolog uses
* Replace Msgf for Msg
* Use '_' instead of '.'
* Start logs with lowercase instead of uppercase characters
* Use the constants in the logs module
* Use With().Logger() instead of log fields when possible
* fix: improve zetatool (#4175)
* scan gateway events by default for all inbound hashes
* scan gateway events by default for all inbound hashes
* test(`e2e`): add a E2E test to test depositAndCall with high gas consumption (#4177)
* set gas limit to 4m in localnet
* add high usage test
* changelog
* Update changelog.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Update e2e/e2etests/e2etests.go
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* test(`e2e`): add all chains by default in `start-localnet` (#4163)
* chore: add Solana to start-localnet to allow to run local tests
* add sui and ton
* Update cmd/zetae2e/local/local.go
Co-authored-by: Tanmay <tanmay@zetachain.com>
---------
Co-authored-by: Tanmay <tanmay@zetachain.com>
* chore: remove redundant words (#4179)
Signed-off-by: keeghcet <keeghcet@outlook.com>
* refactor: omit unnecessary reassignment (#4184)
Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com>
* fix: force rescan if inbound vote monitoring fails (#4183)
* add monitoringErr channel
* update to InboundBlockHeight - 1 , for reseting the block
* fix unit tests
* implement error interface
* rename to ErrTxMonitor
* add forceResetLastScanned flag
* add forceResetLastScanned flag
* add mutex to force scan
* add changelog
* add changelog
* update name to wasForceReset
* wrap UpdateForceResetLastScanned in mutex
* add a bound check to InboundBlockHeight to be safe
* Update zetaclient/chains/base/confirmation.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Update zetaclient/chains/base/observer.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* force update for in memory value if forceResetLastScanned is true
* add a lock on reading block height
* update error message
* update changelog
* wait till end of scan cycle to toggle the forceUpdateFlag
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: remove duplicate solana post-gas-price goroutine (#4194)
* feat: observe inbound from previous gateway package after upgrade (#4138)
* observe inbound from old gateway package optionally
* add changelog entry
* add sui inbound cursor migration; add post-upgrade deposit tests
* improve comments, logs and naming; fix post-upgrade withdraw failure
* protect anyStringMap
* add support for <withdrawcap-id> to Sui gateway address
* fix CI upgrade test failure
* use name previousPackageID and keep name PairID; rename AnyString and cursor migration function; improve test, comments, etc.
* replaced assert by require in sui unit test
* add support for original packageID in Sui gateway address
* avoid wrapping nil error
* use previous package ID in post-upgrade Sui deposit test
* add support for previous package deprecation and fix upgrade test
* fix unit test
* add a note to clarify the PackageID argument used for event query
* add documents to explain Sui gateway address format in the chain params
* refactor: remove unused loggers and log fields (#4180)
* chore: remove unused Headers logger
* refactor: remove (mostly) unused GasPrice logger
* refactor: replace logs.FieldMethod with With().Caller() and standardize logs.FieldModule values
* refactor: remove (mostly) unused log fields FieldTracker and FieldConfirmationMode
* refactor: replace missed log instances of '.' for '_'
* fix: unpack bitcoin revert message without considering 'CallOnRevert' flag (#4169)
* enable bitcoin revertMessage and ignore CallOnRevert flag
* add changelog entry
* update standard memo doc; improve abort address validation
* skip incompatible e2e test to allow CI upgrade test to pass
* fix: add timeout to monitoring routine (#4196)
* add a timeout for vote monitoring thread
* add a timeout for vote monitoring thread
* add comments
* remove typo for cancel call
* fix unit tests
* Update zetaclient/zetacore/client_vote.go
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Update zetaclient/chains/base/observer.go
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
* refactor: use maps.Copy for cleaner map handling (#4198)
Signed-off-by: joemicky <joemickychang@outlook.com>
* chore: fix some comments (#4208)
Signed-off-by: zhoujiaweii <zjwustc@outlook.com>
* fix: update evm version for missing tx types (#4216)
* refactor: replace HasPrefix+TrimPrefix with CutPrefix (#4215)
Signed-off-by: quantpoet <quantway@outlook.com>
* refactor: remove `LastBlockHeight` state variable (#4200)
* proto
* remove other references
* changelog
* refactor: add documentation for ZetaClient logging fields (#4174)
* refactor: use coin.CoinType for compliance logging
* refactor: add documentation for zetaclient logging fields
* fix: remove ZetaChain chain ID from GasStabilityPoolBalances query (#4217)
* fix query
* add test
* changelog
* add commment
* lint
* remove gas token address
* change error type
* refactor: remove index field in ballot (#4205)
* refactor: remove index field in ballot
* changelog
* fix unit tests
* refactor: remove `MsgUpdateERC20CustodyPauseStatus` and `MsgMigrateERC20CustodyFunds` (#4199)
* make message legacy
* remove other reference
* changelog
* refactor: rename whitelistERC20 into whitelistAsset (#4203)
* refactor: rename whitelistERC20 into whitelistAsset
* e2e test
* e2e test
* fix event
* simulation
* changelogs
* update auth list
* add migration script
* apply comment
* feat: provide error information in CCTX struct when Bitcoin deposit fail (#4211)
* add error message to CCTX struct when Bitcoin deposit failed
* add changelog entry
* fix unit test; improve function naming
* add unit test for inbound vote digest
* exclude inbound observation error message from digest
* fix: re-check for finalized ballot when executing inbound vote to create cctx (#4197)
* check for finalized block after ballot is finalized
* fix unit tests and add changelog
* adjust comments
* Apply suggestion from @lumtis
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* Apply suggestion from @lumtis
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* refactor check finalized ballot check to be done before adding the finalizing vote to the ballot
* adjust comments
* adjust comments
* fix comments 2
---------
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
* fix: set zeta ante to true in upgrade tests (#4225)
* add zeta ante
* add to upgrade test regular
* add to upgrade test regular
* update out of gas test
* update out of gas test
* fix tss migration test
* fix lint issues 1
* update v2 zeta version
* chore: resync changelogs with v36 changes (#4223)
* fix: skip writing config file to the filesystem (#4210)
* comment out writing files to the state
* ad changelog
* remove commented code
* return error from fetching FlagSkipConfigOverwrite
* refactor(`observer`): remove deprecated code (#4192)
* update proto
* update code
* changelogs
* fix changelog
* fix gas limit issue in upgrade test
* use ante-zetae2e for admin upgrade tests
* test fix
* refactor: prepare the client interfaces used by the observer-signers for dry-mode (#4213)
refactor: prepare the client interfaces of the observer-signers for dry-mode
* feat: enable NoAssetCall from Bitcoin (#4218)
* enable NoAssetCall from Bitcoin
* add changelog entry
* improve comment and log print
* revert bitcoin NoAssetCall that carries large excessive funds
* adjust btc inbound parsing order; fix test name
* improve function and variable names
* feat: multiple evm calls in single tx (#4157)
* bump protocol contracts
* use newer geth version with cancun support
* e2e test with 2 deposits in same tx
* e2e tests
* inbound trackers for multiple events
* changelog
* generate
* fix e2e tests
* inbound trackers e2e test
* bump protocol contracts
* PR comments
* PR comment
* PR comments
* PR comment
* lower upgrade height in upgrade tests
* try diff upgrade height
* upgrade additional fee in upgrade v36 handler
* chore: fix function name in comment (#4238)
Signed-off-by: russcoss <russcoss@outlook.com>
* revert: add timeout to monitoring routine" (#4244)
Revert "fix: add timeout to monitoring routine (#4196)"
This reverts commit 65f227bbfa585adb408f31d15a5bcf71243d1e52.
* fix(e2e): check test contracts deployment (#4251)
* fix(e2e): check test contracts deployment
* add other contracts
* changelog
* fix chain to wait tx from
* revert: force rescan if inbound vote monitoring fails (#4250)
* feat: refund a portion of remaining unused tokens to user (#3734)
* add new field to cctx structure to track user gas burned
* add unit tests
* add doc
* add unit test for migration
* add check for pre upgrade cctxs
* add older logic for handling cctxs created before upgrade
* remove LegacyChainParams
* add unit test for refund gas fee
* remove old migration
* add temp note for PR review
* fix typo
* fix typo
* generate files
* add missing test case
* add missing test case
* refactor based on comments
* update EtherWithdrawRestricted test
* update EtherWithdrawRest…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The diff is hard to read, since I moved some code around.
Here are the main changes:
mode.ClientModetype.clientMode mode.ClientModefield to the base observer.ClientMode mode.ClientModefield to the base signer.PostVoteInboundso it does not vote when in dry-mode.processOutboundfor dry-mode.zrepopackage to group calls toZetacoreClient.ObserveInbounds/ProcessInboundTrackers).repopackage.repo.Inboundtype.parseTransactionfunction to abstract parsing logic.ensureLastScannedTxtogetLastScannedTransaction.setLastScannedTxtosaveLastScannedTransaction.encoderpackage.rpc.TransactionToHashStringtoencoder.EncodeTx.rpc.TransactionHashFromStringtoencoder.DecodeHash.How Has This Been Tested?
Note
Introduce dry-mode for TON (skips voting/signing/broadcasting), refactor TON observer with a repo layer and new tx hash encoder, and migrate Zetacore client interfaces to zrepo across codebase.
mode.ClientModewith dry-mode; plumb into baseObserver/Signerand TON signer to skip voting/signing/broadcasting in dry-mode.repopackage for TON RPC/data access; add health and gas observers (CheckRPCStatus,ObserveGasPrice).ObserveInbound->ObserveInbounds,ensureLastScannedTx->getLastScannedTransaction,setLastScannedTx->saveLastScannedTransaction; addparseTransactionandInboundstruct.encoderpackage replacing RPC helpers for TON tx lt:hash (EncodeTx,EncodeHash,DecodeHash); update E2E tests and runner.zrepoand migrate usages ofinterfaces.ZetacoreClienttozrepo.ZetacoreClient; addZetaRepohelpers (e.g.,VoteOutbound,GetOutboundTrackers).clientModeinto base observer/signer; schedule new TON tasks (ObserveInbounds,ObserveGasPrice).Written by Cursor Bugbot for commit e516cdb. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
New Features
Refactor
Documentation