refactor: add zrepo package to zetaclient with dry-mode

[renan061]

Description

• Finish ZetaRepo to include ZetacoreClient functions that are relevant to the observer-signers.
  • Move VoteInbound method from the base observer to ZetaRepo.
  • Refactor VoteInbound so it does not ignore client errors from GetCctxByHash.
  • Refactor VoteInbound so it does not ignore client errors from GetBallotByID.
  • Add more tests for VoteInbound.
  • Standardize how errors are returned and logged for most ZetaRepo functions.
  • Methods do not need chainID parameters anymore.
• Add clientMode flag to ZetaRepo.
  • Make Vote* and PostOutboundTracker methods do nothing in dry-mode.
  • Add tests for dry-mode ZetaRepo.
• Remove ZetacoreClient from the base observer (only ZetaRepo from now on).

Closes #4302.

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Summary by CodeRabbit

• Refactor
  • Unified core interactions behind a new repository, streamlining block watching, CCTX/trackers retrieval, and voting (inbound/outbound/gas price) across Bitcoin, EVM, Solana, Sui, and TON.
  • Observer constructors now accept the repository; logging and error propagation simplified.
  • Renamed Sui gas price method to ObserveGasPrice.
• Tests
  • Updated test suites to the new repository pattern and error expectations.
• Documentation
  • Changelog updated under “Refactor”; no functional behavior changes intended.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Introduces a ZetaRepo layer and refactors observers, signers, and per-chain components (Bitcoin, EVM, Solana, Sui, TON) to use it instead of direct ZetacoreClient calls. Updates constructors, method signatures, logging, and error handling. Adds zrepo APIs, dry-mode handling, tests, and replaces PostVote* calls with Vote* via ZetaRepo. Minor changelog and test helpers changes.

Changes

Cohort / File(s)	Summary
Changelog changelog.md	Added Unreleased Refactor note: add zrepo package to zetaclient.
E2E/Test Utils e2e/e2etests/test_ton_withdrawal_concurrent.go, testutil/sample/crosschain.go	Loop style tweak; add OutboundVote(t) helper; remove OutboundVoteSim.
Base Observer Core zetaclient/chains/base/observer.go, .../observer_test.go, .../confirmation.go, .../confirmation_test.go	Replace ZetacoreClient with ZetaRepo across fields, constructor, accessors; remove PostVoteInbound method; adjust logging level; update fast-confirmation to use repo.GetForeignCoinsFromAsset and raw errors; tests updated to use zrepo and error constants.
Bitcoin Chain zetaclient/chains/bitcoin/bitcoin.go, .../observer/*.go, .../observer/*_test.go, .../signer/signer.go, .../signer/signer_test.go	Switch to ZetaRepo for block subscription, pending CCTXs, nonces, trackers, operator address, voting (VoteInbound/Outbound/GasPrice) and tracker posting; simplify errors; tests switched to zrepo and error constants; minor test loop capture removal.
EVM Chain zetaclient/chains/evm/evm.go, .../observer/*.go, .../observer/*_test.go, .../signer/*.go, .../signer/*_test.go	Replace ZetacoreClient with ZetaRepo across scheduling, inbound/outbound processing, gas price voting, tracker fetching, operator address/chain ID accessor; update signer method signatures to accept *ZetaRepo; simplify error handling; tests updated to wrap client via zrepo.New and adjust grpc errors in mocks.
Solana Chain zetaclient/chains/solana/*.go, .../observer/*_test.go, .../signer/*.go	Use ZetaRepo for inbound/outbound processing, gas price voting, trackers, operator address; outbound tracker reporting via repo; update NewObserver call sites; simplify errors; tests wrap client via zrepo.New.
Sui Chain zetaclient/chains/sui/observer/*.go, .../observer/*_test.go, .../sui.go	Rename PostGasPrice→ObserveGasPrice; route trackers, inbound voting, gas price voting through ZetaRepo; update scheduler names; use repo operator/chain accessors; tests updated to zrepo and grpc status errors.
TON Chain zetaclient/chains/ton/observer/*.go, .../observer/*_test.go, .../signer/*.go, .../signer/*_test.go, .../ton.go	Refactor inbound/outbound and signer paths to ZetaRepo for voting/trackers/operator; change intoVoteMessage signature to accept operatorAddress/zetaChain; TON observer struct drops zetaRepo field but accesses via accessor; gas price path to VoteGasPrice; scheduling uses repo for blocks/pending CCTXs; tests updated to zrepo and grpc errors.
ZetaRepo Package (new/expanded) zetaclient/chains/zrepo/client.go, .../errors.go, .../zrepo.go, .../zrepo_test.go, .../dry.go (removed)	Define ZetacoreClientRepo; refactor ZetacoreClient composition; add error taxonomy and wrappers; implement ZetaRepo with clientMode and methods: WatchNewBlocks, GetPendingCCTXs, GetPendingNonces, GetInboundTrackers, GetBTCTSSAddress, Get/Exists helpers, PostOutboundTracker, VoteGasPrice, VoteInbound, VoteOutbound, GetKeysAddress, GetOperatorAddress, GetForeignCoinsFromAsset; add comprehensive tests incl. dry-mode; remove DryZetaRepo stub.
Orchestrator Wiring zetaclient/orchestrator/bootstrap.go	Construct ZetaRepo and pass to base.NewObserver; drop clientMode param from newBaseObserver signature and NewObserver call sites.
Mocks/Test Helpers zetaclient/testutils/mocks/zetacore_client_opts.go	MockGetCctxByHash now accepts cctxIndex to return a stubbed CCTX when provided.
Zetacore Client zetaclient/zetacore/client.go	Remove compile-time assertion against zrepo interface; no API change.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Scheduler
  participant Observer
  participant ZetaRepo
  participant ZetacoreClient

  Scheduler->>Observer: Start()
  Observer->>ZetaRepo: WatchNewBlocks(ctx)
  ZetaRepo->>ZetacoreClient: NewBlockSubscriber(ctx)
  ZetacoreClient-->>ZetaRepo: blocks chan
  ZetaRepo-->>Observer: blocks chan

  loop On block or timer
    Observer->>ZetaRepo: GetPendingCCTXs(ctx)
    ZetaRepo->>ZetacoreClient: ListPendingCCTX(ctx, chain)
    ZetacoreClient-->>ZetaRepo: []*CCTX
    ZetaRepo-->>Observer: []*CCTX

    alt Inbound Event
      Observer->>ZetaRepo: VoteInbound(ctx, logger, msg, retryGas)
      ZetaRepo->>ZetacoreClient: PostVoteInbound(msg, gas)
      ZetacoreClient-->>ZetaRepo: ballot/hash or error
      ZetaRepo-->>Observer: result/error
    else Outbound Event
      Observer->>ZetaRepo: VoteOutbound(ctx, logger, gas, retryGas, msg)
      ZetaRepo->>ZetacoreClient: PostVoteOutbound(msg, gas)
      ZetacoreClient-->>ZetaRepo: zetaTxHash/ballot or error
      ZetaRepo-->>Observer: result/error
      Observer->>ZetaRepo: PostOutboundTracker(ctx, logger, nonce, txHash)
      ZetaRepo->>ZetacoreClient: PostOutboundTracker(nonce, txHash)
      ZetacoreClient-->>ZetaRepo: trackerHash or error
    end

    par Gas Price
      Observer->>ZetaRepo: VoteGasPrice(ctx, logger, price, priority, block)
      ZetaRepo->>ZetacoreClient: PostVoteGasPrice(...)
      ZetacoreClient-->>ZetaRepo: hash or error
    end
  end

Loading

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

• feat: add dry-mode support for TON #4277 — Introduces client dry-mode and refactors TON repo/encoder; overlaps with this PR’s zrepo clientMode and TON refactors.
• refactor(votes)!: drop support for header proofs #3125 — Refactors outbound tracker flow to PostOutboundTracker and removes header proofs; aligns with this PR’s repo-based tracker posting.
• feat: withdraw SOL from ZEVM to Solana #2560 — Modifies Solana observer/signer voting paths; similar areas updated here to use ZetaRepo.

Suggested reviewers

• lumtis
• brewmaster012
• ws4charlie
• skosito
• fbac

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 36.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “refactor: add zrepo package to zetaclient with dry-mode” succinctly captures the primary change of introducing the new repository layer and its dry-mode functionality without extraneous details. It follows a conventional commit style, clearly indicating a refactor and specifying the key feature added.
Description Check	✅ Passed	The pull request description includes both required sections (“Description” and “How Has This Been Tested?”), provides a clear summary of the changes with issue linkage (Closes #4302), and matches the template’s structure and testing checklist, accurately reflecting which tests were executed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 43.82284% with 241 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.86%. Comparing base (df7bb03) to head (2152a44).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
zetaclient/chains/zrepo/zrepo.go	45.19%	94 Missing and 3 partials ⚠️
zetaclient/chains/evm/observer/v2_inbound.go	0.00%	24 Missing ⚠️
zetaclient/chains/evm/observer/inbound.go	37.03%	17 Missing ⚠️
...taclient/chains/evm/observer/v2_inbound_tracker.go	0.00%	15 Missing ⚠️
zetaclient/chains/bitcoin/observer/outbound.go	25.00%	9 Missing ⚠️
...aclient/chains/bitcoin/observer/inbound_tracker.go	0.00%	8 Missing ⚠️
zetaclient/chains/solana/observer/outbound.go	0.00%	7 Missing ⚠️
zetaclient/chains/bitcoin/observer/inbound.go	40.00%	6 Missing ⚠️
...ent/chains/evm/signer/outbound_tracker_reporter.go	0.00%	6 Missing ⚠️
zetaclient/chains/ton/observer/outbound.go	28.57%	5 Missing ⚠️
... and 19 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4296      +/-   ##
===========================================
- Coverage    65.98%   65.86%   -0.12%     
===========================================
  Files          462      462              
  Lines        33720    33793      +73     
===========================================
+ Hits         22249    22257       +8     
- Misses       10488    10551      +63     
- Partials       983      985       +2     

Files with missing lines	Coverage Δ
zetaclient/chains/base/confirmation.go	100.00% <100.00%> (ø)
zetaclient/chains/base/observer.go	80.63% <100.00%> (-0.96%)	⬇️
zetaclient/chains/bitcoin/observer/mempool.go	100.00% <100.00%> (ø)
zetaclient/chains/evm/observer/observer_gas.go	21.73% <100.00%> (-1.24%)	⬇️
zetaclient/chains/ton/observer/observer.go	56.41% <ø> (-4.06%)	⬇️
zetaclient/chains/ton/signer/signer.go	36.97% <100.00%> (ø)
zetaclient/chains/ton/signer/tracker.go	76.08% <100.00%> (+4.65%)	⬆️
zetaclient/chains/zrepo/errors.go	100.00% <100.00%> (+100.00%)	⬆️
zetaclient/mode/mode.go	50.00% <100.00%> (+50.00%)	⬆️
zetaclient/orchestrator/bootstrap.go	61.70% <100.00%> (-1.12%)	⬇️
... and 30 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 7

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)

zetaclient/chains/evm/evm.go (1)

165-223: Per-CCTX scheduling interval is mutated across iterations

scheduleInterval is defined once and then modified inside the loop, affecting subsequent CCTX decisions. Use a per-iteration copy to avoid skewed scheduling.

Apply:

 for idx, cctx := range cctxList {
-    var (
+    var (
       params     = cctx.GetCurrentOutboundParam()
       nonce      = params.TssNonce
       outboundID = base.OutboundIDFromCCTX(cctx)
     )
+    // use a per-CCTX copy
+    currScheduleInterval := scheduleInterval

@@
-            if count >= 5 {
-                scheduleInterval = criticalInterval
-            }
+            if count >= 5 {
+                currScheduleInterval = criticalInterval
+            }
@@
-    if _, ok := trackerSet[nonce]; ok {
-        scheduleInterval = nonCriticalInterval
-    }
+    if _, ok := trackerSet[nonce]; ok {
+        currScheduleInterval = nonCriticalInterval
+    }
@@
-    if nonce%scheduleInterval == zetaHeight%scheduleInterval {
+    if nonce%currScheduleInterval == zetaHeight%currScheduleInterval {
         go e.signer.TryProcessOutbound(
             ctx,
             cctx,
             e.observer.ZetaRepo(),
             zetaHeight,
         )
     }

zetaclient/chains/sui/sui.go (1)

189-196: Fix closure capturing loop variables in async worker

bg.Work runs asynchronously; the closure captures cctx and zetaHeight by reference, leading to races/incorrect CCTX used.

- bg.Work(ctx, func(ctx context.Context) error {
-     if err := s.signer.ProcessCCTX(ctx, cctx, zetaHeight); err != nil {
+ c := cctx
+ zh := zetaHeight
+ bg.Work(ctx, func(ctx context.Context) error {
+     if err := s.signer.ProcessCCTX(ctx, c, zh); err != nil {
          s.outboundLogger(outboundID).Error().Err(err).Msg("error calling ProcessCCTX")
      }
      return nil
  })

zetaclient/chains/base/observer.go (1)

76-107: Validate zetaRepo is non-nil in constructor

A nil repository will panic at first use (ob.ZetaRepo()). Fail fast in NewObserver.

 func NewObserver(
     chain chains.Chain,
     chainParams observertypes.ChainParams,
-    zetaRepo *zrepo.ZetaRepo,
+    zetaRepo *zrepo.ZetaRepo,
     tssSigner interfaces.TSSSigner,
@@
 ) (*Observer, error) {
+    if zetaRepo == nil {
+        return nil, errors.New("zetaRepo is nil")
+    }
     blockCache, err := lru.New(blockCacheSize)

🧹 Nitpick comments (7)

zetaclient/chains/zrepo/errors.go (1)

18-32: Consider adding godoc comments for error constants.

The error constants provide clear semantic meaning for different client operation failures. Adding brief godoc comments would enhance maintainability and help developers understand when each error should be used.

Example:

 var (
 	ErrClient = errors.New("error calling a zetacore client function")
 
+	// ErrClientGetBTCTSSAddress indicates failure to retrieve BTC TSS address from zetacore.
 	ErrClientGetBTCTSSAddress        = errors.New("failed to get BTC TSS address")
+	// ErrClientGetCCTX indicates failure to retrieve a cross-chain transaction by nonce.
 	ErrClientGetCCTX                 = errors.New("failed to get CCTX for nonce")
 	// ... (continue for other constants)
 )

zetaclient/chains/bitcoin/signer/signer.go (1)

109-113: Consider logging the error from GetKeysAddress.

If GetKeysAddress() fails, the function silently returns without logging the error. This could make debugging difficult when the signer address cannot be retrieved.

Apply this diff to log the error before returning:

 	signerAddress, err := observer.ZetaRepo().GetKeysAddress()
 	if err != nil {
+		signer.Logger().Std.Error().Err(err).Msg("failed to get signer address")
 		return
 	}

zetaclient/chains/bitcoin/observer/outbound.go (1)

233-236: Guard against nil CCTX from repo

If GetCCTX can return (nil, nil) on not-found, this will panic on deref. Add a nil check.

- send, err := ob.ZetaRepo().GetCCTX(ctx, nonce)
+ send, err := ob.ZetaRepo().GetCCTX(ctx, nonce)
  if err != nil {
      return "", err
  }
+ if send == nil {
+     return "", fmt.Errorf("cctx not found for nonce %d", nonce)
+ }

Please confirm GetCCTX never returns (nil, nil); if guaranteed, ignore this.

zetaclient/chains/bitcoin/observer/inbound_tracker.go (1)

17-20: Continue on individual tracker errors to maximize progress

Returning on the first failing tracker aborts the batch. Prefer logging and continuing.

 trackers, err := ob.ZetaRepo().GetInboundTrackers(ctx)
 if err != nil {
     return err
 }
 for _, tracker := range trackers {
@@
-    if _, err := ob.CheckReceiptForBtcTxHash(ctx, tracker.TxHash, true); err != nil {
-        return err
-    }
+    if _, err := ob.CheckReceiptForBtcTxHash(ctx, tracker.TxHash, true); err != nil {
+        ob.logger.Inbound.Error().
+            Str(logs.FieldTx, tracker.TxHash).
+            Err(err).
+            Msg("failed processing inbound tracker; continuing")
+        continue
+    }

Also applies to: 27-30

zetaclient/chains/sui/sui.go (1)

58-61: Wrap repo-call errors and enforce WatchNewBlocks channel closure

• Wrap both calls with contextual errors:

- newBlockChan, err := s.observer.ZetaRepo().WatchNewBlocks(ctx)
- if err != nil {
-     return err
- }
+ newBlockChan, err := s.observer.ZetaRepo().WatchNewBlocks(ctx)
+ if err != nil {
+     return errors.Wrap(err, "watch new blocks")
+ }

- cctxList, err := s.observer.ZetaRepo().GetPendingCCTXs(ctx)
- if err != nil {
-     return err
- }
+ cctxList, err := s.observer.ZetaRepo().GetPendingCCTXs(ctx)
+ if err != nil {
+     return errors.Wrap(err, "get pending cctxs")
+ }

• Ensure newBlockChan is closed when ctx is cancelled (e.g. forward <-ctx.Done() to close(newBlockChan)).

zetaclient/chains/zrepo/zrepo_test.go (1)

318-320: Consider using t.Fatal instead of panic for test validation.

The panic on line 319 validates mutually exclusive test parameters but could be more idiomatic for Go tests.

Apply this diff:

 if testCase.hash != "" && testCase.id != "" {
-    panic("invalid test case")
+    t.Fatal("test case cannot specify both hash and id")
 }

zetaclient/chains/zrepo/zrepo.go (1)

281-292: Validate asset format before conversion.

Line 285 uses ethcommon.HexToAddress(asset) to convert the asset string to an Ethereum address. If asset is not a valid hex-encoded address, HexToAddress returns a zero address without signaling an error. This could lead to unexpected behavior where an invalid asset is silently accepted and queried, potentially returning incorrect or misleading results.

Consider adding validation before the conversion:

 func (repo *ZetaRepo) GetForeignCoinsFromAsset(ctx context.Context,
 	asset string,
 ) (*fungible.ForeignCoins, error) {
 	chainID := repo.connectedChain.ChainId
+	if !ethcommon.IsHexAddress(asset) {
+		return nil, fmt.Errorf("%w: invalid hex address %s", ErrClientGetForeignCoinsForAsset, asset)
+	}
 	address := ethcommon.HexToAddress(asset)
 	coins, err := repo.client.GetForeignCoinsFromAsset(ctx, chainID, address)
 	if err != nil {
 		outterErr := fmt.Errorf("%w %s", ErrClientGetForeignCoinsForAsset, asset)
 		return nil, newClientError(outterErr, err)
 	}
 	return &coins, nil
 }

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3b3ed36 and 94fdc3a.

📒 Files selected for processing (64)

• changelog.md (1 hunks)
• e2e/e2etests/test_ton_withdrawal_concurrent.go (1 hunks)
• testutil/sample/crosschain.go (1 hunks)
• zetaclient/chains/base/confirmation.go (1 hunks)
• zetaclient/chains/base/confirmation_test.go (3 hunks)
• zetaclient/chains/base/observer.go (5 hunks)
• zetaclient/chains/base/observer_test.go (2 hunks)
• zetaclient/chains/bitcoin/bitcoin.go (2 hunks)
• zetaclient/chains/bitcoin/observer/db_test.go (0 hunks)
• zetaclient/chains/bitcoin/observer/gas_price.go (1 hunks)
• zetaclient/chains/bitcoin/observer/inbound.go (3 hunks)
• zetaclient/chains/bitcoin/observer/inbound_test.go (2 hunks)
• zetaclient/chains/bitcoin/observer/inbound_tracker.go (3 hunks)
• zetaclient/chains/bitcoin/observer/mempool.go (1 hunks)
• zetaclient/chains/bitcoin/observer/mempool_test.go (2 hunks)
• zetaclient/chains/bitcoin/observer/observer_test.go (3 hunks)
• zetaclient/chains/bitcoin/observer/outbound.go (5 hunks)
• zetaclient/chains/bitcoin/observer/outbound_test.go (2 hunks)
• zetaclient/chains/bitcoin/observer/utxos_test.go (2 hunks)
• zetaclient/chains/bitcoin/signer/signer.go (2 hunks)
• zetaclient/chains/bitcoin/signer/signer_test.go (2 hunks)
• zetaclient/chains/evm/evm.go (4 hunks)
• zetaclient/chains/evm/observer/inbound.go (9 hunks)
• zetaclient/chains/evm/observer/inbound_test.go (2 hunks)
• zetaclient/chains/evm/observer/observer_gas.go (1 hunks)
• zetaclient/chains/evm/observer/observer_test.go (3 hunks)
• zetaclient/chains/evm/observer/outbound.go (3 hunks)
• zetaclient/chains/evm/observer/v2_inbound.go (6 hunks)
• zetaclient/chains/evm/observer/v2_inbound_tracker.go (3 hunks)
• zetaclient/chains/evm/signer/outbound_tracker_reporter.go (3 hunks)
• zetaclient/chains/evm/signer/signer.go (10 hunks)
• zetaclient/chains/evm/signer/signer_test.go (3 hunks)
• zetaclient/chains/solana/observer/inbound.go (2 hunks)
• zetaclient/chains/solana/observer/inbound_test.go (3 hunks)
• zetaclient/chains/solana/observer/inbound_tracker.go (1 hunks)
• zetaclient/chains/solana/observer/observer_gas.go (1 hunks)
• zetaclient/chains/solana/observer/observer_test.go (1 hunks)
• zetaclient/chains/solana/observer/outbound.go (4 hunks)
• zetaclient/chains/solana/observer/outbound_test.go (2 hunks)
• zetaclient/chains/solana/signer/outbound_tracker_reporter.go (2 hunks)
• zetaclient/chains/solana/signer/signer.go (4 hunks)
• zetaclient/chains/solana/solana.go (3 hunks)
• zetaclient/chains/sui/observer/inbound.go (3 hunks)
• zetaclient/chains/sui/observer/observer.go (3 hunks)
• zetaclient/chains/sui/observer/observer_test.go (5 hunks)
• zetaclient/chains/sui/observer/outbound.go (5 hunks)
• zetaclient/chains/sui/sui.go (4 hunks)
• zetaclient/chains/ton/observer/gas.go (1 hunks)
• zetaclient/chains/ton/observer/inbound.go (4 hunks)
• zetaclient/chains/ton/observer/observer.go (1 hunks)
• zetaclient/chains/ton/observer/observer_test.go (3 hunks)
• zetaclient/chains/ton/observer/outbound.go (4 hunks)
• zetaclient/chains/ton/signer/signer.go (3 hunks)
• zetaclient/chains/ton/signer/signer_test.go (4 hunks)
• zetaclient/chains/ton/signer/tracker.go (2 hunks)
• zetaclient/chains/ton/ton.go (3 hunks)
• zetaclient/chains/zrepo/client.go (2 hunks)
• zetaclient/chains/zrepo/dry.go (0 hunks)
• zetaclient/chains/zrepo/errors.go (1 hunks)
• zetaclient/chains/zrepo/zrepo.go (2 hunks)
• zetaclient/chains/zrepo/zrepo_test.go (1 hunks)
• zetaclient/orchestrator/bootstrap.go (7 hunks)
• zetaclient/testutils/mocks/zetacore_client_opts.go (1 hunks)
• zetaclient/zetacore/client.go (0 hunks)

💤 Files with no reviewable changes (3)

• zetaclient/chains/zrepo/dry.go
• zetaclient/zetacore/client.go
• zetaclient/chains/bitcoin/observer/db_test.go

🧰 Additional context used

📓 Path-based instructions (1)

**/*.go

⚙️ CodeRabbit configuration file

Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

Files:

• zetaclient/chains/bitcoin/observer/mempool.go
• zetaclient/chains/bitcoin/observer/inbound_test.go
• zetaclient/chains/evm/observer/observer_gas.go
• zetaclient/chains/solana/observer/outbound_test.go
• zetaclient/chains/evm/signer/outbound_tracker_reporter.go
• zetaclient/chains/bitcoin/observer/outbound.go
• zetaclient/chains/solana/signer/outbound_tracker_reporter.go
• zetaclient/testutils/mocks/zetacore_client_opts.go
• zetaclient/chains/base/confirmation_test.go
• testutil/sample/crosschain.go
• zetaclient/chains/ton/signer/tracker.go
• zetaclient/chains/solana/signer/signer.go
• zetaclient/chains/solana/observer/inbound_test.go
• zetaclient/chains/solana/observer/inbound_tracker.go
• zetaclient/chains/base/confirmation.go
• zetaclient/chains/evm/observer/v2_inbound_tracker.go
• zetaclient/chains/ton/observer/gas.go
• zetaclient/chains/bitcoin/observer/outbound_test.go
• zetaclient/chains/bitcoin/bitcoin.go
• zetaclient/chains/ton/signer/signer.go
• zetaclient/chains/bitcoin/signer/signer_test.go
• zetaclient/chains/bitcoin/observer/observer_test.go
• zetaclient/chains/ton/observer/inbound.go
• zetaclient/chains/evm/signer/signer.go
• zetaclient/chains/base/observer.go
• zetaclient/chains/ton/observer/observer.go
• zetaclient/orchestrator/bootstrap.go
• zetaclient/chains/bitcoin/observer/gas_price.go
• zetaclient/chains/sui/observer/outbound.go
• zetaclient/chains/solana/observer/outbound.go
• zetaclient/chains/ton/ton.go
• zetaclient/chains/evm/signer/signer_test.go
• zetaclient/chains/sui/observer/inbound.go
• zetaclient/chains/evm/observer/observer_test.go
• zetaclient/chains/bitcoin/observer/inbound.go
• zetaclient/chains/zrepo/zrepo.go
• zetaclient/chains/ton/observer/outbound.go
• zetaclient/chains/zrepo/errors.go
• zetaclient/chains/solana/observer/inbound.go
• zetaclient/chains/evm/evm.go
• zetaclient/chains/bitcoin/observer/utxos_test.go
• zetaclient/chains/solana/observer/observer_gas.go
• zetaclient/chains/solana/solana.go
• zetaclient/chains/sui/observer/observer_test.go
• zetaclient/chains/evm/observer/inbound.go
• zetaclient/chains/evm/observer/inbound_test.go
• zetaclient/chains/solana/observer/observer_test.go
• zetaclient/chains/zrepo/zrepo_test.go
• zetaclient/chains/evm/observer/outbound.go
• zetaclient/chains/bitcoin/signer/signer.go
• zetaclient/chains/sui/observer/observer.go
• zetaclient/chains/evm/observer/v2_inbound.go
• zetaclient/chains/ton/observer/observer_test.go
• e2e/e2etests/test_ton_withdrawal_concurrent.go
• zetaclient/chains/ton/signer/signer_test.go
• zetaclient/chains/bitcoin/observer/inbound_tracker.go
• zetaclient/chains/zrepo/client.go
• zetaclient/chains/base/observer_test.go
• zetaclient/chains/bitcoin/observer/mempool_test.go
• zetaclient/chains/sui/sui.go

🧠 Learnings (7)

📚 Learning: 2024-10-08T15:34:48.217Z

Learnt from: ws4charlie
PR: zeta-chain/node#2907
File: zetaclient/chains/bitcoin/observer/outbound_test.go:81-82
Timestamp: 2024-10-08T15:34:48.217Z
Learning: In the `mineTxNSetNonceMark` function within `bitcoin/observer/outbound_test.go`, it's acceptable to hardcode the chain ID, as the tests do not require varying chain IDs.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound_test.go

📚 Learning: 2024-07-04T23:47:56.072Z

Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/orchestrator.go:222-237
Timestamp: 2024-07-04T23:47:56.072Z
Learning: The `GetUpdatedChainObserver` method in the `Orchestrator` class is covered by unit tests in `zetaclient/orchestrator/orchestrator_test.go` and `zetaclient/orchestrator/chain_activate_test.go`.

Applied to files:

• zetaclient/chains/bitcoin/observer/inbound_test.go
• zetaclient/chains/solana/observer/inbound_test.go
• zetaclient/chains/bitcoin/signer/signer_test.go
• zetaclient/chains/solana/observer/observer_test.go
• zetaclient/chains/ton/observer/observer_test.go
• zetaclient/chains/base/observer_test.go

📚 Learning: 2025-03-04T22:39:58.395Z

Learnt from: gartnera
PR: zeta-chain/node#3632
File: zetaclient/chains/solana/signer/signer.go:304-304
Timestamp: 2025-03-04T22:39:58.395Z
Learning: The Solana signer implementation in zetaclient/chains/solana/signer/signer.go has limited test coverage, particularly for the transaction broadcasting logic with fallback scenarios. Adding this coverage has been acknowledged as a potential future improvement outside the scope of immediate fixes.

Applied to files:

• zetaclient/chains/solana/signer/signer.go
• zetaclient/chains/evm/signer/signer.go
• zetaclient/chains/evm/signer/signer_test.go
• zetaclient/chains/bitcoin/signer/signer.go
• zetaclient/chains/ton/signer/signer_test.go

📚 Learning: 2024-07-05T00:02:31.446Z

Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/chain_activate.go:184-247
Timestamp: 2024-07-05T00:02:31.446Z
Learning: The `CreateSignerObserverBTC` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.

Applied to files:

• zetaclient/chains/bitcoin/signer/signer_test.go
• zetaclient/chains/bitcoin/signer/signer.go

📚 Learning: 2024-07-05T00:02:36.493Z

Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/chain_activate.go:116-181
Timestamp: 2024-07-05T00:02:36.493Z
Learning: The `CreateSignerObserverEVM` function in `zetaclient/orchestrator/chain_activate.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go`.

Applied to files:

• zetaclient/chains/bitcoin/signer/signer_test.go

📚 Learning: 2024-07-04T23:46:38.428Z

Learnt from: ws4charlie
PR: zeta-chain/node#2411
File: zetaclient/orchestrator/orchestrator.go:192-217
Timestamp: 2024-07-04T23:46:38.428Z
Learning: The `GetUpdatedSigner` method in `zetaclient/orchestrator/orchestrator.go` is covered by unit tests in `zetaclient/orchestrator/chain_activate_test.go` and `zetaclient/orchestrator/orchestrator_test.go`.

Applied to files:

• zetaclient/chains/bitcoin/signer/signer_test.go
• zetaclient/chains/ton/signer/signer_test.go

📚 Learning: 2025-01-14T03:37:18.430Z

Learnt from: ws4charlie
PR: zeta-chain/node#3306
File: pkg/math/integer_test.go:0-0
Timestamp: 2025-01-14T03:37:18.430Z
Learning: Use big.Int for handling large number calculations and edge cases to avoid integer overflow issues.

Applied to files:

• zetaclient/chains/sui/observer/outbound.go

🧬 Code graph analysis (58)

zetaclient/chains/bitcoin/observer/mempool.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/bitcoin/observer/inbound_test.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/evm/observer/observer_gas.go (2)

zetaclient/chains/base/logger.go (1)

• Logger (18-21)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/solana/observer/outbound_test.go (2)

zetaclient/chains/base/observer.go (1)

• NewObserver (77-107)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/chains/evm/signer/outbound_tracker_reporter.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/bitcoin/observer/outbound.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/logs/fields.go (2)

• FieldNonce (23-23)
• FieldTx (26-26)

zetaclient/chains/solana/signer/outbound_tracker_reporter.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/testutils/mocks/zetacore_client_opts.go (2)

zetaclient/testutils/mocks/zetacore_client.go (1)

• ZetacoreClient (31-33)

testutil/sample/crosschain.go (1)

• CrossChainTx (266-279)

zetaclient/chains/base/confirmation_test.go (1)

zetaclient/chains/zrepo/errors.go (1)

• ErrClientGetForeignCoinsForAsset (24-24)

testutil/sample/crosschain.go (4)

x/crosschain/types/tx.pb.go (3)

• MsgVoteOutbound (948-962)
• MsgVoteOutbound (966-966)
• MsgVoteOutbound (967-969)

x/crosschain/types/cross_chain_tx.pb.go (11)

• CrossChainTx (766-776)
• CrossChainTx (780-780)
• CrossChainTx (781-783)
• Status (588-605)
• Status (609-609)
• Status (610-612)
• InboundParams (181-201)
• InboundParams (205-205)
• InboundParams (206-208)
• ConfirmationMode (93-93)
• ConfirmationMode (114-116)

testutil/sample/crypto.go (1)

• EthAddress (89-91)

pkg/chains/chains.pb.go (1)

• ReceiveStatus_success (34-34)

zetaclient/chains/ton/signer/tracker.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/solana/signer/signer.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/solana/observer/inbound_test.go (4)

zetaclient/keys/keys.go (1)

• Keys (36-41)

zetaclient/chains/base/observer.go (1)

• NewObserver (77-107)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/solana/observer/inbound_tracker.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/base/confirmation.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/evm/observer/v2_inbound_tracker.go (2)

zetaclient/zetacore/constant.go (1)

• PostVoteInboundExecutionGasLimit (20-20)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/ton/observer/gas.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/bitcoin/observer/outbound_test.go (3)

zetaclient/chains/base/observer.go (1)

• NewObserver (77-107)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/bitcoin/bitcoin.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/ton/signer/signer.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/bitcoin/signer/signer_test.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/chains/base/observer.go (1)

• NewObserver (77-107)

zetaclient/chains/bitcoin/observer/observer_test.go (3)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/chains/bitcoin/observer/observer.go (1)

• New (135-191)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/ton/observer/inbound.go (3)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

x/crosschain/types/tx.pb.go (3)

• MsgVoteInbound (1110-1140)
• MsgVoteInbound (1144-1144)
• MsgVoteInbound (1145-1147)

x/crosschain/types/message_vote_inbound.go (1)

• NewMsgVoteInbound (66-117)

zetaclient/chains/evm/signer/signer.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/solana/signer/signer.go (1)

• IsPendingOutboundFromZetaChain (477-483)

zetaclient/chains/base/observer.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/ton/observer/observer.go (1)

zetaclient/chains/ton/repo/repo.go (1)

• TONRepo (19-25)

zetaclient/orchestrator/bootstrap.go (2)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/base/observer.go (1)

• NewObserver (77-107)

zetaclient/chains/bitcoin/observer/gas_price.go (2)

zetaclient/chains/bitcoin/observer/observer.go (1)

• Logger (79-85)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/sui/observer/outbound.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/logs/fields.go (1)

• FieldTx (26-26)

zetaclient/chains/solana/observer/outbound.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

x/crosschain/types/message_vote_outbound.go (1)

• NewMsgVoteOutbound (17-47)

zetaclient/chains/ton/ton.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/evm/signer/signer_test.go (3)

zetaclient/chains/evm/client/client.go (1)

• New (47-49)

zetaclient/chains/solana/observer/observer.go (1)

• New (90-115)

zetaclient/testutils/mocks/zetacore_client.go (1)

• NewZetacoreClient (1024-1034)

zetaclient/chains/sui/observer/inbound.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/zetacore/constant.go (1)

• PostVoteInboundExecutionGasLimit (20-20)

zetaclient/chains/evm/observer/observer_test.go (3)

zetaclient/chains/evm/observer/observer.go (1)

• New (86-102)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/base/observer.go (1)

• NewObserver (77-107)

zetaclient/chains/bitcoin/observer/inbound.go (3)

zetaclient/zetacore/constant.go (1)

• PostVoteInboundExecutionGasLimit (20-20)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

pkg/chains/chains.pb.go (3)

• Chain (356-376)
• Chain (380-380)
• Chain (381-383)

zetaclient/chains/zrepo/zrepo.go (5)

zetaclient/chains/zrepo/client.go (2)

• ZetacoreClientRepo (66-94)
• ZetacoreClient (100-132)

zetaclient/mode/mode.go (2)

• ClientMode (5-5)
• DryMode (9-9)

zetaclient/chains/zrepo/errors.go (15)

• ErrClientGetCCTX (19-19)
• ErrClientGetPendingCCTXs (22-22)
• ErrClientGetPendingNonces (23-23)
• ErrClientGetInboundTrackers (20-20)
• ErrClientGetBTCTSSAddress (18-18)
• ErrClientPostOutboundTracker (26-26)
• ErrClientVoteGasPrice (27-27)
• ErrClientVoteInbound (28-28)
• ErrClientVoteOutbound (29-29)
• ErrClientWatchNewBlocks (31-31)
• ErrGetKeysAddress (35-35)
• ErrClientGetForeignCoinsForAsset (24-24)
• ErrNotRPCError (9-9)
• ErrClientGetCCTXByHash (11-11)
• ErrClientGetBallotByID (12-12)

zetaclient/logs/fields.go (5)

• FieldMode (7-7)
• FieldZetaTx (29-29)
• FieldTx (26-26)
• FieldCoinType (43-43)
• FieldBallotIndex (39-39)

zetaclient/zetacore/constant.go (1)

• PostVoteInboundGasLimit (14-14)

zetaclient/chains/ton/observer/outbound.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/logs/fields.go (1)

• FieldNonce (23-23)

zetaclient/chains/zrepo/errors.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/chains/solana/observer/inbound.go (2)

zetaclient/zetacore/constant.go (1)

• PostVoteInboundExecutionGasLimit (20-20)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/evm/evm.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/bitcoin/observer/utxos_test.go (1)

zetaclient/chains/zrepo/errors.go (2)

• ErrClient (16-16)
• ErrClientGetCCTX (19-19)

zetaclient/chains/solana/observer/observer_gas.go (2)

zetaclient/chains/bitcoin/observer/observer.go (1)

• Logger (79-85)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/solana/solana.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/sui/observer/observer_test.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/chains/base/observer.go (1)

• NewObserver (77-107)

zetaclient/chains/evm/observer/inbound.go (3)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/zetacore/constant.go (2)

• PostVoteInboundExecutionGasLimit (20-20)
• PostVoteInboundMessagePassingExecutionGasLimit (23-23)

pkg/coin/coin.pb.go (2)

• CoinType_ERC20 (29-29)
• CoinType_Gas (28-28)

zetaclient/chains/solana/observer/observer_test.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/zrepo/zrepo_test.go (8)

zetaclient/testutils/mocks/zetacore_client.go (1)

• NewZetacoreClient (1024-1034)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

pkg/chains/chains.go (2)

• Ethereum (24-34)
• ZetaChainMainnet (11-21)

zetaclient/mode/mode.go (2)

• DryMode (9-9)
• StandardMode (8-8)

testutil/sample/sample.go (2)

• String (72-74)
• ZetaIndex (54-58)

testutil/sample/crosschain.go (3)

• InboundVote (355-374)
• OutboundVote (376-392)
• CrossChainTx (266-279)

x/crosschain/types/message_vote_inbound.go (1)

• MaxMessageLength (21-21)

zetaclient/chains/zrepo/errors.go (4)

• ErrNotRPCError (9-9)
• ErrClient (16-16)
• ErrClientGetCCTXByHash (11-11)
• ErrClientGetBallotByID (12-12)

zetaclient/chains/evm/observer/outbound.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

x/crosschain/types/message_vote_outbound.go (1)

• NewMsgVoteOutbound (17-47)

zetaclient/chains/bitcoin/signer/signer.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/sui/observer/observer.go (2)

zetaclient/chains/base/observer.go (1)

• Observer (35-74)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/evm/observer/v2_inbound.go (2)

zetaclient/zetacore/constant.go (1)

• PostVoteInboundExecutionGasLimit (20-20)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/chains/ton/observer/observer_test.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/ton/signer/signer_test.go (2)

zetaclient/chains/zrepo/zrepo.go (2)

• ZetaRepo (29-35)
• New (38-40)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/bitcoin/observer/inbound_tracker.go (2)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

zetaclient/zetacore/constant.go (1)

• PostVoteInboundExecutionGasLimit (20-20)

zetaclient/chains/zrepo/client.go (3)

zetaclient/testutils/mocks/zetacore_client.go (1)

• ZetacoreClient (31-33)

zetaclient/zetacore/client.go (1)

• Client (31-53)

zetaclient/keys/interfaces/interfaces.go (1)

• ObserverKeys (10-17)

zetaclient/chains/base/observer_test.go (3)

zetaclient/chains/zrepo/zrepo.go (1)

• New (38-40)

zetaclient/mode/mode.go (1)

• StandardMode (8-8)

zetaclient/chains/base/observer.go (1)

• NewObserver (77-107)

zetaclient/chains/bitcoin/observer/mempool_test.go (1)

zetaclient/chains/zrepo/errors.go (1)

• ErrClientGetPendingNonces (23-23)

zetaclient/chains/sui/sui.go (1)

zetaclient/chains/zrepo/zrepo.go (1)

• ZetaRepo (29-35)

🔇 Additional comments (81)

e2e/e2etests/test_ton_withdrawal_concurrent.go (1)

30-30: LGTM: Modern Go loop idiom.

The change from a traditional C-style loop to range recipientsCount is a clean adoption of Go 1.22+ range-over-integer syntax. The behavior is functionally identical, and the code is more idiomatic.

zetaclient/chains/bitcoin/observer/utxos_test.go (1)

13-13: LGTM: Improved error handling with typed error assertions.

The addition of the zrepo import and the replacement of generic error checks with explicit require.ErrorIs assertions for zrepo.ErrClient and zrepo.ErrClientGetCCTX enhances test precision and robustness. This approach correctly validates the error chain and aligns with best practices for error wrapping and type checking in Go.

Also applies to: 49-51

zetaclient/chains/base/confirmation_test.go (3)

17-17: LGTM: Import addition aligns with zrepo refactoring.

The import of the zrepo package is correctly placed and necessary for referencing the centralized error constant used in the test assertion.

---

371-371: LGTM: Centralized error constant improves consistency.

Referencing zrepo.ErrClientGetForeignCoinsForAsset.Error() instead of a hardcoded string enhances maintainability and ensures consistent error messaging across tests.

---

395-403: LGTM: Improved readability through formatting.

The multi-line formatting of the mock setup enhances readability without altering functionality. This is a beneficial stylistic improvement.

testutil/sample/crosschain.go (1)

376-392: No references to OutboundVoteSim found. The search yielded zero matches; manually confirm no tests or other code paths depend on this removed function.

changelog.md (1)

14-17: LGTM!

The changelog entry appropriately documents the addition of the zrepo package under the Refactor section. The format is consistent with existing entries.

zetaclient/chains/base/observer_test.go (2)

72-77: LGTM!

The test suite has been correctly updated to use the zrepo.New wrapper pattern, ensuring tests exercise the repository-based client interface introduced in this PR. The migration is consistent and maintains test coverage.

---

146-146: LGTM!

Consistent application of the zrepo.New wrapper pattern in the test table, aligning with the repository-based architecture.

zetaclient/chains/solana/signer/signer.go (2)

151-156: LGTM!

The signature change to accept zetaRepo *zrepo.ZetaRepo aligns with the repository pattern introduced across the codebase. The parameter threading is correct.

---

329-336: Outbound tracker reporting verified
Confirmed that reportToOutboundTracker invokes zetaRepo.PostOutboundTracker and that PostOutboundTracker no-ops in dry-mode.

zetaclient/chains/zrepo/errors.go (2)

38-42: LGTM!

The updated newClientError function properly chains errors using %w with fmt.Errorf, creating a three-level error hierarchy: ErrClient → outer (operation-specific) → inner (actual error). This enables proper error unwrapping with errors.Is and errors.As.

---

8-13: All new error constants are referenced The new error variables ErrNotRPCError, ErrClientGetCCTXByHash, and ErrClientGetBallotByID are used in both implementation (zrepo.go) and tests (zrepo_test.go); no unused declarations remain.

zetaclient/chains/solana/observer/observer_test.go (1)

43-53: LGTM!

The test helper MockSolanaObserver has been correctly updated to inject a zrepo-wrapped client into the base observer, maintaining consistency with the repository pattern migration across the codebase.

zetaclient/chains/ton/signer/signer_test.go (2)

126-143: LGTM!

The test suite has been properly refactored to use ZetaRepo. The zetaRepo field is correctly initialized via zrepo.New and threaded through to signer methods under test.

---

109-110: LGTM!

The TryProcessOutbound calls correctly pass ts.zetaRepo, aligning with the new signature and repository-based testing pattern.

zetaclient/chains/bitcoin/observer/inbound_test.go (2)

250-250: LGTM!

The receiver chain ID is now correctly sourced from ob.ZetaRepo().ZetaChain().ChainId, aligning with the repository-based access pattern. The change maintains the same semantic behavior while using the new abstraction.

---

311-311: LGTM!

Consistent application of the repository-based access pattern for retrieving the ZetaChain ID.

zetaclient/testutils/mocks/zetacore_client_opts.go (1)

68-75: No additional CCTX fields required in mocks
Search for usages of MockGetCctxByHash found no tests accessing any CrossChainTx fields beyond Index; the current mock is sufficient.

zetaclient/chains/evm/observer/inbound_test.go (1)

21-22: LGTM! Test error signaling now uses grpc status codes.

The addition of grpc imports and the update to mock GetCctxByHash to return a grpc status error aligns with the repository-wide migration to standardized error handling via ZetaRepo.

Also applies to: 465-466

zetaclient/chains/bitcoin/observer/mempool.go (1)

136-138: LGTM! Migration to ZetaRepo for pending nonces retrieval.

The change from ZetacoreClient.GetPendingNoncesByChain to ZetaRepo().GetPendingNonces is correct and aligns with the repository-wide refactor. The simplified error handling (returning raw error) is also consistent with the new pattern.

zetaclient/chains/bitcoin/observer/mempool_test.go (1)

17-17: LGTM! Test now uses centralized zrepo error variable.

The addition of the zrepo import and the update to use zrepo.ErrClientGetPendingNonces.Error() for the expected error aligns with the repository-wide migration to standardized error handling via ZetaRepo.

Also applies to: 203-203

zetaclient/chains/ton/observer/observer_test.go (1)

23-23: LGTM! TON observer tests now use zrepo-based dependency injection.

The addition of zrepo and grpc imports, the update to base.NewObserver to accept a zrepo-wrapped repository, and the use of grpc status errors in mocks all align with the repository-wide migration to ZetaRepo and standardized error handling.

Also applies to: 30-31, 88-88, 190-191

zetaclient/chains/evm/observer/observer_gas.go (1)

37-39: LGTM! Gas price posting migrated to ZetaRepo.

The change from ZetacoreClient().PostVoteGasPrice to ZetaRepo().VoteGasPrice with a local logger is correct and aligns with the repository-wide refactor. The simplified error handling (returning raw error) is also consistent with the new pattern.

zetaclient/chains/ton/observer/observer.go (1)

20-20: LGTM! Observer now uses TON-specific repository.

The change from a direct Zetacore client field to a tonRepo *repo.TONRepo field aligns with the repository-wide refactor to use repository-based dependencies for chain-specific operations.

zetaclient/chains/bitcoin/observer/outbound_test.go (1)

11-11: LGTM! Bitcoin observer test now uses zrepo-based dependency injection.

The addition of the zrepo import and the update to base.NewObserver to use zrepo.New(nil, chain, mode.StandardMode) align with the repository-wide migration to ZetaRepo-based dependency injection.

Also applies to: 41-42

zetaclient/chains/solana/observer/observer_gas.go (1)

58-60: LGTM! Solana gas price posting migrated to ZetaRepo.

The change from ZetacoreClient().PostVoteGasPrice to ZetaRepo().VoteGasPrice with a local logger is correct and aligns with the repository-wide refactor. The simplified error handling (returning raw error) is also consistent with the new pattern.

zetaclient/chains/evm/signer/signer_test.go (2)

154-161: LGTM!

The test correctly adapts to the new repository pattern by wrapping the mock client with zrepo.New and passing it to TryProcessOutbound. The changes are consistent with the broader refactoring effort.

---

195-195: LGTM!

The inline construction of zrepo.New(...) for BroadcastOutbound correctly follows the new signature pattern.

zetaclient/chains/bitcoin/observer/observer_test.go (3)

47-47: Modern Go syntax usage noted.

The use of for i := range 2 is idiomatic in Go 1.22+. This is good practice.

---

148-155: LGTM!

The observer construction correctly wraps the Zetacore client with zrepo.New, aligning with the new base observer signature.

---

329-336: LGTM!

Test suite initialization correctly adopts the repository pattern.

zetaclient/chains/evm/observer/observer_test.go (2)

191-197: LGTM!

The EVM observer test correctly adopts the repository pattern, consistent with changes in other chain observer tests.

---

434-436: LGTM!

Test suite initialization follows the established pattern.

zetaclient/chains/evm/signer/outbound_tracker_reporter.go (2)

68-74: LGTM!

The change from GetCctxByNonce to GetCCTX with updated error handling is consistent with the repository pattern. The use of Send() instead of Msg() for error logging is appropriate when no additional message is needed.

---

87-87: Ensure PostOutboundTracker return values are intentionally discarded
The call to zetaRepo.PostOutboundTracker ignores both the returned zetaHash and error; verify this is intentional and doesn’t impact observability.

zetaclient/chains/solana/solana.go (3)

61-64: Verify that WatchNewBlocks filters by the connected chain.

Consistent with changes in other chain modules, ensure the ZetaRepo implementation returns blocks only for the Solana observer's connected chain.

---

150-153: Verify that GetPendingCCTXs filters by the connected chain.

The method no longer receives a chain parameter. Ensure it filters pending CCTXs appropriately based on the ZetaRepo's connectedChain field.

---

211-211: LGTM!

The signer correctly receives ZetaRepo() instead of the raw Zetacore client, aligning with the repository pattern migration.

zetaclient/chains/bitcoin/bitcoin.go (2)

144-147: No action required: GetPendingCCTXs already filters by the observer’s connected chain.

---

50-53: Limit WatchNewBlocks to the configured chain
WatchNewBlocks delegates straight to client.NewBlockSubscriber without using repo.connectedChain; confirm the ZetacoreClient passed into ZetaRepo is instantiated per chain (so subscriptions are scoped correctly) or add filtering by repo.connectedChain.

zetaclient/chains/base/confirmation.go (1)

77-80: GetForeignCoinsFromAsset handles hex string conversion internally. No further changes required.

zetaclient/chains/solana/observer/inbound_tracker.go (1)

15-18: GetInboundTrackers correctly filters by connected chain
Verified it delegates to client.GetInboundTrackersForChain(ctx, repo.connectedChain.ChainId), ensuring only the connected chain’s trackers are returned.

zetaclient/chains/ton/observer/gas.go (1)

18-22: LGTM! Repository migration properly handled.

The migration from ZetacoreClient().PostVoteGasPrice to ZetaRepo().VoteGasPrice is correct. The new signature accepts a logger parameter, which aligns with the standardized logging pattern introduced across the codebase. The simplified error handling (direct return without wrapping) is appropriate here, as the error from VoteGasPrice should already contain sufficient context.

zetaclient/chains/ton/signer/signer.go (2)

58-68: LGTM! TryProcessOutbound properly refactored to use ZetaRepo.

The method signature correctly accepts zetaRepo *zrepo.ZetaRepo and propagates it to processOutbound. This aligns with the PR's objective to migrate from direct ZetacoreClient usage to repository-based access patterns.

---

90-95: LGTM! processOutbound signature updated consistently.

The processOutbound method signature correctly accepts zetaRepo *zrepo.ZetaRepo and uses it downstream in the trackOutbound call (line 142). The parameter propagation is consistent and correct.

zetaclient/chains/ton/signer/tracker.go (1)

72-73: LGTM! Outbound tracker posting migrated to ZetaRepo.

The call to zetaRepo.PostOutboundTracker correctly passes the logger and returns the error directly. Ignoring the first return value with _ is appropriate if the tracker response is not needed here. The simplified error handling (direct return) is acceptable assuming PostOutboundTracker provides adequate error context.

zetaclient/chains/ton/observer/inbound.go (3)

279-291: LGTM! Inbound voting flow properly migrated to ZetaRepo.

The changes correctly:

1. Fetch operatorAddress, senderChain, and zetaChain from ZetaRepo (lines 279-281).
2. Pass explicit parameters to intoVoteMessage instead of a client (line 283).
3. Call VoteInbound via ZetaRepo with a logger (line 285).
4. Use simplified error handling with direct return (line 287).

The migration is consistent with the repository pattern introduced across the codebase.

---

375-414: LGTM! intoVoteMessage signature refactored correctly.

The function signature change from accepting a ZetacoreClient to accepting explicit operatorAddress (string) and zetaChain (int64) parameters is appropriate. This decouples the message construction from client dependencies and makes the function more testable. The implementation correctly uses the provided parameters.

---

168-171: No changes needed for GetInboundTrackers error handling.

ZetaRepo.GetInboundTrackers wraps client errors with ErrClientGetInboundTrackers, so returning the error directly here preserves sufficient context.

zetaclient/chains/bitcoin/signer/signer.go (1)

214-214: LGTM! PostOutboundTracker correctly migrated to ZetaRepo.

The call to PostOutboundTracker via ZetaRepo is correct. Ignoring both return values with _, _ is appropriate for this fire-and-forget operation, as indicated by the comment above. The logger is passed as a parameter, consistent with the new repository pattern.

zetaclient/chains/evm/evm.go (1)

58-61: Add context to repo-call errors and verify block watcher cleanup

• Wrap all repo calls in evm.go (WatchNewBlocks, GetPendingCCTXs, GetOutboundTrackers) using errors.Wrap for actionable error context. For example:

- newBlockChan, err := e.observer.ZetaRepo().WatchNewBlocks(ctx)
- if err != nil {
-     return err
- }
+ newBlockChan, err := e.observer.ZetaRepo().WatchNewBlocks(ctx)
+ if err != nil {
+     return errors.Wrap(err, "watch new blocks")
+ }

• Inspect ZetaRepo.WatchNewBlocks (calls client.NewBlockSubscriber) to ensure its channel is closed when ctx is canceled, avoiding potential goroutine/channel leaks.

zetaclient/chains/zrepo/zrepo_test.go (3)

25-95: Dry-mode tests are well-structured.

The test suite properly verifies that dry-mode operations are no-ops with appropriate logging. The pattern is consistent across all four scenarios (PostOutboundTracker, VoteGasPrice, VoteInbound, VoteOutbound).

---

97-194: Comprehensive VoteInbound test coverage.

The test scenarios thoroughly exercise the VoteInbound logic including success paths, edge cases (already voted, invalid message length), and state validation (CCTX exists without ballot, finalized ballot). Mock expectations and assertions are properly structured.

---

200-338: Auxiliary function tests are thorough.

The TestCheckCode and TestExists functions use effective table-driven test patterns. The coverage includes both success and error paths, with proper error chain validation using require.ErrorIs.

zetaclient/chains/evm/observer/v2_inbound.go (4)

106-111: Approve ZetaRepo migration in observeGatewayDeposit.

The changes correctly migrate to ZetaRepo-based voting with appropriate error handling. The constant retryGasLimit improves code clarity.

---

169-176: Approve ZetaRepo accessor usage.

The operator address and chain ID are correctly sourced from ZetaRepo, aligning with the refactored repository pattern.

---

229-232: Consistent ZetaRepo migration across inbound flows.

The refactoring pattern is uniformly applied across observeGatewayCall and observeGatewayDepositAndCall, maintaining consistency with observeGatewayDeposit.

Also applies to: 339-343

---

280-300: Approve newCallInboundVote and newDepositAndCallInboundVote updates.

Both functions correctly migrate to ZetaRepo accessors for operator address (lines 280, 396) and chain ID (lines 285, 401).

zetaclient/chains/solana/observer/outbound.go (3)

51-69: Approve ProcessOutboundTrackers refactoring.

The migration to ZetaRepo-based tracker and CCTX retrieval is correct. The removal of chainID parameters aligns with the repository pattern where the connected chain is implicit.

---

182-182: Verify intentional error suppression.

Line 182 ignores all return values from VoteOutbound, including potential errors. While this may align with Solana's outbound flow characteristics, ensure that error suppression is intentional and documented.

Please confirm that ignoring VoteOutbound errors is the intended behavior for Solana outbound voting. If errors should be handled, consider:

-_, _, _ = ob.ZetaRepo().VoteOutbound(ctx, logger, gasLimit, retryGasLimit, msg)
+if _, _, err := ob.ZetaRepo().VoteOutbound(ctx, logger, gasLimit, retryGasLimit, msg); err != nil {
+    logger.Warn().Err(err).Msg("failed to vote outbound")
+}

---

204-207: Approve operator address migration.

The operator address is correctly sourced from ZetaRepo and passed as a string to the MsgVoteOutbound constructor, aligning with the expected signature.

zetaclient/chains/evm/signer/signer.go (4)

265-273: Approve operator address and logging updates.

The operator address is correctly sourced from ZetaRepo (line 265). The logging field change from Stringer("signer", myID) to Str("signer", myID) (line 272) is appropriate given that GetOperatorAddress() returns a string.

---

337-406: Approve SignOutboundFromCCTX refactoring.

The zetaRepo parameter is correctly threaded through the function and used for chain ID comparisons (lines 369, 381). The overall signing logic remains intact while migrating to the repository pattern.

---

409-495: Approve BroadcastOutbound migration.

The zetaRepo parameter is correctly used for outbound tracker reporting (lines 468, 475), maintaining the broadcast flow while migrating to the repository pattern.

---

499-505: Approve IsPendingOutboundFromZetaChain refactoring.

The function correctly uses zetaRepo for chain ID comparison (line 503), replacing the previous client-based accessor with the repository pattern.

zetaclient/chains/evm/observer/inbound.go (4)

39-42: Approve ProcessInboundTrackers refactoring.

The inbound tracker retrieval correctly uses ZetaRepo (line 39) with simplified error handling, consistent with the repository pattern.

---

335-338: Approve vote posting refactoring.

The observeZetaSent and observeERC20Deposited functions correctly use ZetaRepo.VoteInbound with appropriate gas limits and simplified error handling.

Also applies to: 417-421

---

500-501: Approve checkAndVoteInboundToken refactoring.*

All three token-type-specific voting functions correctly migrate to ZetaRepo.VoteInbound with appropriate gas limits (MessagePassingExecutionGasLimit for Zeta, ExecutionGasLimit for ERC20 and Gas).

Also applies to: 557-558, 599-600

---

653-661: Approve message construction refactoring.

All inbound vote message construction functions correctly source chain ID and operator address from ZetaRepo, maintaining consistency across different inbound types (Deposited, ZetaSent, TokenSentToTSS).

Also applies to: 725-725, 774-774, 782-782

zetaclient/chains/zrepo/zrepo.go (7)

27-40: LGTM!

The addition of the clientMode field and the corresponding constructor parameter enables dry-mode functionality. The field name change to ZetacoreClientRepo aligns with the new interface segregation.

---

46-100: LGTM!

The getter methods follow a consistent error-wrapping pattern and provide clear context in error messages. The TODO comment on line 91 regarding moving GetBTCTSSAddress to a TSS repository is noted for future refactoring.

---

106-154: LGTM!

The PostOutboundTracker and VoteGasPrice methods correctly implement dry-mode guards, error wrapping, and logging. The logic is straightforward and consistent.

---

224-252: LGTM!

The VoteOutbound method correctly implements dry-mode guards, error wrapping, and logging. The logic is sound and consistent with other voting methods.

---

258-265: LGTM!

The WatchNewBlocks method is a straightforward wrapper with consistent error handling.

---

267-279: LGTM!

The GetKeysAddress and GetOperatorAddress methods are simple accessors. The TODO comments on lines 267 and 276 note that these functions may be out of place, which is acknowledged for future refactoring.

---

298-344: LGTM!

The auxiliary functions checkCode, exists, cctxExists, and ballotExists are well-structured and handle GRPC error codes correctly. The defensive res != nil check on line 333 is reasonable given the possibility of unexpected return values from the underlying client methods.

zetaclient/chains/zrepo/client.go (4)

1-21: LGTM!

The addition of the zetacore package import and the compile-time assertion on line 20 ensures that zetacore.Client correctly implements the ZetacoreClient interface, catching any interface mismatches at compile time.

---

25-63: LGTM!

The ZetacoreWriter interface is well-defined and clearly documents the mutation methods for ZetaChain state.

---

65-94: LGTM!

The ZetacoreClientRepo interface is comprehensive and aligns with the repository pattern, composing ZetacoreWriter with query methods used by ZetaRepo.

---

96-132: LGTM!

The ZetacoreClient interface is comprehensive, composing ZetacoreClientRepo with broader query methods. The TODO comment on lines 97-98 notes that this interface should eventually be moved elsewhere, which is acknowledged for future refactoring.

[lumtis]

@renan061 please attach the related issues to the PR when it get open for reviews

[lumtis]

We should be able to use Solana again, rerunning CI

[lumtis]

It looks good to me, just a few minor comments.

Would be great to address the lint issues as well.

[ws4charlie]

PR looks great