[Regression] zig fetch fails to unpack tarball

[linusg]

Zig Version

0.12.0-dev.3074+ae7f3fc36

Steps to Reproduce and Observed Behavior

This works for me with 0.12.0-dev.3033+031f23117 (my local install) but started failing on a newer version (0.12.0-dev.3074+ae7f3fc36, observed via unpinned zig in a CI pipeline):

$ zig fetch https://github.com/mitchellh/zig-build-macos-sdk/archive/ee70f27c08680307fa35ada92e6b2c36e0ff84c6.tar.gz
error: unable to unpack tarball
    note: unable to create symlink from 'Frameworks/AppKit.framework/AppKit.tbd' to 'Versions/Current/AppKit.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/ApplicationServices.framework/ApplicationServices.tbd' to 'Versions/Current/ApplicationServices.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/ATS.tbd' to 'Versions/Current/ATS.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATSUI.framework/ATSUI.tbd' to 'Versions/Current/ATSUI.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/ColorSyncLegacy.tbd' to 'Versions/Current/ColorSyncLegacy.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/HIServices.tbd' to 'Versions/Current/HIServices.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/AudioToolbox.framework/AudioToolbox.tbd' to 'Versions/Current/AudioToolbox.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/AudioUnit.framework/AudioUnit.tbd' to 'Versions/Current/AudioUnit.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CFNetwork.framework/CFNetwork.tbd' to 'Versions/Current/CFNetwork.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Carbon.tbd' to 'Versions/Current/Carbon.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/CommonPanels.tbd' to 'Versions/Current/CommonPanels.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/HIToolbox.tbd' to 'Versions/Current/HIToolbox.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Ink.tbd' to 'Versions/Current/Ink.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/CloudKit.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/Cocoa.framework/Cocoa.tbd' to 'Versions/Current/Cocoa.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/ColorSync.framework/ColorSync.tbd' to 'Versions/Current/ColorSync.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreAudio.framework/CoreAudio.tbd' to 'Versions/Current/CoreAudio.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreAudioTypes.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreData.framework/CoreData.tbd' to 'Versions/Current/CoreData.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreFoundation.framework/CoreFoundation.tbd' to 'Versions/Current/CoreFoundation.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreGraphics.framework/CoreGraphics.tbd' to 'Versions/Current/CoreGraphics.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreImage.framework/CoreImage.metallib' to 'Versions/Current/CoreImage.metallib': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreLocation.framework/CoreLocation.tbd' to 'Versions/Current/CoreLocation.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/CoreServices.tbd' to 'Versions/Current/CoreServices.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/AE.tbd' to 'Versions/Current/AE.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/CarbonCore.tbd' to 'Versions/Current/CarbonCore.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/DictionaryServices.tbd' to 'Versions/Current/DictionaryServices.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/FSEvents.tbd' to 'Versions/Current/FSEvents.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreText.framework/CoreText.tbd' to 'Versions/Current/CoreText.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/CoreVideo.framework/CoreVideo.tbd' to 'Versions/Current/CoreVideo.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/DiskArbitration.framework/DiskArbitration.tbd' to 'Versions/Current/DiskArbitration.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/Foundation.framework/Foundation.tbd' to 'Versions/Current/Foundation.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/GameController.framework/GameController.tbd' to 'Versions/Current/GameController.tbd': FileNotFound
    note: unable to create symlink from 'Frameworks/IOKit.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/IOSurface.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/ImageIO.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/Metal.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/OpenGL.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/QuartzCore.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/Security.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'Frameworks/Symbols.framework/Headers' to 'Versions/Current/Headers': FileNotFound
    note: unable to create symlink from 'include/libxml2/libxml' to '../libxml': FileNotFound
    note: unable to create symlink from 'include/readline/history.h' to '../editline/readline.h': FileNotFound
    note: unable to create symlink from 'include/servers/bootstrap.h' to '../bootstrap.h': FileNotFound

Expected Behavior

$ zig fetch https://github.com/mitchellh/zig-build-macos-sdk/archive/ee70f27c08680307fa35ada92e6b2c36e0ff84c6.tar.gz
1220b415f529f1c04ed876c2b481e9f8119d353d4e3d4d7c8607ee302d2142e13eca

[linusg]

The primary commit that stands out between those two revisions is 4e2570b, unfortunately I don't have a local compiler build for bisecting (cc @jacobly0)

[jacobly0]

Not sure what http changes would have to do with unpacking errors when this change happened: 😄

65e5c46d6122120b2837c8c74c43801f78aaf60f is the first bad commit
commit 65e5c46d6122120b2837c8c74c43801f78aaf60f
Author: Igor Anić <igor.anic@gmail.com>
Date:   Mon Feb 26 00:24:23 2024 +0100

    std.tar fix refactored function
    
    It was not returning error in all cases. Bug in refactoring.

 lib/std/tar.zig | 1 +
 1 file changed, 1 insertion(+)

cc @ianic

[linusg]

Thanks! Looks like createDirAndSymlink needs a return in the nested if statement much like createDirAndFile, otherwise it returns the error unconditionally.

[ianic]

O, how stupid. Sorry guys.