std.tar: fix unconditional error return#19126
Merged
andrewrk merged 2 commits intoziglang:masterfrom Feb 29, 2024
Merged
Conversation
jacobly0
approved these changes
Feb 29, 2024
Member
jacobly0
left a comment
jacobly0
left a comment
There was a problem hiding this comment.
Thanks for following through with a fix!
Just to pass ci of regression fix ziglang#19126. I'll return to this later. Currently can't reproduce on my Windows wm, here I'm failing on symlink creation in ci fails later in the process.
auto-merge was automatically disabled
February 29, 2024 07:01
Head branch was pushed to by a user without write access
Member
|
I can reproduce the Windows failure, and it is unrelated to tar. Windows symlink creation currently mishandles test "symlink target with /" {
var tmp = std.testing.tmpDir(.{});
defer tmp.cleanup();
try tmp.dir.symLink("../file", "symlink", .{});
_ = try tmp.dir.statFile("symlink");
}Will have a fix shortly. This can be merged in the meantime. |
Member
|
I'll merge since @squeek502 is on it. But note that standard process is to open an issue to track the disabled test, then link to the issue in the code that disables the test. |
RossComputerGuy
pushed a commit
to ExpidusOS-archive/zig
that referenced
this pull request
Mar 20, 2024
Just to pass ci of regression fix ziglang#19126. I'll return to this later. Currently can't reproduce on my Windows wm, here I'm failing on symlink creation in ci fails later in the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression made by previous PR #19081
Fixes #19124