ast-gen: use correct token_src for switch, if and while exprs#18582
Merged
Vexu merged 2 commits intoziglang:masterfrom Jan 16, 2024
Merged
ast-gen: use correct token_src for switch, if and while exprs#18582Vexu merged 2 commits intoziglang:masterfrom
Vexu merged 2 commits intoziglang:masterfrom
Conversation
6b17f2f to
bf21417
Compare
Contributor
Author
|
I added back in this line per suggestion by @Techatrix. I believe this applies to const e: error{A}!u32 = error.A;
if (e) |*ptr| {...} else |err| switch (err) {...}
// ^ previous range
// ^^^ current rangeEDIT |
Contributor
Author
|
I think I'm missing some compile error tests. Correct me if I'm wrong, but I think they should go in test/cases/compile_errors. I'm working on adding them now. |
Contributor
Author
|
I've added the compile error tests. Not sure about this stuff: // error
// backend=stage2
// target=native
//I copied that from another file in that directory and they pass locally running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #18579
i've verified that after this change, the following error ranges are correct and point at the identifiers instead of the asterisks