fix compile error on the std.c.EXC.MASK field on darwin#21273
Merged
alexrp merged 7 commits intoziglang:masterfrom Jan 26, 2025
Merged
fix compile error on the std.c.EXC.MASK field on darwin#21273alexrp merged 7 commits intoziglang:masterfrom
std.c.EXC.MASK field on darwin#21273alexrp merged 7 commits intoziglang:masterfrom
Conversation
std.c.EXC.MASK field on darwinstd.c.EXC.MASK field on darwin
Contributor
I would use Reference: https://github.com/apple-oss-distributions/xnu/blob/main/osfmk/mach/exception_types.h#L207 |
Contributor
Author
In that case, why not use |
Contributor
|
|
Contributor
Author
|
Interesting. I wonder why that decision was taken. |
alexrp
approved these changes
Jan 26, 2025
Fri3dNstuff
pushed a commit
to Fri3dNstuff/zig
that referenced
this pull request
Jan 27, 2025
Fri3dNstuff
pushed a commit
to Fri3dNstuff/zig
that referenced
this pull request
Jan 27, 2025
Turns out this was already fixed in ziglang#21964. I have no idea why GitHub showed an incorrect diff in ziglang#21273, or how applying the diff to master was even possible, but here we are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backing integer for the
MASKstruct is au32, but the bool fields sum up to au13.I've added 19 bits of padding.
Alternatively, we could add3bits of padding and make it au16backed packed struct?EDIT: Looks using
std.c.darwing.exception_mask_twould be a better idea here.Is there a reason why the std library doesn't use C types in these places?
Reference: #21094
P.S: Should we consider having a
testblock for this just to see if it compiles? Something like: