Fix std.c.EXC.MASK struct to match definition in mach/exception_types.h#21964
Merged
alexrp merged 2 commits intoziglang:masterfrom Nov 13, 2024
Merged
Fix std.c.EXC.MASK struct to match definition in mach/exception_types.h#21964alexrp merged 2 commits intoziglang:masterfrom
alexrp merged 2 commits intoziglang:masterfrom
Conversation
alexrp
requested changes
Nov 12, 2024
Co-authored-by: Alex Rønne Petersen <alex@alexrp.com>
alexrp
approved these changes
Nov 12, 2024
Fri3dNstuff
pushed a commit
to Fri3dNstuff/zig
that referenced
this pull request
Jan 27, 2025
Turns out this was already fixed in ziglang#21964. I have no idea why GitHub showed an incorrect diff in ziglang#21273, or how applying the diff to master was even possible, but here we are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes two issues:
std.c.EXC.MASKhad the mask flags starting at bit 0, but the header it's copying has this:Obviously the mask isn't used anywhere is zig, because it would've caused a packed structure padding compile error. On the chance that it is used in the future, either by the compiler, or as an api provided by std, I figured I'd save future poor souls from mysterious bugs caused by the mask flags bits being off by one bit.