Skip to content

Fix compiler errors in std.process and std.Build.Step.Compile#22511

Merged
andrewrk merged 2 commits intoziglang:masterfrom
apwadkar:master
Jan 21, 2025
Merged

Fix compiler errors in std.process and std.Build.Step.Compile#22511
andrewrk merged 2 commits intoziglang:masterfrom
apwadkar:master

Conversation

@apwadkar
Copy link
Contributor

Fixes

_ = &std.process.changeCurDirC;
_ = &std.Build.Step.Compile.dependsOnSystemLibrary;

from #20505.

Looks like chdirC was renamed chdirZ but that wasn't reflected in the std.process alias. I'm not sure if this alias is even needed, I couldn't find any references to changeCurDir in std.

For dependsOnSystemLibrary, it looks like because of the way it finds dependency libraries, compile can't be a *const Compile. And since Module::link_libc returns a ?bool with null meaning "doesn't matter", I used best judgement and assigned it to false based on how is_linking_libc is being used.

@andrewrk andrewrk merged commit 0d6b17b into ziglang:master Jan 21, 2025
10 checks passed
@andrewrk
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants