Skip to content

Fix compiler errors in std.process and std.Build.Step.Compile #22511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewrk merged 2 commits into from
Jan 21, 2025
Merged

Fix compiler errors in std.process and std.Build.Step.Compile #22511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5a2487
Fix chdirC compile error
apwadkar Jan 17, 2025
23facb6
Fix dependsOnSystemLibrary compile error
apwadkar Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/std/Build/Step/Compile.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ pub fn forceUndefinedSymbol(compile: *Compile, symbol_name: []const u8) void {

/// Returns whether the library, executable, or object depends on a particular system library.
/// Includes transitive dependencies.
pub fn dependsOnSystemLibrary(compile: *const Compile, name: []const u8) bool {
pub fn dependsOnSystemLibrary(compile: *Compile, name: []const u8) bool {
var is_linking_libc = false;
var is_linking_libcpp = false;

Expand All @@ -613,8 +613,8 @@ pub fn dependsOnSystemLibrary(compile: *const Compile, name: []const u8) bool {
else => {},
}
}
if (mod.link_libc) is_linking_libc = true;
if (mod.link_libcpp) is_linking_libcpp = true;
if (mod.link_libc orelse false) is_linking_libc = true;
if (mod.link_libcpp orelse false) is_linking_libcpp = true;
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/std/process.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pub const Child = @import("process/Child.zig");
pub const abort = posix.abort;
pub const exit = posix.exit;
pub const changeCurDir = posix.chdir;
pub const changeCurDirC = posix.chdirC;
pub const changeCurDirZ = posix.chdirZ;

pub const GetCwdError = posix.GetCwdError;

Expand Down
Loading