std.Build: Demote errors for exceeding max_rss to warnings.#23525
std.Build: Demote errors for exceeding max_rss to warnings.#23525alexrp merged 2 commits intoziglang:masterfrom
std.Build: Demote errors for exceeding max_rss to warnings.#23525Conversation
andrewrk
left a comment
There was a problem hiding this comment.
Please do not add a ci option to the build script. The CI is there to make sure things work, with no exceptions or affordances made for it.
If someone is experiencing the max rss being incorrect, then we need to troubleshoot why sometimes the peak memory usage is much higher than expected. Or we need to decide that it is in fact expected and bump the max rss. Or perhaps we learn that it is target-dependent and decide that is acceptable.
|
Just to make sure I understand where you're at: In your view, what is the purpose of setting On the other hand, I don't see any clear value in enforcing Obviously we can just bump the values when users complain, but in my view, that isn't actually serving users well. Being greeted with a failed build due to a I think |
|
One more factor that you might not be aware of is that the max rss value is used by the build runner when scheduling tasks, to avoid running too many tasks at the same time that use a lot of memory. This avoids triggering OOM when using So this change would cause |
|
That's a fair concern, but I think What do you think about an |
This reverts commit 9356cb1. #20514 (comment)
max_rss options in CIstd.Build: Demote errors for exceeding max_rss to warnings.
|
cc @Jan200101 @xtexx |
Upstream changed behavior so that the "max_rss" field in one line of their build.zig is now required: ziglang/zig#25402 Drop the command removing it, as it is no longer needed. "max_rss" errors were downgraded to warnings in: ziglang/zig#23525 Upstream suggestion: ziglang/zig#25659 Closes: https://bugs.gentoo.org/964953 Signed-off-by: Eric Joldasov <bratishkaerik@landless-city.net>
We have no control over memory usage on arbitrary systems in the wild. But we would still like to get the warnings so we can adjust the values based on observations in the official ZSF CI.
Closes #23254.
Closes #23638.