Add tests for using directory operations on files#5684
Merged
andrewrk merged 2 commits intoziglang:masterfrom Jun 25, 2020
Merged
Add tests for using directory operations on files#5684andrewrk merged 2 commits intoziglang:masterfrom
andrewrk merged 2 commits intoziglang:masterfrom
Conversation
daurnimator
added
os-windows
kubkon
approved these changes
Jun 24, 2020
Member
kubkon
left a comment
kubkon
left a comment
There was a problem hiding this comment.
LGTM! As far as WASI is concerned, I think you've nailed it. tmpDir is the way to go which wraps either cwd or PreopenList depending if it's non-WASI or WASI host.
| testing.expectError(error.NotDir, tmp_dir.dir.deleteDir(test_file_name)); | ||
|
|
||
| if (builtin.os.tag != .wasi) { | ||
| // TODO: use Dir's realpath function once that exists |
Member
There was a problem hiding this comment.
Perhaps #5701 could be of use here (not necessarily saying to wait on it to land, just an FYI)
Now correctly returns error.NotDir
squeek502
force-pushed
the
fs-file-dir-ops
branch
from
3b9fe7c to
dcdbb70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes
fs.Dir.openDiron Windows when called with a path to a file. Contributes towards #5653cc @kubkon to make sure this would work for WASI (I'm unsure of how to test WASI).