Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

fix: zks_l1_chain_id not returning int type#67

Merged
petarTxFusion merged 1 commit intozksync-sdk:masterfrom
comilao:fix/zks-l1-chain-id-not-returning-int
Apr 24, 2024
Merged

fix: zks_l1_chain_id not returning int type#67
petarTxFusion merged 1 commit intozksync-sdk:masterfrom
comilao:fix/zks-l1-chain-id-not-returning-int

Conversation

@comilao
Copy link
Contributor

@comilao comilao commented Apr 24, 2024

What 💻

zks_l1_chain_id is not returning int, it's returning the hex string

Why ✋

  • Reason why first thing was added to PR
  • Reason why second thing was added to PR
  • Reason why third thing was added to PR

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes 📝

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@comilao comilao requested a review from a team April 24, 2024 13:48
@petarTxFusion petarTxFusion merged commit 0ebd1b8 into zksync-sdk:master Apr 24, 2024
@comilao comilao deleted the fix/zks-l1-chain-id-not-returning-int branch April 25, 2024 14:22
@github-actions
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants