Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

fix: zks_l1_chain_id not returning int type #67

Merged
petarTxFusion merged 1 commit into from
Apr 24, 2024
Merged

fix: zks_l1_chain_id not returning int type #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration/test_zksync_web3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ def test_get_all_account_balances(self):

# @skip("Integration test, used for develop purposes only")
def test_get_l1_chain_id(self):
l1_chain_id = self.web3.zksync.zks_l1_chain_id()
self.assertIsInstance(self.web3.zksync.zks_l1_chain_id(), int)

# @skip("Integration test, used for develop purposes only")
def test_get_bridge_addresses(self):
Expand Down
2 changes: 1 addition & 1 deletion zksync2/module/zksync_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ def zks_get_token_price(self, token_address: TokenAddress) -> Decimal:
return self._zks_get_token_price(token_address)

def zks_l1_chain_id(self) -> int:
return self._zks_l1_chain_id()
return int(self._zks_l1_chain_id(), 16)

def zks_get_balance(
self,
Expand Down