refactor: add comments to just addnoun and tweak logic

[hippietrail]

Addresses ccoVeille's concerns

[ccoVeille]

Suggested change

	# 'S', plural -(e)s suffix only for common nouns (not capitalized)
	if [[ "{{noun}}" =~ ^[a-z] ]]; then
	flags+='S'
	fi
	# detect nouns (not capitalized)
	if [[ "{{noun}}" =~ ^[a-z] ]]; then
	# 'S', plural -(e)s suffix
	flags+='S'
	fi

Maybe something like this. You can rephrase of course, but you get the point I think

[elijah-potter]

I'm not sure how to resolve these conflicts. Mind taking a look @hippietrail?

[hippietrail]

I'm not sure how to resolve these conflicts. Mind taking a look @hippietrail?

Sorry it's 1.30am here and git/github are confusing me. I don't understand why there's a conflict. Shouldn't my change just replace the old code like usual in PRs or is there a change from ccoVeille there too and not just a comment? My local copy of this feature branch has

  # 'M', possessive -'s suffix for both common and proper nouns
  flags='M'

  # 'S', plural -(e)s suffix only for common nouns (not capitalized)
  if [[ "{{noun}}" =~ ^[a-z] ]]; then
    flags+='S'
  fi

But now I see a bug because the flags should include 1 for common noun and 2 for proper noun.

If I try to push another change while in it's in this state will it become more of a mess or just fix it?

[elijah-potter]

If I try to push another change while in it's in this state will it become more of a mess or just fix it?

It might fix it. Just go ahead and push the change. I'll figure it out from there.

[hippietrail]

If I try to push another change while in it's in this state will it become more of a mess or just fix it?

It might fix it. Just go ahead and push the change. I'll figure it out from there.

I think I'll just update it to fix the bug I spotted and push that... in the morning. OK it's done now with the fix mentioned in my other comment. Should be ready to merge.