Skip to content

[Modules] Added NetworkInterface module#1400

Merged
AlexanderSehr merged 20 commits intomainfrom
users/alsehr/1396_nic
May 19, 2022
Merged

[Modules] Added NetworkInterface module#1400
AlexanderSehr merged 20 commits intomainfrom
users/alsehr/1396_nic

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented May 16, 2022 •
edited
Loading

Description

  • Added deciated Network Interface module

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Build Status

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this May 16, 2022
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label May 16, 2022
@AlexanderSehr AlexanderSehr linked an issue May 16, 2022 that may be closed by this pull request
[Feature Request]: Create Network Interface module #1396
Closed
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) May 16, 2022 15:45
eriqua
eriqua reviewed May 16, 2022
View reviewed changes
eriqua
eriqua reviewed May 16, 2022
View reviewed changes
eriqua
eriqua reviewed May 16, 2022
View reviewed changes
eriqua
eriqua reviewed May 16, 2022
View reviewed changes
AlexanderSehr and others added 2 commits May 16, 2022 23:35
@AlexanderSehr @eriqua
Update .github/workflows/ms.network.networkinterfaces.yml
cf40cc7 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update .github/workflows/ms.network.networkinterfaces.yml
224ed07 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr mentioned this pull request May 17, 2022
Merged
4 tasks
eriqua
eriqua reviewed May 19, 2022
View reviewed changes
eriqua
eriqua reviewed May 19, 2022
View reviewed changes
eriqua
eriqua reviewed May 19, 2022
View reviewed changes
AlexanderSehr and others added 2 commits May 19, 2022 12:47
@AlexanderSehr @eriqua
Update .azuredevops/modulePipelines/ms.network.networkinterfaces.yml
eef85ad 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update arm/Microsoft.Network/networkInterfaces/deploy.bicep
7ac144d 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr mentioned this pull request May 19, 2022
Open
eriqua
eriqua approved these changes May 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit fa28ffe into main May 19, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1396_nic branch May 19, 2022 21:40
@AlexanderSehr AlexanderSehr changed the title [NetworkInterface] Added module [Module] Added NetworkInterface module Jun 17, 2022
@AlexanderSehr AlexanderSehr changed the title [Module] Added NetworkInterface module [Modules] Added NetworkInterface module Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Create Network Interface module

2 participants

@AlexanderSehr @eriqua