Skip to content

Conversation

@johanste
Copy link
Member

No description provided.

johanste added a commit that referenced this pull request Feb 24, 2016
Add Python3 configuration to launch.json + change from tab to two spaces
@johanste johanste merged commit 9168291 into Azure:master Feb 24, 2016
derekbekoe pushed a commit that referenced this pull request Feb 7, 2017
* Add batch data plane commands:

-- Add custom commands
-- Add auto execution data plane codes
-- Import mgmt commands experience

* Added file stream support

* bug fixes

* Fixed regex raw strings

* Added support for JSON input

* Custom and type validation (#4)

* Additional validation and parsing

* Some cleanups

* Minor code refinements

* Fix pylint errors and get rid unused codes.

* List and type validation (#5)

* list and type validation

* Remove auth kwargs

* Fixed typo

* clean pylint error and add data plane command test.

* Bug fixes (#6)

* Remove auth kwargs

* Bug fixes

* Fixed kwargs

* Move the update pool command to custom command.

* Add custom commands test cases

* Tests and delete confirmation (#7)

* Added some tests

* Bug fixes

* Added tests to sln

* Delete confirmation

* Some pylint cleanup

* More tests and fixes (#8)

* Fix pylint and test errors.

* Following PEP8 complaint.

* Use this decroator on doc transfer

* Deferred imports for performance (#9)

* streamlined imports

* pylint fixes

* Renamed AzureDataPlaneCommand

* PyLint and PEP8 clean up.

* Use single parameter for storage account id and name.

* Review feedback + help fixes (#10)

* node-user -> node user

* Review feedback

* More feedback fixes

* pep fixes

* fixed underscore

* More touch ups

* Review fixes (#11)

* Command refinements

* More command feedback

* Test fixes

* More tests

* Add enum list for vmsize and thumbprint algorithm.

* Streamlined commands (#13)

* streamlined commands

* Updated tests

* Fixed arg loading test

* Further command refinements (#14)

* support silent args

* Fixed pool error message

* Further command editing

* last fixes

* Fixed tests (#15)

* Change the coding style.
DaeunYim pushed a commit to DaeunYim/azure-cli that referenced this pull request Sep 10, 2020
Adding local context and test code for new parameters and changes
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
* Fix tests

* No more allow failures

* Allow failures for now
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
* NFSAAS-1708 add initial version of anf cli extension

* NFSAAS-1708 lint fixes

* NFSAAS-1708 code owner

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update with code review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments (Azure#9)

* Nfsaas 1708 initial cli extension (Azure#10)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#11)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#13)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#14)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#16)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#17)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
* NFSAAS-1708 add initial version of anf cli extension

* NFSAAS-1708 lint fixes

* NFSAAS-1708 code owner

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update with code review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments (Azure#9)

* Nfsaas 1708 initial cli extension (Azure#10)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#11)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#13)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#14)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#16)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (Azure#17)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 add anf to cli extension index

* NFSAAS-1708 add anf to cli extension index (Azure#18)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index (Azure#22)

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#23)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#24)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#25)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#26)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (Azure#27)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
* Azure quantum extension v0 (Azure#2)

Initial version.

* Fixing style issues

* Incorporating feedback (Azure#6)

* readme
* feedback

* Help

* Make storage account optional (Azure#7)

* Storage is now optional (Azure#8)

* Making storage an argument, not an env variable (Azure#9)

* Adding implementation of 'az quantum workspace delete' command.

* Setting new temporary version.

* Fixing missing file in test change

* Adding details to README.md (Azure#5)

* Updating generated files for Azure Quantum resource manager from new swagger file version

* Remove manual edit of generated file.

* Updating generated files for Azure Quantum data plane from new swagger file version

* Updating generated files for Azure Quantum resource manager from new swagger file version. (2020-11-06) (Azure#13)

* Adding implementation of 'az quantum workspace create' command. (Azure#14)

Adding initial implementation of 'az quantum workspace create' command.

-----------------------------------
Command
az quantum workspace create : Creates a new Azure Quantum workspace.
Command group 'quantum' is in preview. It may be changed/removed in a future
release.
Arguments
--location -l : Location. Values from: az account list-locations. You can configure
the default location using az configure --defaults location=<location>.
--resource-group -g : Name of resource group. You can configure the default group using az configure --defaults group=<name>.
--storage_account -sa : Name of the storage account to be used by a quantum workspace.
--workspace-name -w : Name of the Quantum Workspace. You can configure the default workspace
using az quantum workspace set.

* Update Azure CLI quantum extension to multi-region (Azure#17)

This change will set the URL for the data plan API accordingly with a location parameter specified as part of the command.

* Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. (Azure#16)

Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr.

* Fixing tests for multi-region URL change on Az CLI quantum extension (Azure#19)

Fixing tests for multi-region URL change on Az CLI quantum extension

* Incorporating ARM feedback  (Azure#18)

* Picking up latest changes from swagger after ARM feedback

* updated create_or_update

* run command

* Setting default location in workspace calls if not specified (Azure#20)

* updating python azure quantum rest client (Azure#21)

* Update generated files from swagger file (Version 2021-01-11) (Azure#22)

* Hot fixes on December 2020 release of Azure CLI extension (Azure#23)

* Fixing issue with over specification of location
* Updating version information of extension

* Update CLI with generated clients from more recent swagger files (Azure#24)

- Data plane updated to official swagger file (2021-01-11 19:01:32 UTC) on azure-rest-api-specs @ 98ae52b87af2f172f84f3305f8fe46f819543a49.

- Resource manager updated to candidate swagger file (2021-01-15 19:35:41 UTC) on anpaz:quantum/resource-manager @ a9a9e271c13500aa54fdbb1bcb656eb61d82d38b.

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Require location as a mandatory parameter in workspace specification (Azure#25)

* Make location mandatory in commands
* Update test recordings

* Resetting the version history for the released version.

* Fix description of workspace clear command

* Updatig Readme file to RST format.

* Update Readme file per pull request comments.

* Fixing az quantum run and execute commands to include location parameter

* Performing role assignment on storage account on workspace creation. (Azure#29)

* Add warning message about providers during workspace creation (Azure#30)

* Enable command az quantum workspace quotas (Azure#31)

* Removing extra space in Readme.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Fix punctuation in Readme.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/azext_quantum/_params.py

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* First round of code review feedback on Readme.rst

* Improve code readability on job commands

* Avoid IndexError in case of malformed URL

* Extended info on targetId parameter

* Add help to each individual command

* Reorganize sections in Readme.rst and merge in a single set of instructions.

* Static analysis fixes

* Fix CLI Linter errors

* Fix CLI Linter errors. Part 2

* Fix typo in show command.

* Fix show command for Linter

* Use standard name for show command method

* Modify workspace create test to skip role assignment

* Update tests with workspace names used currently.

* Update test recordings.

* Set subscription for the recordings.

* Update test recordings.

* Update QDK version number

* Remove asserts and checks for subscription

* Experiment: Remove check for preview subscription

* Refresh recordings with current test values.

* Update recordings after typo fix.

* Remove commented out API that references subscription

* Enable QuantumJobsScenarioTest.test_submit_args only on live mode

Co-authored-by: Ricardo Espinoza <ricardoe@microsoft.com>
Co-authored-by: Feiyue Yu <iamyfy@163.com>
kaibocai added a commit to kaibocai/azure-cli that referenced this pull request Jun 6, 2023
AllyW pushed a commit to AllyW/azure-cli that referenced this pull request Jul 16, 2024
Upload generated models from vm module
sturrent added a commit to sturrent/azure-cli that referenced this pull request Oct 21, 2025
Updated PHASE6-PROGRESS.md with complete Test 1.1 results:

Bug Tracker Updates:
- Added Bug Azure#12: NSGAnalyzer logger parameter inconsistency
- Added Bug Azure#13: Azure CLI logger integration (knack system)
- Added Bug Azure#14: NSG analyzer resource ID parsing failure
- Updated total: 14 bugs found and fixed (100% success rate)

Git Commits Section:
- Documented all 4 Phase 6 commits with details
- Commit fdb423c: Initial 11 bugs fixed
- Commit f19a14a: Documentation created
- Commit 67e64ad: Logger integration fixed
- Commit 2e90460: NSG resource ID parsing fixed

Files Modified Updates:
- Updated to 6 unique files (added base_analyzer.py, dns_analyzer.py)
- Documented line changes: ~141 total modifications
- Added details on logger and NSG parser changes

Test 1.1 Final Status:
- Duration: ~10 seconds (excellent performance)
- Result: PASSED after 14 bug fixes
- Validation: Output matches standalone tool
- NSG findings: sec_close rule detected correctly

Success Criteria Progress:
✅ Critical bugs fixed (14/14)
✅ Output matches standalone tool
✅ Performance excellent (<10s vs 30s target)
✅ Documentation updated

Updated Conclusion:
- Confidence level: 90% (up from 85%)
- All major integration issues resolved
- 7 bug categories documented
- Technical improvements detailed
- Remaining work: 28 tests, 5-8 hours estimated

Next Step: Test 1.2 (--details flag)
sturrent added a commit to sturrent/azure-cli that referenced this pull request Oct 21, 2025
Updated PHASE6-PROGRESS.md with complete Test 1.1 results:

Bug Tracker Updates:
- Added Bug Azure#12: NSGAnalyzer logger parameter inconsistency
- Added Bug Azure#13: Azure CLI logger integration (knack system)
- Added Bug Azure#14: NSG analyzer resource ID parsing failure
- Updated total: 14 bugs found and fixed (100% success rate)

Git Commits Section:
- Documented all 4 Phase 6 commits with details
- Commit fdb423c: Initial 11 bugs fixed
- Commit f19a14a: Documentation created
- Commit 67e64ad: Logger integration fixed
- Commit 2e90460: NSG resource ID parsing fixed

Files Modified Updates:
- Updated to 6 unique files (added base_analyzer.py, dns_analyzer.py)
- Documented line changes: ~141 total modifications
- Added details on logger and NSG parser changes

Test 1.1 Final Status:
- Duration: ~10 seconds (excellent performance)
- Result: PASSED after 14 bug fixes
- Validation: Output matches standalone tool
- NSG findings: sec_close rule detected correctly

Success Criteria Progress:
✅ Critical bugs fixed (14/14)
✅ Output matches standalone tool
✅ Performance excellent (<10s vs 30s target)
✅ Documentation updated

Updated Conclusion:
- Confidence level: 90% (up from 85%)
- All major integration issues resolved
- 7 bug categories documented
- Technical improvements detailed
- Remaining work: 28 tests, 5-8 hours estimated

Next Step: Test 1.2 (--details flag)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant