Refactor session state storage #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@yugangw-msft Here's my updated version of the session state storage |
Contributor
|
@BurtBiel thanks. The change look good, but let us chat to see whether it can incorporate with my commit for account management, because we are updating same file with similar functionalities :-) |
Contributor
Author
|
Yugang also did refactoring work in this file and it doesn't make sense to reset his work for this change. Closing PR |
derekbekoe
pushed a commit
that referenced
this pull request
Feb 7, 2017
* Add batch data plane commands: -- Add custom commands -- Add auto execution data plane codes -- Import mgmt commands experience * Added file stream support * bug fixes * Fixed regex raw strings * Added support for JSON input * Custom and type validation (#4) * Additional validation and parsing * Some cleanups * Minor code refinements * Fix pylint errors and get rid unused codes. * List and type validation (#5) * list and type validation * Remove auth kwargs * Fixed typo * clean pylint error and add data plane command test. * Bug fixes (#6) * Remove auth kwargs * Bug fixes * Fixed kwargs * Move the update pool command to custom command. * Add custom commands test cases * Tests and delete confirmation (#7) * Added some tests * Bug fixes * Added tests to sln * Delete confirmation * Some pylint cleanup * More tests and fixes (#8) * Fix pylint and test errors. * Following PEP8 complaint. * Use this decroator on doc transfer * Deferred imports for performance (#9) * streamlined imports * pylint fixes * Renamed AzureDataPlaneCommand * PyLint and PEP8 clean up. * Use single parameter for storage account id and name. * Review feedback + help fixes (#10) * node-user -> node user * Review feedback * More feedback fixes * pep fixes * fixed underscore * More touch ups * Review fixes (#11) * Command refinements * More command feedback * Test fixes * More tests * Add enum list for vmsize and thumbprint algorithm. * Streamlined commands (#13) * streamlined commands * Updated tests * Fixed arg loading test * Further command refinements (#14) * support silent args * Fixed pool error message * Further command editing * last fixes * Fixed tests (#15) * Change the coding style.
tibortakacs
added a commit
to tibortakacs/azure-cli
that referenced
this pull request
Aug 7, 2020
* Only use credential cache if it is available * Pass tenant id to Identity properly * Use the client id and scopes properly in client factory * Accept single string scope (not a bug but good to have) Co-authored-by: Tibor Takacs <titakac@microsoft.com>
DaeunYim
added a commit
to DaeunYim/azure-cli
that referenced
this pull request
Sep 9, 2020
sterling local context update and more meru test scenarios added
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* Static CI checks - Fix style of image-copy - Add PR template - Add license and codeowner checks - pylint/pep8 * Use build stages correctly
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* NFSAAS-1708 add initial version of anf cli extension * NFSAAS-1708 lint fixes * NFSAAS-1708 code owner * NFSAAS-1708 update from review comments * NFSAAS-1708 update from review comments * NFSAAS-1708 update with code review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments (Azure#9) * Nfsaas 1708 initial cli extension (Azure#10) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#11) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#13) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#14) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#16) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#17) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* NFSAAS-1708 add initial version of anf cli extension * NFSAAS-1708 lint fixes * NFSAAS-1708 code owner * NFSAAS-1708 update from review comments * NFSAAS-1708 update from review comments * NFSAAS-1708 update with code review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments (Azure#9) * Nfsaas 1708 initial cli extension (Azure#10) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#11) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#13) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#14) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#16) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#17) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 add anf to cli extension index * NFSAAS-1708 add anf to cli extension index (Azure#18) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index (Azure#22) Plus correct some help validation errors * Nfsaas 1708 add index (Azure#23) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * Nfsaas 1708 add index (Azure#24) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * Nfsaas 1708 add index (Azure#25) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * Nfsaas 1708 add index (Azure#26) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * Nfsaas 1708 add index (Azure#27) * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors * NFSAAS-1708 add ANF CLI extension to index Plus correct some help validation errors
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* Azure quantum extension v0 (Azure#2) Initial version. * Fixing style issues * Incorporating feedback (Azure#6) * readme * feedback * Help * Make storage account optional (Azure#7) * Storage is now optional (Azure#8) * Making storage an argument, not an env variable (Azure#9) * Adding implementation of 'az quantum workspace delete' command. * Setting new temporary version. * Fixing missing file in test change * Adding details to README.md (Azure#5) * Updating generated files for Azure Quantum resource manager from new swagger file version * Remove manual edit of generated file. * Updating generated files for Azure Quantum data plane from new swagger file version * Updating generated files for Azure Quantum resource manager from new swagger file version. (2020-11-06) (Azure#13) * Adding implementation of 'az quantum workspace create' command. (Azure#14) Adding initial implementation of 'az quantum workspace create' command. ----------------------------------- Command az quantum workspace create : Creates a new Azure Quantum workspace. Command group 'quantum' is in preview. It may be changed/removed in a future release. Arguments --location -l : Location. Values from: az account list-locations. You can configure the default location using az configure --defaults location=<location>. --resource-group -g : Name of resource group. You can configure the default group using az configure --defaults group=<name>. --storage_account -sa : Name of the storage account to be used by a quantum workspace. --workspace-name -w : Name of the Quantum Workspace. You can configure the default workspace using az quantum workspace set. * Update Azure CLI quantum extension to multi-region (Azure#17) This change will set the URL for the data plan API accordingly with a location parameter specified as part of the command. * Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. (Azure#16) Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. * Fixing tests for multi-region URL change on Az CLI quantum extension (Azure#19) Fixing tests for multi-region URL change on Az CLI quantum extension * Incorporating ARM feedback (Azure#18) * Picking up latest changes from swagger after ARM feedback * updated create_or_update * run command * Setting default location in workspace calls if not specified (Azure#20) * updating python azure quantum rest client (Azure#21) * Update generated files from swagger file (Version 2021-01-11) (Azure#22) * Hot fixes on December 2020 release of Azure CLI extension (Azure#23) * Fixing issue with over specification of location * Updating version information of extension * Update CLI with generated clients from more recent swagger files (Azure#24) - Data plane updated to official swagger file (2021-01-11 19:01:32 UTC) on azure-rest-api-specs @ 98ae52b87af2f172f84f3305f8fe46f819543a49. - Resource manager updated to candidate swagger file (2021-01-15 19:35:41 UTC) on anpaz:quantum/resource-manager @ a9a9e271c13500aa54fdbb1bcb656eb61d82d38b. * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <iamyfy@163.com> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <iamyfy@163.com> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <iamyfy@163.com> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <iamyfy@163.com> * Require location as a mandatory parameter in workspace specification (Azure#25) * Make location mandatory in commands * Update test recordings * Resetting the version history for the released version. * Fix description of workspace clear command * Updatig Readme file to RST format. * Update Readme file per pull request comments. * Fixing az quantum run and execute commands to include location parameter * Performing role assignment on storage account on workspace creation. (Azure#29) * Add warning message about providers during workspace creation (Azure#30) * Enable command az quantum workspace quotas (Azure#31) * Removing extra space in Readme.rst Co-authored-by: Feiyue Yu <iamyfy@163.com> * Fix punctuation in Readme.rst Co-authored-by: Feiyue Yu <iamyfy@163.com> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <iamyfy@163.com> * Update src/quantum/azext_quantum/_params.py Co-authored-by: Feiyue Yu <iamyfy@163.com> * First round of code review feedback on Readme.rst * Improve code readability on job commands * Avoid IndexError in case of malformed URL * Extended info on targetId parameter * Add help to each individual command * Reorganize sections in Readme.rst and merge in a single set of instructions. * Static analysis fixes * Fix CLI Linter errors * Fix CLI Linter errors. Part 2 * Fix typo in show command. * Fix show command for Linter * Use standard name for show command method * Modify workspace create test to skip role assignment * Update tests with workspace names used currently. * Update test recordings. * Set subscription for the recordings. * Update test recordings. * Update QDK version number * Remove asserts and checks for subscription * Experiment: Remove check for preview subscription * Refresh recordings with current test values. * Update recordings after typo fix. * Remove commented out API that references subscription * Enable QuantumJobsScenarioTest.test_submit_args only on live mode Co-authored-by: Ricardo Espinoza <ricardoe@microsoft.com> Co-authored-by: Feiyue Yu <iamyfy@163.com>
Closed
ReaNAiveD
pushed a commit
to ReaNAiveD/azure-cli
that referenced
this pull request
Nov 17, 2023
…mentdb [Add] Add command group `microsoft.documentdb/databaseaccounts`
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Nov 6, 2025
- Created demo-docs directory for demo materials - Moved DEMO-SCENARIOS.md, DEMO-SUMMARY.md, and COVERAGE-MATRIX.md - Added Gap Azure#9: AKS LocalDNS preview feature (not tested) - Updated all internal documentation links - Corrected probe test behavior (runs on node OS, not pods) - Added API Server VNet Integration gap to coverage matrices - Updated DNS Analysis completeness (100% -> 95%) Total identified gaps: 9 - High priority: Azure CNI Overlay NSG, Non-VMSS support, Network Isolated Clusters, BYO Private DNS, API VNet Integration - Medium priority: LocalDNS, Node Pool Display - Low priority: User-Assigned NAT Gateway, Cross-Subscription BYO VNet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed profile class in favor of methods, updated commands to reference new format