Skip to content

{Core} Directly call acquire_token_for_client to acquire access token for service principal #27002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Nov 3, 2023
Merged

{Core} Directly call acquire_token_for_client to acquire access token for service principal #27002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/azure-cli-core/azure/cli/core/auth/msal_authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ def get_token(self, *scopes, **kwargs):
logger.debug("ServicePrincipalCredential.get_token: scopes=%r, kwargs=%r", scopes, kwargs)

scopes = list(scopes)
result = self.acquire_token_silent(scopes, None, **kwargs)
if not result:
result = self.acquire_token_for_client(scopes, **kwargs)
result = self.acquire_token_for_client(scopes, **kwargs)
Copy link
Member Author

@jiasli jiasli Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is purely for code cleanliness.

MSAL 1.24.0b1 installed by #26980 will also include this functionality, as calling acquire_token_silent with account=None is now a no-op:

https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/95df6086ec186e395186e097f8c9103c4ee74d83/msal/application.py#L1272-L1273

        if not account:
            return None  # A backward-compatible NO-OP to drop the account=None usage

check_result(result)
return build_sdk_access_token(result)