[Monitor][Ingestion] Adjust upload error handling#27556
Merged
pvaneck merged 4 commits intoAzure:mainfrom Jan 6, 2023
Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
pvaneck
force-pushed
the
ingestion-error
branch
3 times, most recently
from
cefce57 to
ac9de7e
Compare
pvaneck
force-pushed
the
ingestion-error
branch
from
ac9de7e to
7e393ea
Compare
pvaneck
force-pushed
the
ingestion-error
branch
from
7e393ea to
85b26b8
Compare
pvaneck
force-pushed
the
ingestion-error
branch
3 times, most recently
from
0e596fc to
ce74c43
Compare
This uses a callback approach to error handling where the user can optionally pass in an error callback function for custom error handling. If no callback function is provided, the default behavior is to raise the first error encountered. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
ingestion-error
branch
2 times, most recently
from
bb335d9 to
ccdafce
Compare
Seems the type hints are more feasible with positional args. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
ingestion-error
branch
from
ccdafce to
399be1c
Compare
annatisch
reviewed
Jan 3, 2023
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_helpers.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_helpers.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_operations/_patch.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_helpers.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-ingestion/samples/sample_send_small_logs.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
annatisch
approved these changes
Jan 6, 2023
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_operations/_patch.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/_operations/_patch.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/aio/_operations/_patch.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/aio/_operations/_patch.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Anna Tisch <antisch@microsoft.com>
iscai-msft
added a commit
that referenced
this pull request
Apr 26, 2023
…into version_tolerant_models * 'main' of https://github.com/Azure/azure-sdk-for-python: (1604 commits) [Storage] Matching `_shared` folder contents across all packages (#28031) [ml] Rename MLException back to MlException (#28210) [EventHubs] update readme to include uamqp backcompat section (#28198) [Monitor][Ingestion] Adjust upload error handling (#27556) Add 3.11 to QA (#28169) p1 component deployment exisitng job definition (#28194) Typing for identity (#28159) [ServiceBus] Allow clearing of session state (#27726) [ML][Pipelines] Fix parallel-for validation rule: allow empty dict as loop config item (#28178) [ML][Pipelines] feat: enable concurrent component registration (#28118) [ML][Pipelines] Test: update invalid reuse test (#28180) [AutoRelease] t2-loadtesting-2022-12-23-48532(can only be merged by SDK owner) (#28042) [ML][Pipelines] Test: update unstable tests in ci (#28157) [ML]: Adding experimental decorator to JobDefinition (#28200) [Identity] Fix 'az' existence check in CliCred (#27991) [EventHubs] fix tracing bug (#28149) ShortForMigrateFrom (#28192) Address the API review comments (#28188) [SchemaRegistryAvro] update recordings (#28158) [EventHub] update uamqp_transport docstring (#28186) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses a callback approach where a user can optionally pass in an
on_errorcallback function for custom error handing.This callback function should expect arbitrary keyword arguments (
**kwargs) or expect anerrorandlogsargument.If no
on_errorcallback function is passed in, then the default behavior will be to raise the first error encountered.A sync and async sample were added demonstrating usage.