[Identity] Fix 'az' existence check in CliCred#27991
Merged
pvaneck merged 2 commits intoAzure:mainfrom Jan 6, 2023
Merged
Conversation
ghost
added
the
lmazuel
reviewed
Dec 20, 2022
sdk/identity/azure-identity/azure/identity/_credentials/azure_cli.py
Outdated
Show resolved
Hide resolved
This change updates AzureCliCredential to use "shutil.which" to verify that the "az" command is available before trying to get a token. This provides a more reliable and cross-platform way to check if the Azure CLI installed without having to parse error messages which may not always be in English. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-cli-fix
branch
from
519994b to
06b743a
Compare
xiangyan99
approved these changes
Jan 6, 2023
Collaborator
|
API change check API changes are not detected in this pull request. |
iscai-msft
added a commit
that referenced
this pull request
Apr 26, 2023
…into version_tolerant_models * 'main' of https://github.com/Azure/azure-sdk-for-python: (1604 commits) [Storage] Matching `_shared` folder contents across all packages (#28031) [ml] Rename MLException back to MlException (#28210) [EventHubs] update readme to include uamqp backcompat section (#28198) [Monitor][Ingestion] Adjust upload error handling (#27556) Add 3.11 to QA (#28169) p1 component deployment exisitng job definition (#28194) Typing for identity (#28159) [ServiceBus] Allow clearing of session state (#27726) [ML][Pipelines] Fix parallel-for validation rule: allow empty dict as loop config item (#28178) [ML][Pipelines] feat: enable concurrent component registration (#28118) [ML][Pipelines] Test: update invalid reuse test (#28180) [AutoRelease] t2-loadtesting-2022-12-23-48532(can only be merged by SDK owner) (#28042) [ML][Pipelines] Test: update unstable tests in ci (#28157) [ML]: Adding experimental decorator to JobDefinition (#28200) [Identity] Fix 'az' existence check in CliCred (#27991) [EventHubs] fix tracing bug (#28149) ShortForMigrateFrom (#28192) Address the API review comments (#28188) [SchemaRegistryAvro] update recordings (#28158) [EventHub] update uamqp_transport docstring (#28186) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates AzureCliCredential to use "shutil.which" to verify that the "az" command is available before trying to get a token. This provides a more reliable and cross-platform way to check if the Azure CLI installed without having to parse error messages which may not always be in English.
Closes: #27965
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines