[ServiceBus] Allow clearing of session state#27726
Merged
kashifkhan merged 7 commits intoAzure:mainfrom Jan 6, 2023
Merged
Conversation
ghost
added
the
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kashifkhan
changed the title
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kashifkhan
commented
Nov 30, 2022
kashifkhan
commented
Nov 30, 2022
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_session.py
Outdated
Show resolved
Hide resolved
kashifkhan
commented
Nov 30, 2022
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_session_async.py
Outdated
Show resolved
Hide resolved
kashifkhan
commented
Nov 30, 2022
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_session_async.py
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
approved these changes
Dec 2, 2022
Member
swathipil
left a comment
swathipil
left a comment
There was a problem hiding this comment.
lgtm! (checking that this isn't related to an existing issue/customer report and doesn't need to be linked?)
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_session.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_session_async.py
Outdated
Show resolved
Hide resolved
|
@swathipil this is the issue associated with this #27726 |
Member
@sebastian2696 -- looks like you might've accidentally linked back to this PR? 🙂 |
Not that I am aware... Unless you are asking how I know this PR exists? |
annatisch
reviewed
Dec 7, 2022
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_session.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/tests/async_tests/test_sessions_async.py
Show resolved
Hide resolved
iscai-msft
added a commit
that referenced
this pull request
Apr 26, 2023
…into version_tolerant_models * 'main' of https://github.com/Azure/azure-sdk-for-python: (1604 commits) [Storage] Matching `_shared` folder contents across all packages (#28031) [ml] Rename MLException back to MlException (#28210) [EventHubs] update readme to include uamqp backcompat section (#28198) [Monitor][Ingestion] Adjust upload error handling (#27556) Add 3.11 to QA (#28169) p1 component deployment exisitng job definition (#28194) Typing for identity (#28159) [ServiceBus] Allow clearing of session state (#27726) [ML][Pipelines] Fix parallel-for validation rule: allow empty dict as loop config item (#28178) [ML][Pipelines] feat: enable concurrent component registration (#28118) [ML][Pipelines] Test: update invalid reuse test (#28180) [AutoRelease] t2-loadtesting-2022-12-23-48532(can only be merged by SDK owner) (#28042) [ML][Pipelines] Test: update unstable tests in ci (#28157) [ML]: Adding experimental decorator to JobDefinition (#28200) [Identity] Fix 'az' existence check in CliCred (#27991) [EventHubs] fix tracing bug (#28149) ShortForMigrateFrom (#28192) Address the API review comments (#28188) [SchemaRegistryAvro] update recordings (#28158) [EventHub] update uamqp_transport docstring (#28186) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per this document
The previously set session state can be cleared by passing null to the SetState method on the receiver.The python SDK currently does not accept
Noneand raises an Exception since it tries to convert it in to a bytearray.This brings it in to parity with other languages that accept null, nil etc.
Fixes #27582