Add support for POP tokens to MSAL Java and MSAL Java Brokers by Avery-Dunn · Pull Request #639 · AzureAD/microsoft-authentication-library-for-java

Avery-Dunn · 2023-05-01T16:04:42Z

Adds POP token support by introducing a new AuthScheme parameter than can be set in supported flows, and calling the relevant interop API to set up the required auth parameters to request POP tokens.

The interop changes in this PR https://github.com/AzureAD/microsoft-authentication-library-for-cpp/pull/3514 need to be released before any of these changes will work outside of a dev environment.

regional endpoint change to always use login.microsoft.com

* Add support for both current and legacy B2C authority formats * Fix B2C format test

add 2 seconds timeout while calling IMDS

…#599)

updated versions for release

* Add tests for a CIAM user and reduce code duplication in several test files * Revert changed method name * Attempt to resolve credscan flag * Resolve credscan issues * Address code review comments * Use default scope

Instance discovery throws exception only with invalid authority

expose extraQueryParameters

version updates for release

Updated json-smart version to a 'bug-free' version

update json-smart version

Replaced broken link in change log reference with msal4j-sdk/changelog.txt

…soft-authentication-library-for-java into avdunn/pop-support

…pop-support

Issue 447 - support for macOs, Linux and Unix

bgavrilMS · 2023-06-12T10:54:46Z

msal4j-brokers/src/test/java/test/ProofOfPossessionTest.java

+
+        seleniumDriver = SeleniumExtensions.createDefaultWebDriver();
+
+        //First, get a non-PoP (bearer) token through a browser


Why not use non-WAM Username/Password? UI testing is brittle, should be avoided as much as possible.

bgavrilMS · 2023-06-12T10:57:36Z

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthenticationResult.java


    private final String scopes;
+
+    private final Boolean isPopAuthorization;


Is this used?

Yes, it can be set when creating the AuthenticationResult in the IBroker file: https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/8363f81cfd942e269758e9af1e2c2c1c53fca275/msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IBroker.java#LL83C20-L83C20

(the field here is 'private', but we use a dependency called Lombok to generate the getters/setters and other boilerplate code for these fields)

bgavrilMS · 2023-06-12T11:13:20Z

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAuthenticationResult.java

+    /**
+     * @return whether this is a proof-of-possession token
+     */
+    Boolean isPopAuthorization();


Adding a member to an interface is a breaking change (since you'll break ppl using this interface). Can you use default methods instead?

Alternative: deprecate the interface and just the data object AuthenticationResult, since data objects don't need to be put behind interfaces...

.NET uses "string TokenType" instead to differentiate "Bearer", "pop" and potentially others (SSH-cert is the other one).

Good point about it being a breaking change. We've made a couple additive changes to these sorts of interfaces over the years but it's definitely a risk.

For the this beta release I simply got rid of this new field, and we can discuss more about deprecating interfaces and following best practices.

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IBroker.java

bgavrilMS · 2023-06-12T11:21:30Z

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/PublicClientApplication.java

+     * Used to determine whether to call into an IBroker instance instead of standard MSAL Java's normal username/password flow,
+     * and may throw exceptions or log messages if broker-only parameters are used when a broker is not enabled/available
+     */
+    private boolean validateBrokerUsage(UserNamePasswordParameters parameters) {


On top of this, the spec states to have an API like "IsPoPSupportedByClient" so that clients can have logic like

does RP support POP and does client support POP?

I suppose that IsBrokerSupported is public API and it can be used for the same?

Yes, there is an 'isBrokerAvailable' API that essentially just answers the question "could the MSALRuntime startup API be called successfully".

Unless there is some scenario where POP isn't supported but MSALRuntime works, then for MSAL Java at least an isBrokerSupported API and an isPoPSupported API would always return the same thing.

msal4j-brokers/src/test/java/test/ProofOfPossessionTest.java

bgavrilMS · 2023-06-12T11:24:48Z

msal4j-brokers/src/test/java/test/ProofOfPossessionTest.java

+    }
+
+    @Test
+    public void acquirePopToken_BrowserAndBroker() throws Exception {


I would maybe also add a test where you get a Bearer token from WAM and a POP token from WAM.

MSAL should not cache either on its side.

bgavrilMS

Some comments, nothing blocking.

Would also like to double check that we have a test that checks:

get tokens using non-WAM (ROPC) and store AT and RT in cache
get tokens using WAM silently. the AT and RT are NOT used at all. We should never fallback to non-WAM tokens in WAM flows.

…D/microsoft-authentication-library-for-java into avdunn/pop-support

…tion-library-for-java into avdunn/pop-support # Conflicts: # msal4j-sdk/README.md # msal4j-sdk/bnd.bnd # msal4j-sdk/changelog.txt # msal4j-sdk/pom.xml # msal4j-sdk/src/samples/msal-b2c-web-sample/pom.xml # msal4j-sdk/src/samples/msal-obo-sample/pom.xml # msal4j-sdk/src/samples/msal-web-sample/pom.xml

* Add IBroker implementation for MSALRuntime * Remove dll used during testing * Integrate broker steps to relevant flows in PublicClientApplication * Add logic to cancel MsalRuntimeFutures * Expand javadocs and exception handling * Address code review comments * Simplify future chaining, address code review comments * Reorganize future chaining, fix testing issues * Adjust how broker availability is checked * Create automated test * Adjust startup logic * Correct version number for interop * Correct broker versioning * Move broker tests to MSAL Java package * Remove usage of msal4j-brokers from msal4j * Add missing SLFJ dependency * Use newest msal4j * Bump javamsalruntime version number * Version changes for 1.14.0-beta release (#589) * Add missing pom info needed by sonatype * APIs for toggling MSALRuntime's logging (#608) * Add APIs for toggling MSALRuntime's logging systems * Rename logging methods to be more clear * Add support for POP tokens to MSAL Java and MSAL Java Brokers (#639) * Version changes for 1.14.0-beta release * regional endpoint change to always use login.microsoft.com * Add support for both current and legacy B2C authority formats (#594) * Add support for both current and legacy B2C authority formats * Fix B2C format test * add 2 seconds timeout while calling IMDS * Fix failing tests * Fix failing tests * delete commented out code * Use the dedicated admin consent endpoint instead of a query parameter (#599) * updated versions for release * update condition to throw exception * added test for invalid authority * Add tests for a CIAM user and reduce test code duplication (#603) * Add tests for a CIAM user and reduce code duplication in several test files * Revert changed method name * Attempt to resolve credscan flag * Resolve credscan issues * Address code review comments * Use default scope * expose extraQueryParameters * expose extraQueryParameters * ExtraQueryParameters tests * retrigger the tests * Updated an existing test case to check added parameters * Replace exception with warning * version updates for release * update json-smart version * Updated json-smart version Updated json-smart version to a 'bug-free' version * version updates for release * Initial commit * add CIAM authority file * revert authority validation changes * Fix failing tests * Fix failing tests * remove commented out line * remove unnecessary code * update exception message for device code flow * add refresh_in logic * resolve build issues + address PR comments * update tests * updated org-json version to resolve Dependabot alert * Better redirect URI error handling and dependency upgrade (#633) * Better error handling for redirect URIs * Update oauth2-oidc-sdk dependency * Address review comments Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> --------- Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Version updates for 1.13.8 release (#634) * Version updates for 1.13.8 release * Update changelog.txt * Point to MSAL Java reference docs onboarded to Microsoft Learn * Add support for POP tokens to MSAL Java and MSAL Java Brokers * Send extraQueryParameters to interop's AuthParameters * Avoid exposing new PopParameters class, change API to match design doc * Update msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Update msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Update change log URl in README.md (#649) Replaced broken link in change log reference with msal4j-sdk/changelog.txt * Issue 447 * Feedback incorporation * enum for os type * Use enum for HTTP methods * Add broker tests, address PR review comments * Improve PoP tests * Address code review comments * Version updates * Re-add extraQueryParameters support --------- Co-authored-by: siddhijain <siddhijain@microsoft.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: Dickson Mwendia <64727760+Dickson-Mwendia@users.noreply.github.com> Co-authored-by: Tamas Csizmadia <tamas@me.com> * Fix silent issue * Ensure correlation ID is never null * Broker fixes and feedback (#733) * Delete codeql.yml * Test framework update (#672) * Initial working tests * Remove CIAM extra query parameter * Fix failing tests * Remove duplicate unit tests * Remove duplicate unit tests * Update tests with mocking to use Mockito * Remove testng and powermock, add junit and mockito * Remove AbstractMsalTests and PowerMockTestCase * Fix mistaken null check * Properly scope dependency * Update CIAM tests (#673) * Bump guava from 31.1-jre to 32.0.0-jre in /msal4j-sdk (#671) Bumps [guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Delete contributing.md (#667) Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Create Contributing.md (#668) Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Version changes for 1.13.9 (#674) * Add space between command and arguments when executing linux command to open browser. Refs #682 (#683) Co-authored-by: Ric Emery <remery@denmartech.com> * Assorted fixes (#684) * Remove default timeouts and improve exception messages * Fix NPE for on-prem ADFS scenario * Log MSAL message but re-throw exception * Update vulnerable test dependency * Issue-679: Fix for Account Cache; .contains() was not possible and you had to iterate through all elements as workaround. (#681) * Version changes for 1.13.10 (#685) * Move changelog * Move changelog to root * Update issue templates (#707) * Re-add lombok source line (#705) * Version changes for release 1.13.11 (#714) * Update bug report * Delete .github/ISSUE_TEMPLATE/bug_report.md * Update bug_report.yaml * Create FeatureRequest.yaml * Update FeatureRequest.yaml * Set default throttling time to 5 sec (#721) Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> * Ensure correlation ID is never null * Rename MsalRuntimeBroker and add builder pattern for better API consistency --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ric Emery <ric.emery@gmail.com> Co-authored-by: Ric Emery <remery@denmartech.com> Co-authored-by: Maximilian Pfeffer <admin@maxpfeffer.de> Co-authored-by: akulyakhtin <akulyakhtin@gmail.com> Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> * Version changes for msal4j-brokers 1.0.3-beta and msal4j 1.14.3-beta (#734) * Ensure correlation ID is never null * Version changes for msal4j-brokers 1.0.3-beta and msal4j 1.14.3-beta * Ensure that builder values for supported OS's are used * Release 1.14.0/1.0.0 version changes (#736) * Delete codeql.yml * Test framework update (#672) * Initial working tests * Remove CIAM extra query parameter * Fix failing tests * Remove duplicate unit tests * Remove duplicate unit tests * Update tests with mocking to use Mockito * Remove testng and powermock, add junit and mockito * Remove AbstractMsalTests and PowerMockTestCase * Fix mistaken null check * Properly scope dependency * Update CIAM tests (#673) * Bump guava from 31.1-jre to 32.0.0-jre in /msal4j-sdk (#671) Bumps [guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Delete contributing.md (#667) Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Create Contributing.md (#668) Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Version changes for 1.13.9 (#674) * Add space between command and arguments when executing linux command to open browser. Refs #682 (#683) Co-authored-by: Ric Emery <remery@denmartech.com> * Assorted fixes (#684) * Remove default timeouts and improve exception messages * Fix NPE for on-prem ADFS scenario * Log MSAL message but re-throw exception * Update vulnerable test dependency * Issue-679: Fix for Account Cache; .contains() was not possible and you had to iterate through all elements as workaround. (#681) * Version changes for 1.13.10 (#685) * Move changelog * Move changelog to root * Update issue templates (#707) * Re-add lombok source line (#705) * Version changes for release 1.13.11 (#714) * Update bug report * Delete .github/ISSUE_TEMPLATE/bug_report.md * Update bug_report.yaml * Create FeatureRequest.yaml * Update FeatureRequest.yaml * Set default throttling time to 5 sec (#721) Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> * Version changes for 1.14.0 msal4j and 1.0.0 msal4j-brokers --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ric Emery <ric.emery@gmail.com> Co-authored-by: Ric Emery <remery@denmartech.com> Co-authored-by: Maximilian Pfeffer <admin@maxpfeffer.de> Co-authored-by: akulyakhtin <akulyakhtin@gmail.com> Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: siddhijain <siddhijain@microsoft.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: Dickson Mwendia <64727760+Dickson-Mwendia@users.noreply.github.com> Co-authored-by: Tamas Csizmadia <tamas@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ric Emery <ric.emery@gmail.com> Co-authored-by: Ric Emery <remery@denmartech.com> Co-authored-by: Maximilian Pfeffer <admin@maxpfeffer.de> Co-authored-by: akulyakhtin <akulyakhtin@gmail.com> Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com>

* Move changelog to root * Update issue templates (#707) * Re-add lombok source line (#705) * Version changes for release 1.13.11 (#714) * Update bug report * Delete .github/ISSUE_TEMPLATE/bug_report.md * Update bug_report.yaml * Create FeatureRequest.yaml * Update FeatureRequest.yaml * Set default throttling time to 5 sec (#721) Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> * MSAL Java/MSALRuntime integration (#590) * Add IBroker implementation for MSALRuntime * Remove dll used during testing * Integrate broker steps to relevant flows in PublicClientApplication * Add logic to cancel MsalRuntimeFutures * Expand javadocs and exception handling * Address code review comments * Simplify future chaining, address code review comments * Reorganize future chaining, fix testing issues * Adjust how broker availability is checked * Create automated test * Adjust startup logic * Correct version number for interop * Correct broker versioning * Move broker tests to MSAL Java package * Remove usage of msal4j-brokers from msal4j * Add missing SLFJ dependency * Use newest msal4j * Bump javamsalruntime version number * Version changes for 1.14.0-beta release (#589) * Add missing pom info needed by sonatype * APIs for toggling MSALRuntime's logging (#608) * Add APIs for toggling MSALRuntime's logging systems * Rename logging methods to be more clear * Add support for POP tokens to MSAL Java and MSAL Java Brokers (#639) * Version changes for 1.14.0-beta release * regional endpoint change to always use login.microsoft.com * Add support for both current and legacy B2C authority formats (#594) * Add support for both current and legacy B2C authority formats * Fix B2C format test * add 2 seconds timeout while calling IMDS * Fix failing tests * Fix failing tests * delete commented out code * Use the dedicated admin consent endpoint instead of a query parameter (#599) * updated versions for release * update condition to throw exception * added test for invalid authority * Add tests for a CIAM user and reduce test code duplication (#603) * Add tests for a CIAM user and reduce code duplication in several test files * Revert changed method name * Attempt to resolve credscan flag * Resolve credscan issues * Address code review comments * Use default scope * expose extraQueryParameters * expose extraQueryParameters * ExtraQueryParameters tests * retrigger the tests * Updated an existing test case to check added parameters * Replace exception with warning * version updates for release * update json-smart version * Updated json-smart version Updated json-smart version to a 'bug-free' version * version updates for release * Initial commit * add CIAM authority file * revert authority validation changes * Fix failing tests * Fix failing tests * remove commented out line * remove unnecessary code * update exception message for device code flow * add refresh_in logic * resolve build issues + address PR comments * update tests * updated org-json version to resolve Dependabot alert * Better redirect URI error handling and dependency upgrade (#633) * Better error handling for redirect URIs * Update oauth2-oidc-sdk dependency * Address review comments Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> --------- Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Version updates for 1.13.8 release (#634) * Version updates for 1.13.8 release * Update changelog.txt * Point to MSAL Java reference docs onboarded to Microsoft Learn * Add support for POP tokens to MSAL Java and MSAL Java Brokers * Send extraQueryParameters to interop's AuthParameters * Avoid exposing new PopParameters class, change API to match design doc * Update msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Update msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Update change log URl in README.md (#649) Replaced broken link in change log reference with msal4j-sdk/changelog.txt * Issue 447 * Feedback incorporation * enum for os type * Use enum for HTTP methods * Add broker tests, address PR review comments * Improve PoP tests * Address code review comments * Version updates * Re-add extraQueryParameters support --------- Co-authored-by: siddhijain <siddhijain@microsoft.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: Dickson Mwendia <64727760+Dickson-Mwendia@users.noreply.github.com> Co-authored-by: Tamas Csizmadia <tamas@me.com> * Fix silent issue * Ensure correlation ID is never null * Broker fixes and feedback (#733) * Delete codeql.yml * Test framework update (#672) * Initial working tests * Remove CIAM extra query parameter * Fix failing tests * Remove duplicate unit tests * Remove duplicate unit tests * Update tests with mocking to use Mockito * Remove testng and powermock, add junit and mockito * Remove AbstractMsalTests and PowerMockTestCase * Fix mistaken null check * Properly scope dependency * Update CIAM tests (#673) * Bump guava from 31.1-jre to 32.0.0-jre in /msal4j-sdk (#671) Bumps [guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Delete contributing.md (#667) Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Create Contributing.md (#668) Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Version changes for 1.13.9 (#674) * Add space between command and arguments when executing linux command to open browser. Refs #682 (#683) Co-authored-by: Ric Emery <remery@denmartech.com> * Assorted fixes (#684) * Remove default timeouts and improve exception messages * Fix NPE for on-prem ADFS scenario * Log MSAL message but re-throw exception * Update vulnerable test dependency * Issue-679: Fix for Account Cache; .contains() was not possible and you had to iterate through all elements as workaround. (#681) * Version changes for 1.13.10 (#685) * Move changelog * Move changelog to root * Update issue templates (#707) * Re-add lombok source line (#705) * Version changes for release 1.13.11 (#714) * Update bug report * Delete .github/ISSUE_TEMPLATE/bug_report.md * Update bug_report.yaml * Create FeatureRequest.yaml * Update FeatureRequest.yaml * Set default throttling time to 5 sec (#721) Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> * Ensure correlation ID is never null * Rename MsalRuntimeBroker and add builder pattern for better API consistency --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ric Emery <ric.emery@gmail.com> Co-authored-by: Ric Emery <remery@denmartech.com> Co-authored-by: Maximilian Pfeffer <admin@maxpfeffer.de> Co-authored-by: akulyakhtin <akulyakhtin@gmail.com> Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> * Version changes for msal4j-brokers 1.0.3-beta and msal4j 1.14.3-beta (#734) * Ensure correlation ID is never null * Version changes for msal4j-brokers 1.0.3-beta and msal4j 1.14.3-beta * Ensure that builder values for supported OS's are used * Release 1.14.0/1.0.0 version changes (#736) * Delete codeql.yml * Test framework update (#672) * Initial working tests * Remove CIAM extra query parameter * Fix failing tests * Remove duplicate unit tests * Remove duplicate unit tests * Update tests with mocking to use Mockito * Remove testng and powermock, add junit and mockito * Remove AbstractMsalTests and PowerMockTestCase * Fix mistaken null check * Properly scope dependency * Update CIAM tests (#673) * Bump guava from 31.1-jre to 32.0.0-jre in /msal4j-sdk (#671) Bumps [guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Delete contributing.md (#667) Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Create Contributing.md (#668) Co-authored-by: Avery-Dunn <avdunn@microsoft.com> * Version changes for 1.13.9 (#674) * Add space between command and arguments when executing linux command to open browser. Refs #682 (#683) Co-authored-by: Ric Emery <remery@denmartech.com> * Assorted fixes (#684) * Remove default timeouts and improve exception messages * Fix NPE for on-prem ADFS scenario * Log MSAL message but re-throw exception * Update vulnerable test dependency * Issue-679: Fix for Account Cache; .contains() was not possible and you had to iterate through all elements as workaround. (#681) * Version changes for 1.13.10 (#685) * Move changelog * Move changelog to root * Update issue templates (#707) * Re-add lombok source line (#705) * Version changes for release 1.13.11 (#714) * Update bug report * Delete .github/ISSUE_TEMPLATE/bug_report.md * Update bug_report.yaml * Create FeatureRequest.yaml * Update FeatureRequest.yaml * Set default throttling time to 5 sec (#721) Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> * Version changes for 1.14.0 msal4j and 1.0.0 msal4j-brokers --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ric Emery <ric.emery@gmail.com> Co-authored-by: Ric Emery <remery@denmartech.com> Co-authored-by: Maximilian Pfeffer <admin@maxpfeffer.de> Co-authored-by: akulyakhtin <akulyakhtin@gmail.com> Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: siddhijain <siddhijain@microsoft.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: Dickson Mwendia <64727760+Dickson-Mwendia@users.noreply.github.com> Co-authored-by: Tamas Csizmadia <tamas@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ric Emery <ric.emery@gmail.com> Co-authored-by: Ric Emery <remery@denmartech.com> Co-authored-by: Maximilian Pfeffer <admin@maxpfeffer.de> Co-authored-by: akulyakhtin <akulyakhtin@gmail.com> Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> * Version changes for 1.14.0 msal4j * Bump org.json:json in /msal4j-sdk/src/samples/msal-obo-sample (#740) Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.json:json in /msal4j-sdk/src/samples/msal-b2c-web-sample (#739) Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.json:json in /msal4j-sdk/src/samples/msal-web-sample (#737) Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Version updates for 1.14.4-beta release --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: akulyakhtin <akulyakhtin@gmail.com> Co-authored-by: Kulyakhtin, Alexander (Ext) <alexander.kulyakhtin_ext@novartis.com> Co-authored-by: siddhijain <siddhijain@microsoft.com> Co-authored-by: Dickson Mwendia <64727760+Dickson-Mwendia@users.noreply.github.com> Co-authored-by: Tamas Csizmadia <tamas@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ric Emery <ric.emery@gmail.com> Co-authored-by: Ric Emery <remery@denmartech.com> Co-authored-by: Maximilian Pfeffer <admin@maxpfeffer.de>

Avery-Dunn and others added 30 commits January 31, 2023 14:29

Version changes for 1.14.0-beta release

7b64fea

regional endpoint change to always use login.microsoft.com

b8e6a70

Merge pull request #596 from AzureAD/SJAIN/regional-endpoint-fix

d1cb3be

regional endpoint change to always use login.microsoft.com

Add support for both current and legacy B2C authority formats (#594)

92eace8

* Add support for both current and legacy B2C authority formats * Fix B2C format test

add 2 seconds timeout while calling IMDS

6d850b1

Merge branch 'dev' into SJAIN/add-2s-timeout-to-IMDS-call

7150965

Fix failing tests

9a286ab

Fix failing tests

8c26f4c

delete commented out code

d6ac699

Merge pull request #598 from AzureAD/SJAIN/add-2s-timeout-to-IMDS-call

290b543

add 2 seconds timeout while calling IMDS

Use the dedicated admin consent endpoint instead of a query parameter (…

68a9972

…#599)

updated versions for release

5ce95b6

Merge pull request #600 from AzureAD/SJAIN/update-versions-for-release

9683c9d

updated versions for release

update condition to throw exception

12ca836

added test for invalid authority

cf814eb

Add tests for a CIAM user and reduce test code duplication (#603)

ed7df00

* Add tests for a CIAM user and reduce code duplication in several test files * Revert changed method name * Attempt to resolve credscan flag * Resolve credscan issues * Address code review comments * Use default scope

expose extraQueryParameters

3bfa042

Merge pull request #606 from AzureAD/SJAIN/Issue-605

00c991a

Instance discovery throws exception only with invalid authority

expose extraQueryParameters

82a9155

ExtraQueryParameters tests

974cc55

retrigger the tests

34c3b01

Updated an existing test case to check added parameters

e6daa31

Replace exception with warning

6106d52

Merge pull request #607 from AzureAD/SJAIN/add-extraQueryParameters

88949fc

expose extraQueryParameters

version updates for release

50249de

Merge pull request #609 from AzureAD/SJAIN/version-updates-for-release

17c4c6d

version updates for release

update json-smart version

fa63cad

Updated json-smart version

bc99394

Updated json-smart version to a 'bug-free' version

Merge pull request #612 from AzureAD/SJAIN/update-json-dependency

b1c75bd

update json-smart version

version updates for release

34b2d83

tcsizmadia and others added 10 commits May 10, 2023 08:49

Update change log URl in README.md (#649)

60eb345

Replaced broken link in change log reference with msal4j-sdk/changelog.txt

Issue 447

302a0b2

Merge branch 'avdunn/1.14.0-beta' of https://github.com/AzureAD/micro…

043596a

…soft-authentication-library-for-java into avdunn/pop-support

Feedback incorporation

07ef572

Merge remote-tracking branch 'origin/avdunn/pop-support' into avdunn/…

849a7cd

…pop-support

enum for os type

e215337

Use enum for HTTP methods

cedc977

Add broker tests, address PR review comments

7f17b37

Merge pull request #651 from AzureAD/SJAIN/support-for-mac-unix-linux

fe7e69c

Issue 447 - support for macOs, Linux and Unix

Improve PoP tests

8363f81

Avery-Dunn requested a review from bgavrilMS May 18, 2023 20:04

bgavrilMS reviewed Jun 12, 2023

View reviewed changes

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IBroker.java Outdated Show resolved Hide resolved

bgavrilMS reviewed Jun 12, 2023

View reviewed changes

msal4j-brokers/src/test/java/test/ProofOfPossessionTest.java Outdated Show resolved Hide resolved

bgavrilMS reviewed Jun 12, 2023

View reviewed changes

msal4j-brokers/src/test/java/test/ProofOfPossessionTest.java Show resolved Hide resolved

bgavrilMS reviewed Jun 12, 2023

View reviewed changes

bgavrilMS approved these changes Jun 12, 2023

View reviewed changes

Avery-Dunn added 5 commits June 16, 2023 12:17

Merge branch 'avdunn/msalruntime-broker' of https://github.com/AzureA…

c224df6

…D/microsoft-authentication-library-for-java into avdunn/pop-support

Address code review comments

7dc1c72

Version updates

61b66d2

Re-add extraQueryParameters support

ff6f15d

Avery-Dunn merged commit b27c81b into avdunn/msalruntime-broker Jun 19, 2023

Avery-Dunn mentioned this pull request Aug 17, 2023

[Enhancement] Add support for extraQueryParameters #256

Closed

6 tasks

Avery-Dunn deleted the avdunn/pop-support branch December 7, 2023 17:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for POP tokens to MSAL Java and MSAL Java Brokers#639

Add support for POP tokens to MSAL Java and MSAL Java Brokers#639
Avery-Dunn merged 70 commits intoavdunn/msalruntime-brokerfrom
avdunn/pop-support

Avery-Dunn commented May 1, 2023

Uh oh!

bgavrilMS Jun 12, 2023

Uh oh!

bgavrilMS Jun 12, 2023

Uh oh!

Avery-Dunn Jun 14, 2023

Uh oh!

bgavrilMS Jun 12, 2023 •

edited

Loading

Uh oh!

Avery-Dunn Jun 19, 2023

Uh oh!

Uh oh!

bgavrilMS Jun 12, 2023

Uh oh!

Avery-Dunn Jun 19, 2023

Uh oh!

Uh oh!

Uh oh!

bgavrilMS Jun 12, 2023

Uh oh!

bgavrilMS left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		seleniumDriver = SeleniumExtensions.createDefaultWebDriver();

		//First, get a non-PoP (bearer) token through a browser


		private final String scopes;

		private final Boolean isPopAuthorization;

Conversation

Avery-Dunn commented May 1, 2023

Uh oh!

bgavrilMS Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

bgavrilMS Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

Avery-Dunn Jun 14, 2023

Choose a reason for hiding this comment

Uh oh!

bgavrilMS Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Avery-Dunn Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bgavrilMS Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

Avery-Dunn Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bgavrilMS Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

bgavrilMS left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bgavrilMS Jun 12, 2023 •

edited

Loading