DO NOT MERGE - Test remove imageex to evaluate binary impact size #3733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Otherwise we need to apply Markdown package csproj patch to be able to reference Core.) TODO: Only thing that this leaves us though is a missing DropShadowPanel for the ColorPicker... But I think it might be ok?
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
Member
Author
|
@nmetulev @azchohfi @vgromfeld this is the culprit!!! Over 750kb difference in our test environment on the optimized app footprint. Finishing my last analysis in #3731 as well, but will follow-up for our next steps soon. |
ghost
pushed a commit
that referenced
this pull request
Feb 17, 2021
Quick test to evaluate the footprint of this individual control on the package. Based off PR #3727 Comparing against #3733, wondering if it's this single API or not that has an effect, as everything else seems rather common or using other things already being used in other APIs in the Toolkit... Updated as we identified the custom caching in #2486 is the culprit to the application footprint. Reverting to just use System Cache with the applied fix still to evaluate final impact again with compiled dlls. This should save around **675kb** to optimized app footprint. Also Fixes #3741 removing unused element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick test to evaluate the footprint of this individual control on the package.
Based off PR #3727