ImageEx: Added caching strategy and fixed caching of the Image. #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrons
reviewed
Sep 20, 2018
Contributor
|
ping @hermitdave to review |
nmetulev
approved these changes
Sep 24, 2018
ghost
pushed a commit
that referenced
this pull request
Feb 17, 2021
Quick test to evaluate the footprint of this individual control on the package. Based off PR #3727 Comparing against #3733, wondering if it's this single API or not that has an effect, as everything else seems rather common or using other things already being used in other APIs in the Toolkit... Updated as we identified the custom caching in #2486 is the culprit to the application footprint. Reverting to just use System Cache with the applied fix still to evaluate final impact again with compiled dlls. This should save around **675kb** to optimized app footprint. Also Fixes #3741 removing unused element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2460
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
At the moment the property
IsCacheEnabledfromImageExcontrol doesn't seem to work. Setting it to false displays a cached image even though the physical image has changed.What is the new behavior?
If
IsCacheEnabledis set tofalsethe Image will not be cached at all, not even Internally by UWP.Users now have the ability to choose what type of caching do they want for the image through the
CachingStrategyproperty which can be:ImageCachecustom caching system.PR Checklist
Please check if your PR fulfills the following requirements:
Other information