-
Notifications
You must be signed in to change notification settings - Fork 118
Merge FROM CDL-MVP #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge FROM CDL-MVP #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line cannot handle 'let' at this version
replaced instances of 'let' with 'var' in js files.
…line cannot handle 'let' at this version
Removed unecessary JS from view
switched remaining 'let' in JS to 'var'
… export but decided to make a copy instead of reusing in case we want to add watermarks or something
Public DMPs page
Public DMPs page bug fix to handle nil plan.owner
fixed broken routing tests
…d copyright info to public DMP export
changed text for plan titles on view plans and public dmps page. adde…
updated plan visibility language
… aren't loading multiple times
…l go back later to update our tests. this would be better served by asserting that the proper portions of the DOM were updated #494
…y active users show
Redesign of the Write plan page
updated policy name #242
Bugfix for Public Export
Made labels not bold & removed colons for #424
Create Account: Fix styling/code issues for Organisation dropdown #518
…ised auth for public pages
Make organisation mandatory for register form #518
raycarrick-ed
added a commit
to DigitalCurationCentre/roadmap
that referenced
this pull request
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config/DB changes
Overview of code changes
Restructured JS (lib/assets/javascripts)
javascripts
|-----application.js
|-----dmproadmap/ (Generic JS - available to each page)
|-----locale/ (Fastgettext json)
|-----vendor/ (jquery, autocomplete, etc.)
|-----views/ (page specific JS - loaded by specific pages)
Restructured CSS (lib/assets/stylesheets)
css
|-----dmproadmap.scss (This is the new file that can/should be customized per install)
|-----dmproadmap/ (Generic CSS styles broken apart by topic)
|-----vendor/ (jquery ui styling)