Skip to content

Conversation

@briri
Copy link
Contributor

@briri briri commented Jun 30, 2017

Config/DB changes

  • There is a new config setting that will enable the custom shib discovery service page. It is off by default
  • There is a new config setting for the default plan visibility. Set to private visibility by default
  • The plans table has a new data_contact_email and data_contact_phone.
  • There is a new org_identifiers table. Its setup and mapped similarly to our user_identifiers table
  • The users table now has a new 'prefs' field that stores a hash. This stores the user's email notification preferences

Overview of code changes

  • removed bootstrap
  • removed show route for orgs, guidance groups and guidance
  • added Shib DS routes to the orgs_controller
  • added visibility logic to the plans_controller
  • added public DMPs pages and route to plans_controller
  • added email notifications to registrations_controller
  • updated layout of edit profile page
  • added error messaging for when a user tries to attach an orcid that's already used
  • removed the old helper logic that built the view plans columns
  • added deep_copy to plans and answers
  • added an org_identifiers table for use with shibboleth DS and future maDMP stuff (fundref)
  • added an owned_by? method to plans
  • added data_contact_email and data_contact_phone to plans table
  • cleaned out old block-commented lines from plans
  • rebuild CSS from scratch (see below)
  • restructure the JS (see below)
  • Applied new CSS to all but the template writing pages (in progress)

Restructured JS (lib/assets/javascripts)

javascripts
|-----application.js
|-----dmproadmap/ (Generic JS - available to each page)
|-----locale/ (Fastgettext json)
|-----vendor/ (jquery, autocomplete, etc.)
|-----views/ (page specific JS - loaded by specific pages)

  • dmproadmap/ contains generic JS (e.g. tabs, accordions, helper functions, etc.) These files are loaded as part of the core application.js
  • vendor/ contains JS components from outside entities
  • views/ contains page specific JS. The file naming conventions follow the app/assets/views hierarchy (e.g. views/plans/edit.js belongs to views/plans/edit.html.erb) These are loaded by their specific pages
  • admin.js and plans.js (leftover and will go away once we're confident all of the JS has been accounted for in the new files)

Restructured CSS (lib/assets/stylesheets)

css
|-----dmproadmap.scss (This is the new file that can/should be customized per install)
|-----dmproadmap/ (Generic CSS styles broken apart by topic)
|-----vendor/ (jquery ui styling)

  • The new dmproadmap.scss file is meant to be customized for each installation. It allows you to change the colors, fonts, etc. in one spot. You can also control various aspects of the header from here
  • The files in dmproadmap/ are broken apart into functional parts like accordions, tabs, tables, forms, etc. The base.scss contains the general page layout and is loaded first.
  • If specific tweaks need to be made for a paticular page they should be done within the appropriate scss file at the bottom. For example if we need to restyle tabs for the edit profile page we would place that customization at the bottom of the tabs.scss file.

briri and others added 30 commits June 15, 2017 14:24
replaced instances of 'let' with 'var' in js files.
Removed unecessary JS from view
switched remaining 'let' in JS to 'var'
… export but decided to make a copy instead of reusing in case we want to add watermarks or something
Public DMPs page bug fix to handle nil plan.owner
fixed broken routing tests
changed text for plan titles on view plans and public dmps page. adde…
updated plan visibility language
briri and others added 26 commits July 20, 2017 16:16
…l go back later to update our tests. this would be better served by asserting that the proper portions of the DOM were updated #494
Redesign of the Write plan page
Made labels not bold & removed colons for #424
Create Account: Fix styling/code issues for Organisation dropdown #518
Xsrust/mvp #436, #158 
Will fix broken tests in a separate PR
Make organisation mandatory for register form #518
@briri briri merged commit f299cc8 into development Jul 27, 2017
raycarrick-ed added a commit to DigitalCurationCentre/roadmap that referenced this pull request Apr 13, 2021
portagenetwork referenced this pull request in portagenetwork/roadmap Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants