Conversation
prognant
added
do-not-merge/WIP
[deprecated] team/agent-core
prognant
changed the title
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing
branch
from
5164e89 to
262d561
Compare
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing-part2
branch
from
48c13d7 to
2aee6df
Compare
prognant
changed the title
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing
branch
from
262d561 to
10b9ae7
Compare
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing-part2
branch
from
e9f2c9c to
74cb382
Compare
ogaca-dd
reviewed
Sep 1, 2020
| if err != nil { | ||
| log.Debug(err) | ||
| } | ||
| // track the raw data length and the timestamp so that the agent tails |
Contributor
There was a problem hiding this comment.
Do you want to continue the execution of the code when err != nill?
Contributor
Author
There was a problem hiding this comment.
I tried to kept the behaviour consistent with the current one, I think that's ok to attempt to send the line even if the parsing fails. But on the other hand having the parsing logic failing almost silently may not be a good idea after all... I'll try to think about an alternate solution.
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing
branch
from
10b9ae7 to
19d6b97
Compare
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing-part2
branch
from
74cb382 to
3417758
Compare
ogaca-dd
approved these changes
Sep 11, 2020
gaetan-deputier
approved these changes
Sep 15, 2020
prognant
changed the base branch from
prognant/aggregates-long-lines-k8s-file-tailing
to
master
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing-part2
branch
from
3417758 to
6f7d49a
Compare
prognant
deleted the
prognant/aggregates-long-lines-k8s-file-tailing-part2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable buffering+concatenation for split lines.
Useful in k8s env when tailing from file (
logs_config.k8s_container_use_file: true)Motivation
Get entire log line show in log explorer when lines are longer tha 16kB.
Additional Notes
Depends on #6265
Describe your test plan
UT
IRL tests : agent running in k8s with different container runtime (at least containerd and docker) and
logs_config.k8s_container_use_file: true: