[WIP][logs] Docker tailer: split line support#6268
Closed
prognant wants to merge 14 commits intoprognant/aggregates-long-lines-k8s-file-tailing-part2from
Closed
[WIP][logs] Docker tailer: split line support#6268prognant wants to merge 14 commits intoprognant/aggregates-long-lines-k8s-file-tailing-part2from
prognant wants to merge 14 commits intoprognant/aggregates-long-lines-k8s-file-tailing-part2from
Conversation
prognant
added
changelog/no-changelog
prognant
changed the base branch from
prognant/aggregates-long-lines-k8s-file-tailing
to
prognant/aggregates-long-lines-k8s-file-tailing-part2
prognant
force-pushed
the
prognant/docker-parser-split-line-support
branch
3 times, most recently
from
1c406a4 to
7e79a63
Compare
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing-part2
branch
from
48c13d7 to
2aee6df
Compare
prognant
force-pushed
the
prognant/docker-parser-split-line-support
branch
from
1ca0740 to
599a5bf
Compare
prognant
force-pushed
the
prognant/aggregates-long-lines-k8s-file-tailing-part2
branch
from
e9f2c9c to
74cb382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary note
Decoder/matching logic need to be rework before further work on this PR
(Problem to be solved : decoder is splitting line based on a byte begin equal to
0x0A-aka ascii code for\n-, however docker header comes with a small binary header that may sometimes contain a byte equal to0x0Aleading to problematic line splitting)What does this PR do?
Part of the following PR series: #6265, #6266
It implement split line reconciliation when tailing from the docker socket.
Motivation
It aims to reagregate split lines to ship complete line to the DD log intake,
thus complete, un-split line will show up in the explorer.
Additional Notes
Depends on #6265 and #6266.
Describe your test plan
New UT.
IRL tests (plain docker on ubuntu 18.04)